#include "settings/viewmodes/viewmodesettings.h"
#include "views/zoomlevelinfo.h"
-#include <KLocalizedString>
#include <KFormat>
+#include <KLocalizedString>
#include <QApplication>
+#include <QButtonGroup>
#include <QCheckBox>
#include <QComboBox>
-#include <QHelpEvent>
#include <QFormLayout>
-#include <QSpinBox>
+#include <QHelpEvent>
#include <QRadioButton>
-#include <QButtonGroup>
-#include <QLabel>
-
-ViewSettingsTab::ViewSettingsTab(Mode mode, QWidget* parent) :
- QWidget(parent),
- m_mode(mode),
- m_defaultSizeSlider(nullptr),
- m_previewSizeSlider(nullptr),
- m_fontRequester(nullptr),
- m_widthBox(nullptr),
- m_maxLinesBox(nullptr),
- m_expandableFolders(nullptr),
- m_recursiveDirectorySizeLimit(nullptr),
- m_useRelatetiveDates(nullptr),
- m_useShortDates(nullptr)
+#include <QSpinBox>
+
+ViewSettingsTab::ViewSettingsTab(Mode mode, QWidget *parent)
+ : QWidget(parent)
+ , m_mode(mode)
+ , m_defaultSizeSlider(nullptr)
+ , m_previewSizeSlider(nullptr)
+ , m_fontRequester(nullptr)
+ , m_widthBox(nullptr)
+ , m_maxLinesBox(nullptr)
+ , m_expandableFolders(nullptr)
+ , m_recursiveDirectorySizeLimit(nullptr)
+ , m_useRelatetiveDates(nullptr)
+ , m_useShortDates(nullptr)
{
- QFormLayout* topLayout = new QFormLayout(this);
+ QFormLayout *topLayout = new QFormLayout(this);
// Create "Icon Size" section
const int minRange = ZoomLevelInfo::minimumLevel();
m_defaultSizeSlider->setPageStep(1);
m_defaultSizeSlider->setTickPosition(QSlider::TicksBelow);
m_defaultSizeSlider->setRange(minRange, maxRange);
- connect(m_defaultSizeSlider, &QSlider::valueChanged,
- this, &ViewSettingsTab::slotDefaultSliderMoved);
+ connect(m_defaultSizeSlider, &QSlider::valueChanged, this, &ViewSettingsTab::slotDefaultSliderMoved);
topLayout->addRow(i18nc("@label:listbox", "Default icon size:"), m_defaultSizeSlider);
m_previewSizeSlider = new QSlider(Qt::Horizontal);
m_previewSizeSlider->setPageStep(1);
m_previewSizeSlider->setTickPosition(QSlider::TicksBelow);
m_previewSizeSlider->setRange(minRange, maxRange);
- connect(m_previewSizeSlider, &QSlider::valueChanged,
- this, &ViewSettingsTab::slotPreviewSliderMoved);
+ connect(m_previewSizeSlider, &QSlider::valueChanged, this, &ViewSettingsTab::slotPreviewSliderMoved);
topLayout->addRow(i18nc("@label:listbox", "Preview icon size:"), m_previewSizeSlider);
-
topLayout->addItem(new QSpacerItem(0, Dolphin::VERTICAL_SPACER_HEIGHT, QSizePolicy::Fixed, QSizePolicy::Fixed));
-
// Create "Label" section
m_fontRequester = new DolphinFontRequester(this);
topLayout->addRow(i18nc("@label:listbox", "Label font:"), m_fontRequester);
m_expandableFolders = new QCheckBox(i18nc("@option:check", "Expandable"));
topLayout->addRow(i18nc("@label:checkbox", "Folders:"), m_expandableFolders);
+ // Item activation area
+ m_entireRow = new QRadioButton(i18nc("@option:radio how files/folders are opened", "By clicking anywhere on the row"));
+ m_iconAndNameOnly = new QRadioButton(i18nc("@option:radio how files/folders are opened", "By clicking on icon or name"));
+
+ auto itemActivationAreaGroup = new QButtonGroup(this);
+ itemActivationAreaGroup->addButton(m_entireRow);
+ itemActivationAreaGroup->addButton(m_iconAndNameOnly);
+
+ // clang-format off
+ // i18n: Users can choose here if items are opened by clicking on their name/icon or by clicking in the row.
+ topLayout->addRow(i18nc("@title:group", "Open files and folders:"), m_entireRow);
+ // clang-format on
+ topLayout->addRow(QString(), m_iconAndNameOnly);
+
#ifndef Q_OS_WIN
// Sorting properties
m_numberOfItems = new QRadioButton(i18nc("option:radio", "Number of items"));
m_sizeOfContents = new QRadioButton(i18nc("option:radio", "Size of contents, up to "));
- QButtonGroup* sortingModeGroup = new QButtonGroup(this);
+ QButtonGroup *sortingModeGroup = new QButtonGroup(this);
sortingModeGroup->addButton(m_numberOfItems);
sortingModeGroup->addButton(m_sizeOfContents);
QLocale local;
KFormat formatter(local);
- m_useRelatetiveDates = new QRadioButton(i18nc(
- "option:radio as in relative date", "Relative (e.g. '%1')", formatter.formatRelativeDateTime(thirtyMinutesAgo, QLocale::ShortFormat))
- );
- m_useShortDates = new QRadioButton(
- i18nc("option:radio as in absolute date", "Absolute (e.g. '%1')", local.toString(thirtyMinutesAgo, QLocale::ShortFormat))
- );
+ m_useRelatetiveDates = new QRadioButton(
+ i18nc("option:radio as in relative date", "Relative (e.g. '%1')", formatter.formatRelativeDateTime(thirtyMinutesAgo, QLocale::ShortFormat)));
+ m_useShortDates =
+ new QRadioButton(i18nc("option:radio as in absolute date", "Absolute (e.g. '%1')", local.toString(thirtyMinutesAgo, QLocale::ShortFormat)));
- QButtonGroup* dateFormatGroup = new QButtonGroup(this);
+ QButtonGroup *dateFormatGroup = new QButtonGroup(this);
dateFormatGroup->addButton(m_useRelatetiveDates);
dateFormatGroup->addButton(m_useShortDates);
connect(m_widthBox, &QComboBox::currentIndexChanged, this, &ViewSettingsTab::changed);
break;
case DetailsMode:
+ connect(m_entireRow, &QCheckBox::toggled, this, &ViewSettingsTab::changed);
connect(m_expandableFolders, &QCheckBox::toggled, this, &ViewSettingsTab::changed);
#ifndef Q_OS_WIN
connect(m_recursiveDirectorySizeLimit, &QSpinBox::valueChanged, this, &ViewSettingsTab::changed);
CompactModeSettings::setMaximumTextWidthIndex(m_widthBox->currentIndex());
break;
case DetailsMode:
+ // We need side-padding when the full row is a click target to still be able to not click items.
+ // So here the default padding is enabled when the full row highlight is enabled.
+ if (m_entireRow->isChecked() && !DetailsModeSettings::highlightEntireRow()) {
+ auto detailsModeSettings = DetailsModeSettings::self();
+ const bool usedDefaults = detailsModeSettings->useDefaults(true);
+ const uint defaultSidePadding = detailsModeSettings->sidePadding();
+ detailsModeSettings->useDefaults(usedDefaults);
+ if (DetailsModeSettings::sidePadding() < defaultSidePadding) {
+ DetailsModeSettings::setSidePadding(defaultSidePadding);
+ }
+ } else if (!m_entireRow->isChecked() && DetailsModeSettings::highlightEntireRow()) {
+ // The full row click target is disabled so now most of the view area can be used to interact
+ // with the view background. Having an extra side padding has no usability benefit in this case.
+ DetailsModeSettings::setSidePadding(0);
+ }
+ DetailsModeSettings::setHighlightEntireRow(m_entireRow->isChecked());
DetailsModeSettings::setExpandableFolders(m_expandableFolders->isChecked());
#ifndef Q_OS_WIN
DetailsModeSettings::setDirectorySizeCount(m_numberOfItems->isChecked());
settings.setPreviewSize(previewSize);
settings.setUseSystemFont(useSystemFont);
- settings.setFontFamily(font.family());
- settings.setFontSize(font.pointSizeF());
- settings.setItalicFont(font.italic());
- settings.setFontWeight(font.weight());
+ settings.setViewFont(font);
settings.save();
}
m_widthBox->setCurrentIndex(CompactModeSettings::maximumTextWidthIndex());
break;
case DetailsMode:
+ m_entireRow->setChecked(DetailsModeSettings::highlightEntireRow());
+ m_iconAndNameOnly->setChecked(!m_entireRow->isChecked());
m_expandableFolders->setChecked(DetailsModeSettings::expandableFolders());
- #ifndef Q_OS_WIN
- if (DetailsModeSettings::directorySizeCount()) {
- m_numberOfItems->setChecked(true);
- m_recursiveDirectorySizeLimit->setEnabled(false);
- } else {
- m_sizeOfContents->setChecked(true);
- m_recursiveDirectorySizeLimit->setEnabled(true);
- }
- m_recursiveDirectorySizeLimit->setValue(DetailsModeSettings::recursiveDirectorySizeLimit());
- #endif
+#ifndef Q_OS_WIN
+ if (DetailsModeSettings::directorySizeCount()) {
+ m_numberOfItems->setChecked(true);
+ m_recursiveDirectorySizeLimit->setEnabled(false);
+ } else {
+ m_sizeOfContents->setChecked(true);
+ m_recursiveDirectorySizeLimit->setEnabled(true);
+ }
+ m_recursiveDirectorySizeLimit->setValue(DetailsModeSettings::recursiveDirectorySizeLimit());
+#endif
m_useRelatetiveDates->setChecked(DetailsModeSettings::useShortRelativeDates());
m_useShortDates->setChecked(!DetailsModeSettings::useShortRelativeDates());
break;
const QSize previewSize(settings.previewSize(), settings.previewSize());
m_previewSizeSlider->setValue(ZoomLevelInfo::zoomLevelForIconSize(previewSize));
- m_fontRequester->setMode(settings.useSystemFont()
- ? DolphinFontRequester::SystemFont
- : DolphinFontRequester::CustomFont);
+ m_fontRequester->setMode(settings.useSystemFont() ? DolphinFontRequester::SystemFont : DolphinFontRequester::CustomFont);
- QFont font(settings.fontFamily(), qRound(settings.fontSize()));
- font.setItalic(settings.italicFont());
- font.setWeight(settings.fontWeight());
- font.setPointSizeF(settings.fontSize());
+ QFont font(settings.viewFont());
m_fontRequester->setCustomFont(font);
}
showToolTip(m_previewSizeSlider, value);
}
-void ViewSettingsTab::showToolTip(QSlider* slider, int value)
+void ViewSettingsTab::showToolTip(QSlider *slider, int value)
{
const int size = ZoomLevelInfo::iconSizeForZoomLevel(value);
slider->setToolTip(i18ncp("@info:tooltip", "Size: 1 pixel", "Size: %1 pixels", size));
QHelpEvent toolTipEvent(QEvent::ToolTip, QPoint(0, 0), slider->mapToGlobal(global));
QApplication::sendEvent(slider, &toolTipEvent);
}
-
projects / dolphin.git / blobdiff