KFileItemListWidget: wrong selection when renamed file ends with a dot

[dolphin.git] / src / settings / viewmodes / viewmodesettings.cpp

diff --git a/src/settings/viewmodes/viewmodesettings.cpp b/src/settings/viewmodes/viewmodesettings.cpp
index 5936e29701de7905acd5d1683a51ea8f5337c4c0..1644cc074a2713f52e2bfa468e480835c6a73a7e 100644 (file)
--- a/src/settings/viewmodes/viewmodesettings.cpp
+++ b/src/settings/viewmodes/viewmodesettings.cpp
@@ -1,6 +1,6 @@
 /*
  * SPDX-FileCopyrightText: 2011 Peter Penz <peter.penz19@gmail.com>
- * SPDX-FileCopyrightText: 2021 Felix Ernst <fe.a.ernst@gmail.com>
+ * SPDX-FileCopyrightText: 2021 Felix Ernst <felixernst@kde.org>
  *
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
@@ -24,7 +24,7 @@ ViewModeSettings::ViewModeSettings()
     KSharedConfig::Ptr config = KSharedConfig::openConfig();
     // Migrate old config entries
     if (GeneralSettings::version() < 202) {
-        for (const char *groupName : {"CompactMode", "DetailsMode", "IconsMode"}) {
+        for (const QString &groupName : {QStringLiteral("CompactMode"), QStringLiteral("DetailsMode"), QStringLiteral("IconsMode")}) {
             KConfigGroup group = config->group(groupName);
             const QString family = group.readEntry("FontFamily", QString{});
             if (family.isEmpty()) {
@@ -51,9 +51,15 @@ ViewModeSettings::ViewModeSettings(DolphinView::Mode mode)
     : ViewModeSettings()
 {
     switch (mode) {
-    case DolphinView::IconsView:    m_viewModeSettingsVariant = IconsModeSettings::self();   return;
-    case DolphinView::CompactView:  m_viewModeSettingsVariant = CompactModeSettings::self(); return;
-    case DolphinView::DetailsView:  m_viewModeSettingsVariant = DetailsModeSettings::self(); return;
+    case DolphinView::IconsView:
+        m_viewModeSettingsVariant = IconsModeSettings::self();
+        return;
+    case DolphinView::CompactView:
+        m_viewModeSettingsVariant = CompactModeSettings::self();
+        return;
+    case DolphinView::DetailsView:
+        m_viewModeSettingsVariant = DetailsModeSettings::self();
+        return;
     default:
         Q_UNREACHABLE();
     }
@@ -63,9 +69,15 @@ ViewModeSettings::ViewModeSettings(ViewSettingsTab::Mode mode)
     : ViewModeSettings()
 {
     switch (mode) {
-    case ViewSettingsTab::IconsMode:    m_viewModeSettingsVariant = IconsModeSettings::self();   return;
-    case ViewSettingsTab::CompactMode:  m_viewModeSettingsVariant = CompactModeSettings::self(); return;
-    case ViewSettingsTab::DetailsMode:  m_viewModeSettingsVariant = DetailsModeSettings::self(); return;
+    case ViewSettingsTab::IconsMode:
+        m_viewModeSettingsVariant = IconsModeSettings::self();
+        return;
+    case ViewSettingsTab::CompactMode:
+        m_viewModeSettingsVariant = CompactModeSettings::self();
+        return;
+    case ViewSettingsTab::DetailsMode:
+        m_viewModeSettingsVariant = DetailsModeSettings::self();
+        return;
     default:
         Q_UNREACHABLE();
     }
@@ -75,9 +87,15 @@ ViewModeSettings::ViewModeSettings(KStandardItemListView::ItemLayout itemLayout)
     : ViewModeSettings()
 {
     switch (itemLayout) {
-    case KStandardItemListView::IconsLayout:    m_viewModeSettingsVariant = IconsModeSettings::self();   return;
-    case KStandardItemListView::CompactLayout:  m_viewModeSettingsVariant = CompactModeSettings::self(); return;
-    case KStandardItemListView::DetailsLayout:  m_viewModeSettingsVariant = DetailsModeSettings::self(); return;
+    case KStandardItemListView::IconsLayout:
+        m_viewModeSettingsVariant = IconsModeSettings::self();
+        return;
+    case KStandardItemListView::CompactLayout:
+        m_viewModeSettingsVariant = CompactModeSettings::self();
+        return;
+    case KStandardItemListView::DetailsLayout:
+        m_viewModeSettingsVariant = DetailsModeSettings::self();
+        return;
     default:
         Q_UNREACHABLE();
     }
@@ -85,77 +103,99 @@ ViewModeSettings::ViewModeSettings(KStandardItemListView::ItemLayout itemLayout)
 
 void ViewModeSettings::setIconSize(int iconSize)
 {
-    std::visit([iconSize](auto &&v) {
-        v->setIconSize(iconSize);
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [iconSize](auto &&v) {
+            v->setIconSize(iconSize);
+        },
+        m_viewModeSettingsVariant);
 }
 
 int ViewModeSettings::iconSize() const
 {
-    return std::visit([](auto &&v) {
-        return v->iconSize();
-    }, m_viewModeSettingsVariant);
+    return std::visit(
+        [](auto &&v) {
+            return v->iconSize();
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::setPreviewSize(int previewSize)
 {
-    std::visit([previewSize](auto &&v) {
-        v->setPreviewSize(previewSize);
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [previewSize](auto &&v) {
+            v->setPreviewSize(previewSize);
+        },
+        m_viewModeSettingsVariant);
 }
 
 int ViewModeSettings::previewSize() const
 {
-    return std::visit([](auto &&v) {
-        return v->previewSize();
-    }, m_viewModeSettingsVariant);
+    return std::visit(
+        [](auto &&v) {
+            return v->previewSize();
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::setUseSystemFont(bool useSystemFont)
 {
-    std::visit([useSystemFont](auto &&v) {
-        v->setUseSystemFont(useSystemFont);
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [useSystemFont](auto &&v) {
+            v->setUseSystemFont(useSystemFont);
+        },
+        m_viewModeSettingsVariant);
 }
 
 bool ViewModeSettings::useSystemFont() const
 {
-    return std::visit([](auto &&v) {
-        return v->useSystemFont();
-    }, m_viewModeSettingsVariant);
+    return std::visit(
+        [](auto &&v) {
+            return v->useSystemFont();
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::setViewFont(const QFont &font)
 {
-    std::visit([&font](auto &&v) {
-        v->setViewFont(font);
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [&font](auto &&v) {
+            v->setViewFont(font);
+        },
+        m_viewModeSettingsVariant);
 }
 
 QFont ViewModeSettings::viewFont() const
 {
-    return std::visit([](auto &&v) {
-        return v->viewFont();
-    }, m_viewModeSettingsVariant);
+    return std::visit(
+        [](auto &&v) {
+            return v->viewFont();
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::useDefaults(bool useDefaults)
 {
-    std::visit([useDefaults](auto &&v) {
-        v->useDefaults(useDefaults);
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [useDefaults](auto &&v) {
+            v->useDefaults(useDefaults);
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::readConfig()
 {
-    std::visit([](auto &&v) {
-        v->load();
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [](auto &&v) {
+            v->load();
+        },
+        m_viewModeSettingsVariant);
 }
 
 void ViewModeSettings::save()
 {
-    std::visit([](auto &&v) {
-        return v->save();
-    }, m_viewModeSettingsVariant);
+    std::visit(
+        [](auto &&v) {
+            return v->save();
+        },
+        m_viewModeSettingsVariant);
 }