fix crash when pressing F2 on startup

[dolphin.git] / src / dolphinpart.cpp

diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp
index 3a76286e70f889ef095b0f9cf20903dc9bb7706c..f278edddf4c3380912e9bfc02f564ac6e829ccb9 100644 (file)
--- a/src/dolphinpart.cpp
+++ b/src/dolphinpart.cpp
@@ -78,14 +78,18 @@ DolphinPart::DolphinPart(QWidget* parentWidget, QObject* parent, const QStringLi
             this, SLOT(slotErrorMessage(QString)));
     connect(m_view, SIGNAL(itemTriggered(KFileItem)),
             this, SLOT(slotItemTriggered(KFileItem)));
-    connect(m_view, SIGNAL(requestContextMenu(KFileItem, const KUrl&)),
-            this, SLOT(slotOpenContextMenu(KFileItem, const KUrl&)));
+    connect(m_view, SIGNAL(requestContextMenu(KFileItem,KUrl)),
+            this, SLOT(slotOpenContextMenu(KFileItem,KUrl)));
     connect(m_view, SIGNAL(selectionChanged(KFileItemList)),
             m_extension, SIGNAL(selectionInfo(KFileItemList)));
+    connect(m_view, SIGNAL(selectionChanged(KFileItemList)),
+            this, SLOT(slotSelectionChanged(KFileItemList)));
     connect(m_view, SIGNAL(requestItemInfo(KFileItem)),
             this, SLOT(slotRequestItemInfo(KFileItem)));
-    connect(m_view, SIGNAL(urlChanged(const KUrl&)),
-            this, SLOT(slotUrlChanged(const KUrl&)));
+    connect(m_view, SIGNAL(urlChanged(KUrl)),
+            this, SLOT(slotUrlChanged(KUrl)));
+    connect(m_view, SIGNAL(modeChanged()),
+            this, SLOT(updateViewActions()));
 
     createActions();
     updateViewActions();
@@ -93,6 +97,9 @@ DolphinPart::DolphinPart(QWidget* parentWidget, QObject* parent, const QStringLi
     // TODO provide these actions in the menu, merged with the existing view-mode-actions somehow
     // [Q_PROPERTY introspection?]
 
+    // TODO sort_by_* actions
+    // TODO show_*_info actions
+
     // TODO connect to urlsDropped
 
     // TODO there was a "always open a new window" (when clicking on a directory) setting in konqueror
@@ -119,6 +126,28 @@ void DolphinPart::createActions()
     viewModeActions->addAction(DolphinView::detailsModeAction(actionCollection()));
     viewModeActions->addAction(DolphinView::columnsModeAction(actionCollection()));
     connect(viewModeActions, SIGNAL(triggered(QAction*)), this, SLOT(slotViewModeActionTriggered(QAction*)));
+
+    KAction* renameAction = new KAction(i18nc("@action:inmenu", "Rename..."), this);
+    connect(renameAction, SIGNAL(triggered()), m_view, SLOT(renameSelectedItems()));
+    renameAction->setEnabled(false);
+    renameAction->setShortcut(Qt::Key_F2);
+    actionCollection()->addAction("rename", renameAction);
+}
+
+void DolphinPart::slotSelectionChanged(const KFileItemList& selection)
+{
+    // Yes, DolphinMainWindow has very similar code :/
+    if (selection.isEmpty()) {
+        stateChanged("has_no_selection");
+    } else {
+        stateChanged("has_selection");
+
+        QAction* renameAction = actionCollection()->action("rename");
+        Q_ASSERT(renameAction);
+        if (renameAction) {
+            renameAction->setEnabled(true);
+        }
+    }
 }
 
 void DolphinPart::updateViewActions()
@@ -137,14 +166,14 @@ KAboutData* DolphinPart::createAboutData()
 
 bool DolphinPart::openUrl(const KUrl& url)
 {
-    const QString prettyUrl = url.pathOrUrl();
-    emit setWindowCaption(prettyUrl);
-    emit m_extension->setLocationBarUrl(prettyUrl);
     const bool reload = arguments().reload();
     if (m_view->url() == url && !reload) { // DolphinView won't do anything in that case, so don't emit started
         return true;
     }
     setUrl(url); // remember it at the KParts level
+    const QString prettyUrl = url.pathOrUrl();
+    emit setWindowCaption(prettyUrl);
+    emit m_extension->setLocationBarUrl(prettyUrl);
     m_view->setUrl(url);
     if (reload)
         m_view->reload();
@@ -215,8 +244,18 @@ void DolphinPart::slotOpenContextMenu(const KFileItem& _item, const KUrl&)
         item = KFileItem( S_IFDIR, (mode_t)-1, url() );
     }
 
+    KParts::BrowserExtension::ActionGroupMap actionGroups;
+    QList<QAction *> editActions;
+    editActions.append(actionCollection()->action("rename"));
+    actionGroups.insert("editactions", editActions);
+
     KFileItemList items; items.append(item);
-    emit m_extension->popupMenu( QCursor::pos(), items, KParts::OpenUrlArguments(), KParts::BrowserArguments(), popupFlags );
+    emit m_extension->popupMenu(QCursor::pos(),
+                                items,
+                                KParts::OpenUrlArguments(),
+                                KParts::BrowserArguments(),
+                                popupFlags,
+                                actionGroups);
 }
 
 void DolphinPart::slotViewModeActionTriggered(QAction* action)