Properly use X11 startup ids

[dolphin.git] / src / dolphinmainwindow.cpp

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 7cdfbc6fba092609cf21894794013612f873e7c0..f3ec70753ca4f502b10fda1a3ea2915602cbd460 100644 (file)
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -41,9 +41,13 @@
 #include <KConfigGui>
 #include <KDualAction>
 #include <KFileItemListProperties>
 #include <KConfigGui>
 #include <KDualAction>
 #include <KFileItemListProperties>

-#include <KHelpMenu>

 #include <KIO/CommandLauncherJob>
 #include <KIO/CommandLauncherJob>

+#include <kio_version.h>
+#if KIO_VERSION >= QT_VERSION_CHECK(5, 98, 0)
+#include <KIO/JobUiDelegateFactory>
+#else

 #include <KIO/JobUiDelegate>
 #include <KIO/JobUiDelegate>

+#endif

 #include <KIO/OpenFileManagerWindowJob>
 #include <KIO/OpenUrlJob>
 #include <KJobWidgets>
 #include <KIO/OpenFileManagerWindowJob>
 #include <KIO/OpenUrlJob>
 #include <KJobWidgets>


@@ -66,6 +70,7 @@
 #include <KWindowSystem>
 #include <KXMLGUIFactory>
 
 #include <KWindowSystem>
 #include <KXMLGUIFactory>
 

+#include <kwidgetsaddons_version.h>

 #include <kio_version.h>
 
 #include <QApplication>
 #include <kio_version.h>
 
 #include <QApplication>


@@ -82,7 +87,6 @@
 #include <QStandardPaths>
 #include <QTimer>
 #include <QToolButton>
 #include <QStandardPaths>
 #include <QTimer>
 #include <QToolButton>

-#include <QWhatsThisClickedEvent>

 
 namespace {
     // Used for GeneralSettings::version() to determine whether
 
 namespace {
     // Used for GeneralSettings::version() to determine whether


@@ -99,15 +103,12 @@ namespace {
 DolphinMainWindow::DolphinMainWindow() :
     KXmlGuiWindow(nullptr),
     m_newFileMenu(nullptr),
 DolphinMainWindow::DolphinMainWindow() :
     KXmlGuiWindow(nullptr),
     m_newFileMenu(nullptr),

-    m_helpMenu(nullptr),

     m_tabWidget(nullptr),
     m_activeViewContainer(nullptr),
     m_actionHandler(nullptr),
     m_remoteEncoding(nullptr),
     m_settingsDialog(),
     m_bookmarkHandler(nullptr),
     m_tabWidget(nullptr),
     m_activeViewContainer(nullptr),
     m_actionHandler(nullptr),
     m_remoteEncoding(nullptr),
     m_settingsDialog(),
     m_bookmarkHandler(nullptr),

-    m_controlButton(nullptr),
-    m_updateToolBarTimer(nullptr),

     m_lastHandleUrlOpenJob(nullptr),
     m_terminalPanel(nullptr),
     m_placesPanel(nullptr),
     m_lastHandleUrlOpenJob(nullptr),
     m_terminalPanel(nullptr),
     m_placesPanel(nullptr),


@@ -281,11 +282,17 @@ void DolphinMainWindow::openFiles(const QStringList& files, bool splitView)
     openFiles(QUrl::fromStringList(files), splitView);
 }
 
     openFiles(QUrl::fromStringList(files), splitView);
 }
 

-void DolphinMainWindow::activateWindow()
+void DolphinMainWindow::activateWindow(const QString &activationToken)

 {
     window()->setAttribute(Qt::WA_NativeWindow, true);
 {
     window()->setAttribute(Qt::WA_NativeWindow, true);

-    KStartupInfo::setNewStartupId(window()->windowHandle(), KStartupInfo::startupId());
-    KWindowSystem::activateWindow(window()->effectiveWinId());
+
+    if (KWindowSystem::isPlatformWayland()) {
+        KWindowSystem::setCurrentXdgActivationToken(activationToken);
+    } else {
+        KStartupInfo::setNewStartupId(window()->windowHandle(), activationToken.toUtf8());
+    }
+
+    KWindowSystem::activateWindow(window()->windowHandle());

 }
 
 bool DolphinMainWindow::isActiveWindow()
 }
 
 bool DolphinMainWindow::isActiveWindow()


@@ -815,7 +822,6 @@ void DolphinMainWindow::slotAboutToShowBackPopupMenu()
     m_backAction->menu()->clear();
     for (int i = urlNavigator->historyIndex() + 1; i < urlNavigator->historySize() && entries < MaxNumberOfNavigationentries; ++i, ++entries) {
         QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_backAction->menu());
     m_backAction->menu()->clear();
     for (int i = urlNavigator->historyIndex() + 1; i < urlNavigator->historySize() && entries < MaxNumberOfNavigationentries; ++i, ++entries) {
         QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_backAction->menu());

-        action->setData(i);

         m_backAction->menu()->addAction(action);
     }
 }
         m_backAction->menu()->addAction(action);
     }
 }


@@ -844,7 +850,6 @@ void DolphinMainWindow::slotAboutToShowForwardPopupMenu()
     m_forwardAction->menu()->clear();
     for (int i = urlNavigator->historyIndex() - 1; i >= 0 && entries < MaxNumberOfNavigationentries; --i, ++entries) {
         QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_forwardAction->menu());
     m_forwardAction->menu()->clear();
     for (int i = urlNavigator->historyIndex() - 1; i >= 0 && entries < MaxNumberOfNavigationentries; --i, ++entries) {
         QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_forwardAction->menu());

-        action->setData(i);

         m_forwardAction->menu()->addAction(action);
     }
 }
         m_forwardAction->menu()->addAction(action);
     }
 }


@@ -1173,11 +1178,19 @@ void DolphinMainWindow::openTerminalHere()
     if (urls.count() > 5) {
         QString question = i18np("Are you sure you want to open 1 terminal window?",
                                  "Are you sure you want to open %1 terminal windows?", urls.count());
     if (urls.count() > 5) {
         QString question = i18np("Are you sure you want to open 1 terminal window?",
                                  "Are you sure you want to open %1 terminal windows?", urls.count());

+#if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0)
+        const int answer = KMessageBox::warningTwoActions(this, question, {},
+#else

         const int answer = KMessageBox::warningYesNo(this, question, {},
         const int answer = KMessageBox::warningYesNo(this, question, {},

+#endif

                                                      KGuiItem(i18ncp("@action:button", "Open %1 Terminal", "Open %1 Terminals", urls.count()),
                                                               QStringLiteral("utilities-terminal")),
                                                      KStandardGuiItem::cancel());
                                                      KGuiItem(i18ncp("@action:button", "Open %1 Terminal", "Open %1 Terminals", urls.count()),
                                                               QStringLiteral("utilities-terminal")),
                                                      KStandardGuiItem::cancel());

+#if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0)
+        if (answer != KMessageBox::PrimaryAction) {
+#else

         if (answer != KMessageBox::Yes) {
         if (answer != KMessageBox::Yes) {

+#endif

             return;
         }
     }
             return;
         }
     }


@@ -1248,7 +1261,11 @@ void DolphinMainWindow::handleUrl(const QUrl& url)
         activeViewContainer()->setUrl(url);
     } else {
         m_lastHandleUrlOpenJob = new KIO::OpenUrlJob(url);
         activeViewContainer()->setUrl(url);
     } else {
         m_lastHandleUrlOpenJob = new KIO::OpenUrlJob(url);

+#if KIO_VERSION >= QT_VERSION_CHECK(5, 98, 0)
+        m_lastHandleUrlOpenJob->setUiDelegate(KIO::createDefaultJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
+#else

         m_lastHandleUrlOpenJob->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
         m_lastHandleUrlOpenJob->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));

+#endif

         m_lastHandleUrlOpenJob->setShowOpenOrExecuteDialog(true);
 
         connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this,
         m_lastHandleUrlOpenJob->setShowOpenOrExecuteDialog(true);
 
         connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this,


@@ -1438,6 +1455,10 @@ void DolphinMainWindow::activeViewChanged(DolphinViewContainer* viewContainer)
         // except the requestItemInfo so that on hover the information panel can still be updated
         connect(oldViewContainer->view(), &DolphinView::requestItemInfo,
                 this, &DolphinMainWindow::requestItemInfo);
         // except the requestItemInfo so that on hover the information panel can still be updated
         connect(oldViewContainer->view(), &DolphinView::requestItemInfo,
                 this, &DolphinMainWindow::requestItemInfo);

+
+        // Disconnect other slots.
+        disconnect(nullptr, &DolphinViewContainer::selectionModeChanged,
+                   actionCollection()->action(QStringLiteral("toggle_selection_mode")), &QAction::setChecked);

     }
 
     connectViewSignals(viewContainer);
     }
 
     connectViewSignals(viewContainer);


@@ -1527,7 +1548,7 @@ void DolphinMainWindow::setViewsToHomeIfMountPathOpen(const QString& mountPath)
 
 void DolphinMainWindow::setupActions()
 {
 
 void DolphinMainWindow::setupActions()
 {

-    KStandardAction::hamburgerMenu(nullptr, nullptr, actionCollection());
+    auto hamburgerMenuAction = KStandardAction::hamburgerMenu(nullptr, nullptr, actionCollection());

 
     // setup 'File' menu
     m_newFileMenu = new DolphinNewFileMenu(actionCollection(), this);
 
     // setup 'File' menu
     m_newFileMenu = new DolphinNewFileMenu(actionCollection(), this);


@@ -1891,9 +1912,12 @@ void DolphinMainWindow::setupActions()
     // setup 'Settings' menu
     KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection());
     showMenuBar->setWhatsThis(xi18nc("@info:whatsthis",
     // setup 'Settings' menu
     KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection());
     showMenuBar->setWhatsThis(xi18nc("@info:whatsthis",

-            "This switches between having a <emphasis>Menubar</emphasis> "
-            "and having a <interface>Control</interface> button. Both "
-            "contain mostly the same commands and configuration options."));
+            "<para>This switches between having a <emphasis>Menubar</emphasis> "
+            "and having a <interface>%1</interface> button. Both "
+            "contain mostly the same actions and configuration options.</para>"
+            "<para>The Menubar takes up more space but allows for fast and organised access to all "
+            "actions an application has to offer.</para><para>The <interface>%1</interface> button "
+            "is simpler and small which makes triggering advanced actions more time consuming.</para>", hamburgerMenuAction->text().replace('&', "")));

     connect(showMenuBar, &KToggleAction::triggered,                   // Fixes #286822
             this, &DolphinMainWindow::toggleShowMenuBar, Qt::QueuedConnection);
 
     connect(showMenuBar, &KToggleAction::triggered,                   // Fixes #286822
             this, &DolphinMainWindow::toggleShowMenuBar, Qt::QueuedConnection);
 


@@ -1908,18 +1932,6 @@ void DolphinMainWindow::setupActions()
     KStandardAction::keyBindings(this, &DolphinMainWindow::slotKeyBindings, actionCollection());
     KStandardAction::preferences(this, &DolphinMainWindow::editSettings, actionCollection());
 
     KStandardAction::keyBindings(this, &DolphinMainWindow::slotKeyBindings, actionCollection());
     KStandardAction::preferences(this, &DolphinMainWindow::editSettings, actionCollection());
 

-    // setup 'Help' menu for the m_controlButton. The other one is set up in the base class.
-    m_helpMenu = new KHelpMenu(nullptr);
-    m_helpMenu->menu()->installEventFilter(this);
-    // remove duplicate shortcuts
-    auto removeHelpActionShortcut = [this](KHelpMenu::MenuId menuId) {
-        if (auto *action = m_helpMenu->action(menuId)) {
-            action->setShortcut(QKeySequence());
-        }
-    };
-    removeHelpActionShortcut(KHelpMenu::menuHelpContents);
-    removeHelpActionShortcut(KHelpMenu::menuWhatsThis);
-

     // not in menu actions
     QList<QKeySequence> nextTabKeys = KStandardShortcut::tabNext();
     nextTabKeys.append(QKeySequence(Qt::CTRL | Qt::Key_Tab));
     // not in menu actions
     QList<QKeySequence> nextTabKeys = KStandardShortcut::tabNext();
     nextTabKeys.append(QKeySequence(Qt::CTRL | Qt::Key_Tab));


@@ -2029,7 +2041,7 @@ void DolphinMainWindow::setupDockWidgets()
 
     // i18n: This is the last paragraph for the "What's This"-texts of all four panels.
     const QString panelWhatsThis = xi18nc("@info:whatsthis", "<para>To show or "
 
     // i18n: This is the last paragraph for the "What's This"-texts of all four panels.
     const QString panelWhatsThis = xi18nc("@info:whatsthis", "<para>To show or "

-        "hide panels like this go to <interface>Control|Panels</interface> "
+        "hide panels like this go to <interface>Menu|Panels</interface> "

         "or <interface>View|Panels</interface>.</para>");
 #if HAVE_BALOO
     actionCollection()->action(QStringLiteral("show_information_panel"))
         "or <interface>View|Panels</interface>.</para>");
 #if HAVE_BALOO
     actionCollection()->action(QStringLiteral("show_information_panel"))


@@ -2300,13 +2312,6 @@ void DolphinMainWindow::updateViewActions()
 {
     m_actionHandler->updateViewActions();
 
 {
     m_actionHandler->updateViewActions();
 

-    QAction *toggleSelectionModeAction = actionCollection()->action(QStringLiteral("toggle_selection_mode"));
-    disconnect(nullptr, &DolphinViewContainer::selectionModeChanged,
-               toggleSelectionModeAction, &QAction::setChecked);
-    toggleSelectionModeAction->setChecked(m_activeViewContainer->isSelectionModeEnabled());
-    connect(m_activeViewContainer, &DolphinViewContainer::selectionModeChanged,
-            toggleSelectionModeAction, &QAction::setChecked);
-

     QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
     toggleFilterBarAction->setChecked(m_activeViewContainer->isFilterBarVisible());
 
     QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
     toggleFilterBarAction->setChecked(m_activeViewContainer->isFilterBarVisible());
 


@@ -2364,6 +2369,12 @@ void DolphinMainWindow::connectViewSignals(DolphinViewContainer* container)
     const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
     connect(toggleSearchAction, &QAction::triggered, container, &DolphinViewContainer::setSearchModeEnabled);
 
     const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
     connect(toggleSearchAction, &QAction::triggered, container, &DolphinViewContainer::setSearchModeEnabled);
 

+    // Make the toggled state of the selection mode actions visually follow the selection mode state of the view.
+    auto toggleSelectionModeAction = actionCollection()->action(QStringLiteral("toggle_selection_mode"));
+    toggleSelectionModeAction->setChecked(m_activeViewContainer->isSelectionModeEnabled());
+    connect(m_activeViewContainer, &DolphinViewContainer::selectionModeChanged,
+            toggleSelectionModeAction, &QAction::setChecked);
+

     const DolphinView* view = container->view();
     connect(view, &DolphinView::selectionChanged,
             this, &DolphinMainWindow::slotSelectionChanged);
     const DolphinView* view = container->view();
     connect(view, &DolphinView::selectionChanged,
             this, &DolphinMainWindow::slotSelectionChanged);


@@ -2492,16 +2503,16 @@ void DolphinMainWindow::setupWhatsThis()
         "configuration options. Left-click on any of the menus on this "
         "bar to see its contents.</para><para>The Menubar can be hidden "
         "by unchecking <interface>Settings|Show Menubar</interface>. Then "
         "configuration options. Left-click on any of the menus on this "
         "bar to see its contents.</para><para>The Menubar can be hidden "
         "by unchecking <interface>Settings|Show Menubar</interface>. Then "

-        "most of its contents become available through a <interface>Control"
+        "most of its contents become available through a <interface>Menu"

         "</interface> button on the <emphasis>Toolbar</emphasis>.</para>"));
     toolBar()->setWhatsThis(xi18nc("@info:whatsthis", "<para>This is the "
         "<emphasis>Toolbar</emphasis>. It allows quick access to "
         "frequently used actions.</para><para>It is highly customizable. "
         "</interface> button on the <emphasis>Toolbar</emphasis>.</para>"));
     toolBar()->setWhatsThis(xi18nc("@info:whatsthis", "<para>This is the "
         "<emphasis>Toolbar</emphasis>. It allows quick access to "
         "frequently used actions.</para><para>It is highly customizable. "

-        "All items you see in the <interface>Control</interface> menu or "
+        "All items you see in the <interface>Menu</interface> or "

         "in the <interface>Menubar</interface> can be placed on the "
         "Toolbar. Just right-click on it and select <interface>Configure "
         "in the <interface>Menubar</interface> can be placed on the "
         "Toolbar. Just right-click on it and select <interface>Configure "

-        "Toolbars…</interface> or find this action in the <interface>"
-        "Control</interface> or <interface>Settings</interface> menu."
+        "Toolbars…</interface> or find this action within the <interface>"
+        "menu</interface>."

         "</para><para>The location of the bar and the style of its "
         "buttons can also be changed in the right-click menu. Right-click "
         "a button if you want to show or hide its text.</para>"));
         "</para><para>The location of the bar and the style of its "
         "buttons can also be changed in the right-click menu. Right-click "
         "a button if you want to show or hide its text.</para>"));


@@ -2530,8 +2541,7 @@ void DolphinMainWindow::setupWhatsThis()
     actionCollection()->action(KStandardAction::name(KStandardAction::ConfigureToolbars))
         ->setWhatsThis(xi18nc("@info:whatsthis","<para>This opens a window in which "
         "you can change which buttons appear on the <emphasis>Toolbar</emphasis>.</para>"
     actionCollection()->action(KStandardAction::name(KStandardAction::ConfigureToolbars))
         ->setWhatsThis(xi18nc("@info:whatsthis","<para>This opens a window in which "
         "you can change which buttons appear on the <emphasis>Toolbar</emphasis>.</para>"

-        "<para>All items you see in the <interface>Control</interface> menu "
-        "or in the <interface>Menubar</interface> can also be placed on the Toolbar.</para>"));
+        "<para>All items you see in the <interface>Menu</interface> can also be placed on the Toolbar.</para>"));

     actionCollection()->action(KStandardAction::name(KStandardAction::Preferences))
         ->setWhatsThis(xi18nc("@info:whatsthis","This opens a window where you can "
         "change a multitude of settings for this application. For an explanation "
     actionCollection()->action(KStandardAction::name(KStandardAction::Preferences))
         ->setWhatsThis(xi18nc("@info:whatsthis","This opens a window where you can "
         "change a multitude of settings for this application. For an explanation "


@@ -2539,77 +2549,38 @@ void DolphinMainWindow::setupWhatsThis()
         "</emphasis> in <interface>Help|Dolphin Handbook</interface>."));
 
     // Help menu
         "</emphasis> in <interface>Help|Dolphin Handbook</interface>."));
 
     // Help menu

-    // The whatsthis has to be set for the m_helpMenu and for the
-    // StandardAction separately because both are used in different locations.
-    // m_helpMenu is only used for createControlButton() button.
-
-    auto setStandardActionWhatsThis = [this](KStandardAction::StandardAction actionId,
-                                             const QString &whatsThis) {
-        if (auto *action = actionCollection()->action(KStandardAction::name(actionId))) {
-            action->setWhatsThis(whatsThis);
-        }
-    };
-    auto setHelpActionWhatsThis = [this](KHelpMenu::MenuId menuId, const QString &whatsThis) {
-        if (auto *action = m_helpMenu->action(menuId)) {
-            action->setWhatsThis(whatsThis);
-        }
-    };
-
-    // Links do not work within the Menubar so texts without links are provided there.

 
 

-    // i18n: If the external link isn't available in your language you should
-    // probably state the external link language at least in brackets to not
+    // i18n: If the external link isn't available in your language it might make
+    // sense to state the external link's language in brackets to not

     // frustrate the user. If there are multiple languages that the user might
     // know with a reasonable chance you might want to have 2 external links.
     // frustrate the user. If there are multiple languages that the user might
     // know with a reasonable chance you might want to have 2 external links.

-    // The same is in my opinion true for every external link you translate.
-    const QString whatsThisHelpContents = xi18nc("@info:whatsthis handbook",
-        "<para>This opens the Handbook for this application. It provides "
-        "explanations for every part of <emphasis>Dolphin</emphasis>.</para>");
-    setStandardActionWhatsThis(KStandardAction::HelpContents, whatsThisHelpContents
-        + xi18nc("@info:whatsthis second half of handbook hb text without link",
-        "<para>If you want more elaborate introductions to the "
-        "different features of <emphasis>Dolphin</emphasis> "
-        "go to the KDE UserBase Wiki.</para>"));
-    setHelpActionWhatsThis(KHelpMenu::menuHelpContents, whatsThisHelpContents
-        + xi18nc("@info:whatsthis second half of handbook text with link",
-        "<para>If you want more elaborate introductions to the "
-        "different features of <emphasis>Dolphin</emphasis> "
-        "<link url='https://userbase.kde.org/Dolphin/File_Management'>click here</link>. "
-        "It will open the dedicated page in the KDE UserBase Wiki.</para>"));
-
-    const QString whatsThisWhatsThis = xi18nc("@info:whatsthis whatsthis button",
+    // The same might be true for any external link you translate.
+    actionCollection()->action(KStandardAction::name(KStandardAction::HelpContents))->setWhatsThis(xi18nc("@info:whatsthis handbook", "<para>This opens the Handbook for this application. It provides explanations for every part of <emphasis>Dolphin</emphasis>.</para><para>If you want more elaborate introductions to the different features of <emphasis>Dolphin</emphasis> <link url='https://userbase.kde.org/Dolphin/File_Management'>click here</link>. It will open the dedicated page in the KDE UserBase Wiki.</para>"));
+    // (The i18n call should be completely in the line following the i18n: comment without any line breaks within the i18n call or the comment might not be correctly extracted. See: https://commits.kde.org/kxmlgui/a31135046e1b3335b5d7bbbe6aa9a883ce3284c1 )
+
+    actionCollection()->action(KStandardAction::name(KStandardAction::WhatsThis))->setWhatsThis(
+        xi18nc("@info:whatsthis whatsthis button",

         "<para>This is the button that invokes the help feature you are "
         "using right now! Click it, then click any component of this "
         "application to ask \"What's this?\" about it. The mouse cursor "
         "<para>This is the button that invokes the help feature you are "
         "using right now! Click it, then click any component of this "
         "application to ask \"What's this?\" about it. The mouse cursor "

-        "will change appearance if no help is available for a spot.</para>");
-    setStandardActionWhatsThis(KStandardAction::WhatsThis, whatsThisWhatsThis
-        + xi18nc("@info:whatsthis second half of whatsthis button text without link",
-        "<para>There are two other ways to get help for this application: The "
-        "<interface>Dolphin Handbook</interface> in the <interface>Help"
-        "</interface> menu and the <emphasis>KDE UserBase Wiki</emphasis> "
-        "article about <emphasis>File Management</emphasis> online."
-        "</para><para>The \"What's this?\" help is "
-        "missing in most other windows so don't get too used to this.</para>"));
-    setHelpActionWhatsThis(KHelpMenu::menuWhatsThis, whatsThisWhatsThis
-        + xi18nc("@info:whatsthis second half of whatsthis button text with link",
+        "will change appearance if no help is available for a spot.</para>"

         "<para>There are two other ways to get help: "
         "The <link url='help:/dolphin/index.html'>Dolphin Handbook</link> and "
         "the <link url='https://userbase.kde.org/Dolphin/File_Management'>KDE "
         "UserBase Wiki</link>.</para><para>The \"What's this?\" help is "
         "missing in most other windows so don't get too used to this.</para>"));
 
         "<para>There are two other ways to get help: "
         "The <link url='help:/dolphin/index.html'>Dolphin Handbook</link> and "
         "the <link url='https://userbase.kde.org/Dolphin/File_Management'>KDE "
         "UserBase Wiki</link>.</para><para>The \"What's this?\" help is "
         "missing in most other windows so don't get too used to this.</para>"));
 

-    const QString whatsThisReportBug = xi18nc("@info:whatsthis","<para>This opens a "
+    actionCollection()->action(KStandardAction::name(KStandardAction::ReportBug))->setWhatsThis(
+        xi18nc("@info:whatsthis","<para>This opens a "

         "window that will guide you through reporting errors or flaws "
         "window that will guide you through reporting errors or flaws "

-        "in this application or in other KDE software.</para>");
-    setStandardActionWhatsThis(KStandardAction::ReportBug, whatsThisReportBug);
-    setHelpActionWhatsThis(KHelpMenu::menuReportBug, whatsThisReportBug
-        + xi18nc("@info:whatsthis second half of reportbug text with link",
+        "in this application or in other KDE software.</para>"

         "<para>High-quality bug reports are much appreciated. To learn "
         "how to make your bug report as effective as possible "
         "<link url='https://community.kde.org/Get_Involved/Bug_Reporting'>"
         "click here</link>.</para>"));
 
         "<para>High-quality bug reports are much appreciated. To learn "
         "how to make your bug report as effective as possible "
         "<link url='https://community.kde.org/Get_Involved/Bug_Reporting'>"
         "click here</link>.</para>"));
 

-    const QString whatsThisDonate = xi18nc("@info:whatsthis","<para>This opens a "
+    actionCollection()->action(KStandardAction::name(KStandardAction::Donate))->setWhatsThis(
+        xi18nc("@info:whatsthis", "<para>This opens a "

         "<emphasis>web page</emphasis> where you can donate to "
         "support the continued work on this application and many "
         "other projects by the <emphasis>KDE</emphasis> community.</para>"
         "<emphasis>web page</emphasis> where you can donate to "
         "support the continued work on this application and many "
         "other projects by the <emphasis>KDE</emphasis> community.</para>"


@@ -2618,31 +2589,25 @@ void DolphinMainWindow::setupWhatsThis()
         "free therefore your donation is needed to cover things that "
         "require money like servers, contributor meetings, etc.</para>"
         "<para><emphasis>KDE e.V.</emphasis> is the non-profit "
         "free therefore your donation is needed to cover things that "
         "require money like servers, contributor meetings, etc.</para>"
         "<para><emphasis>KDE e.V.</emphasis> is the non-profit "

-        "organization behind the KDE community.</para>");
-    setStandardActionWhatsThis(KStandardAction::Donate, whatsThisDonate);
-    setHelpActionWhatsThis(KHelpMenu::menuDonate, whatsThisDonate);
+        "organization behind the KDE community.</para>"));

 
 

-    const QString whatsThisSwitchLanguage = xi18nc("@info:whatsthis",
+    actionCollection()->action(KStandardAction::name(KStandardAction::SwitchApplicationLanguage))->setWhatsThis(
+        xi18nc("@info:whatsthis",

         "With this you can change the language this application uses."
         "<nl/>You can even set secondary languages which will be used "
         "With this you can change the language this application uses."
         "<nl/>You can even set secondary languages which will be used "

-        "if texts are not available in your preferred language.");
-    setStandardActionWhatsThis(KStandardAction::SwitchApplicationLanguage,
-                               whatsThisSwitchLanguage);
-    setHelpActionWhatsThis(KHelpMenu::menuSwitchLanguage, whatsThisSwitchLanguage);
+        "if texts are not available in your preferred language."));

 
 

-    const QString whatsThisAboutApp = xi18nc("@info:whatsthis","This opens a "
+    actionCollection()->action(KStandardAction::name(KStandardAction::AboutApp))->setWhatsThis(
+        xi18nc("@info:whatsthis","This opens a "

         "window that informs you about the version, license, "
         "window that informs you about the version, license, "

-        "used libraries and maintainers of this application.");
-    setStandardActionWhatsThis(KStandardAction::AboutApp, whatsThisAboutApp);
-    setHelpActionWhatsThis(KHelpMenu::menuAboutApp, whatsThisAboutApp);
+        "used libraries and maintainers of this application."));

 
 

-    const QString whatsThisAboutKDE = xi18nc("@info:whatsthis","This opens a "
+    actionCollection()->action(KStandardAction::name(KStandardAction::AboutKDE))->setWhatsThis(
+        xi18nc("@info:whatsthis","This opens a "

         "window with information about <emphasis>KDE</emphasis>. "
         "The KDE community are the people behind this free software."
         "<nl/>If you like using this application but don't know "
         "window with information about <emphasis>KDE</emphasis>. "
         "The KDE community are the people behind this free software."
         "<nl/>If you like using this application but don't know "

-        "about KDE or want to see a cute dragon have a look!");
-    setStandardActionWhatsThis(KStandardAction::AboutKDE, whatsThisAboutKDE);
-    setHelpActionWhatsThis(KHelpMenu::menuAboutKDE, whatsThisAboutKDE);
+        "about KDE or want to see a cute dragon have a look!"));

 }
 
 bool DolphinMainWindow::addHamburgerMenuToToolbar()
 }
 
 bool DolphinMainWindow::addHamburgerMenuToToolbar()


@@ -2668,29 +2633,6 @@ bool DolphinMainWindow::addHamburgerMenuToToolbar()
     // whenever this method is removed (maybe in the year ~2026).
 }
 
     // whenever this method is removed (maybe in the year ~2026).
 }
 

-bool DolphinMainWindow::event(QEvent *event)
-{
-    if (event->type() == QEvent::WhatsThisClicked) {
-        event->accept();
-        QWhatsThisClickedEvent* whatsThisEvent = dynamic_cast<QWhatsThisClickedEvent*>(event);
-        QDesktopServices::openUrl(QUrl(whatsThisEvent->href()));
-        return true;
-    }
-    return KXmlGuiWindow::event(event);
-}
-
-bool DolphinMainWindow::eventFilter(QObject* obj, QEvent* event)
-{
-    Q_UNUSED(obj)
-    if (event->type() == QEvent::WhatsThisClicked) {
-        event->accept();
-        QWhatsThisClickedEvent* whatsThisEvent = dynamic_cast<QWhatsThisClickedEvent*>(event);
-        QDesktopServices::openUrl(QUrl(whatsThisEvent->href()));
-        return true;
-    }
-    return false;
-}
-

 // Set a sane initial window size
 QSize DolphinMainWindow::sizeHint() const
 {
 // Set a sane initial window size
 QSize DolphinMainWindow::sizeHint() const
 {


@@ -2753,7 +2695,7 @@ bool DolphinMainWindow::isUrlOpen(const QString &url)
     return m_tabWidget->isUrlOpen(QUrl::fromUserInput(url));
 }
 
     return m_tabWidget->isUrlOpen(QUrl::fromUserInput(url));
 }
 

-bool DolphinMainWindow::isUrlOrParentOpen(const QString &url)
+bool DolphinMainWindow::isItemVisibleInAnyView(const QString &urlOfItem)

 {
 {

-    return m_tabWidget->isUrlOrParentOpen(QUrl::fromUserInput(url));
+    return m_tabWidget->isItemVisibleInAnyView(QUrl::fromUserInput(urlOfItem));

 }
 }