]> cloud.milkyroute.net Git - dolphin.git/blobdiff - src/settings/interface/folderstabssettingspage.cpp
Add comment to explain KColorSchemeManager
[dolphin.git] / src / settings / interface / folderstabssettingspage.cpp
index d71ad2d96b01922c960ba400e22d1d787b235ba2..286295e64fd7e34377b140453dcbd476c2a13ae2 100644 (file)
@@ -115,13 +115,14 @@ FoldersTabsSettingsPage::FoldersTabsSettingsPage(QWidget *parent)
     topLayout->addItem(new QSpacerItem(0, Dolphin::VERTICAL_SPACER_HEIGHT, QSizePolicy::Fixed, QSizePolicy::Fixed));
 
     // 'Switch between panes of split views with tab key'
-    m_useTabForSplitViewSwitch = new QCheckBox(i18nc("option:check split view panes", "Switch between panes with Tab key"));
+    m_useTabForSplitViewSwitch = new QCheckBox(i18nc("option:check split view panes", "Switch between views with Tab key"));
     topLayout->addRow(i18nc("@title:group", "Split view: "), m_useTabForSplitViewSwitch);
 
     // 'Close active pane when turning off split view'
-    m_closeActiveSplitView = new QCheckBox(i18nc("option:check", "Turning off split view closes active pane"));
+    m_closeActiveSplitView = new QCheckBox(i18nc("option:check", "Turning off split view closes the view in focus"));
     topLayout->addRow(QString(), m_closeActiveSplitView);
-    m_closeActiveSplitView->setToolTip(i18n("When deactivated, turning off split view will close the inactive pane"));
+    m_closeActiveSplitView->setToolTip(
+        i18n("When unchecked, the opposite view will be closed. The Close icon always illustrates which view (left or right) will be closed."));
 
     // 'Begin in split view mode'
     m_splitView = new QCheckBox(i18nc("@option:check Startup Settings", "Begin in split view mode"));
@@ -160,7 +161,7 @@ void FoldersTabsSettingsPage::applySettings()
     settings->setCloseActiveSplitView(m_closeActiveSplitView->isChecked());
     const QUrl url(QUrl::fromUserInput(m_homeUrl->text(), QString(), QUrl::AssumeLocalFile));
     if (url.isValid() && KProtocolManager::supportsListing(url)) {
-        KIO::StatJob *job = KIO::statDetails(url, KIO::StatJob::SourceSide, KIO::StatDetail::StatBasic, KIO::JobFlag::HideProgressInfo);
+        KIO::StatJob *job = KIO::stat(url, KIO::StatJob::SourceSide, KIO::StatDetail::StatBasic, KIO::JobFlag::HideProgressInfo);
         connect(job, &KJob::result, this, [this, settings, url](KJob *job) {
             if (job->error() == 0 && qobject_cast<KIO::StatJob *>(job)->statResult().isDir()) {
                 settings->setHomeUrl(url.toDisplayString(QUrl::PreferLocalFile));
@@ -174,7 +175,7 @@ void FoldersTabsSettingsPage::applySettings()
 
     // Remove saved state if "remember open tabs" has been turned off
     if (!m_rememberOpenedTabsRadioButton->isChecked()) {
-        KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "WindowState"};
+        KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), QStringLiteral("WindowState")};
         if (windowState.exists()) {
             windowState.deleteGroup();
         }