]> cloud.milkyroute.net Git - dolphin.git/blobdiff - src/dolphincontextmenu.cpp
Use a QLinkedList instead of Q3PtrList
[dolphin.git] / src / dolphincontextmenu.cpp
index bea01afc44dc516212770693f71265b45d495500..4c04170d6223a538bf05e00ceb6af207a8a92c06 100644 (file)
@@ -15,7 +15,7 @@
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
  ***************************************************************************/
 
 #include "dolphincontextmenu.h"
@@ -23,7 +23,7 @@
 #include <kactioncollection.h>
 #include <kbookmarkmanager.h>
 #include <kbookmark.h>
-#include <ktrader.h>
+#include <kmimetypetrader.h>
 #include <klocale.h>
 #include <krun.h>
 #include <qdir.h>
 #include <kpropertiesdialog.h>
 #include <kdesktopfile.h>
 #include <assert.h>
-#include <ksortablevaluelist.h>
 #include <kio/netaccess.h>
+#include <kmenu.h>
+#include <kstdaction.h>
 
-#include "dolphin.h"
+#include "dolphinmainwindow.h"
 #include "dolphinview.h"
 #include "editbookmarkdialog.h"
 #include "dolphinsettings.h"
@@ -76,28 +77,23 @@ void DolphinContextMenu::openViewportContextMenu()
     // (Copyright (C) 2000  David Faure <faure@kde.org>)
 
     assert(m_fileInfo == 0);
-    const int propertiesID = 100;
-       const int bookmarkID = 101;
 
     KMenu* popup = new KMenu(m_dolphinView);
-    Dolphin& dolphin = Dolphin::mainWin();
+    DolphinMainWindow *dolphin = m_dolphinView->mainWindow();
 
     // setup 'Create New' menu
     KMenu* createNewMenu = new KMenu();
 
-    KAction* createFolderAction = dolphin.actionCollection()->action("create_folder");
+    QAction* createFolderAction = dolphin->actionCollection()->action("create_folder");
     if (createFolderAction != 0) {
-        createFolderAction->plug(createNewMenu);
+        createNewMenu->addAction(createFolderAction);
     }
 
     createNewMenu->insertSeparator();
 
-    KAction* action = 0;
-
-    Q3PtrListIterator<KAction> fileGrouptIt(dolphin.fileGroupActions());
-    while ((action = fileGrouptIt.current()) != 0) {
-        action->plug(createNewMenu);
-        ++fileGrouptIt;
+    QLinkedListIterator<QAction*> fileGrouptIt(dolphin->fileGroupActions());
+    while (fileGrouptIt.hasNext()) {
+        createNewMenu->addAction(fileGrouptIt.next());
     }
 
     // TODO: not used yet. See documentation of Dolphin::linkGroupActions()
@@ -105,14 +101,14 @@ void DolphinContextMenu::openViewportContextMenu()
     //
     //createNewMenu->insertSeparator();
     //
-    //QPtrListIterator<KAction> linkGroupIt(dolphin.linkGroupActions());
+    //QPtrListIterator<KAction> linkGroupIt(dolphin->linkGroupActions());
     //while ((action = linkGroupIt.current()) != 0) {
     //    action->plug(createNewMenu);
     //    ++linkGroupIt;
     //}
     //
-    //KPopupMenu* linkToDeviceMenu = new KPopupMenu();
-    //QPtrListIterator<KAction> linkToDeviceIt(dolphin.linkToDeviceActions());
+    //KMenu* linkToDeviceMenu = new KMenu();
+    //QPtrListIterator<KAction> linkToDeviceIt(dolphin->linkToDeviceActions());
     //while ((action = linkToDeviceIt.current()) != 0) {
     //    action->plug(linkToDeviceMenu);
     //    ++linkToDeviceIt;
@@ -123,37 +119,37 @@ void DolphinContextMenu::openViewportContextMenu()
     popup->insertItem(SmallIcon("filenew"), i18n("Create New"), createNewMenu);
     popup->insertSeparator();
 
-    KAction* pasteAction = dolphin.actionCollection()->action(KStdAction::stdName(KStdAction::Paste));
-    pasteAction->plug(popup);
+    QAction* pasteAction = dolphin->actionCollection()->action(KStdAction::stdName(KStdAction::Paste));
+    popup->addAction(pasteAction);
 
     // setup 'View Mode' menu
     KMenu* viewModeMenu = new KMenu();
 
-    KAction* iconsMode = dolphin.actionCollection()->action("icons");
-    iconsMode->plug(viewModeMenu);
+    QAction* iconsMode = dolphin->actionCollection()->action("icons");
+    viewModeMenu->addAction(iconsMode);
 
-    KAction* detailsMode = dolphin.actionCollection()->action("details");
-    detailsMode->plug(viewModeMenu);
+    QAction* detailsMode = dolphin->actionCollection()->action("details");
+    viewModeMenu->addAction(detailsMode);
 
-    KAction* previewsMode = dolphin.actionCollection()->action("previews");
-    previewsMode->plug(viewModeMenu);
+    QAction* previewsMode = dolphin->actionCollection()->action("previews");
+    viewModeMenu->addAction(previewsMode);
 
     popup->insertItem(i18n("View Mode"), viewModeMenu);
     popup->insertSeparator();
 
-    popup->insertItem(i18n("Bookmark this folder"), bookmarkID);
+    QAction *bookmarkAction = popup->addAction(i18n("Bookmark this folder"));
     popup->insertSeparator();
 
-    popup->insertItem(i18n("Properties..."), propertiesID);
+    QAction *propertiesAction = popup->addAction(i18n("Properties..."));
 
-    int id = popup->exec(m_pos);
-    if (id == propertiesID) {
-        new KPropertiesDialog(dolphin.activeView()->url());
+    QAction *activatedAction = popup->exec(m_pos);
+    if (activatedAction == propertiesAction) {
+        new KPropertiesDialog(dolphin->activeView()->url());
     }
-    else if (id == bookmarkID) {
-        const KURL& url = dolphin.activeView()->url();
+    else if (activatedAction == bookmarkAction) {
+        const KUrl& url = dolphin->activeView()->url();
         KBookmark bookmark = EditBookmarkDialog::getBookmark(i18n("Add folder as bookmark"),
-                                                             url.filename(),
+                                                             url.fileName(),
                                                              url,
                                                              "bookmark");
         if (!bookmark.isNull()) {
@@ -177,64 +173,64 @@ void DolphinContextMenu::openItemContextMenu()
     assert(m_fileInfo != 0);
 
     KMenu* popup = new KMenu(m_dolphinView);
-    Dolphin& dolphin = Dolphin::mainWin();
-    const KURL::List urls = m_dolphinView->selectedURLs();
+    DolphinMainWindow* dolphin = m_dolphinView->mainWindow();
+    const KUrl::List urls = m_dolphinView->selectedUrls();
 
     // insert 'Cut', 'Copy' and 'Paste'
     const KStdAction::StdAction actionNames[] = { KStdAction::Cut, KStdAction::Copy, KStdAction::Paste };
     const int count = sizeof(actionNames) / sizeof(KStdAction::StdAction);
     for (int i = 0; i < count; ++i) {
-        KAction* action = dolphin.actionCollection()->action(KStdAction::stdName(actionNames[i]));
-        if (action != 0) {
-            action->plug(popup);
-        }
+        QAction* action = dolphin->actionCollection()->action(KStdAction::stdName(actionNames[i]));
+        if (action)
+            popup->addAction(action);
     }
     popup->insertSeparator();
 
     // insert 'Rename'
-    KAction* renameAction = dolphin.actionCollection()->action("rename");
-    renameAction->plug(popup);
+    QAction* renameAction = dolphin->actionCollection()->action("rename");
+    popup->addAction(renameAction);
 
-    // insert 'Move to Trash' for local URLs, otherwise insert 'Delete'
-    const KURL& url = dolphin.activeView()->url();
+    // insert 'Move to Trash' for local Urls, otherwise insert 'Delete'
+    const KUrl& url = dolphin->activeView()->url();
     if (url.isLocalFile()) {
-        KAction* moveToTrashAction = dolphin.actionCollection()->action("move_to_trash");
-        moveToTrashAction->plug(popup);
+        QAction* moveToTrashAction = dolphin->actionCollection()->action("move_to_trash");
+        popup->addAction(moveToTrashAction);
     }
     else {
-        KAction* deleteAction = dolphin.actionCollection()->action("delete");
-        deleteAction->plug(popup);
+        QAction* deleteAction = dolphin->actionCollection()->action("delete");
+        popup->addAction(deleteAction);
     }
 
     // insert 'Bookmark this folder...' entry
     // urls is a list of selected items, so insert boolmark menu if
     // urls contains only one item, i.e. no multiple selection made
+    QAction *bookmarkAction = 0;
     if (m_fileInfo->isDir() && (urls.count() == 1)) {
-        popup->insertItem(i18n("Bookmark this folder"), bookmarkID);
+        bookmarkAction = popup->addAction(i18n("Bookmark this folder"));
     }
 
     popup->insertSeparator();
 
     // Insert 'Open With...' sub menu
     Q3ValueVector<KService::Ptr> openWithVector;
-    const int openWithID = insertOpenWithItems(popup, openWithVector);
+    const QList<QAction*> openWithActions = insertOpenWithItems(popup, openWithVector);
 
     // Insert 'Actions' sub menu
     Q3ValueVector<KDEDesktopMimeType::Service> actionsVector;
-    insertActionItems(popup, actionsVector);
+    const QList<QAction*> serviceActions = insertActionItems(popup, actionsVector);
 
     // insert 'Properties...' entry
     popup->insertSeparator();
-    KAction* propertiesAction = dolphin.actionCollection()->action("properties");
-    propertiesAction->plug(popup);
+    QAction* propertiesAction = dolphin->actionCollection()->action("properties");
+    popup->addAction(propertiesAction);
 
-    int id = popup->exec(m_pos);
+    QAction *activatedAction = popup->exec(m_pos);
 
-    if (id == bookmarkID) {
-        const KURL selectedURL(m_fileInfo->url());
+    if (bookmarkAction!=0 && activatedAction == bookmarkAction) {
+        const KUrl selectedUrl(m_fileInfo->url());
         KBookmark bookmark = EditBookmarkDialog::getBookmark(i18n("Add folder as bookmark"),
-                                                             selectedURL.filename(),
-                                                             selectedURL,
+                                                             selectedUrl.fileName(),
+                                                             selectedUrl,
                                                              "bookmark");
         if (!bookmark.isNull()) {
             KBookmarkManager* manager = DolphinSettings::instance().bookmarkManager();
@@ -243,19 +239,21 @@ void DolphinContextMenu::openItemContextMenu()
             manager->emitChanged(root);
         }
     }
-    else if (id >= actionsIDStart) {
+    else if (serviceActions.contains(activatedAction)) {
         // one of the 'Actions' items has been selected
-        KDEDesktopMimeType::executeService(urls, actionsVector[id - actionsIDStart]);
+        int id = serviceActions.indexOf(activatedAction);
+        KDEDesktopMimeType::executeService(urls, actionsVector[id]);
     }
-    else if (id >= openWithIDStart) {
+    else if (openWithActions.contains(activatedAction)) {
         // one of the 'Open With' items has been selected
-        if (id == openWithID) {
+        if (openWithActions.last()==activatedAction) {
             // the item 'Other...' has been selected
-            KRun::displayOpenWithDialog(urls);
+            KRun::displayOpenWithDialog(urls, m_dolphinView);
         }
         else {
-            KService::Ptr servicePtr = openWithVector[id - openWithIDStart];
-            KRun::run(*servicePtr, urls);
+            int id = openWithActions.indexOf(activatedAction);
+            KService::Ptr servicePtr = openWithVector[id];
+            KRun::run(*servicePtr, urls, m_dolphinView);
         }
     }
 
@@ -264,35 +262,33 @@ void DolphinContextMenu::openItemContextMenu()
     popup->deleteLater();
 }
 
-int DolphinContextMenu::insertOpenWithItems(KMenu* popup,
-                                            Q3ValueVector<KService::Ptr>& openWithVector)
+QList<QAction*> DolphinContextMenu::insertOpenWithItems(KMenu* popup,
+                                                        Q3ValueVector<KService::Ptr>& openWithVector)
 {
     // Prepare 'Open With' sub menu. Usually a sub menu is created, where all applications
     // are listed which are registered to open the item. As last entry "Other..." will be
     // attached which allows to select a custom application. If no applications are registered
     // no sub menu is created at all, only "Open With..." will be offered.
-    const KFileItemList* list = m_dolphinView->selectedItems();
-    assert(list != 0);
+    const KFileItemList list = m_dolphinView->selectedItems();
 
     bool insertOpenWithItems = true;
     const QString contextMimeType(m_fileInfo->mimetype());
-    KFileItemListIterator mimeIt(*list);
-    KFileItem* item = 0;
-    while (insertOpenWithItems && ((item = mimeIt.current()) != 0)) {
+    QListIterator<KFileItem*> mimeIt(list);
+    while (insertOpenWithItems && mimeIt.hasNext()) {
+        KFileItem* item = mimeIt.next();
         insertOpenWithItems = (contextMimeType == item->mimetype());
-        ++mimeIt;
     }
 
-    int openWithID = -1;
+    QList<QAction*> openWithActions;
 
     if (insertOpenWithItems) {
         // fill the 'Open with' sub menu with application types
-        const KMimeType::Ptr mimePtr = KMimeType::findByURL(m_fileInfo->url());
-        KTrader::OfferList offers = KTrader::self()->query(mimePtr->name(),
-                                                           "Type == 'Application'");
-        int index = openWithIDStart;
+        const KMimeType::Ptr mimePtr = KMimeType::findByUrl(m_fileInfo->url());
+        KService::List offers = KMimeTypeTrader::self()->query(mimePtr->name(),
+                                                               "Application",
+                                                               "Type == 'Application'");
         if (offers.count() > 0) {
-            KTrader::OfferList::Iterator it;
+            KService::List::Iterator it;
             KMenu* openWithMenu = new KMenu();
             for(it = offers.begin(); it != offers.end(); ++it) {
                 // The offer list from the KTrader returns duplicate
@@ -301,43 +297,42 @@ int DolphinContextMenu::insertOpenWithItems(KMenu* popup,
                 // will be skipped here.
                 const QString appName((*it)->name());
                 if (!containsEntry(openWithMenu, appName)) {
-                    openWithMenu->insertItem((*it)->pixmap(KIcon::Small),
-                                            appName, index);
+                    QAction *action = openWithMenu->addAction((*it)->pixmap(K3Icon::Small),
+                                                              appName);
                     openWithVector.append(*it);
-                    ++index;
+                    openWithActions << action;
                 }
             }
 
             openWithMenu->insertSeparator();
-            openWithMenu->insertItem(i18n("&Other..."), index);
+            QAction *action = openWithMenu->addAction(i18n("&Other..."));
+            openWithActions << action;
             popup->insertItem(i18n("Open With"), openWithMenu);
         }
         else {
             // No applications are registered, hence just offer
             // a "Open With..." item instead of a sub menu containing
             // only one entry.
-            popup->insertItem(i18n("Open With..."), openWithIDStart);
+            QAction *action = popup->addAction(i18n("Open With..."));
+            openWithActions << action;
         }
-        openWithID = index;
     }
     else {
         // At least one of the selected items has a different MIME type. In this case
         // just show a disabled "Open With..." entry.
-        popup->insertItem(i18n("Open With..."), openWithIDStart);
-        popup->setItemEnabled(openWithIDStart, false);
+        QAction *action = popup->addAction(i18n("Open With..."));
+        action->setEnabled(false);
     }
 
-    popup->setItemEnabled(openWithID, insertOpenWithItems);
-
-    return openWithID;
+    return openWithActions;
 }
 
-void DolphinContextMenu::insertActionItems(KMenu* popup,
-                                           Q3ValueVector<KDEDesktopMimeType::Service>& actionsVector)
+QList<QAction*> DolphinContextMenu::insertActionItems(KMenu* popup,
+                                                      Q3ValueVector<KDEDesktopMimeType::Service>& actionsVector)
 {
     KMenu* actionsMenu = new KMenu();
 
-    int actionsIndex = 0;
+    QList<QAction*> serviceActions;
 
     QStringList dirs = KGlobal::dirs()->findDirs("data", "dolphin/servicemenus/");
 
@@ -359,15 +354,13 @@ void DolphinContextMenu::insertActionItems(KMenu* popup,
                     if ((*it) == "all/allfiles") {
                         // The service type is valid for all files, but not for directories.
                         // Check whether the selected items only consist of files...
-                        const KFileItemList* list = m_dolphinView->selectedItems();
-                        assert(list != 0);
+                        const KFileItemList list = m_dolphinView->selectedItems();
 
-                        KFileItemListIterator mimeIt(*list);
-                        KFileItem* item = 0;
+                        QListIterator<KFileItem*> mimeIt(list);
                         insert = true;
-                        while (insert && ((item = mimeIt.current()) != 0)) {
+                        while (insert && mimeIt.hasNext()) {
+                            KFileItem* item = mimeIt.next();
                             insert = !item->isDir();
-                            ++mimeIt;
                         }
                     }
 
@@ -375,20 +368,18 @@ void DolphinContextMenu::insertActionItems(KMenu* popup,
                         // Check whether the MIME types of all selected files match
                         // to the mimetype of the service action. As soon as one MIME
                         // type does not match, no service menu is shown at all.
-                        const KFileItemList* list = m_dolphinView->selectedItems();
-                        assert(list != 0);
+                        const KFileItemList list = m_dolphinView->selectedItems();
 
-                        KFileItemListIterator mimeIt(*list);
-                        KFileItem* item = 0;
+                        QListIterator<KFileItem*> mimeIt(list);
                         insert = true;
-                        while (insert && ((item = mimeIt.current()) != 0)) {
-                            const QString mimeType((*mimeIt)->mimetype());
-                            const QString mimeGroup(mimeType.left(mimeType.find('/')));
+                        while (insert && mimeIt.hasNext()) {
+                            KFileItem* item = mimeIt.next();
+                            const QString mimeType(item->mimetype());
+                            const QString mimeGroup(mimeType.left(mimeType.indexOf('/')));
 
                             insert  = (*it == mimeType) ||
                                       ((*it).right(1) == "*") &&
-                                      ((*it).left((*it).find('/')) == mimeGroup);
-                            ++mimeIt;
+                                      ((*it).left((*it).indexOf('/')) == mimeGroup);
                         }
                     }
 
@@ -408,16 +399,15 @@ void DolphinContextMenu::insertActionItems(KMenu* popup,
                         for (serviceIt = userServices.begin(); serviceIt != userServices.end(); ++serviceIt) {
                             KDEDesktopMimeType::Service service = (*serviceIt);
                             if (!service.m_strIcon.isEmpty()) {
-                                menu->insertItem(SmallIcon(service.m_strIcon),
-                                                 service.m_strName,
-                                                 actionsIDStart + actionsIndex);
+                                QAction *action = menu->addAction(SmallIcon(service.m_strIcon),
+                                                                  service.m_strName);
+                                serviceActions << action;
                             }
                             else {
-                                menu->insertItem(service.m_strName,
-                                                 actionsIDStart + actionsIndex);
+                                QAction *action = menu->addAction(service.m_strName);
+                                serviceActions << action;
                             }
                             actionsVector.append(service);
-                            ++actionsIndex;
                         }
                     }
                 }
@@ -439,12 +429,16 @@ void DolphinContextMenu::insertActionItems(KMenu* popup,
             // The item is an action, hence show the action in the root menu.
             const int id = actionsMenu->idAt(0);
             const QString text(actionsMenu->text(id));
-            const QIcon* iconSet = actionsMenu->iconSet(id);
-            if (iconSet == 0) {
-                popup->insertItem(text, id);
+            QIcon iconSet = actionsMenu->iconSet(id);
+            if (iconSet.isNull()) {
+                QAction *action = popup->addAction(text);
+                serviceActions.clear();
+                serviceActions << action;
             }
             else {
-                popup->insertItem(*iconSet, text, id);
+                QAction *action = popup->addAction(iconSet, text);
+                serviceActions.clear();
+                serviceActions << action;
             }
         }
         else {
@@ -457,6 +451,8 @@ void DolphinContextMenu::insertActionItems(KMenu* popup,
     else {
         popup->insertItem(i18n("Actions"), actionsMenu);
     }
+
+    return serviceActions;
 }
 
 bool DolphinContextMenu::containsEntry(const KMenu* menu,