*/
void DolphinSearchBoxTest::testBalooSearchParsing_data()
{
- const QString text = QStringLiteral("xyz");
- const QString filename = QStringLiteral("filename:\"xyz\"");
+ const QString text = QStringLiteral("abc");
+ const QString textS = QStringLiteral("abc xyz");
+ const QString filename = QStringLiteral("filename:\"%1\"").arg(text);
+ const QString filenameS = QStringLiteral("filename:\"%1\"").arg(textS);
+
const QString rating = QStringLiteral("rating>=2");
- const QString modified = QString("modified>=2019-08-07");
+ const QString modified = QStringLiteral("modified>=2019-08-07");
+
+ const QString tag = QStringLiteral("tag:tagA");
+ const QString tagS = QStringLiteral("tag:\"tagB with spaces\""); // in search url
+ const QString tagR = QStringLiteral("tag:tagB with spaces"); // in result term
QTest::addColumn<QString>("searchString");
QTest::addColumn<QString>("expectedText");
QTest::addColumn<QStringList>("expectedTerms");
+ QTest::addColumn<bool>("hasContent");
+ QTest::addColumn<bool>("hasFileName");
// Test for "Content"
- QTest::newRow("content") << text << text << QStringList();
- QTest::newRow("content/empty") << "" << "" << QStringList();
- QTest::newRow("content/singleQuote") << "\"" << "" << QStringList();
- QTest::newRow("content/doubleQuote") << "\"\"" << "" << QStringList();
- // Test for empty `filename`
- QTest::newRow("filename") << filename << text << QStringList();
- QTest::newRow("filename/empty") << "filename:" << "" << QStringList();
- QTest::newRow("filename/singleQuote") << "filename:\"" << "" << QStringList();
- QTest::newRow("filename/doubleQuote") << "filename:\"\"" << "" << QStringList();
+ QTest::newRow("content") << text << text << QStringList() << true << false;
+ QTest::newRow("content/space") << textS << textS << QStringList() << true << false;
+ QTest::newRow("content/empty") << "" << "" << QStringList() << false << false;
+ QTest::newRow("content/single_quote") << "\"" << "\"" << QStringList() << true << false;
+ QTest::newRow("content/double_quote") << "\"\"" << "" << QStringList() << false << false;
+
+ // Test for "FileName"
+ QTest::newRow("filename") << filename << text << QStringList() << false << true;
+ QTest::newRow("filename/space") << filenameS << textS << QStringList() << false << true;
+ QTest::newRow("filename/empty") << "filename:" << "" << QStringList() << false << false;
+ QTest::newRow("filename/single_quote") << "filename:\"" << "\"" << QStringList() << false << true;
+ QTest::newRow("filename/double_quote") << "filename:\"\"" << "" << QStringList() << false << false;
+
+ // Combined content and filename search
+ QTest::newRow("content+filename")
+ << text + " " + filename
+ << text + " " + filename << QStringList() << true << true;
// Test for rating
- QTest::newRow("rating") << rating << "" << QStringList({rating});
- QTest::newRow("rating+content") << rating + " " + text << text << QStringList({rating});
- QTest::newRow("rating+filename") << rating + " " + filename << text << QStringList({rating});
+ QTest::newRow("rating") << rating << "" << QStringList({rating}) << false << false;
+ QTest::newRow("rating+content") << rating + " " + text << text << QStringList({rating}) << true << false;
+ QTest::newRow("rating+filename") << rating + " " + filename << text << QStringList({rating}) << false << true;
+
// Test for modified date
- QTest::newRow("modified") << modified << "" << QStringList({modified});
- QTest::newRow("modified+content") << modified + " " + text << text << QStringList({modified});
- QTest::newRow("modified+filename") << modified + " " + filename << text << QStringList({modified});
- // Combined tests
- QTest::newRow("rating+modified") << rating + " AND " + modified << "" << QStringList({modified, rating});
- QTest::newRow("rating+modified+content") << rating + " AND " + modified + " " + text << text << QStringList({modified, rating});
- QTest::newRow("rating+modified+filename") << rating + " AND " + modified + " " + filename << text << QStringList({modified, rating});
+ QTest::newRow("modified") << modified << "" << QStringList({modified}) << false << false;
+ QTest::newRow("modified+content") << modified + " " + text << text << QStringList({modified}) << true << false;
+ QTest::newRow("modified+filename") << modified + " " + filename << text << QStringList({modified}) << false << true;
+
+ // Test for tags
+ QTest::newRow("tag") << tag << "" << QStringList({tag}) << false << false;
+ QTest::newRow("tag/space" ) << tagS << "" << QStringList({tagR}) << false << false;
+ QTest::newRow("tag/double") << tag + " " + tagS << "" << QStringList({tag, tagR}) << false << false;
+ QTest::newRow("tag+content") << tag + " " + text << text << QStringList({tag}) << true << false;
+ QTest::newRow("tag+filename") << tag + " " + filename << text << QStringList({tag}) << false << true;
+
+ // Combined search terms
+ QTest::newRow("searchTerms")
+ << rating + " AND " + modified + " AND " + tag + " AND " + tagS
+ << "" << QStringList({modified, rating, tag, tagR}) << false << false;
+
+ QTest::newRow("searchTerms+content")
+ << rating + " AND " + modified + " " + text + " " + tag + " AND " + tagS
+ << text << QStringList({modified, rating, tag, tagR}) << true << false;
+
+ QTest::newRow("searchTerms+filename")
+ << rating + " AND " + modified + " " + filename + " " + tag + " AND " + tagS
+ << text << QStringList({modified, rating, tag, tagR}) << false << true;
+
+ QTest::newRow("allTerms")
+ << text + " " + filename + " " + rating + " AND " + modified + " AND " + tag
+ << text + " " + filename << QStringList({modified, rating, tag}) << true << true;
+
+ QTest::newRow("allTerms/space")
+ << textS + " " + filenameS + " " + rating + " AND " + modified + " AND " + tagS
+ << textS + " " + filenameS << QStringList({modified, rating, tagR}) << true << true;
}
/**
QFETCH(QString, searchString);
QFETCH(QString, expectedText);
QFETCH(QStringList, expectedTerms);
+ QFETCH(bool, hasContent);
+ QFETCH(bool, hasFileName);
const QUrl testUrl = composeQueryUrl(searchString);
const DolphinQuery query = DolphinQuery::fromBalooSearchUrl(testUrl);
QStringList searchTerms = query.searchTerms();
searchTerms.sort();
- // FIXME: Current parsing bugs
- QEXPECT_FAIL("content/singleQuote", "Quotes around text are shown", Continue);
- QEXPECT_FAIL("content/doubleQuote", "Quotes around text are shown", Continue);
-
- QEXPECT_FAIL("filename", "Quotes around text are shown", Continue);
- QEXPECT_FAIL("filename/singleQuote", "Quotes around text are shown", Continue);
- QEXPECT_FAIL("filename/doubleQuote", "Quotes around text are shown", Continue);
-
- QEXPECT_FAIL("rating" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("rating+content" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("rating+filename" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("modified" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("modified+content" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("modified+filename" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("rating+modified" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("rating+modified+content" , "Text includes also search terms", Continue);
- QEXPECT_FAIL("rating+modified+filename", "Text includes also search terms", Continue);
-
// Check for parsed text (would be displayed on the input search bar)
QCOMPARE(query.text(), expectedText);
for (int i = 0; i < expectedTerms.count(); i++) {
QCOMPARE(searchTerms.at(i), expectedTerms.at(i));
}
+
+ // Check for filename and content detection
+ QCOMPARE(query.hasContentSearch(), hasContent);
+ QCOMPARE(query.hasFileName(), hasFileName);
}
QTEST_MAIN(DolphinSearchBoxTest)
projects / dolphin.git / blobdiff