* fixed drag & drop issue in column view (dropping on files was not possible -> handl...

[dolphin.git] / src / dolphindetailsview.cpp

diff --git a/src/dolphindetailsview.cpp b/src/dolphindetailsview.cpp
index 6cd9fbaf9a000a8c37f53148b50ada6c1f9ee0b9..e55c2582d59c31e9426ec4c7e00a1e2980272ddd 100644 (file)
--- a/src/dolphindetailsview.cpp
+++ b/src/dolphindetailsview.cpp
@@ -97,6 +97,8 @@ DolphinDetailsView::DolphinDetailsView(QWidget* parent, DolphinController* contr
             this, SLOT(zoomIn()));
     connect(controller, SIGNAL(zoomOut()),
             this, SLOT(zoomOut()));
+    connect(controller->dolphinView(), SIGNAL(additionalInfoChanged(const KFileItemDelegate::InformationList&)),
+            this, SLOT(updateColumnVisibility()));
 
     // apply the details mode settings to the widget
     const DetailsModeSettings* settings = DolphinSettings::instance().detailsModeSettings();
@@ -120,6 +122,8 @@ DolphinDetailsView::DolphinDetailsView(QWidget* parent, DolphinController* contr
 #endif
 
     updateDecorationSize();
+
+    setFocus();
 }
 
 DolphinDetailsView::~DolphinDetailsView()
@@ -138,28 +142,7 @@ bool DolphinDetailsView::event(QEvent* event)
         headerView->setResizeMode(0, QHeaderView::Stretch);
         headerView->setMovable(false);
 
-        // hide columns if this is indicated by the settings
-        const DetailsModeSettings* settings = DolphinSettings::instance().detailsModeSettings();
-        Q_ASSERT(settings != 0);
-        if (!settings->showDate()) {
-            hideColumn(DolphinModel::ModifiedTime);
-        }
-
-        if (!settings->showPermissions()) {
-            hideColumn(DolphinModel::Permissions);
-        }
-
-        if (!settings->showOwner()) {
-            hideColumn(DolphinModel::Owner);
-        }
-
-        if (!settings->showGroup()) {
-            hideColumn(DolphinModel::Group);
-        }
-
-        if (!settings->showType()) {
-            hideColumn(DolphinModel::Type);
-        }
+        updateColumnVisibility();
 
         hideColumn(DolphinModel::Rating);
         hideColumn(DolphinModel::Tags);
@@ -193,7 +176,7 @@ void DolphinDetailsView::contextMenuEvent(QContextMenuEvent* event)
 
 void DolphinDetailsView::mousePressEvent(QMouseEvent* event)
 {
-    m_controller->triggerActivation();
+    m_controller->requestActivation();
 
     QTreeView::mousePressEvent(event);
 
@@ -266,7 +249,11 @@ void DolphinDetailsView::dragMoveEvent(QDragMoveEvent* event)
         m_dragging = false;
     } else {
         m_dragging = true;
-        m_dropRect = visualRect(index);
+        if (itemForIndex(index).isDir()) {
+            m_dropRect = visualRect(index);
+        } else {
+            m_dropRect.setSize(QSize()); // set as invalid
+        }
         setDirtyRegion(m_dropRect);
     }
 }
@@ -276,10 +263,14 @@ void DolphinDetailsView::dropEvent(QDropEvent* event)
     const KUrl::List urls = KUrl::List::fromMimeData(event->mimeData());
     if (!urls.isEmpty()) {
         event->acceptProposedAction();
+        const QModelIndex index = indexAt(event->pos());
+        KFileItem item;
+        if (index.isValid() && (index.column() == DolphinModel::Name)) {
+            item = itemForIndex(index);
+        }
         m_controller->indicateDroppedUrls(urls,
                                           m_controller->url(),
-                                          indexAt(event->pos()),
-                                          event->source());
+                                          item);
     }
     QTreeView::dropEvent(event);
     m_dragging = false;
@@ -451,7 +442,7 @@ void DolphinDetailsView::configureColumns(const QPoint& pos)
     popup.addTitle(i18nc("@title:menu", "Columns"));
 
     QHeaderView* headerView = header();
-    for (int i = DolphinModel::ModifiedTime; i <= DolphinModel::Type; ++i) {
+    for (int i = DolphinModel::Size; i <= DolphinModel::Type; ++i) {
         const int logicalIndex = headerView->logicalIndex(i);
         const QString text = model()->headerData(i, Qt::Horizontal).toString();
         QAction* action = popup.addAction(text);
@@ -463,29 +454,55 @@ void DolphinDetailsView::configureColumns(const QPoint& pos)
     QAction* activatedAction = popup.exec(header()->mapToGlobal(pos));
     if (activatedAction != 0) {
         const bool show = activatedAction->isChecked();
-        DetailsModeSettings* settings = DolphinSettings::instance().detailsModeSettings();
-        Q_ASSERT(settings != 0);
-
-        // remember the changed column visibility in the settings
         const int columnIndex = activatedAction->data().toInt();
+
+        KFileItemDelegate::InformationList list = m_controller->dolphinView()->additionalInfo();
+        KFileItemDelegate::Information info = KFileItemDelegate::NoInformation;
         switch (columnIndex) {
-        case DolphinModel::ModifiedTime: settings->setShowDate(show); break;
-        case DolphinModel::Permissions:  settings->setShowPermissions(show); break;
-        case DolphinModel::Owner:        settings->setShowOwner(show); break;
-        case DolphinModel::Group:        settings->setShowGroup(show); break;
-        case DolphinModel::Type:         settings->setShowType(show); break;
+        case DolphinModel::Size:         info = KFileItemDelegate::Size; break;
+        case DolphinModel::ModifiedTime: info = KFileItemDelegate::ModificationTime; break;
+        case DolphinModel::Permissions:  info = KFileItemDelegate::Permissions; break;
+        case DolphinModel::Owner:        info = KFileItemDelegate::Owner; break;
+        case DolphinModel::Group:        info = KFileItemDelegate::OwnerAndGroup; break;
+        case DolphinModel::Type:         info = KFileItemDelegate::FriendlyMimeType; break;
         default: break;
         }
 
-        // apply the changed column visibility
         if (show) {
-            showColumn(columnIndex);
+            Q_ASSERT(!list.contains(info));
+            list.append(info);
         } else {
-            hideColumn(columnIndex);
+            Q_ASSERT(list.contains(info));
+            const int index = list.indexOf(info);
+            list.removeAt(index);
         }
+
+        m_controller->indicateAdditionalInfoChange(list);
+        setColumnHidden(columnIndex, !show);
     }
 }
 
+void DolphinDetailsView::updateColumnVisibility()
+{
+    KFileItemDelegate::InformationList list = m_controller->dolphinView()->additionalInfo();
+    if (list.isEmpty() || list.contains(KFileItemDelegate::NoInformation)) {
+        // Using the details view without any additional information (-> additional column)
+        // makes no sense and leads to a usability problem as no viewport area is available
+        // anymore. Hence as fallback provide at least a size and date column.
+        list.clear();
+        list.append(KFileItemDelegate::Size);
+        list.append(KFileItemDelegate::ModificationTime);
+        m_controller->indicateAdditionalInfoChange(list);
+    }
+
+    setColumnHidden(DolphinModel::Size,         !list.contains(KFileItemDelegate::Size));
+    setColumnHidden(DolphinModel::ModifiedTime, !list.contains(KFileItemDelegate::ModificationTime));
+    setColumnHidden(DolphinModel::Permissions,  !list.contains(KFileItemDelegate::Permissions));
+    setColumnHidden(DolphinModel::Owner,        !list.contains(KFileItemDelegate::Owner));
+    setColumnHidden(DolphinModel::Group,        !list.contains(KFileItemDelegate::OwnerAndGroup));
+    setColumnHidden(DolphinModel::Type,         !list.contains(KFileItemDelegate::FriendlyMimeType));
+}
+
 bool DolphinDetailsView::isZoomInPossible() const
 {
     DetailsModeSettings* settings = DolphinSettings::instance().detailsModeSettings();