Status bar: Hide the space free bar when size is unknown

[dolphin.git] / src / statusbar / statusbarspaceinfo.cpp

diff --git a/src/statusbar/statusbarspaceinfo.cpp b/src/statusbar/statusbarspaceinfo.cpp
index 82fa47143cf04e0ff98bee5caa87bb3c4ccfddba..acffcf69dba126a8cbf423ad708f74be111cbe8d 100644 (file)
--- a/src/statusbar/statusbarspaceinfo.cpp
+++ b/src/statusbar/statusbarspaceinfo.cpp
@@ -20,90 +20,122 @@
 
 #include "statusbarspaceinfo.h"
 
 
 #include "statusbarspaceinfo.h"
 

-#include <KDiskFreeSpaceInfo>
-#include <KLocale>
-#include <KIO/Job>
+#include "spaceinfoobserver.h"

 
 

-#include <QTimer>
-#include <QKeyEvent>
+#include <KLocalizedString>
+#include <KNS3/KMoreToolsMenuFactory>
+
+#include <QMouseEvent>

 
 StatusBarSpaceInfo::StatusBarSpaceInfo(QWidget* parent) :
     KCapacityBar(KCapacityBar::DrawTextInline, parent),
 
 StatusBarSpaceInfo::StatusBarSpaceInfo(QWidget* parent) :
     KCapacityBar(KCapacityBar::DrawTextInline, parent),

-    m_kBSize(0),
-    m_timer(0)
+    m_observer(nullptr)

 {
 {

-    // Use a timer to update the space information. Polling is useful
-    // here, as files can be deleted/added outside the scope of Dolphin.
-    m_timer = new QTimer(this);
-    connect(m_timer, &QTimer::timeout, this, &StatusBarSpaceInfo::calculateSpaceInfo);
+    setCursor(Qt::PointingHandCursor);

 }
 
 StatusBarSpaceInfo::~StatusBarSpaceInfo()
 {
 }
 
 }
 
 StatusBarSpaceInfo::~StatusBarSpaceInfo()
 {
 }
 

-void StatusBarSpaceInfo::setUrl(const KUrl& url)
+void StatusBarSpaceInfo::setShown(bool shown)
+{
+    m_shown = shown;
+    if (!m_shown) {
+        hide();
+        m_ready = false;
+    }
+}
+
+void StatusBarSpaceInfo::setUrl(const QUrl& url)

 {
     if (m_url != url) {
         m_url = url;
 {
     if (m_url != url) {
         m_url = url;

-        if (isVisible()) {
-            calculateSpaceInfo();
+        m_ready = false;
+        if (m_observer) {
+            m_observer.reset(new SpaceInfoObserver(m_url, this));
+            connect(m_observer.data(), &SpaceInfoObserver::valuesChanged, this, &StatusBarSpaceInfo::slotValuesChanged);

         }
     }
 }
 
         }
     }
 }
 

-KUrl StatusBarSpaceInfo::url() const
+QUrl StatusBarSpaceInfo::url() const

 {
     return m_url;
 }
 
 {
     return m_url;
 }
 

+void StatusBarSpaceInfo::update()
+{
+    if (m_observer) {
+        m_observer->update();
+    }
+}
+

 void StatusBarSpaceInfo::showEvent(QShowEvent* event)
 {
 void StatusBarSpaceInfo::showEvent(QShowEvent* event)
 {

-    KCapacityBar::showEvent(event);
-    if (!event->spontaneous()) {
-        calculateSpaceInfo();
-        m_timer->start(10000);
+    if (m_shown) {
+        if (m_ready) {
+            KCapacityBar::showEvent(event);
+        }
+
+        if (m_observer.isNull()) {
+            m_observer.reset(new SpaceInfoObserver(m_url, this));
+            connect(m_observer.data(), &SpaceInfoObserver::valuesChanged, this, &StatusBarSpaceInfo::slotValuesChanged);
+        }

     }
 }
 
 void StatusBarSpaceInfo::hideEvent(QHideEvent* event)
 {
     }
 }
 
 void StatusBarSpaceInfo::hideEvent(QHideEvent* event)
 {

-    m_timer->stop();
+    if (m_ready) {
+        m_observer.reset();
+        m_ready = false;
+    }

     KCapacityBar::hideEvent(event);
 }
 
     KCapacityBar::hideEvent(event);
 }
 

-void StatusBarSpaceInfo::calculateSpaceInfo()
+void StatusBarSpaceInfo::mousePressEvent(QMouseEvent* event)

 {
 {

-    // KDiskFreeSpace is for local paths only
-    if (!m_url.isLocalFile()) {
-        setText(i18nc("@info:status", "Unknown size"));
-        setValue(0);
-        update();
-        return;
+    if (event->button() == Qt::LeftButton) {
+        // Creates a menu with tools that help to find out more about free
+        // disk space for the given url.
+
+        // Note that this object must live long enough in case the user opens
+        // the "Configure..." dialog
+        KMoreToolsMenuFactory menuFactory(QStringLiteral("dolphin/statusbar-diskspace-menu"));
+        menuFactory.setParentWidget(this);
+        auto menu = menuFactory.createMenuFromGroupingNames(
+            { "disk-usage", "more:", "disk-partitions" }, m_url);
+
+        menu->exec(QCursor::pos());

     }
     }

+}

 
 

-    KDiskFreeSpaceInfo job = KDiskFreeSpaceInfo::freeSpaceInfo(m_url.toLocalFile());
-    if (!job.isValid()) {
-        setText(i18nc("@info:status", "Unknown size"));
-        setValue(0);
-        update();
+void StatusBarSpaceInfo::slotValuesChanged()
+{
+    Q_ASSERT(m_observer);
+    const quint64 size = m_observer->size();
+
+    if (!m_shown || size == 0) {
+        hide();

         return;
     }
 
         return;
     }
 

-    KIO::filesize_t kBSize = job.size() / 1024;
-    KIO::filesize_t kBUsed = job.used() / 1024;
+    m_ready = true;
+
+    const quint64 available = m_observer->available();
+    const quint64 used = size - available;
+    const int percentUsed = qRound(100.0 * qreal(used) / qreal(size));

 
 

-    const bool valuesChanged = (kBUsed != static_cast<quint64>(value())) || (kBSize != m_kBSize);
-    if (valuesChanged) {
-        setText(i18nc("@info:status Free disk space", "%1 free",
-                KIO::convertSize(job.available())));
+    setText(i18nc("@info:status Free disk space", "%1 free", KIO::convertSize(available)));
+    setUpdatesEnabled(false);
+    setValue(percentUsed);
+    setUpdatesEnabled(true);

 
 

-        setUpdatesEnabled(false);
-        m_kBSize = kBSize;
-        setValue(kBSize > 0 ? (kBUsed * 100) / kBSize : 0);
-        setUpdatesEnabled(true);
+    if (!isVisible()) {
+        show();
+    } else {

         update();
     }
 }
 
         update();
     }
 }
 

-#include "statusbarspaceinfo.moc"