]> cloud.milkyroute.net Git - dolphin.git/blobdiff - src/infosidebarpage.cpp
assure that no expensive operations are done when the Information Panel has been...
[dolphin.git] / src / infosidebarpage.cpp
index af81ebb29db76a213a303ae8fa8501319559f839..2c87f430d9ef21f94b71da57a782507107a69611 100644 (file)
@@ -79,8 +79,8 @@ QSize InfoSidebarPage::sizeHint() const
 void InfoSidebarPage::setUrl(const KUrl& url)
 {
     SidebarPage::setUrl(url);
-    if (url.isValid() && !m_shownUrl.equals(url, KUrl::CompareWithoutTrailingSlash)) {
-        if (m_initialized) {
+    if (url.isValid() && !isEqualToShownUrl(url)) {
+        if (isVisible()) {
             cancelRequest();
             m_shownUrl = url;
             showItemInfo();
@@ -92,7 +92,7 @@ void InfoSidebarPage::setUrl(const KUrl& url)
 
 void InfoSidebarPage::setSelection(const KFileItemList& selection)
 {
-    if (!m_initialized) {
+    if (!isVisible()) {
         return;
     }
 
@@ -108,8 +108,10 @@ void InfoSidebarPage::setSelection(const KFileItemList& selection)
 
     const int count = selection.count();
     if (count == 0) {
-        m_shownUrl = url();
-        showItemInfo();
+        if (!isEqualToShownUrl(url())) {
+            m_shownUrl = url();
+            showItemInfo();
+        }
     } else {
         if ((count == 1) && !selection.first().url().isEmpty()) {
             m_urlCandidate = selection.first().url();
@@ -120,7 +122,7 @@ void InfoSidebarPage::setSelection(const KFileItemList& selection)
 
 void InfoSidebarPage::requestDelayedItemInfo(const KFileItem& item)
 {
-    if (!m_initialized) {
+    if (!isVisible()) {
         return;
     }
 
@@ -134,10 +136,13 @@ void InfoSidebarPage::requestDelayedItemInfo(const KFileItem& item)
             m_pendingPreview = false;
             m_infoTimer->start();
         }
-    } else if (!item.url().isEmpty()) {
-        m_urlCandidate = item.url();
-        m_fileItem = item;
-        m_infoTimer->start();
+    } else {
+        const KUrl url = item.url();
+        if (url.isValid() && !isEqualToShownUrl(url)) {
+            m_urlCandidate = item.url();
+            m_fileItem = item;
+            m_infoTimer->start();
+        }    
     }
 }
 
@@ -157,7 +162,7 @@ void InfoSidebarPage::showEvent(QShowEvent* event)
 
 void InfoSidebarPage::resizeEvent(QResizeEvent* event)
 {
-    if (m_initialized) {
+    if (isVisible()) {
         // If the text inside the name label or the info label cannot
         // get wrapped, then the maximum width of the label is increased
         // so that the width of the information sidebar gets increased.
@@ -183,11 +188,6 @@ void InfoSidebarPage::showItemInfo()
 
     cancelRequest();
 
-    const KUrl file = fileUrl();
-    if (!file.isValid()) {
-        return;
-    }
-
     if (showMultipleSelectionInfo()) {
         KIconLoader iconLoader;
         QPixmap icon = iconLoader.loadIcon("dialog-information",
@@ -195,33 +195,35 @@ void InfoSidebarPage::showItemInfo()
                                            KIconLoader::SizeEnormous);
         m_preview->setPixmap(icon);
         m_nameLabel->setText(i18ncp("@info", "%1 item selected", "%1 items selected",  m_selection.count()));
-    } else if (!applyPlace(file)) {
-        // try to get a preview pixmap from the item...
-        KUrl::List list;
-        list.append(file);
-
-        m_pendingPreview = true;
-
-        // Mark the currently shown preview as outdated. This is done
-        // with a small delay to prevent a flickering when the next preview
-        // can be shown within a short timeframe.
-        m_outdatedPreviewTimer->start();
-
-        KIO::PreviewJob* job = KIO::filePreview(list,
-                                                m_preview->width(),
-                                                m_preview->height(),
-                                                0,
-                                                0,
-                                                true,
-                                                false);
-        job->setIgnoreMaximumSize(true);
-
-        connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
-                this, SLOT(showPreview(const KFileItem&, const QPixmap&)));
-        connect(job, SIGNAL(failed(const KFileItem&)),
-                this, SLOT(showIcon(const KFileItem&)));
-
-        m_nameLabel->setText(file.fileName());
+        m_shownUrl = KUrl();
+    } else {
+        const KFileItem item = fileItem();
+        const KUrl itemUrl = item.url();
+        if (!applyPlace(itemUrl)) {
+            // try to get a preview pixmap from the item...
+            m_pendingPreview = true;
+
+            // Mark the currently shown preview as outdated. This is done
+            // with a small delay to prevent a flickering when the next preview
+            // can be shown within a short timeframe.
+            m_outdatedPreviewTimer->start();
+
+            KIO::PreviewJob* job = KIO::filePreview(KUrl::List() << itemUrl,
+                                                    m_preview->width(),
+                                                    m_preview->height(),
+                                                    0,
+                                                    0,
+                                                    true,
+                                                    false);
+            job->setIgnoreMaximumSize(true);
+
+            connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
+                    this, SLOT(showPreview(const KFileItem&, const QPixmap&)));
+            connect(job, SIGNAL(failed(const KFileItem&)),
+                    this, SLOT(showIcon(const KFileItem&)));
+
+            m_nameLabel->setText(itemUrl.fileName());
+        }
     }
 
     showMetaInfo();
@@ -372,25 +374,23 @@ void InfoSidebarPage::showMetaInfo()
         }
         m_metaTextLabel->add(i18nc("@label", "Total size:"), KIO::convertSize(totalSize));
     } else {
-        KFileItem fileItem(KFileItem::Unknown, KFileItem::Unknown, fileUrl());
-        fileItem.refresh();
-
-        if (fileItem.isDir()) {
+        const KFileItem item = fileItem();
+        if (item.isDir()) {
             m_metaTextLabel->add(i18nc("@label", "Type:"), i18nc("@label", "Folder"));
-            m_metaTextLabel->add(i18nc("@label", "Modified:"), fileItem.timeString());
+            m_metaTextLabel->add(i18nc("@label", "Modified:"), item.timeString());
         } else {
-            m_metaTextLabel->add(i18nc("@label", "Type:"), fileItem.mimeComment());
+            m_metaTextLabel->add(i18nc("@label", "Type:"), item.mimeComment());
 
-            m_metaTextLabel->add(i18nc("@label", "Size:"), KIO::convertSize(fileItem.size()));
-            m_metaTextLabel->add(i18nc("@label", "Modified:"), fileItem.timeString());
+            m_metaTextLabel->add(i18nc("@label", "Size:"), KIO::convertSize(item.size()));
+            m_metaTextLabel->add(i18nc("@label", "Modified:"), item.timeString());
 
-            if (fileItem.isLocalFile()) {
+            if (item.isLocalFile()) {
                 // TODO: See convertMetaInfo below, find a way to display only interesting information
                 // in a readable way
                 const KFileMetaInfo::WhatFlags flags = KFileMetaInfo::Fastest |
                                                        KFileMetaInfo::TechnicalInfo |
                                                        KFileMetaInfo::ContentInfo;
-                const QString path = fileItem.url().path();
+                const QString path = item.url().path();
                 const KFileMetaInfo fileMetaInfo(path, QString(), flags);
                 if (fileMetaInfo.isValid()) {
                     const QHash<QString, KFileMetaInfoItem>& items = fileMetaInfo.items();
@@ -410,28 +410,29 @@ void InfoSidebarPage::showMetaInfo()
         }
 
         if (m_metaDataWidget != 0) {
-            m_metaDataWidget->setFile(fileItem.targetUrl());
+            m_metaDataWidget->setFile(item.targetUrl());
         }
     }
 }
 
 bool InfoSidebarPage::convertMetaInfo(const QString& key, QString& text) const
 {
-    // TODO: This code prevents that interesting meta information might be hidden
-    // and only bypasses the current problem that not all the meta information should
-    // be shown to the user. Check whether it's possible with Nepomuk to show
-    // all "user relevant" information in a readable way...
-
     struct MetaKey {
         const char* key;
-        const char* text;
+        QString text;
     };
 
     // sorted list of keys, where its data should be shown
     static const MetaKey keys[] = {
-        { "audio.album", "Album:" },
-        { "audio.artist", "Artist:" },
-        { "audio.title", "Title:" },
+        { "http://freedesktop.org/standards/xesam/1.0/core#album",       i18nc("@label", "Album:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#artist",      i18nc("@label", "Artist:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#genre",       i18nc("@label", "Genre:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#height",      i18nc("@label", "Height:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#lineCount",   i18nc("@label", "Lines:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#title",       i18nc("@label", "Title:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#type",        i18nc("@label", "Type:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#trackNumber", i18nc("@label", "Track:") },
+        { "http://freedesktop.org/standards/xesam/1.0/core#width",       i18nc("@label", "Width:") }
     };
 
     // do a binary search for the key...
@@ -453,9 +454,22 @@ bool InfoSidebarPage::convertMetaInfo(const QString& key, QString& text) const
     return false;
 }
 
-KUrl InfoSidebarPage::fileUrl() const
+KFileItem InfoSidebarPage::fileItem() const
 {
-    return (!m_fileItem.isNull() || m_selection.isEmpty()) ? m_shownUrl : m_selection[0].url();
+    if (!m_fileItem.isNull()) {
+        return m_fileItem;
+    }
+
+    if (!m_selection.isEmpty()) {
+        Q_ASSERT(m_selection.count() == 1);
+        return m_selection.first();
+    }
+
+    // no item is hovered and no selection has been done: provide
+    // an item for the directory represented by m_shownUrl
+    KFileItem item(KFileItem::Unknown, KFileItem::Unknown, m_shownUrl);
+    item.refresh();
+    return item;
 }
 
 bool InfoSidebarPage::showMultipleSelectionInfo() const
@@ -463,6 +477,11 @@ bool InfoSidebarPage::showMultipleSelectionInfo() const
     return m_fileItem.isNull() && (m_selection.count() > 1);
 }
 
+bool InfoSidebarPage::isEqualToShownUrl(const KUrl& url) const
+{
+    return m_shownUrl.equals(url, KUrl::CompareWithoutTrailingSlash);
+}
+
 void InfoSidebarPage::init()
 {
     const int spacing = KDialog::spacingHint();