#include "dolphinmainwindow.h"
-#include "dolphinmainwindowadaptor.h"
-#include "global.h"
+#include "admin/workerintegration.h"
+#include "dolphin_generalsettings.h"
#include "dolphinbookmarkhandler.h"
-#include "dolphindockwidget.h"
#include "dolphincontextmenu.h"
+#include "dolphindockwidget.h"
+#include "dolphinmainwindowadaptor.h"
#include "dolphinnavigatorswidgetaction.h"
#include "dolphinnewfilemenu.h"
-#include "dolphinrecenttabsmenu.h"
#include "dolphinplacesmodelsingleton.h"
+#include "dolphinrecenttabsmenu.h"
+#include "dolphintabpage.h"
#include "dolphinurlnavigatorscontroller.h"
#include "dolphinviewcontainer.h"
-#include "dolphintabpage.h"
+#include "global.h"
#include "middleclickactioneventfilter.h"
#include "panels/folders/folderspanel.h"
#include "panels/places/placespanel.h"
#include "panels/terminal/terminalpanel.h"
+#include "search/dolphinquery.h"
#include "selectionmode/actiontexthelper.h"
#include "settings/dolphinsettingsdialog.h"
+#include "statusbar/diskspaceusagemenu.h"
#include "statusbar/dolphinstatusbar.h"
-#include "views/dolphinviewactionhandler.h"
+#include "views/dolphinnewfilemenuobserver.h"
#include "views/dolphinremoteencoding.h"
+#include "views/dolphinviewactionhandler.h"
#include "views/draganddrophelper.h"
#include "views/viewproperties.h"
-#include "views/dolphinnewfilemenuobserver.h"
-#include "dolphin_generalsettings.h"
#include <KActionCollection>
#include <KActionMenu>
#include <KAuthorized>
+#include <KColorSchemeManager>
#include <KConfig>
#include <KConfigGui>
+#include <KDesktopFile>
+#include <KDialogJobUiDelegate>
#include <KDualAction>
#include <KFileItemListProperties>
#include <KIO/CommandLauncherJob>
-#include <kio_version.h>
-#if KIO_VERSION >= QT_VERSION_CHECK(5, 98, 0)
#include <KIO/JobUiDelegateFactory>
-#else
-#include <KIO/JobUiDelegate>
-#endif
#include <KIO/OpenFileManagerWindowJob>
#include <KIO/OpenUrlJob>
#include <KJobWidgets>
#include <KLocalizedString>
#include <KMessageBox>
-#include <KMoreToolsMenuFactory>
#include <KProtocolInfo>
#include <KProtocolManager>
+#include <KRecentFilesAction>
+#include <KRuntimePlatform>
#include <KShell>
#include <KShortcutsDialog>
#include <KStandardAction>
-#include <KStartupInfo>
#include <KSycoca>
#include <KTerminalLauncherJob>
#include <KToggleAction>
#include <KXMLGUIFactory>
#include <kwidgetsaddons_version.h>
-#include <kio_version.h>
#include <QApplication>
#include <QClipboard>
#include <QStandardPaths>
#include <QTimer>
#include <QToolButton>
+#include <QtConcurrentRun>
+#include <dolphindebug.h>
+
+#include <algorithm>
-namespace {
- // Used for GeneralSettings::version() to determine whether
- // an updated version of Dolphin is running, so as to migrate
- // removed/renamed ...etc config entries; increment it in such
- // cases
- const int CurrentDolphinVersion = 202;
- // The maximum number of entries in the back/forward popup menu
- const int MaxNumberOfNavigationentries = 12;
- // The maximum number of "Activate Tab" shortcuts
- const int MaxActivateTabShortcuts = 9;
-}
-
-DolphinMainWindow::DolphinMainWindow() :
- KXmlGuiWindow(nullptr),
- m_newFileMenu(nullptr),
- m_tabWidget(nullptr),
- m_activeViewContainer(nullptr),
- m_actionHandler(nullptr),
- m_remoteEncoding(nullptr),
- m_settingsDialog(),
- m_bookmarkHandler(nullptr),
- m_lastHandleUrlOpenJob(nullptr),
- m_terminalPanel(nullptr),
- m_placesPanel(nullptr),
- m_tearDownFromPlacesRequested(false),
- m_backAction(nullptr),
- m_forwardAction(nullptr)
+#if HAVE_X11
+#include <KStartupInfo>
+#endif
+
+namespace
+{
+// Used for GeneralSettings::version() to determine whether
+// an updated version of Dolphin is running, so as to migrate
+// removed/renamed ...etc config entries; increment it in such
+// cases
+const int CurrentDolphinVersion = 202;
+// The maximum number of entries in the back/forward popup menu
+const int MaxNumberOfNavigationentries = 12;
+// The maximum number of "Go to Tab" shortcuts
+const int MaxActivateTabShortcuts = 9;
+}
+
+DolphinMainWindow::DolphinMainWindow()
+ : KXmlGuiWindow(nullptr)
+ , m_newFileMenu(nullptr)
+ , m_tabWidget(nullptr)
+ , m_activeViewContainer(nullptr)
+ , m_actionHandler(nullptr)
+ , m_remoteEncoding(nullptr)
+ , m_settingsDialog()
+ , m_bookmarkHandler(nullptr)
+ , m_disabledActionNotifier(nullptr)
+ , m_lastHandleUrlOpenJob(nullptr)
+ , m_terminalPanel(nullptr)
+ , m_placesPanel(nullptr)
+ , m_tearDownFromPlacesRequested(false)
+ , m_backAction(nullptr)
+ , m_forwardAction(nullptr)
+ , m_splitViewAction(nullptr)
+ , m_splitViewMenuAction(nullptr)
+ , m_diskSpaceUsageMenu(nullptr)
+ , m_sessionSaveTimer(nullptr)
+ , m_sessionSaveWatcher(nullptr)
+ , m_sessionSaveScheduled(false)
{
Q_INIT_RESOURCE(dolphin);
new MainWindowAdaptor(this);
#ifndef Q_OS_WIN
- setWindowFlags(Qt::WindowContextHelpButtonHint);
+ setWindowFlags(Qt::WindowContextHelpButtonHint);
#endif
setComponentName(QStringLiteral("dolphin"), QGuiApplication::applicationDisplayName());
setObjectName(QStringLiteral("Dolphin#"));
setStateConfigGroup("State");
- connect(&DolphinNewFileMenuObserver::instance(), &DolphinNewFileMenuObserver::errorMessage,
- this, &DolphinMainWindow::showErrorMessage);
+#if defined(Q_OS_WIN) || defined(Q_OS_MACOS)
+ new KColorSchemeManager(this); // Sets a sensible color scheme which fixes unreadable icons and text on Windows.
+#endif
- KIO::FileUndoManager* undoManager = KIO::FileUndoManager::self();
+ connect(&DolphinNewFileMenuObserver::instance(), &DolphinNewFileMenuObserver::errorMessage, this, &DolphinMainWindow::showErrorMessage);
+
+ KIO::FileUndoManager *undoManager = KIO::FileUndoManager::self();
undoManager->setUiInterface(new UndoUiInterface());
- connect(undoManager, &KIO::FileUndoManager::undoAvailable,
- this, &DolphinMainWindow::slotUndoAvailable);
- connect(undoManager, &KIO::FileUndoManager::undoTextChanged,
- this, &DolphinMainWindow::slotUndoTextChanged);
- connect(undoManager, &KIO::FileUndoManager::jobRecordingStarted,
- this, &DolphinMainWindow::clearStatusBar);
- connect(undoManager, &KIO::FileUndoManager::jobRecordingFinished,
- this, &DolphinMainWindow::showCommand);
+ connect(undoManager, &KIO::FileUndoManager::undoAvailable, this, &DolphinMainWindow::slotUndoAvailable);
+ connect(undoManager, &KIO::FileUndoManager::undoTextChanged, this, &DolphinMainWindow::slotUndoTextChanged);
+ connect(undoManager, &KIO::FileUndoManager::jobRecordingStarted, this, &DolphinMainWindow::clearStatusBar);
+ connect(undoManager, &KIO::FileUndoManager::jobRecordingFinished, this, &DolphinMainWindow::showCommand);
const bool firstRun = (GeneralSettings::version() < 200);
if (firstRun) {
actionCollection()->addAction(QStringLiteral("url_navigators"), navigatorsWidgetAction);
m_tabWidget = new DolphinTabWidget(navigatorsWidgetAction, this);
m_tabWidget->setObjectName("tabWidget");
- connect(m_tabWidget, &DolphinTabWidget::activeViewChanged,
- this, &DolphinMainWindow::activeViewChanged);
- connect(m_tabWidget, &DolphinTabWidget::tabCountChanged,
- this, &DolphinMainWindow::tabCountChanged);
- connect(m_tabWidget, &DolphinTabWidget::currentUrlChanged,
- this, &DolphinMainWindow::updateWindowTitle);
+ connect(m_tabWidget, &DolphinTabWidget::activeViewChanged, this, &DolphinMainWindow::activeViewChanged);
+ connect(m_tabWidget, &DolphinTabWidget::tabCountChanged, this, &DolphinMainWindow::tabCountChanged);
+ connect(m_tabWidget, &DolphinTabWidget::currentUrlChanged, this, &DolphinMainWindow::updateWindowTitle);
setCentralWidget(m_tabWidget);
m_actionTextHelper = new SelectionMode::ActionTextHelper(this);
m_actionHandler = new DolphinViewActionHandler(actionCollection(), m_actionTextHelper, this);
connect(m_actionHandler, &DolphinViewActionHandler::actionBeingHandled, this, &DolphinMainWindow::clearStatusBar);
connect(m_actionHandler, &DolphinViewActionHandler::createDirectoryTriggered, this, &DolphinMainWindow::createDirectory);
+ connect(m_actionHandler, &DolphinViewActionHandler::createFileTriggered, this, &DolphinMainWindow::createFile);
connect(m_actionHandler, &DolphinViewActionHandler::selectionModeChangeTriggered, this, &DolphinMainWindow::slotSetSelectionMode);
+ QAction *newDirAction = actionCollection()->action(QStringLiteral("create_dir"));
+ Q_CHECK_PTR(newDirAction);
+ m_newFileMenu->setNewFolderShortcutAction(newDirAction);
+
+ QAction *newFileAction = actionCollection()->action(QStringLiteral("create_file"));
+ Q_CHECK_PTR(newFileAction);
+ m_newFileMenu->setNewFileShortcutAction(newFileAction);
+
m_remoteEncoding = new DolphinRemoteEncoding(this, m_actionHandler);
- connect(this, &DolphinMainWindow::urlChanged,
- m_remoteEncoding, &DolphinRemoteEncoding::slotAboutToOpenUrl);
+ connect(this, &DolphinMainWindow::urlChanged, m_remoteEncoding, &DolphinRemoteEncoding::slotAboutToOpenUrl);
+
+ m_disabledActionNotifier = new DisabledActionNotifier(this);
+ connect(m_disabledActionNotifier, &DisabledActionNotifier::disabledActionTriggered, this, [this](const QAction *, QString reason) {
+ m_activeViewContainer->showMessage(reason, KMessageWidget::Warning);
+ });
setupDockWidgets();
- setupGUI(Save | Create | ToolBar);
+ const bool usePhoneUi{KRuntimePlatform::runtimePlatform().contains(QLatin1String("phone"))};
+ setupGUI(Save | Create | ToolBar, usePhoneUi ? QStringLiteral("dolphinuiforphones.rc") : QString() /* load the default dolphinui.rc file */);
stateChanged(QStringLiteral("new_file"));
- QClipboard* clipboard = QApplication::clipboard();
- connect(clipboard, &QClipboard::dataChanged,
- this, &DolphinMainWindow::updatePasteAction);
+ QClipboard *clipboard = QApplication::clipboard();
+ connect(clipboard, &QClipboard::dataChanged, this, &DolphinMainWindow::updatePasteAction);
- QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
+ QAction *toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
toggleFilterBarAction->setChecked(GeneralSettings::filterBar());
if (firstRun) {
menuBar()->setVisible(false);
+
+ if (usePhoneUi) {
+ Q_ASSERT(qobject_cast<QDockWidget *>(m_placesPanel->parent()));
+ m_placesPanel->parentWidget()->hide();
+ auto settings = GeneralSettings::self();
+ settings->setShowZoomSlider(false); // Zooming can be done with pinch gestures instead and we are short on horizontal space.
+ settings->setRenameInline(false); // This works around inline renaming currently not working well with virtual keyboards.
+ settings->save(); // Otherwise the RenameInline setting is not picked up for the first time Dolphin is used.
+ }
}
const bool showMenu = !menuBar()->isHidden();
- QAction* showMenuBarAction = actionCollection()->action(KStandardAction::name(KStandardAction::ShowMenubar));
- showMenuBarAction->setChecked(showMenu); // workaround for bug #171080
+ QAction *showMenuBarAction = actionCollection()->action(KStandardAction::name(KStandardAction::ShowMenubar));
+ showMenuBarAction->setChecked(showMenu); // workaround for bug #171080
- auto hamburgerMenu = static_cast<KHamburgerMenu *>(actionCollection()->action(
- KStandardAction::name(KStandardAction::HamburgerMenu)));
+ auto hamburgerMenu = static_cast<KHamburgerMenu *>(actionCollection()->action(KStandardAction::name(KStandardAction::HamburgerMenu)));
hamburgerMenu->setMenuBar(menuBar());
hamburgerMenu->setShowMenuBarAction(showMenuBarAction);
- connect(hamburgerMenu, &KHamburgerMenu::aboutToShowMenu,
- this, &DolphinMainWindow::updateHamburgerMenu);
+ connect(hamburgerMenu, &KHamburgerMenu::aboutToShowMenu, this, &DolphinMainWindow::updateHamburgerMenu);
hamburgerMenu->hideActionsOf(toolBar());
if (GeneralSettings::version() < 201 && !toolBar()->actions().contains(hamburgerMenu)) {
addHamburgerMenuToToolbar();
}
updateAllowedToolbarAreas();
+ updateNavigatorsBackground();
// enable middle-click on back/forward/up to open in a new tab
auto *middleClickEventFilter = new MiddleClickActionEventFilter(this);
showErrorMessage(errorMessage);
});
- connect(GeneralSettings::self(), &GeneralSettings::splitViewChanged,
- this, &DolphinMainWindow::slotSplitViewChanged);
+ connect(GeneralSettings::self(), &GeneralSettings::splitViewChanged, this, &DolphinMainWindow::slotSplitViewChanged);
}
DolphinMainWindow::~DolphinMainWindow()
{
// This fixes a crash on Wayland when closing the mainwindow while another dialog is open.
disconnect(QGuiApplication::clipboard(), &QClipboard::dataChanged, this, &DolphinMainWindow::updatePasteAction);
+
+ // This fixes a crash in dolphinmainwindowtest where the connection below fires even though the KMainWindow destructor of this object is already running.
+ Q_CHECK_PTR(qobject_cast<DolphinDockWidget *>(m_placesPanel->parent()));
+ disconnect(static_cast<DolphinDockWidget *>(m_placesPanel->parent()),
+ &DolphinDockWidget::visibilityChanged,
+ this,
+ &DolphinMainWindow::slotPlacesPanelVisibilityChanged);
}
-QVector<DolphinViewContainer*> DolphinMainWindow::viewContainers() const
+QVector<DolphinViewContainer *> DolphinMainWindow::viewContainers() const
{
- QVector<DolphinViewContainer*> viewContainers;
+ QVector<DolphinViewContainer *> viewContainers;
for (int i = 0; i < m_tabWidget->count(); ++i) {
DolphinTabPage *tabPage = m_tabWidget->tabPageAt(i);
return viewContainers;
}
-void DolphinMainWindow::openDirectories(const QList<QUrl>& dirs, bool splitView)
+void DolphinMainWindow::openDirectories(const QList<QUrl> &dirs, bool splitView)
{
m_tabWidget->openDirectories(dirs, splitView);
}
-void DolphinMainWindow::openDirectories(const QStringList& dirs, bool splitView)
+void DolphinMainWindow::openDirectories(const QStringList &dirs, bool splitView)
{
openDirectories(QUrl::fromStringList(dirs), splitView);
}
-void DolphinMainWindow::openFiles(const QList<QUrl>& files, bool splitView)
+void DolphinMainWindow::openFiles(const QList<QUrl> &files, bool splitView)
{
m_tabWidget->openFiles(files, splitView);
}
#endif
}
-void DolphinMainWindow::openFiles(const QStringList& files, bool splitView)
+bool DolphinMainWindow::isSplitViewEnabledInCurrentTab() const
+{
+ return m_tabWidget->currentTabPage()->splitViewEnabled();
+}
+
+void DolphinMainWindow::openFiles(const QStringList &files, bool splitView)
{
openFiles(QUrl::fromStringList(files), splitView);
}
if (KWindowSystem::isPlatformWayland()) {
KWindowSystem::setCurrentXdgActivationToken(activationToken);
- } else {
+ } else if (KWindowSystem::isPlatformX11()) {
+#if HAVE_X11
KStartupInfo::setNewStartupId(window()->windowHandle(), activationToken.toUtf8());
+#endif
}
KWindowSystem::activateWindow(window()->windowHandle());
void DolphinMainWindow::showCommand(CommandType command)
{
- DolphinStatusBar* statusBar = m_activeViewContainer->statusBar();
+ DolphinStatusBar *statusBar = m_activeViewContainer->statusBar();
switch (command) {
case KIO::FileUndoManager::Copy:
statusBar->setText(i18nc("@info:status", "Successfully copied."));
updatePasteAction();
updateViewActions();
updateGoActions();
+ m_diskSpaceUsageMenu->setUrl(url);
+
+ // will signal used urls to activities manager, too
+ m_recentFiles->addUrl(url, QString(), "inode/directory");
Q_EMIT urlChanged(url);
}
-void DolphinMainWindow::slotTerminalDirectoryChanged(const QUrl& url)
+void DolphinMainWindow::slotTerminalDirectoryChanged(const QUrl &url)
{
if (m_tearDownFromPlacesRequested && url == QUrl::fromLocalFile(QDir::homePath())) {
m_placesPanel->proceedWithTearDown();
m_tearDownFromPlacesRequested = false;
}
- m_activeViewContainer->setAutoGrabFocus(false);
+ m_activeViewContainer->setGrabFocusOnUrlChange(false);
changeUrl(url);
- m_activeViewContainer->setAutoGrabFocus(true);
+ m_activeViewContainer->setGrabFocusOnUrlChange(true);
}
void DolphinMainWindow::slotEditableStateChanged(bool editable)
{
- KToggleAction* editableLocationAction =
- static_cast<KToggleAction*>(actionCollection()->action(QStringLiteral("editable_location")));
+ KToggleAction *editableLocationAction = static_cast<KToggleAction *>(actionCollection()->action(QStringLiteral("editable_location")));
editableLocationAction->setChecked(editable);
}
-void DolphinMainWindow::slotSelectionChanged(const KFileItemList& selection)
+void DolphinMainWindow::slotSelectionChanged(const KFileItemList &selection)
{
updateFileAndEditActions();
const int selectedUrlsCount = m_tabWidget->currentTabPage()->selectedItemsCount();
- QAction* compareFilesAction = actionCollection()->action(QStringLiteral("compare_files"));
+ QAction *compareFilesAction = actionCollection()->action(QStringLiteral("compare_files"));
if (selectedUrlsCount == 2) {
compareFilesAction->setEnabled(isKompareInstalled());
} else {
const KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigatorInternalWithHistory();
const int index = urlNavigator->historyIndex();
- QAction* backAction = actionCollection()->action(KStandardAction::name(KStandardAction::Back));
+ QAction *backAction = actionCollection()->action(KStandardAction::name(KStandardAction::Back));
if (backAction) {
backAction->setToolTip(i18nc("@info", "Go back"));
backAction->setWhatsThis(i18nc("@info:whatsthis go back", "Return to the previously viewed folder."));
backAction->setEnabled(index < urlNavigator->historySize() - 1);
}
- QAction* forwardAction = actionCollection()->action(KStandardAction::name(KStandardAction::Forward));
+ QAction *forwardAction = actionCollection()->action(KStandardAction::name(KStandardAction::Forward));
if (forwardAction) {
forwardAction->setToolTip(i18nc("@info", "Go forward"));
- forwardAction->setWhatsThis(xi18nc("@info:whatsthis go forward",
- "This undoes a <interface>Go|Back</interface> action."));
+ forwardAction->setWhatsThis(xi18nc("@info:whatsthis go forward", "This undoes a <interface>Go|Back</interface> action."));
forwardAction->setEnabled(index > 0);
}
}
void DolphinMainWindow::updateFilterBarAction(bool show)
{
- QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
+ QAction *toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
toggleFilterBarAction->setChecked(show);
}
}
if (url.isValid()) {
QString icon;
- if (m_activeViewContainer->isSearchModeEnabled()) {
+ if (isSearchUrl(url)) {
icon = QStringLiteral("folder-saved-search-symbolic");
} else {
icon = KIO::iconNameForUrl(url);
}
}
-void DolphinMainWindow::openNewTab(const QUrl& url)
+DolphinTabPage *DolphinMainWindow::openNewTab(const QUrl &url)
{
- m_tabWidget->openNewTab(url, QUrl());
+ return m_tabWidget->openNewTab(url, QUrl());
}
void DolphinMainWindow::openNewTabAndActivate(const QUrl &url)
void DolphinMainWindow::slotSplitViewChanged()
{
m_tabWidget->currentTabPage()->setSplitViewEnabled(GeneralSettings::splitView(), WithAnimation);
- updateSplitAction();
+ updateSplitActions();
}
void DolphinMainWindow::openInNewTab()
{
- const KFileItemList& list = m_activeViewContainer->view()->selectedItems();
+ const KFileItemList &list = m_activeViewContainer->view()->selectedItems();
bool tabCreated = false;
- for (const KFileItem& item : list) {
- const QUrl& url = DolphinView::openItemAsFolderUrl(item);
+ for (const KFileItem &item : list) {
+ const QUrl &url = DolphinView::openItemAsFolderUrl(item);
if (!url.isEmpty()) {
openNewTab(url);
tabCreated = true;
if (list.isEmpty()) {
newWindowUrl = m_activeViewContainer->url();
} else if (list.count() == 1) {
- const KFileItem& item = list.first();
+ const KFileItem &item = list.first();
newWindowUrl = DolphinView::openItemAsFolderUrl(item);
}
}
}
-void DolphinMainWindow::showTarget()
+void DolphinMainWindow::openInSplitView(const QUrl &url)
{
- const auto link = m_activeViewContainer->view()->selectedItems().at(0);
- const auto linkLocationDir = QFileInfo(link.localPath()).absoluteDir();
- auto linkDestination = link.linkDest();
- if (QFileInfo(linkDestination).isRelative()) {
- linkDestination = linkLocationDir.filePath(linkDestination);
+ QUrl newSplitViewUrl = url;
+
+ if (newSplitViewUrl.isEmpty()) {
+ const KFileItemList list = m_activeViewContainer->view()->selectedItems();
+ if (list.count() == 1) {
+ const KFileItem &item = list.first();
+ newSplitViewUrl = DolphinView::openItemAsFolderUrl(item);
+ }
}
- if (QFileInfo::exists(linkDestination)) {
- KIO::highlightInFileManager({QUrl::fromLocalFile(linkDestination).adjusted(QUrl::StripTrailingSlash)});
+
+ if (newSplitViewUrl.isEmpty()) {
+ return;
+ }
+
+ DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
+ if (tabPage->splitViewEnabled()) {
+ tabPage->switchActiveView();
+ tabPage->activeViewContainer()->setUrl(newSplitViewUrl);
} else {
- m_activeViewContainer->showMessage(xi18nc("@info", "Could not access <filename>%1</filename>.", linkDestination),
- DolphinViewContainer::Warning);
+ tabPage->setSplitViewEnabled(true, WithAnimation, newSplitViewUrl);
+ updateViewActions();
+ }
+}
+
+void DolphinMainWindow::showTarget()
+{
+ const KFileItem link = m_activeViewContainer->view()->selectedItems().at(0);
+ const QUrl destinationUrl = link.url().resolved(QUrl(link.linkDest()));
+
+ auto job = KIO::stat(destinationUrl, KIO::StatJob::SourceSide, KIO::StatNoDetails);
+
+ connect(job, &KJob::finished, this, [this, destinationUrl](KJob *job) {
+ KIO::StatJob *statJob = static_cast<KIO::StatJob *>(job);
+
+ if (statJob->error()) {
+ m_activeViewContainer->showMessage(job->errorString(), KMessageWidget::Error);
+ } else {
+ KIO::highlightInFileManager({destinationUrl});
+ }
+ });
+}
+
+bool DolphinMainWindow::event(QEvent *event)
+{
+ if (event->type() == QEvent::ShortcutOverride) {
+ const QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);
+ if (keyEvent->key() == Qt::Key_Space && m_activeViewContainer->view()->handleSpaceAsNormalKey()) {
+ event->accept();
+ return true;
+ }
}
+
+ return KXmlGuiWindow::event(event);
}
-void DolphinMainWindow::showEvent(QShowEvent* event)
+void DolphinMainWindow::showEvent(QShowEvent *event)
{
KXmlGuiWindow::showEvent(event);
- if (!event->spontaneous()) {
+ if (!event->spontaneous() && m_activeViewContainer) {
m_activeViewContainer->view()->setFocus();
}
}
-void DolphinMainWindow::closeEvent(QCloseEvent* event)
+void DolphinMainWindow::closeEvent(QCloseEvent *event)
{
// Find out if Dolphin is closed directly by the user or
// by the session manager because the session is closed
closedByUser = false;
}
- if (m_tabWidget->count() > 1
- && GeneralSettings::confirmClosingMultipleTabs()
- && !GeneralSettings::rememberOpenedTabs()
- && closedByUser) {
+ if (m_tabWidget->count() > 1 && GeneralSettings::confirmClosingMultipleTabs() && !GeneralSettings::rememberOpenedTabs() && closedByUser) {
// Ask the user if he really wants to quit and close all tabs.
// Open a confirmation dialog with 3 buttons:
// QDialogButtonBox::Yes -> Quit
QDialog *dialog = new QDialog(this, Qt::Dialog);
dialog->setWindowTitle(i18nc("@title:window", "Confirmation"));
dialog->setModal(true);
- QDialogButtonBox* buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel);
- KGuiItem::assign(buttons->button(QDialogButtonBox::Yes), KGuiItem(i18nc("@action:button 'Quit Dolphin' button", "&Quit %1", QGuiApplication::applicationDisplayName()), QIcon::fromTheme(QStringLiteral("application-exit"))));
+ QDialogButtonBox *buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel);
+ KGuiItem::assign(buttons->button(QDialogButtonBox::Yes),
+ KGuiItem(i18nc("@action:button 'Quit Dolphin' button", "&Quit %1", QGuiApplication::applicationDisplayName()),
+ QIcon::fromTheme(QStringLiteral("application-exit"))));
KGuiItem::assign(buttons->button(QDialogButtonBox::No), KGuiItem(i18n("C&lose Current Tab"), QIcon::fromTheme(QStringLiteral("tab-close"))));
KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel());
buttons->button(QDialogButtonBox::Yes)->setDefault(true);
bool doNotAskAgainCheckboxResult = false;
const auto result = KMessageBox::createKMessageBox(dialog,
- buttons,
- QMessageBox::Warning,
- i18n("You have multiple tabs open in this window, are you sure you want to quit?"),
- QStringList(),
- i18n("Do not ask again"),
- &doNotAskAgainCheckboxResult,
- KMessageBox::Notify);
+ buttons,
+ QMessageBox::Warning,
+ i18n("You have multiple tabs open in this window, are you sure you want to quit?"),
+ QStringList(),
+ i18n("Do not ask again"),
+ &doNotAskAgainCheckboxResult,
+ KMessageBox::Notify);
if (doNotAskAgainCheckboxResult) {
GeneralSettings::setConfirmClosingMultipleTabs(false);
}
switch (result) {
- case QDialogButtonBox::Yes:
- // Quit
- break;
- case QDialogButtonBox::No:
- // Close only the current tab
- m_tabWidget->closeTab();
- Q_FALLTHROUGH();
- default:
- event->ignore();
- return;
+ case QDialogButtonBox::Yes:
+ // Quit
+ break;
+ case QDialogButtonBox::No:
+ // Close only the current tab
+ m_tabWidget->closeTab();
+ Q_FALLTHROUGH();
+ default:
+ event->ignore();
+ return;
}
}
QDialogButtonBox *buttons = new QDialogButtonBox(standardButtons);
KGuiItem::assign(buttons->button(QDialogButtonBox::Yes), KStandardGuiItem::quit());
if (!m_terminalPanel->isVisible()) {
- KGuiItem::assign(
- buttons->button(QDialogButtonBox::No),
- KGuiItem(i18n("Show &Terminal Panel"), QIcon::fromTheme(QStringLiteral("dialog-scripts"))));
+ KGuiItem::assign(buttons->button(QDialogButtonBox::No), KGuiItem(i18n("Show &Terminal Panel"), QIcon::fromTheme(QStringLiteral("dialog-scripts"))));
}
KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel());
bool doNotAskAgainCheckboxResult = false;
const auto result = KMessageBox::createKMessageBox(
- dialog,
- buttons,
- QMessageBox::Warning,
- i18n("The program '%1' is still running in the Terminal panel. Are you sure you want to quit?", m_terminalPanel->runningProgramName()),
- QStringList(),
- i18n("Do not ask again"),
- &doNotAskAgainCheckboxResult,
- KMessageBox::Dangerous);
+ dialog,
+ buttons,
+ QMessageBox::Warning,
+ i18n("The program '%1' is still running in the Terminal panel. Are you sure you want to quit?", m_terminalPanel->runningProgramName()),
+ QStringList(),
+ i18n("Do not ask again"),
+ &doNotAskAgainCheckboxResult,
+ KMessageBox::Notify | KMessageBox::Dangerous);
if (doNotAskAgainCheckboxResult) {
GeneralSettings::setConfirmClosingTerminalRunningProgram(false);
}
switch (result) {
- case QDialogButtonBox::Yes:
- // Quit
- break;
- case QDialogButtonBox::No:
- actionCollection()->action("show_terminal_panel")->trigger();
- // Do not quit, ignore quit event
- Q_FALLTHROUGH();
- default:
- event->ignore();
- return;
+ case QDialogButtonBox::Yes:
+ // Quit
+ break;
+ case QDialogButtonBox::No:
+ actionCollection()->action("show_terminal_panel")->trigger();
+ // Do not quit, ignore quit event
+ Q_FALLTHROUGH();
+ default:
+ event->ignore();
+ return;
}
}
- if (GeneralSettings::rememberOpenedTabs()) {
+ if (m_sessionSaveTimer && (m_sessionSaveTimer->isActive() || m_sessionSaveWatcher->isRunning())) {
+ const bool sessionSaveTimerActive = m_sessionSaveTimer->isActive();
+
+ m_sessionSaveTimer->stop();
+ m_sessionSaveWatcher->disconnect();
+ m_sessionSaveWatcher->waitForFinished();
+
+ if (sessionSaveTimerActive || m_sessionSaveScheduled) {
+ slotSaveSession();
+ }
+ }
+
+ GeneralSettings::setVersion(CurrentDolphinVersion);
+ GeneralSettings::self()->save();
+
+ KXmlGuiWindow::closeEvent(event);
+}
+
+void DolphinMainWindow::slotSaveSession()
+{
+ m_sessionSaveScheduled = false;
+
+ if (m_sessionSaveWatcher->isRunning()) {
+ // The previous session is still being saved - schedule another save.
+ m_sessionSaveWatcher->disconnect();
+ connect(m_sessionSaveWatcher, &QFutureWatcher<void>::finished, this, &DolphinMainWindow::slotSaveSession, Qt::SingleShotConnection);
+ m_sessionSaveScheduled = true;
+ } else if (!m_sessionSaveTimer->isActive()) {
+ // No point in saving the session if the timer is running (since it will save the session again when it times out).
KConfigGui::setSessionConfig(QStringLiteral("dolphin"), QStringLiteral("dolphin"));
KConfig *config = KConfigGui::sessionConfig();
saveGlobalProperties(config);
savePropertiesInternal(config, 1);
- config->sync();
+ KConfigGroup group = config->group(QStringLiteral("Number"));
+ group.writeEntry("NumberOfWindows", 1); // Makes session restore aware that there is a window to restore.
+
+ auto future = QtConcurrent::run([config]() {
+ config->sync();
+ });
+ m_sessionSaveWatcher->setFuture(future);
}
+}
- GeneralSettings::setVersion(CurrentDolphinVersion);
- GeneralSettings::self()->save();
+void DolphinMainWindow::setSessionAutoSaveEnabled(bool enable)
+{
+ if (enable) {
+ if (!m_sessionSaveTimer) {
+ m_sessionSaveTimer = new QTimer(this);
+ m_sessionSaveWatcher = new QFutureWatcher<void>(this);
+ m_sessionSaveTimer->setSingleShot(true);
+ m_sessionSaveTimer->setInterval(22000);
- KXmlGuiWindow::closeEvent(event);
+ connect(m_sessionSaveTimer, &QTimer::timeout, this, &DolphinMainWindow::slotSaveSession);
+ }
+
+ connect(m_tabWidget, &DolphinTabWidget::urlChanged, m_sessionSaveTimer, qOverload<>(&QTimer::start), Qt::UniqueConnection);
+ connect(m_tabWidget, &DolphinTabWidget::tabCountChanged, m_sessionSaveTimer, qOverload<>(&QTimer::start), Qt::UniqueConnection);
+ connect(m_tabWidget, &DolphinTabWidget::activeViewChanged, m_sessionSaveTimer, qOverload<>(&QTimer::start), Qt::UniqueConnection);
+ } else if (m_sessionSaveTimer) {
+ m_sessionSaveTimer->stop();
+ m_sessionSaveWatcher->disconnect();
+ m_sessionSaveScheduled = false;
+
+ m_sessionSaveWatcher->waitForFinished();
+
+ m_sessionSaveTimer->deleteLater();
+ m_sessionSaveWatcher->deleteLater();
+ m_sessionSaveTimer = nullptr;
+ m_sessionSaveWatcher = nullptr;
+ }
}
-void DolphinMainWindow::saveProperties(KConfigGroup& group)
+void DolphinMainWindow::saveProperties(KConfigGroup &group)
{
m_tabWidget->saveProperties(group);
}
-void DolphinMainWindow::readProperties(const KConfigGroup& group)
+void DolphinMainWindow::readProperties(const KConfigGroup &group)
{
m_tabWidget->readProperties(group);
}
void DolphinMainWindow::updateNewMenu()
{
m_newFileMenu->checkUpToDate();
-#if KIO_VERSION >= QT_VERSION_CHECK(5, 97, 0)
m_newFileMenu->setWorkingDirectory(activeViewContainer()->url());
-#else
- m_newFileMenu->setPopupFiles(QList<QUrl>() << activeViewContainer()->url());
-#endif
}
void DolphinMainWindow::createDirectory()
{
-#if KIO_VERSION >= QT_VERSION_CHECK(5, 97, 0)
- m_newFileMenu->setWorkingDirectory(activeViewContainer()->url());
-#else
- m_newFileMenu->setPopupFiles(QList<QUrl>() << activeViewContainer()->url());
-#endif
- m_newFileMenu->createDirectory();
+ // When creating directory, namejob is being run. In network folders,
+ // this job can take long time, so instead of starting multiple namejobs,
+ // just check if we are already running one. This prevents opening multiple
+ // dialogs. BUG:481401
+ if (!m_newFileMenu->isCreateDirectoryRunning()) {
+ m_newFileMenu->setWorkingDirectory(activeViewContainer()->url());
+ m_newFileMenu->createDirectory();
+ }
+}
+
+void DolphinMainWindow::createFile()
+{
+ // Use the same logic as in createDirectory()
+ if (!m_newFileMenu->isCreateFileRunning()) {
+ m_newFileMenu->setWorkingDirectory(activeViewContainer()->url());
+ m_newFileMenu->createFile();
+ }
}
void DolphinMainWindow::quit()
close();
}
-void DolphinMainWindow::showErrorMessage(const QString& message)
+void DolphinMainWindow::showErrorMessage(const QString &message)
{
- m_activeViewContainer->showMessage(message, DolphinViewContainer::Error);
+ m_activeViewContainer->showMessage(message, KMessageWidget::Error);
}
void DolphinMainWindow::slotUndoAvailable(bool available)
{
- QAction* undoAction = actionCollection()->action(KStandardAction::name(KStandardAction::Undo));
+ QAction *undoAction = actionCollection()->action(KStandardAction::name(KStandardAction::Undo));
if (undoAction) {
undoAction->setEnabled(available);
}
}
-void DolphinMainWindow::slotUndoTextChanged(const QString& text)
+void DolphinMainWindow::slotUndoTextChanged(const QString &text)
{
- QAction* undoAction = actionCollection()->action(KStandardAction::name(KStandardAction::Undo));
+ QAction *undoAction = actionCollection()->action(KStandardAction::name(KStandardAction::Undo));
if (undoAction) {
undoAction->setText(text);
}
void DolphinMainWindow::find()
{
- m_activeViewContainer->setSearchModeEnabled(true);
+ m_activeViewContainer->setSearchBarVisible(true);
+ m_activeViewContainer->setFocusToSearchBar();
}
void DolphinMainWindow::updateSearchAction()
{
- QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
- toggleSearchAction->setChecked(m_activeViewContainer->isSearchModeEnabled());
+ QAction *toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
+ toggleSearchAction->setChecked(m_activeViewContainer->isSearchBarVisible());
}
void DolphinMainWindow::updatePasteAction()
{
- QAction* pasteAction = actionCollection()->action(KStandardAction::name(KStandardAction::Paste));
+ QAction *pasteAction = actionCollection()->action(KStandardAction::name(KStandardAction::Paste));
QPair<bool, QString> pasteInfo = m_activeViewContainer->view()->pasteInfo();
pasteAction->setEnabled(pasteInfo.first);
+ m_disabledActionNotifier->setDisabledReason(pasteAction,
+ m_activeViewContainer->rootItem().isWritable()
+ ? i18nc("@info", "Cannot paste: The clipboard is empty.")
+ : i18nc("@info", "Cannot paste: You do not have permission to write into this folder."));
pasteAction->setText(pasteInfo.second);
}
{
const QUrl url = urlNavigator->locationUrl(historyIndex);
- QString text = url.toDisplayString(QUrl::PreferLocalFile);
+ QString text;
- if (!urlNavigator->showFullPath()) {
+ if (isSearchUrl(url)) {
+ text = Search::DolphinQuery(url, QUrl{}).title();
+ } else if (urlNavigator->showFullPath()) {
+ text = url.toDisplayString(QUrl::PreferLocalFile);
+ } else {
const KFilePlacesModel *placesModel = DolphinPlacesModelSingleton::instance().placesModel();
const QModelIndex closestIdx = placesModel->closestItem(url);
{
const KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigatorInternalWithHistory();
int entries = 0;
- m_backAction->menu()->clear();
+ QMenu *menu = m_backAction->popupMenu();
+ menu->clear();
for (int i = urlNavigator->historyIndex() + 1; i < urlNavigator->historySize() && entries < MaxNumberOfNavigationentries; ++i, ++entries) {
- QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_backAction->menu());
- m_backAction->menu()->addAction(action);
+ QAction *action = urlNavigatorHistoryAction(urlNavigator, i, menu);
+ menu->addAction(action);
}
}
-void DolphinMainWindow::slotGoBack(QAction* action)
+void DolphinMainWindow::slotGoBack(QAction *action)
{
int gotoIndex = action->data().value<int>();
const KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigatorInternalWithHistory();
}
}
-void DolphinMainWindow::slotBackForwardActionMiddleClicked(QAction* action)
+void DolphinMainWindow::slotBackForwardActionMiddleClicked(QAction *action)
{
if (action) {
const KUrlNavigator *urlNavigator = activeViewContainer()->urlNavigatorInternalWithHistory();
{
const KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigatorInternalWithHistory();
int entries = 0;
- m_forwardAction->menu()->clear();
+ QMenu *menu = m_forwardAction->popupMenu();
+ menu->clear();
for (int i = urlNavigator->historyIndex() - 1; i >= 0 && entries < MaxNumberOfNavigationentries; --i, ++entries) {
- QAction *action = urlNavigatorHistoryAction(urlNavigator, i, m_forwardAction->menu());
- m_forwardAction->menu()->addAction(action);
+ QAction *action = urlNavigatorHistoryAction(urlNavigator, i, menu);
+ menu->addAction(action);
}
}
-void DolphinMainWindow::slotGoForward(QAction* action)
+void DolphinMainWindow::slotGoForward(QAction *action)
{
int gotoIndex = action->data().value<int>();
const KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigatorInternalWithHistory();
// if the URL navigator is editable and focused, select the whole
// URL instead of all items of the view
- KUrlNavigator* urlNavigator = m_activeViewContainer->urlNavigator();
- QLineEdit* lineEdit = urlNavigator->editor()->lineEdit();
- const bool selectUrl = urlNavigator->isUrlEditable() &&
- lineEdit->hasFocus();
+ KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigator();
+ QLineEdit *lineEdit = urlNavigator->editor()->lineEdit();
+ const bool selectUrl = urlNavigator->isUrlEditable() && lineEdit->hasFocus();
if (selectUrl) {
lineEdit->selectAll();
} else {
void DolphinMainWindow::toggleSplitView()
{
- DolphinTabPage* tabPage = m_tabWidget->currentTabPage();
- tabPage->setSplitViewEnabled(!tabPage->splitViewEnabled(), WithAnimation);
+ QUrl newSplitViewUrl;
+ const KFileItemList list = m_activeViewContainer->view()->selectedItems();
+ if (list.count() == 1) {
+ const KFileItem &item = list.first();
+ newSplitViewUrl = DolphinView::openItemAsFolderUrl(item);
+ }
+ DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
+ tabPage->setSplitViewEnabled(!tabPage->splitViewEnabled(), WithAnimation, newSplitViewUrl);
+ m_tabWidget->updateTabName(m_tabWidget->indexOf(tabPage));
updateViewActions();
}
+void DolphinMainWindow::popoutSplitView()
+{
+ DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
+ if (!tabPage->splitViewEnabled())
+ return;
+ openNewWindow((GeneralSettings::closeActiveSplitView() ? tabPage->activeViewContainer() : tabPage->inactiveViewContainer())->url());
+ tabPage->setSplitViewEnabled(false, WithAnimation);
+ updateSplitActions();
+}
+
void DolphinMainWindow::toggleSplitStash()
{
- DolphinTabPage* tabPage = m_tabWidget->currentTabPage();
+ DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
tabPage->setSplitViewEnabled(false, WithAnimation);
tabPage->setSplitViewEnabled(true, WithAnimation, QUrl("stash:/"));
}
const bool checked = !m_activeViewContainer->isFilterBarVisible();
m_activeViewContainer->setFilterBarVisible(checked);
- QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
+ QAction *toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
toggleFilterBarAction->setChecked(checked);
}
{
clearStatusBar();
- QAction* action = actionCollection()->action(QStringLiteral("editable_location"));
- KUrlNavigator* urlNavigator = m_activeViewContainer->urlNavigator();
+ QAction *action = actionCollection()->action(QStringLiteral("editable_location"));
+ KUrlNavigator *urlNavigator = m_activeViewContainer->urlNavigator();
urlNavigator->setUrlEditable(action->isChecked());
}
void DolphinMainWindow::replaceLocation()
{
- KUrlNavigator* navigator = m_activeViewContainer->urlNavigator();
- QLineEdit* lineEdit = navigator->editor()->lineEdit();
+ KUrlNavigator *navigator = m_activeViewContainer->urlNavigator();
+ QLineEdit *lineEdit = navigator->editor()->lineEdit();
// If the text field currently has focus and everything is selected,
// pressing the keyboard shortcut returns the whole thing to breadcrumb mode
- if (navigator->isUrlEditable()
- && lineEdit->hasFocus()
- && lineEdit->selectedText() == lineEdit->text() ) {
+ // and goes back to the view, just like how it was before this action was triggered the first time.
+ if (navigator->isUrlEditable() && lineEdit->hasFocus() && lineEdit->selectedText() == lineEdit->text()) {
navigator->setUrlEditable(false);
+ m_activeViewContainer->view()->setFocus();
} else {
navigator->setUrlEditable(true);
navigator->setFocus();
{
const bool newLockState = !GeneralSettings::lockPanels();
const auto childrenObjects = children();
- for (QObject* child : childrenObjects) {
- DolphinDockWidget* dock = qobject_cast<DolphinDockWidget*>(child);
+ for (QObject *child : childrenObjects) {
+ DolphinDockWidget *dock = qobject_cast<DolphinDockWidget *>(child);
if (dock) {
dock->setLocked(newLockState);
}
GeneralSettings::setLockPanels(newLockState);
}
-void DolphinMainWindow::slotTerminalPanelVisibilityChanged()
+void DolphinMainWindow::slotTerminalPanelVisibilityChanged(bool visible)
+{
+ if (!visible && m_activeViewContainer) {
+ m_activeViewContainer->view()->setFocus();
+ }
+ // Putting focus to the Terminal is not handled here but in TerminalPanel::showEvent().
+}
+
+void DolphinMainWindow::slotPlacesPanelVisibilityChanged(bool visible)
{
- if (m_terminalPanel->isHiddenInVisibleWindow() && m_activeViewContainer) {
+ if (!visible && m_activeViewContainer) {
m_activeViewContainer->view()->setFocus();
+ return;
}
+ m_placesPanel->setFocus();
}
void DolphinMainWindow::goBack()
void DolphinMainWindow::goBackInNewTab()
{
- const KUrlNavigator* urlNavigator = activeViewContainer()->urlNavigatorInternalWithHistory();
+ const KUrlNavigator *urlNavigator = activeViewContainer()->urlNavigatorInternalWithHistory();
const int index = urlNavigator->historyIndex() + 1;
openNewTab(urlNavigator->locationUrl(index));
}
void DolphinMainWindow::goForwardInNewTab()
{
- const KUrlNavigator* urlNavigator = activeViewContainer()->urlNavigatorInternalWithHistory();
+ const KUrlNavigator *urlNavigator = activeViewContainer()->urlNavigatorInternalWithHistory();
const int index = urlNavigator->historyIndex() - 1;
openNewTab(urlNavigator->locationUrl(index));
}
QPointer<QAction> DolphinMainWindow::preferredSearchTool()
{
m_searchTools.clear();
- KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames(
- &m_searchTools, { "files-find" }, m_activeViewContainer->url()
- );
- QList<QAction*> actions = m_searchTools.actions();
- if (actions.isEmpty()) {
- return nullptr;
- }
- QAction* action = actions.first();
- if (action->isSeparator()) {
+
+ KService::Ptr kfind = KService::serviceByDesktopName(QStringLiteral("org.kde.kfind"));
+
+ if (!kfind) {
return nullptr;
}
+
+ auto *action = new QAction(QIcon::fromTheme(kfind->icon()), kfind->name(), this);
+
+ connect(action, &QAction::triggered, this, [this, kfind] {
+ auto *job = new KIO::ApplicationLauncherJob(kfind);
+ job->setUrls({m_activeViewContainer->url()});
+ job->start();
+ });
+
return action;
}
void DolphinMainWindow::updateOpenPreferredSearchToolAction()
{
- QAction* openPreferredSearchTool = actionCollection()->action(QStringLiteral("open_preferred_search_tool"));
+ QAction *openPreferredSearchTool = actionCollection()->action(QStringLiteral("open_preferred_search_tool"));
if (!openPreferredSearchTool) {
return;
}
{
QList<QUrl> urls = {};
- for (const KFileItem& item : m_activeViewContainer->view()->selectedItems()) {
+ const auto selectedItems = m_activeViewContainer->view()->selectedItems();
+ for (const KFileItem &item : selectedItems) {
QUrl url = item.targetUrl();
if (item.isFile()) {
url.setPath(QFileInfo(url.path()).absolutePath());
}
if (urls.count() > 5) {
- QString question = i18np("Are you sure you want to open 1 terminal window?",
- "Are you sure you want to open %1 terminal windows?", urls.count());
-#if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0)
- const int answer = KMessageBox::warningTwoActions(this, question, {},
-#else
- const int answer = KMessageBox::warningYesNo(this, question, {},
-#endif
- KGuiItem(i18ncp("@action:button", "Open %1 Terminal", "Open %1 Terminals", urls.count()),
- QStringLiteral("utilities-terminal")),
- KStandardGuiItem::cancel());
-#if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0)
- if (answer != KMessageBox::PrimaryAction) {
-#else
- if (answer != KMessageBox::Yes) {
-#endif
+ QString question = i18np("Are you sure you want to open 1 terminal window?", "Are you sure you want to open %1 terminal windows?", urls.count());
+ const int answer = KMessageBox::warningContinueCancel(
+ this,
+ question,
+ {},
+ KGuiItem(i18ncp("@action:button", "Open %1 Terminal", "Open %1 Terminals", urls.count()), QStringLiteral("utilities-terminal")),
+ KStandardGuiItem::cancel(),
+ QStringLiteral("ConfirmOpenManyTerminals"));
+ if (answer != KMessageBox::PrimaryAction && answer != KMessageBox::Continue) {
return;
}
}
- for (const QUrl& url : urls) {
+ for (const QUrl &url : std::as_const(urls)) {
openTerminalJob(url);
}
}
-void DolphinMainWindow::openTerminalJob(const QUrl& url)
+void DolphinMainWindow::openTerminalJob(const QUrl &url)
{
if (url.isLocalFile()) {
auto job = new KTerminalLauncherJob(QString());
return;
}
- // Not a local file, with protocol Class ":local", try stat'ing
+ // Not a local file, with protocol Class ":local", try stat'ing
if (KProtocolInfo::protocolClass(url.scheme()) == QLatin1String(":local")) {
KIO::StatJob *job = KIO::mostLocalUrl(url);
KJobWidgets::setWindow(job, this);
void DolphinMainWindow::editSettings()
{
if (!m_settingsDialog) {
- DolphinViewContainer* container = activeViewContainer();
+ DolphinViewContainer *container = activeViewContainer();
container->view()->writeSettings();
const QUrl url = container->url();
- DolphinSettingsDialog* settingsDialog = new DolphinSettingsDialog(url, this, actionCollection());
+ DolphinSettingsDialog *settingsDialog = new DolphinSettingsDialog(url, this, actionCollection());
connect(settingsDialog, &DolphinSettingsDialog::settingsChanged, this, &DolphinMainWindow::refreshViews);
- connect(settingsDialog, &DolphinSettingsDialog::settingsChanged,
- &DolphinUrlNavigatorsController::slotReadSettings);
+ connect(settingsDialog, &DolphinSettingsDialog::settingsChanged, &DolphinUrlNavigatorsController::slotReadSettings);
settingsDialog->setAttribute(Qt::WA_DeleteOnClose);
settingsDialog->show();
m_settingsDialog = settingsDialog;
}
}
-void DolphinMainWindow::handleUrl(const QUrl& url)
+void DolphinMainWindow::handleUrl(const QUrl &url)
{
delete m_lastHandleUrlOpenJob;
m_lastHandleUrlOpenJob = nullptr;
activeViewContainer()->setUrl(url);
} else {
m_lastHandleUrlOpenJob = new KIO::OpenUrlJob(url);
-#if KIO_VERSION >= QT_VERSION_CHECK(5, 98, 0)
m_lastHandleUrlOpenJob->setUiDelegate(KIO::createDefaultJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
-#else
- m_lastHandleUrlOpenJob->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
-#endif
m_lastHandleUrlOpenJob->setShowOpenOrExecuteDialog(true);
- connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this,
- [this, url](const QString &mimetype) {
- if (mimetype == QLatin1String("inode/directory")) {
- // If it's a dir, we'll take it from here
- m_lastHandleUrlOpenJob->kill();
- m_lastHandleUrlOpenJob = nullptr;
- activeViewContainer()->setUrl(url);
- }
+ connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this, [this, url](const QString &mimetype) {
+ if (mimetype == QLatin1String("inode/directory")) {
+ // If it's a dir, we'll take it from here
+ m_lastHandleUrlOpenJob->kill();
+ m_lastHandleUrlOpenJob = nullptr;
+ activeViewContainer()->setUrl(url);
+ }
});
connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::result, this, [this]() {
// trash:/ is writable but we don't want to create new items in it.
// TODO: remove the trash check once https://phabricator.kde.org/T8234 is implemented
newFileMenu()->setEnabled(isFolderWritable && m_activeViewContainer->url().scheme() != QLatin1String("trash"));
+ // When the menu is disabled, actions in it are disabled later in the event loop, and we need to set the disabled reason after that.
+ QTimer::singleShot(0, this, [this]() {
+ m_disabledActionNotifier->setDisabledReason(actionCollection()->action(QStringLiteral("create_file")),
+ i18nc("@info", "Cannot create new file: You do not have permission to create items in this folder."));
+ m_disabledActionNotifier->setDisabledReason(actionCollection()->action(QStringLiteral("create_dir")),
+ i18nc("@info", "Cannot create new folder: You do not have permission to create items in this folder."));
+ });
}
-void DolphinMainWindow::openContextMenu(const QPoint& pos,
- const KFileItem& item,
- const KFileItemList &selectedItems,
- const QUrl& url)
+void DolphinMainWindow::openContextMenu(const QPoint &pos, const KFileItem &item, const KFileItemList &selectedItems, const QUrl &url)
{
QPointer<DolphinContextMenu> contextMenu = new DolphinContextMenu(this, item, selectedItems, url, &m_fileItemActions);
- contextMenu.data()->exec(pos);
+ contextMenu->exec(pos);
// Delete the menu, unless it has been deleted in its own nested event loop already.
if (contextMenu) {
void DolphinMainWindow::updateHamburgerMenu()
{
- KActionCollection* ac = actionCollection();
- auto hamburgerMenu = static_cast<KHamburgerMenu *>(
- ac->action(KStandardAction::name(KStandardAction::HamburgerMenu)));
+ KActionCollection *ac = actionCollection();
+ auto hamburgerMenu = static_cast<KHamburgerMenu *>(ac->action(KStandardAction::name(KStandardAction::HamburgerMenu)));
auto menu = hamburgerMenu->menu();
if (!menu) {
menu = new QMenu(this);
menu->addAction(ac->action(QStringLiteral("go_forward")));
menu->addMenu(m_newFileMenu->menu());
- if (!toolBar()->isVisible()
- || !toolbarActions.contains(ac->action(QStringLiteral("toggle_selection_mode_tool_bar")))
- ) {
+ if (!toolBar()->isVisible() || !toolbarActions.contains(ac->action(QStringLiteral("toggle_selection_mode_tool_bar")))) {
menu->addAction(ac->action(QStringLiteral("toggle_selection_mode")));
}
menu->addAction(ac->action(QStringLiteral("basic_actions")));
menu->addAction(ac->action(KStandardAction::name(KStandardAction::Undo)));
if (!toolBar()->isVisible()
|| (!toolbarActions.contains(ac->action(QStringLiteral("toggle_search")))
- && !toolbarActions.contains(ac->action(QStringLiteral("open_preferred_search_tool"))))
- ) {
+ && !toolbarActions.contains(ac->action(QStringLiteral("open_preferred_search_tool"))))) {
menu->addAction(ac->action(KStandardAction::name(KStandardAction::Find)));
// This way a search action will only be added if none of the three available
// search actions is present on the toolbar.
}
- if (!toolBar()->isVisible()
- || !toolbarActions.contains(ac->action(QStringLiteral("toggle_filter")))
- ) {
+ if (!toolBar()->isVisible() || !toolbarActions.contains(ac->action(QStringLiteral("toggle_filter")))) {
menu->addAction(ac->action(QStringLiteral("show_filter_bar")));
// This way a filter action will only be added if none of the two available
// filter actions is present on the toolbar.
// The third group contains actions to change what one sees in the view
// and to change the more general UI.
if (!toolBar()->isVisible()
- || (!toolbarActions.contains(ac->action(QStringLiteral("icons")))
- && !toolbarActions.contains(ac->action(QStringLiteral("compact")))
- && !toolbarActions.contains(ac->action(QStringLiteral("details")))
- && !toolbarActions.contains(ac->action(QStringLiteral("view_mode"))))
- ) {
+ || (!toolbarActions.contains(ac->action(QStringLiteral("icons"))) && !toolbarActions.contains(ac->action(QStringLiteral("compact")))
+ && !toolbarActions.contains(ac->action(QStringLiteral("details"))) && !toolbarActions.contains(ac->action(QStringLiteral("view_mode"))))
+ && !toolbarActions.contains(ac->action(QStringLiteral("view_settings")))) {
menu->addAction(ac->action(QStringLiteral("view_mode")));
}
- menu->addAction(ac->action(QStringLiteral("show_hidden_files")));
- menu->addAction(ac->action(QStringLiteral("sort")));
- menu->addAction(ac->action(QStringLiteral("additional_info")));
- if (!GeneralSettings::showStatusBar() || !GeneralSettings::showZoomSlider()) {
- menu->addAction(ac->action(QStringLiteral("zoom")));
+ if (!toolBar()->isVisible() || !toolbarActions.contains(ac->action(QStringLiteral("view_settings")))) {
+ menu->addAction(ac->action(QStringLiteral("show_hidden_files")));
+ menu->addAction(ac->action(QStringLiteral("sort")));
+ menu->addAction(ac->action(QStringLiteral("additional_info")));
+ if (!GeneralSettings::showStatusBar() || !GeneralSettings::showZoomSlider()) {
+ menu->addAction(ac->action(QStringLiteral("zoom")));
+ }
}
menu->addAction(ac->action(QStringLiteral("panels")));
// The "Configure" menu is not added to the actionCollection() because there is hardly
// a good reason for users to put it on their toolbar.
- auto configureMenu = menu->addMenu(QIcon::fromTheme(QStringLiteral("configure")),
- i18nc("@action:inmenu menu for configure actions", "Configure"));
+ auto configureMenu = menu->addMenu(QIcon::fromTheme(QStringLiteral("configure")), i18nc("@action:inmenu menu for configure actions", "Configure"));
configureMenu->addAction(ac->action(KStandardAction::name(KStandardAction::SwitchApplicationLanguage)));
configureMenu->addAction(ac->action(KStandardAction::name(KStandardAction::KeyBindings)));
configureMenu->addAction(ac->action(KStandardAction::name(KStandardAction::ConfigureToolbars)));
hamburgerMenu->hideActionsOf(configureMenu);
}
-void DolphinMainWindow::slotPlaceActivated(const QUrl& url)
+void DolphinMainWindow::slotPlaceActivated(const QUrl &url)
{
- DolphinViewContainer* view = activeViewContainer();
+ DolphinViewContainer *view = activeViewContainer();
if (view->url() == url) {
view->clearFilterBar(); // Fixes bug 259382.
// We can end up here if the user clicked a device in the Places Panel
// which had been unmounted earlier, see https://bugs.kde.org/show_bug.cgi?id=161385.
reloadView();
+
+ m_activeViewContainer->view()->setFocus(); // We always want the focus on the view after activating a place.
} else {
view->disableUrlNavigatorSelectionRequests();
changeUrl(url);
actionCollection()->action(QStringLiteral("undo_close_tab"))->setEnabled(count > 0);
}
-void DolphinMainWindow::activeViewChanged(DolphinViewContainer* viewContainer)
+void DolphinMainWindow::activeViewChanged(DolphinViewContainer *viewContainer)
{
- DolphinViewContainer* oldViewContainer = m_activeViewContainer;
+ DolphinViewContainer *oldViewContainer = m_activeViewContainer;
Q_ASSERT(viewContainer);
m_activeViewContainer = viewContainer;
if (oldViewContainer) {
- const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
- toggleSearchAction->disconnect(oldViewContainer);
-
// Disconnect all signals between the old view container (container,
// view and url navigator) and main window.
oldViewContainer->disconnect(this);
oldViewContainer->view()->disconnect(this);
oldViewContainer->urlNavigatorInternalWithHistory()->disconnect(this);
- auto navigators = static_cast<DolphinNavigatorsWidgetAction *>
- (actionCollection()->action(QStringLiteral("url_navigators")));
+ auto navigators = static_cast<DolphinNavigatorsWidgetAction *>(actionCollection()->action(QStringLiteral("url_navigators")));
navigators->primaryUrlNavigator()->disconnect(this);
if (auto secondaryUrlNavigator = navigators->secondaryUrlNavigator()) {
secondaryUrlNavigator->disconnect(this);
}
+ oldViewContainer->disconnect(m_diskSpaceUsageMenu);
// except the requestItemInfo so that on hover the information panel can still be updated
- connect(oldViewContainer->view(), &DolphinView::requestItemInfo,
- this, &DolphinMainWindow::requestItemInfo);
+ connect(oldViewContainer->view(), &DolphinView::requestItemInfo, this, &DolphinMainWindow::requestItemInfo);
// Disconnect other slots.
- disconnect(nullptr, &DolphinViewContainer::selectionModeChanged,
- actionCollection()->action(QStringLiteral("toggle_selection_mode")), &QAction::setChecked);
+ disconnect(oldViewContainer,
+ &DolphinViewContainer::selectionModeChanged,
+ actionCollection()->action(QStringLiteral("toggle_selection_mode")),
+ &QAction::setChecked);
}
connectViewSignals(viewContainer);
updateViewActions();
updateGoActions();
updateSearchAction();
+ connect(m_diskSpaceUsageMenu,
+ &DiskSpaceUsageMenu::showMessage,
+ viewContainer,
+ [viewContainer](const QString &message, KMessageWidget::MessageType messageType) {
+ viewContainer->showMessage(message, messageType);
+ });
+ connect(m_diskSpaceUsageMenu, &DiskSpaceUsageMenu::showInstallationProgress, viewContainer, &DolphinViewContainer::showProgress);
const QUrl url = viewContainer->url();
Q_EMIT urlChanged(url);
}
}
-void DolphinMainWindow::slotStorageTearDownFromPlacesRequested(const QString& mountPath)
+void DolphinMainWindow::slotStorageTearDownFromPlacesRequested(const QString &mountPath)
{
connect(m_placesPanel, &PlacesPanel::storageTearDownSuccessful, this, [this, mountPath]() {
setViewsToHomeIfMountPathOpen(mountPath);
});
- if (m_terminalPanel && m_terminalPanel->currentWorkingDirectory().startsWith(mountPath)) {
+ if (m_terminalPanel && m_terminalPanel->currentWorkingDirectoryIsChildOf(mountPath)) {
m_tearDownFromPlacesRequested = true;
m_terminalPanel->goHome();
// m_placesPanel->proceedWithTearDown() will be called in slotTerminalDirectoryChanged
}
}
-void DolphinMainWindow::slotStorageTearDownExternallyRequested(const QString& mountPath)
+void DolphinMainWindow::slotStorageTearDownExternallyRequested(const QString &mountPath)
{
connect(m_placesPanel, &PlacesPanel::storageTearDownSuccessful, this, [this, mountPath]() {
setViewsToHomeIfMountPathOpen(mountPath);
});
- if (m_terminalPanel && m_terminalPanel->currentWorkingDirectory().startsWith(mountPath)) {
+ if (m_terminalPanel && m_terminalPanel->currentWorkingDirectoryIsChildOf(mountPath)) {
m_tearDownFromPlacesRequested = false;
m_terminalPanel->goHome();
}
dialog.configure();
}
-void DolphinMainWindow::setViewsToHomeIfMountPathOpen(const QString& mountPath)
+void DolphinMainWindow::setViewsToHomeIfMountPathOpen(const QString &mountPath)
{
- const QVector<DolphinViewContainer*> theViewContainers = viewContainers();
+ const QVector<DolphinViewContainer *> theViewContainers = viewContainers();
for (DolphinViewContainer *viewContainer : theViewContainers) {
if (viewContainer && viewContainer->url().toLocalFile().startsWith(mountPath)) {
viewContainer->setUrl(QUrl::fromLocalFile(QDir::homePath()));
auto hamburgerMenuAction = KStandardAction::hamburgerMenu(nullptr, nullptr, actionCollection());
// setup 'File' menu
- m_newFileMenu = new DolphinNewFileMenu(actionCollection(), this);
- QMenu* menu = m_newFileMenu->menu();
+ m_newFileMenu = new DolphinNewFileMenu(nullptr, nullptr, this);
+ actionCollection()->addAction(QStringLiteral("new_menu"), m_newFileMenu);
+ QMenu *menu = m_newFileMenu->menu();
menu->setTitle(i18nc("@title:menu Create new folder, file, link, etc.", "Create New"));
menu->setIcon(QIcon::fromTheme(QStringLiteral("list-add")));
m_newFileMenu->setPopupMode(QToolButton::InstantPopup);
- connect(menu, &QMenu::aboutToShow,
- this, &DolphinMainWindow::updateNewMenu);
+ connect(menu, &QMenu::aboutToShow, this, &DolphinMainWindow::updateNewMenu);
- QAction* newWindow = KStandardAction::openNew(this, &DolphinMainWindow::openNewMainWindow, actionCollection());
+ QAction *newWindow = KStandardAction::openNew(this, &DolphinMainWindow::openNewMainWindow, actionCollection());
newWindow->setText(i18nc("@action:inmenu File", "New &Window"));
newWindow->setToolTip(i18nc("@info", "Open a new Dolphin window"));
- newWindow->setWhatsThis(xi18nc("@info:whatsthis", "This opens a new "
- "window just like this one with the current location and view."
- "<nl/>You can drag and drop items between windows."));
+ newWindow->setWhatsThis(xi18nc("@info:whatsthis",
+ "This opens a new "
+ "window just like this one with the current location."
+ "<nl/>You can drag and drop items between windows."));
newWindow->setIcon(QIcon::fromTheme(QStringLiteral("window-new")));
- QAction* newTab = actionCollection()->addAction(QStringLiteral("new_tab"));
+ QAction *newTab = actionCollection()->addAction(QStringLiteral("new_tab"));
newTab->setIcon(QIcon::fromTheme(QStringLiteral("tab-new")));
newTab->setText(i18nc("@action:inmenu File", "New Tab"));
- newTab->setWhatsThis(xi18nc("@info:whatsthis", "This opens a new "
- "<emphasis>Tab</emphasis> with the current location and view.<nl/>"
- "A tab is an additional view within this window. "
- "You can drag and drop items between tabs."));
- actionCollection()->setDefaultShortcuts(newTab, {Qt::CTRL | Qt::Key_T, Qt::CTRL | Qt::SHIFT | Qt::Key_N});
+ newTab->setWhatsThis(xi18nc("@info:whatsthis",
+ "This opens a new "
+ "<emphasis>Tab</emphasis> with the current location."
+ "<nl/>Tabs allow you to quickly switch between multiple locations and views within this window. "
+ "You can drag and drop items between tabs."));
+ actionCollection()->setDefaultShortcut(newTab, Qt::CTRL | Qt::Key_T);
connect(newTab, &QAction::triggered, this, &DolphinMainWindow::openNewActivatedTab);
- QAction* addToPlaces = actionCollection()->addAction(QStringLiteral("add_to_places"));
+ QAction *addToPlaces = actionCollection()->addAction(QStringLiteral("add_to_places"));
addToPlaces->setIcon(QIcon::fromTheme(QStringLiteral("bookmark-new")));
addToPlaces->setText(i18nc("@action:inmenu Add current folder to places", "Add to Places"));
- addToPlaces->setWhatsThis(xi18nc("@info:whatsthis", "This adds the selected folder "
- "to the Places panel."));
+ addToPlaces->setWhatsThis(xi18nc("@info:whatsthis",
+ "This adds the selected folder "
+ "to the Places panel."));
connect(addToPlaces, &QAction::triggered, this, &DolphinMainWindow::addToPlaces);
- QAction* closeTab = KStandardAction::close(m_tabWidget, QOverload<>::of(&DolphinTabWidget::closeTab), actionCollection());
+ QAction *closeTab = KStandardAction::close(m_tabWidget, QOverload<>::of(&DolphinTabWidget::closeTab), actionCollection());
closeTab->setText(i18nc("@action:inmenu File", "Close Tab"));
- closeTab->setWhatsThis(i18nc("@info:whatsthis", "This closes the "
- "currently viewed tab. If no more tabs are left this window "
- "will close instead."));
+ closeTab->setToolTip(i18nc("@info", "Close Tab"));
+ closeTab->setWhatsThis(i18nc("@info:whatsthis",
+ "This closes the "
+ "currently viewed tab. If no more tabs are left, this closes "
+ "the whole window instead."));
- QAction* quitAction = KStandardAction::quit(this, &DolphinMainWindow::quit, actionCollection());
+ QAction *quitAction = KStandardAction::quit(this, &DolphinMainWindow::quit, actionCollection());
quitAction->setWhatsThis(i18nc("@info:whatsthis quit", "This closes this window."));
// setup 'Edit' menu
- KStandardAction::undo(this,
- &DolphinMainWindow::undo,
- actionCollection());
+ KStandardAction::undo(this, &DolphinMainWindow::undo, actionCollection());
// i18n: This will be the last paragraph for the whatsthis for all three:
// Cut, Copy and Paste
- const QString cutCopyPastePara = xi18nc("@info:whatsthis", "<para><emphasis>Cut, "
- "Copy</emphasis> and <emphasis>Paste</emphasis> work between many "
- "applications and are among the most used commands. That's why their "
- "<emphasis>keyboard shortcuts</emphasis> are prominently placed right "
- "next to each other on the keyboard: <shortcut>Ctrl+X</shortcut>, "
- "<shortcut>Ctrl+C</shortcut> and <shortcut>Ctrl+V</shortcut>.</para>");
- QAction* cutAction = KStandardAction::cut(this, &DolphinMainWindow::cut, actionCollection());
+ const QString cutCopyPastePara = xi18nc("@info:whatsthis",
+ "<para><emphasis>Cut, "
+ "Copy</emphasis> and <emphasis>Paste</emphasis> work between many "
+ "applications and are among the most used commands. That's why their "
+ "<emphasis>keyboard shortcuts</emphasis> are prominently placed right "
+ "next to each other on the keyboard: <shortcut>Ctrl+X</shortcut>, "
+ "<shortcut>Ctrl+C</shortcut> and <shortcut>Ctrl+V</shortcut>.</para>");
+ QAction *cutAction = KStandardAction::cut(this, &DolphinMainWindow::cut, actionCollection());
m_actionTextHelper->registerTextWhenNothingIsSelected(cutAction, i18nc("@action", "Cut…"));
- cutAction->setWhatsThis(xi18nc("@info:whatsthis cut", "This copies the items "
- "in your current selection to the <emphasis>clipboard</emphasis>.<nl/>"
- "Use the <emphasis>Paste</emphasis> action afterwards to copy them from "
- "the clipboard to a new location. The items will be removed from their "
- "initial location.") + cutCopyPastePara);
- QAction* copyAction = KStandardAction::copy(this, &DolphinMainWindow::copy, actionCollection());
+ cutAction->setWhatsThis(xi18nc("@info:whatsthis cut",
+ "This copies the items "
+ "in your current selection to the <emphasis>clipboard</emphasis>.<nl/>"
+ "Use the <emphasis>Paste</emphasis> action afterwards to copy them from "
+ "the clipboard to a new location. The items will be removed from their "
+ "initial location.")
+ + cutCopyPastePara);
+ QAction *copyAction = KStandardAction::copy(this, &DolphinMainWindow::copy, actionCollection());
m_actionTextHelper->registerTextWhenNothingIsSelected(copyAction, i18nc("@action", "Copy…"));
- copyAction->setWhatsThis(xi18nc("@info:whatsthis copy", "This copies the "
- "items in your current selection to the <emphasis>clipboard</emphasis>."
- "<nl/>Use the <emphasis>Paste</emphasis> action afterwards to copy them "
- "from the clipboard to a new location.") + cutCopyPastePara);
- QAction* paste = KStandardAction::paste(this, &DolphinMainWindow::paste, actionCollection());
+ copyAction->setWhatsThis(xi18nc("@info:whatsthis copy",
+ "This copies the "
+ "items in your current selection to the <emphasis>clipboard</emphasis>."
+ "<nl/>Use the <emphasis>Paste</emphasis> action afterwards to copy them "
+ "from the clipboard to a new location.")
+ + cutCopyPastePara);
+ QAction *paste = KStandardAction::paste(this, &DolphinMainWindow::paste, actionCollection());
// The text of the paste-action is modified dynamically by Dolphin
// (e. g. to "Paste One Folder"). To prevent that the size of the toolbar changes
// due to the long text, the text "Paste" is used:
paste->setIconText(i18nc("@action:inmenu Edit", "Paste"));
- paste->setWhatsThis(xi18nc("@info:whatsthis paste", "This copies the items from "
- "your <emphasis>clipboard</emphasis> to the currently viewed folder.<nl/>"
- "If the items were added to the clipboard by the <emphasis>Cut</emphasis> "
- "action they are removed from their old location.") + cutCopyPastePara);
-
- QAction* copyToOtherViewAction = actionCollection()->addAction(QStringLiteral("copy_to_inactive_split_view"));
- copyToOtherViewAction->setText(i18nc("@action:inmenu", "Copy to Inactive Split View"));
- m_actionTextHelper->registerTextWhenNothingIsSelected(copyToOtherViewAction, i18nc("@action:inmenu", "Copy to Inactive Split View…"));
- copyToOtherViewAction->setWhatsThis(xi18nc("@info:whatsthis Copy", "This copies the selected items from "
- "the <emphasis>active</emphasis> view to the inactive split view."));
+ paste->setWhatsThis(xi18nc("@info:whatsthis paste",
+ "This copies the items from "
+ "your <emphasis>clipboard</emphasis> to the currently viewed folder.<nl/>"
+ "If the items were added to the clipboard by the <emphasis>Cut</emphasis> "
+ "action they are removed from their old location.")
+ + cutCopyPastePara);
+
+ QAction *copyToOtherViewAction = actionCollection()->addAction(QStringLiteral("copy_to_inactive_split_view"));
+ copyToOtherViewAction->setText(i18nc("@action:inmenu", "Copy to Other View"));
+ m_actionTextHelper->registerTextWhenNothingIsSelected(copyToOtherViewAction, i18nc("@action:inmenu", "Copy to Other View…"));
+ copyToOtherViewAction->setWhatsThis(xi18nc("@info:whatsthis Copy",
+ "This copies the selected items from "
+ "the view in focus to the other view. "
+ "(Only available while in Split View mode.)"));
copyToOtherViewAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-copy")));
- copyToOtherViewAction->setIconText(i18nc("@action:inmenu Edit", "Copy to Inactive Split View"));
- actionCollection()->setDefaultShortcut(copyToOtherViewAction, Qt::SHIFT | Qt::Key_F5 );
+ copyToOtherViewAction->setIconText(i18nc("@action:inmenu Edit", "Copy to Other View"));
+ actionCollection()->setDefaultShortcut(copyToOtherViewAction, Qt::SHIFT | Qt::Key_F5);
connect(copyToOtherViewAction, &QAction::triggered, this, &DolphinMainWindow::copyToInactiveSplitView);
- QAction* moveToOtherViewAction = actionCollection()->addAction(QStringLiteral("move_to_inactive_split_view"));
- moveToOtherViewAction->setText(i18nc("@action:inmenu", "Move to Inactive Split View"));
- m_actionTextHelper->registerTextWhenNothingIsSelected(moveToOtherViewAction, i18nc("@action:inmenu", "Move to Inactive Split View…"));
- moveToOtherViewAction->setWhatsThis(xi18nc("@info:whatsthis Move", "This moves the selected items from "
- "the <emphasis>active</emphasis> view to the inactive split view."));
+ QAction *moveToOtherViewAction = actionCollection()->addAction(QStringLiteral("move_to_inactive_split_view"));
+ moveToOtherViewAction->setText(i18nc("@action:inmenu", "Move to Other View"));
+ m_actionTextHelper->registerTextWhenNothingIsSelected(moveToOtherViewAction, i18nc("@action:inmenu", "Move to Other View…"));
+ moveToOtherViewAction->setWhatsThis(xi18nc("@info:whatsthis Move",
+ "This moves the selected items from "
+ "the view in focus to the other view. "
+ "(Only available while in Split View mode.)"));
moveToOtherViewAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-cut")));
- moveToOtherViewAction->setIconText(i18nc("@action:inmenu Edit", "Move to Inactive Split View"));
- actionCollection()->setDefaultShortcut(moveToOtherViewAction, Qt::SHIFT | Qt::Key_F6 );
+ moveToOtherViewAction->setIconText(i18nc("@action:inmenu Edit", "Move to Other View"));
+ actionCollection()->setDefaultShortcut(moveToOtherViewAction, Qt::SHIFT | Qt::Key_F6);
connect(moveToOtherViewAction, &QAction::triggered, this, &DolphinMainWindow::moveToInactiveSplitView);
- QAction* showFilterBar = actionCollection()->addAction(QStringLiteral("show_filter_bar"));
- showFilterBar->setText(i18nc("@action:inmenu Tools", "Filter..."));
+ QAction *showFilterBar = actionCollection()->addAction(QStringLiteral("show_filter_bar"));
+ showFilterBar->setText(i18nc("@action:inmenu Tools", "Filter…"));
showFilterBar->setToolTip(i18nc("@info:tooltip", "Show Filter Bar"));
- showFilterBar->setWhatsThis(xi18nc("@info:whatsthis", "This opens the "
- "<emphasis>Filter Bar</emphasis> at the bottom of the window.<nl/> "
- "There you can enter a text to filter the files and folders currently displayed. "
- "Only those that contain the text in their name will be kept in view."));
+ showFilterBar->setWhatsThis(xi18nc("@info:whatsthis",
+ "This opens the "
+ "<emphasis>Filter Bar</emphasis> at the bottom of the window.<nl/> "
+ "There you can enter text to filter the files and folders currently displayed. "
+ "Only those that contain the text in their name will be kept in view."));
showFilterBar->setIcon(QIcon::fromTheme(QStringLiteral("view-filter")));
actionCollection()->setDefaultShortcuts(showFilterBar, {Qt::CTRL | Qt::Key_I, Qt::Key_Slash});
connect(showFilterBar, &QAction::triggered, this, &DolphinMainWindow::showFilterBar);
connect(toggleFilter, &QAction::triggered, this, &DolphinMainWindow::toggleFilterBar);
QAction *searchAction = KStandardAction::find(this, &DolphinMainWindow::find, actionCollection());
- searchAction->setText(i18n("Search..."));
+ searchAction->setText(i18n("Search…"));
searchAction->setToolTip(i18nc("@info:tooltip", "Search for files and folders"));
- searchAction->setWhatsThis(xi18nc("@info:whatsthis find", "<para>This helps you "
- "find files and folders by opening a <emphasis>find bar</emphasis>. "
- "There you can enter search terms and specify settings to find the "
- "objects you are looking for.</para><para>Use this help again on "
- "the find bar so we can have a look at it while the settings are "
- "explained.</para>"));
+ searchAction->setWhatsThis(xi18nc("@info:whatsthis find",
+ "<para>This helps you "
+ "find files and folders by opening a <emphasis>search bar</emphasis>. "
+ "There you can enter search terms and specify settings to find the "
+ "items you are looking for.</para>"));
// toggle_search acts as a copy of the main searchAction to be used mainly
// in the toolbar, with no default shortcut attached, to avoid messing with
toggleSearchAction->setToolTip(searchAction->toolTip());
toggleSearchAction->setWhatsThis(searchAction->whatsThis());
toggleSearchAction->setCheckable(true);
+ connect(toggleSearchAction, &QAction::triggered, this, [this](bool checked) {
+ if (checked) {
+ find();
+ } else {
+ m_activeViewContainer->setSearchBarVisible(false);
+ }
+ });
QAction *toggleSelectionModeAction = actionCollection()->addAction(QStringLiteral("toggle_selection_mode"));
// i18n: This action toggles a selection mode.
// i18n: Opens a selection mode for selecting files/folders.
// The text is kept so unspecific because it will be shown on the toolbar where space is at a premium.
toggleSelectionModeAction->setIconText(i18nc("@action:intoolbar", "Select"));
- toggleSelectionModeAction->setWhatsThis(xi18nc("@info:whatsthis", "<para>This application only knows which files or folders should be acted on if they are"
+ toggleSelectionModeAction->setWhatsThis(xi18nc(
+ "@info:whatsthis",
+ "<para>This application only knows which files or folders should be acted on if they are"
" <emphasis>selected</emphasis> first. Press this to toggle a <emphasis>Selection Mode</emphasis> which makes selecting and deselecting as easy as "
"pressing an item once.</para><para>While in this mode, a quick access bar at the bottom shows available actions for the currently selected items."
"</para>"));
toggleSelectionModeAction->setIcon(QIcon::fromTheme(QStringLiteral("quickwizard")));
toggleSelectionModeAction->setCheckable(true);
+ actionCollection()->setDefaultShortcut(toggleSelectionModeAction, Qt::Key_Space);
connect(toggleSelectionModeAction, &QAction::triggered, this, &DolphinMainWindow::toggleSelectionMode);
// A special version of the toggleSelectionModeAction for the toolbar that also contains a menu
// with the selectAllAction and invertSelectionAction.
- auto *toggleSelectionModeToolBarAction = new KToolBarPopupAction(toggleSelectionModeAction->icon(), toggleSelectionModeAction->iconText(), actionCollection());
+ auto *toggleSelectionModeToolBarAction =
+ new KToolBarPopupAction(toggleSelectionModeAction->icon(), toggleSelectionModeAction->iconText(), actionCollection());
toggleSelectionModeToolBarAction->setToolTip(toggleSelectionModeAction->text());
toggleSelectionModeToolBarAction->setWhatsThis(toggleSelectionModeAction->whatsThis());
actionCollection()->addAction(QStringLiteral("toggle_selection_mode_tool_bar"), toggleSelectionModeToolBarAction);
toggleSelectionModeToolBarAction->setCheckable(true);
- toggleSelectionModeToolBarAction->setPopupMode(QToolButton::DelayedPopup);
+ toggleSelectionModeToolBarAction->setPopupMode(KToolBarPopupAction::DelayedPopup);
connect(toggleSelectionModeToolBarAction, &QAction::triggered, toggleSelectionModeAction, &QAction::trigger);
connect(toggleSelectionModeAction, &QAction::toggled, toggleSelectionModeToolBarAction, &QAction::setChecked);
- QAction* selectAllAction = KStandardAction::selectAll(this, &DolphinMainWindow::selectAll, actionCollection());
- selectAllAction->setWhatsThis(xi18nc("@info:whatsthis", "This selects all "
- "files and folders in the current location."));
+ QAction *selectAllAction = KStandardAction::selectAll(this, &DolphinMainWindow::selectAll, actionCollection());
+ selectAllAction->setWhatsThis(xi18nc("@info:whatsthis",
+ "This selects all "
+ "files and folders in the current location."));
- QAction* invertSelection = actionCollection()->addAction(QStringLiteral("invert_selection"));
+ QAction *invertSelection = actionCollection()->addAction(QStringLiteral("invert_selection"));
invertSelection->setText(i18nc("@action:inmenu Edit", "Invert Selection"));
- invertSelection->setWhatsThis(xi18nc("@info:whatsthis invert", "This selects all "
- "objects that you have currently <emphasis>not</emphasis> selected instead."));
+ invertSelection->setWhatsThis(xi18nc("@info:whatsthis invert",
+ "This selects all "
+ "items that you have currently <emphasis>not</emphasis> selected instead."));
invertSelection->setIcon(QIcon::fromTheme(QStringLiteral("edit-select-invert")));
actionCollection()->setDefaultShortcut(invertSelection, Qt::CTRL | Qt::SHIFT | Qt::Key_A);
connect(invertSelection, &QAction::triggered, this, &DolphinMainWindow::invertSelection);
// setup 'View' menu
// (note that most of it is set up in DolphinViewActionHandler)
- QAction* split = actionCollection()->addAction(QStringLiteral("split_view"));
- split->setWhatsThis(xi18nc("@info:whatsthis find", "<para>This splits "
- "the folder view below into two autonomous views.</para><para>This "
- "way you can see two locations at once and move items between them "
- "quickly.</para>Click this again afterwards to recombine the views."));
- actionCollection()->setDefaultShortcut(split, Qt::Key_F3);
- connect(split, &QAction::triggered, this, &DolphinMainWindow::toggleSplitView);
+ Admin::WorkerIntegration::createActAsAdminAction(actionCollection(), this);
+
+ m_splitViewAction = actionCollection()->add<KActionMenu>(QStringLiteral("split_view"));
+ m_splitViewMenuAction = actionCollection()->addAction(QStringLiteral("split_view_menu"));
+
+ m_splitViewAction->setWhatsThis(xi18nc("@info:whatsthis split",
+ "<para>This presents "
+ "a second view side-by-side with the current view, so you can see "
+ "the contents of two folders at once and easily move items between "
+ "them.</para><para>The view that is not \"in focus\" will be dimmed. "
+ "</para>Click this button again to close one of the views."));
+ m_splitViewMenuAction->setWhatsThis(m_splitViewAction->whatsThis());
+
+ // only set it for the menu version
+ actionCollection()->setDefaultShortcut(m_splitViewMenuAction, Qt::Key_F3);
+
+ connect(m_splitViewAction, &QAction::triggered, this, &DolphinMainWindow::toggleSplitView);
+ connect(m_splitViewMenuAction, &QAction::triggered, this, &DolphinMainWindow::toggleSplitView);
- QAction* stashSplit = actionCollection()->addAction(QStringLiteral("split_stash"));
+ QAction *popoutSplit = actionCollection()->addAction(QStringLiteral("popout_split_view"));
+ popoutSplit->setWhatsThis(xi18nc("@info:whatsthis",
+ "If the view has been split, this will pop the view in focus "
+ "out into a new window."));
+ popoutSplit->setIcon(QIcon::fromTheme(QStringLiteral("window-new")));
+ actionCollection()->setDefaultShortcut(popoutSplit, Qt::SHIFT | Qt::Key_F3);
+ connect(popoutSplit, &QAction::triggered, this, &DolphinMainWindow::popoutSplitView);
+
+ QAction *stashSplit = actionCollection()->addAction(QStringLiteral("split_stash"));
actionCollection()->setDefaultShortcut(stashSplit, Qt::CTRL | Qt::Key_S);
stashSplit->setText(i18nc("@action:intoolbar Stash", "Stash"));
stashSplit->setToolTip(i18nc("@info", "Opens the stash virtual directory in a split window"));
stashSplit->setVisible(sessionInterface && sessionInterface->isServiceRegistered(QStringLiteral("org.kde.kio.StashNotifier")));
connect(stashSplit, &QAction::triggered, this, &DolphinMainWindow::toggleSplitStash);
- KStandardAction::redisplay(this, &DolphinMainWindow::reloadView, actionCollection());
+ QAction *redisplay = KStandardAction::redisplay(this, &DolphinMainWindow::reloadView, actionCollection());
+ redisplay->setToolTip(i18nc("@info:tooltip", "Refresh view"));
+ redisplay->setWhatsThis(xi18nc("@info:whatsthis refresh",
+ "<para>This refreshes "
+ "the folder view.</para>"
+ "<para>If the contents of this folder have changed, refreshing will re-scan this folder "
+ "and show you a newly-updated view of the files and folders contained here.</para>"
+ "<para>If the view is split, this refreshes the one that is currently in focus.</para>"));
- QAction* stop = actionCollection()->addAction(QStringLiteral("stop"));
+ QAction *stop = actionCollection()->addAction(QStringLiteral("stop"));
stop->setText(i18nc("@action:inmenu View", "Stop"));
stop->setToolTip(i18nc("@info", "Stop loading"));
stop->setWhatsThis(i18nc("@info", "This stops the loading of the contents of the current folder."));
stop->setIcon(QIcon::fromTheme(QStringLiteral("process-stop")));
connect(stop, &QAction::triggered, this, &DolphinMainWindow::stopLoading);
- KToggleAction* editableLocation = actionCollection()->add<KToggleAction>(QStringLiteral("editable_location"));
+ KToggleAction *editableLocation = actionCollection()->add<KToggleAction>(QStringLiteral("editable_location"));
editableLocation->setText(i18nc("@action:inmenu Navigation Bar", "Editable Location"));
editableLocation->setWhatsThis(xi18nc("@info:whatsthis",
- "This toggles the <emphasis>Location Bar</emphasis> to be "
- "editable so you can directly enter a location you want to go to.<nl/>"
- "You can also switch to editing by clicking to the right of the "
- "location and switch back by confirming the edited location."));
+ "This toggles the <emphasis>Location Bar</emphasis> to be "
+ "editable so you can directly enter a location you want to go to.<nl/>"
+ "You can also switch to editing by clicking to the right of the "
+ "location and switch back by confirming the edited location."));
actionCollection()->setDefaultShortcut(editableLocation, Qt::Key_F6);
connect(editableLocation, &KToggleAction::triggered, this, &DolphinMainWindow::toggleEditLocation);
- QAction* replaceLocation = actionCollection()->addAction(QStringLiteral("replace_location"));
+ QAction *replaceLocation = actionCollection()->addAction(QStringLiteral("replace_location"));
replaceLocation->setText(i18nc("@action:inmenu Navigation Bar", "Replace Location"));
// i18n: "enter" is used both in the meaning of "writing" and "going to" a new location here.
// Both meanings are useful but not necessary to understand the use of "Replace Location".
// So you might want to be more verbose in your language to convey the meaning but it's up to you.
replaceLocation->setWhatsThis(xi18nc("@info:whatsthis",
- "This switches to editing the location and selects it "
- "so you can quickly enter a different location."));
- actionCollection()->setDefaultShortcut(replaceLocation, Qt::CTRL | Qt::Key_L);
+ "This switches to editing the location and selects it "
+ "so you can quickly enter a different location."));
+ actionCollection()->setDefaultShortcuts(replaceLocation, {Qt::CTRL | Qt::Key_L, Qt::ALT | Qt::Key_D});
connect(replaceLocation, &QAction::triggered, this, &DolphinMainWindow::replaceLocation);
// setup 'Go' menu
m_backAction->setObjectName(backAction->objectName());
m_backAction->setShortcuts(backAction->shortcuts());
}
- m_backAction->setPopupMode(QToolButton::DelayedPopup);
+ m_backAction->setPopupMode(KToolBarPopupAction::DelayedPopup);
connect(m_backAction, &QAction::triggered, this, &DolphinMainWindow::goBack);
- connect(m_backAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowBackPopupMenu);
- connect(m_backAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoBack);
+ connect(m_backAction->popupMenu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowBackPopupMenu);
+ connect(m_backAction->popupMenu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoBack);
actionCollection()->addAction(m_backAction->objectName(), m_backAction);
auto backShortcuts = m_backAction->shortcuts();
- backShortcuts.append(QKeySequence(Qt::Key_Backspace));
+ // Prepend this shortcut, to avoid being hidden by the two-slot UI (#371130)
+ backShortcuts.prepend(QKeySequence(Qt::Key_Backspace));
actionCollection()->setDefaultShortcuts(m_backAction, backShortcuts);
- DolphinRecentTabsMenu* recentTabsMenu = new DolphinRecentTabsMenu(this);
+ DolphinRecentTabsMenu *recentTabsMenu = new DolphinRecentTabsMenu(this);
actionCollection()->addAction(QStringLiteral("closed_tabs"), recentTabsMenu);
- connect(m_tabWidget, &DolphinTabWidget::rememberClosedTab,
- recentTabsMenu, &DolphinRecentTabsMenu::rememberClosedTab);
- connect(recentTabsMenu, &DolphinRecentTabsMenu::restoreClosedTab,
- m_tabWidget, &DolphinTabWidget::restoreClosedTab);
- connect(recentTabsMenu, &DolphinRecentTabsMenu::closedTabsCountChanged,
- this, &DolphinMainWindow::closedTabsCountChanged);
-
- QAction* undoCloseTab = actionCollection()->addAction(QStringLiteral("undo_close_tab"));
+ connect(m_tabWidget, &DolphinTabWidget::rememberClosedTab, recentTabsMenu, &DolphinRecentTabsMenu::rememberClosedTab);
+ connect(recentTabsMenu, &DolphinRecentTabsMenu::restoreClosedTab, m_tabWidget, &DolphinTabWidget::restoreClosedTab);
+ connect(recentTabsMenu, &DolphinRecentTabsMenu::closedTabsCountChanged, this, &DolphinMainWindow::closedTabsCountChanged);
+
+ QAction *undoCloseTab = actionCollection()->addAction(QStringLiteral("undo_close_tab"));
undoCloseTab->setText(i18nc("@action:inmenu File", "Undo close tab"));
- undoCloseTab->setWhatsThis(i18nc("@info:whatsthis undo close tab",
- "This returns you to the previously closed tab."));
+ undoCloseTab->setWhatsThis(i18nc("@info:whatsthis undo close tab", "This returns you to the previously closed tab."));
actionCollection()->setDefaultShortcut(undoCloseTab, Qt::CTRL | Qt::SHIFT | Qt::Key_T);
undoCloseTab->setIcon(QIcon::fromTheme(QStringLiteral("edit-undo")));
undoCloseTab->setEnabled(false);
connect(undoCloseTab, &QAction::triggered, recentTabsMenu, &DolphinRecentTabsMenu::undoCloseTab);
auto undoAction = actionCollection()->action(KStandardAction::name(KStandardAction::Undo));
- undoAction->setWhatsThis(xi18nc("@info:whatsthis", "This undoes "
- "the last change you made to files or folders.<nl/>"
- "Such changes include <interface>creating, renaming</interface> "
- "and <interface>moving</interface> them to a different location "
- "or to the <filename>Trash</filename>. <nl/>Changes that can't "
- "be undone will ask for your confirmation."));
+ undoAction->setWhatsThis(xi18nc("@info:whatsthis",
+ "This undoes "
+ "the last change you made to files or folders.<nl/>"
+ "Such changes include <interface>creating</interface>, <interface>renaming</interface> "
+ "and <interface>moving</interface> them to a different location "
+ "or to the <filename>Trash</filename>. <nl/>Any changes that cannot be undone "
+ "will ask for your confirmation beforehand."));
undoAction->setEnabled(false); // undo should be disabled by default
{
m_forwardAction->setObjectName(forwardAction->objectName());
m_forwardAction->setShortcuts(forwardAction->shortcuts());
}
- m_forwardAction->setPopupMode(QToolButton::DelayedPopup);
+ m_forwardAction->setPopupMode(KToolBarPopupAction::DelayedPopup);
connect(m_forwardAction, &QAction::triggered, this, &DolphinMainWindow::goForward);
- connect(m_forwardAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowForwardPopupMenu);
- connect(m_forwardAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoForward);
+ connect(m_forwardAction->popupMenu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowForwardPopupMenu);
+ connect(m_forwardAction->popupMenu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoForward);
actionCollection()->addAction(m_forwardAction->objectName(), m_forwardAction);
actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts());
// enable middle-click to open in a new tab
auto *middleClickEventFilter = new MiddleClickActionEventFilter(this);
connect(middleClickEventFilter, &MiddleClickActionEventFilter::actionMiddleClicked, this, &DolphinMainWindow::slotBackForwardActionMiddleClicked);
- m_backAction->menu()->installEventFilter(middleClickEventFilter);
- m_forwardAction->menu()->installEventFilter(middleClickEventFilter);
+ m_backAction->popupMenu()->installEventFilter(middleClickEventFilter);
+ m_forwardAction->popupMenu()->installEventFilter(middleClickEventFilter);
KStandardAction::up(this, &DolphinMainWindow::goUp, actionCollection());
- QAction* homeAction = KStandardAction::home(this, &DolphinMainWindow::goHome, actionCollection());
- homeAction->setWhatsThis(xi18nc("@info:whatsthis", "Go to your "
- "<filename>Home</filename> folder.<nl/>Every user account "
- "has their own <filename>Home</filename> that contains their data "
- "including folders that contain personal application data."));
+ QAction *homeAction = KStandardAction::home(this, &DolphinMainWindow::goHome, actionCollection());
+ homeAction->setWhatsThis(xi18nc("@info:whatsthis",
+ "Go to your "
+ "<filename>Home</filename> folder.<nl/>Every user account "
+ "has their own <filename>Home</filename> that contains their personal files, "
+ "as well as hidden folders for their applications' data and configuration files."));
// setup 'Tools' menu
- QAction* compareFiles = actionCollection()->addAction(QStringLiteral("compare_files"));
+ QAction *compareFiles = actionCollection()->addAction(QStringLiteral("compare_files"));
compareFiles->setText(i18nc("@action:inmenu Tools", "Compare Files"));
compareFiles->setIcon(QIcon::fromTheme(QStringLiteral("kompare")));
compareFiles->setEnabled(false);
connect(compareFiles, &QAction::triggered, this, &DolphinMainWindow::compareFiles);
- QAction* openPreferredSearchTool = actionCollection()->addAction(QStringLiteral("open_preferred_search_tool"));
+ QAction *manageDiskSpaceUsage = actionCollection()->addAction(QStringLiteral("manage_disk_space"));
+ manageDiskSpaceUsage->setText(i18nc("@action:inmenu Tools", "Manage Disk Space Usage"));
+ manageDiskSpaceUsage->setIcon(QIcon::fromTheme(QStringLiteral("filelight")));
+ m_diskSpaceUsageMenu = new DiskSpaceUsageMenu{this};
+ manageDiskSpaceUsage->setMenu(m_diskSpaceUsageMenu);
+
+ QAction *openPreferredSearchTool = actionCollection()->addAction(QStringLiteral("open_preferred_search_tool"));
openPreferredSearchTool->setText(i18nc("@action:inmenu Tools", "Open Preferred Search Tool"));
openPreferredSearchTool->setWhatsThis(xi18nc("@info:whatsthis",
- "<para>This opens a preferred search tool for the viewed location.</para>"
- "<para>Use <emphasis>More Search Tools</emphasis> menu to configure it.</para>"));
+
"<para>This opens a preferred search tool for the viewed location.</para>"
+
"<para>Use <emphasis>More Search Tools</emphasis> menu to configure it.</para>"));
openPreferredSearchTool->setIcon(QIcon::fromTheme(QStringLiteral("search")));
actionCollection()->setDefaultShortcut(openPreferredSearchTool, Qt::CTRL | Qt::SHIFT | Qt::Key_F);
connect(openPreferredSearchTool, &QAction::triggered, this, &DolphinMainWindow::openPreferredSearchTool);
if (KAuthorized::authorize(QStringLiteral("shell_access"))) {
- QAction* openTerminal = actionCollection()->addAction(QStringLiteral("open_terminal"));
+ // Get icon of user default terminal emulator application
+ const KConfigGroup group(KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::SimpleConfig), QStringLiteral("General"));
+ const QString terminalDesktopFilename = group.readEntry("TerminalService");
+ // Use utilities-terminal icon from theme if readEntry() has failed
+ const QString terminalIcon = terminalDesktopFilename.isEmpty() ? "utilities-terminal" : KDesktopFile(terminalDesktopFilename).readIcon();
+
+ QAction *openTerminal = actionCollection()->addAction(QStringLiteral("open_terminal"));
openTerminal->setText(i18nc("@action:inmenu Tools", "Open Terminal"));
openTerminal->setWhatsThis(xi18nc("@info:whatsthis",
- "<para>This opens a <emphasis>terminal</emphasis> application for the viewed location.</para>"
- "<para>To learn more about terminals use the help in the terminal application.</para>"));
- openTerminal->setIcon(QIcon::fromTheme(QStringLiteral("utilities-terminal")));
+
"<para>This opens a <emphasis>terminal</emphasis> application for the viewed location.</para>"
+ "<para>To learn more about terminals use the help features in the terminal application.</para>"));
+ openTerminal->setIcon(QIcon::fromTheme(terminalIcon));
actionCollection()->setDefaultShortcut(openTerminal, Qt::SHIFT | Qt::Key_F4);
connect(openTerminal, &QAction::triggered, this, &DolphinMainWindow::openTerminal);
- QAction* openTerminalHere = actionCollection()->addAction(QStringLiteral("open_terminal_here"));
+ QAction *openTerminalHere = actionCollection()->addAction(QStringLiteral("open_terminal_here"));
// i18n: "Here" refers to the location(s) of the currently selected item(s) or the currently viewed location if nothing is selected.
openTerminalHere->setText(i18nc("@action:inmenu Tools", "Open Terminal Here"));
openTerminalHere->setWhatsThis(xi18nc("@info:whatsthis",
- "<para>This opens <emphasis>terminal</emphasis> applications for the selected items' locations.</para>"
- "<para>To learn more about terminals use the help in the terminal application.</para>"));
- openTerminalHere->setIcon(QIcon::fromTheme(QStringLiteral("utilities-terminal")));
+
"<para>This opens <emphasis>terminal</emphasis> applications for the selected items' locations.</para>"
+ "<para>To learn more about terminals use the help features in the terminal application.</para>"));
+ openTerminalHere->setIcon(QIcon::fromTheme(terminalIcon));
actionCollection()->setDefaultShortcut(openTerminalHere, Qt::SHIFT | Qt::ALT | Qt::Key_F4);
connect(openTerminalHere, &QAction::triggered, this, &DolphinMainWindow::openTerminalHere);
-
-#if HAVE_TERMINAL
- QAction* focusTerminalPanel = actionCollection()->addAction(QStringLiteral("focus_terminal_panel"));
- focusTerminalPanel->setText(i18nc("@action:inmenu Tools", "Focus Terminal Panel"));
- focusTerminalPanel->setIcon(QIcon::fromTheme(QStringLiteral("swap-panels")));
- actionCollection()->setDefaultShortcut(focusTerminalPanel, Qt::CTRL | Qt::SHIFT | Qt::Key_F4);
- connect(focusTerminalPanel, &QAction::triggered, this, &DolphinMainWindow::focusTerminalPanel);
-#endif
}
// setup 'Bookmarks' menu
actionCollection()->addAction(QStringLiteral("bookmarks"), bookmarkMenu);
// setup 'Settings' menu
- KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection());
+ KToggleAction *showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection());
showMenuBar->setWhatsThis(xi18nc("@info:whatsthis",
- "<para>This switches between having a <emphasis>Menubar</emphasis> "
- "and having a <interface>%1</interface> button. Both "
- "contain mostly the same actions and configuration options.</para>"
- "<para>The Menubar takes up more space but allows for fast and organised access to all "
- "actions an application has to offer.</para><para>The <interface>%1</interface> button "
- "is simpler and small which makes triggering advanced actions more time consuming.</para>", hamburgerMenuAction->text().replace('&', "")));
- connect(showMenuBar, &KToggleAction::triggered, // Fixes #286822
- this, &DolphinMainWindow::toggleShowMenuBar, Qt::QueuedConnection);
-
- KToggleAction* showStatusBar = KStandardAction::showStatusbar(nullptr, nullptr, actionCollection());
- showStatusBar->setChecked(GeneralSettings::showStatusBar());
- connect(GeneralSettings::self(), &GeneralSettings::showStatusBarChanged, showStatusBar, &KToggleAction::setChecked);
- connect(showStatusBar, &KToggleAction::triggered, this, [this](bool checked) {
- GeneralSettings::setShowStatusBar(checked);
- refreshViews();
- });
+ "<para>This switches between having a <emphasis>Menubar</emphasis> "
+ "and having an <interface>%1</interface> button. Both "
+ "contain mostly the same actions and configuration options.</para>"
+ "<para>The Menubar takes up more space but allows for fast and organized access to all "
+ "actions an application has to offer.</para><para>The %1 button "
+ "is simpler and small which makes triggering advanced actions more time consuming.</para>",
+ hamburgerMenuAction->text().replace('&', "")));
+ connect(showMenuBar,
+ &KToggleAction::triggered, // Fixes #286822
+ this,
+ &DolphinMainWindow::toggleShowMenuBar,
+ Qt::QueuedConnection);
KStandardAction::keyBindings(this, &DolphinMainWindow::slotKeyBindings, actionCollection());
KStandardAction::preferences(this, &DolphinMainWindow::editSettings, actionCollection());
prevTabKeys.append(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_Tab));
for (int i = 0; i < MaxActivateTabShortcuts; ++i) {
- QAction* activateTab = actionCollection()->addAction(QStringLiteral("activate_tab_%1").arg(i));
- activateTab->setText(i18nc("@action:inmenu", "Activate Tab %1", i + 1));
+ QAction *activateTab = actionCollection()->addAction(QStringLiteral("activate_tab_%1").arg(i));
+ activateTab->setText(i18nc("@action:inmenu", "Go to Tab %1", i + 1));
activateTab->setEnabled(false);
- connect(activateTab, &QAction::triggered, this, [this, i]() { m_tabWidget->activateTab(i); });
+ connect(activateTab, &QAction::triggered, this, [this, i]() {
+ m_tabWidget->activateTab(i);
+ });
// only add default shortcuts for the first 9 tabs regardless of MaxActivateTabShortcuts
if (i < 9) {
}
}
- QAction* activateLastTab = actionCollection()->addAction(QStringLiteral("activate_last_tab"));
- activateLastTab->setText(i18nc("@action:inmenu", "Activate Last Tab"));
+ QAction *activateLastTab = actionCollection()->addAction(QStringLiteral("activate_last_tab"));
+ activateLastTab->setIconText(i18nc("@action:inmenu", "Last Tab"));
+ activateLastTab->setText(i18nc("@action:inmenu", "Go to Last Tab"));
activateLastTab->setEnabled(false);
connect(activateLastTab, &QAction::triggered, m_tabWidget, &DolphinTabWidget::activateLastTab);
actionCollection()->setDefaultShortcut(activateLastTab, Qt::ALT | Qt::Key_0);
- QAction* activateNextTab = actionCollection()->addAction(QStringLiteral("activate_next_tab"));
+ QAction *activateNextTab = actionCollection()->addAction(QStringLiteral("activate_next_tab"));
activateNextTab->setIconText(i18nc("@action:inmenu", "Next Tab"));
- activateNextTab->setText(i18nc("@action:inmenu", "Activate Next Tab"));
+ activateNextTab->setText(i18nc("@action:inmenu", "Go to Next Tab"));
activateNextTab->setEnabled(false);
connect(activateNextTab, &QAction::triggered, m_tabWidget, &DolphinTabWidget::activateNextTab);
actionCollection()->setDefaultShortcuts(activateNextTab, nextTabKeys);
- QAction* activatePrevTab = actionCollection()->addAction(QStringLiteral("activate_prev_tab"));
+ QAction *activatePrevTab = actionCollection()->addAction(QStringLiteral("activate_prev_tab"));
activatePrevTab->setIconText(i18nc("@action:inmenu", "Previous Tab"));
- activatePrevTab->setText(i18nc("@action:inmenu", "Activate Previous Tab"));
+ activatePrevTab->setText(i18nc("@action:inmenu", "Go to Previous Tab"));
activatePrevTab->setEnabled(false);
connect(activatePrevTab, &QAction::triggered, m_tabWidget, &DolphinTabWidget::activatePrevTab);
actionCollection()->setDefaultShortcuts(activatePrevTab, prevTabKeys);
// for context menu
- QAction* showTarget = actionCollection()->addAction(QStringLiteral("show_target"));
+ QAction *showTarget = actionCollection()->addAction(QStringLiteral("show_target"));
showTarget->setText(i18nc("@action:inmenu", "Show Target"));
showTarget->setIcon(QIcon::fromTheme(QStringLiteral("document-open-folder")));
showTarget->setEnabled(false);
connect(showTarget, &QAction::triggered, this, &DolphinMainWindow::showTarget);
- QAction* openInNewTab = actionCollection()->addAction(QStringLiteral("open_in_new_tab"));
+ QAction *openInNewTab = actionCollection()->addAction(QStringLiteral("open_in_new_tab"));
openInNewTab->setText(i18nc("@action:inmenu", "Open in New Tab"));
openInNewTab->setIcon(QIcon::fromTheme(QStringLiteral("tab-new")));
connect(openInNewTab, &QAction::triggered, this, &DolphinMainWindow::openInNewTab);
- QAction* openInNewTabs = actionCollection()->addAction(QStringLiteral("open_in_new_tabs"));
+ QAction *openInNewTabs = actionCollection()->addAction(QStringLiteral("open_in_new_tabs"));
openInNewTabs->setText(i18nc("@action:inmenu", "Open in New Tabs"));
openInNewTabs->setIcon(QIcon::fromTheme(QStringLiteral("tab-new")));
connect(openInNewTabs, &QAction::triggered, this, &DolphinMainWindow::openInNewTab);
- QAction* openInNewWindow = actionCollection()->addAction(QStringLiteral("open_in_new_window"));
+ QAction *openInNewWindow = actionCollection()->addAction(QStringLiteral("open_in_new_window"));
openInNewWindow->setText(i18nc("@action:inmenu", "Open in New Window"));
openInNewWindow->setIcon(QIcon::fromTheme(QStringLiteral("window-new")));
connect(openInNewWindow, &QAction::triggered, this, &DolphinMainWindow::openInNewWindow);
+
+ QAction *openInSplitViewAction = actionCollection()->addAction(QStringLiteral("open_in_split_view"));
+ openInSplitViewAction->setText(i18nc("@action:inmenu", "Open in Split View"));
+ openInSplitViewAction->setIcon(QIcon::fromTheme(QStringLiteral("view-split-left-right")));
+ connect(openInSplitViewAction, &QAction::triggered, this, [this]() {
+ openInSplitView(QUrl());
+ });
+
+ m_recentFiles = new KRecentFilesAction(this);
}
void DolphinMainWindow::setupDockWidgets()
DolphinPlacesModelSingleton::instance().placesModel()->setPanelsLocked(lock);
- KDualAction* lockLayoutAction = actionCollection()->add<KDualAction>(QStringLiteral("lock_panels"));
+ KDualAction *lockLayoutAction = actionCollection()->add<KDualAction>(QStringLiteral("lock_panels"));
lockLayoutAction->setActiveText(i18nc("@action:inmenu Panels", "Unlock Panels"));
lockLayoutAction->setActiveIcon(QIcon::fromTheme(QStringLiteral("object-unlocked")));
lockLayoutAction->setInactiveText(i18nc("@action:inmenu Panels", "Lock Panels"));
lockLayoutAction->setInactiveIcon(QIcon::fromTheme(QStringLiteral("object-locked")));
- lockLayoutAction->setWhatsThis(xi18nc("@info:whatsthis", "This "
- "switches between having panels <emphasis>locked</emphasis> or "
- "<emphasis>unlocked</emphasis>.<nl/>Unlocked panels can be "
- "dragged to the other side of the window and have a close "
- "button.<nl/>Locked panels are embedded more cleanly."));
+ lockLayoutAction->setWhatsThis(xi18nc("@info:whatsthis",
+ "This "
+ "switches between having panels <emphasis>locked</emphasis> or "
+ "<emphasis>unlocked</emphasis>.<nl/>Unlocked panels can be "
+ "dragged to the other side of the window and have a close "
+ "button.<nl/>Locked panels are embedded more cleanly."));
lockLayoutAction->setActive(lock);
connect(lockLayoutAction, &KDualAction::triggered, this, &DolphinMainWindow::togglePanelLockState);
// Setup "Information"
- DolphinDockWidget* infoDock = new DolphinDockWidget(i18nc("@title:window", "Information"));
+ DolphinDockWidget *infoDock = new DolphinDockWidget(i18nc("@title:window", "Information"));
infoDock->setLocked(lock);
infoDock->setObjectName(QStringLiteral("infoDock"));
infoDock->setAllowedAreas(Qt::LeftDockWidgetArea | Qt::RightDockWidgetArea);
#if HAVE_BALOO
- InformationPanel* infoPanel = new InformationPanel(infoDock);
+ InformationPanel *infoPanel = new InformationPanel(infoDock);
infoPanel->setCustomContextMenuActions({lockLayoutAction});
connect(infoPanel, &InformationPanel::urlActivated, this, &DolphinMainWindow::handleUrl);
infoDock->setWidget(infoPanel);
- QAction* infoAction = infoDock->toggleViewAction();
- createPanelAction(QIcon::fromTheme(QStringLiteral("dialog-information")), Qt::Key_F11, infoAction, QStringLiteral("show_information_panel"));
+ createPanelAction(QIcon::fromTheme(QStringLiteral("documentinfo")), Qt::Key_F11, infoDock, QStringLiteral("show_information_panel"));
addDockWidget(Qt::RightDockWidgetArea, infoDock);
- connect(this, &DolphinMainWindow::urlChanged,
- infoPanel, &InformationPanel::setUrl);
- connect(this, &DolphinMainWindow::selectionChanged,
- infoPanel, &InformationPanel::setSelection);
- connect(this, &DolphinMainWindow::requestItemInfo,
- infoPanel, &InformationPanel::requestDelayedItemInfo);
- connect(this, &DolphinMainWindow::fileItemsChanged,
- infoPanel, &InformationPanel::slotFilesItemChanged);
+ connect(this, &DolphinMainWindow::urlChanged, infoPanel, &InformationPanel::setUrl);
+ connect(this, &DolphinMainWindow::selectionChanged, infoPanel, &InformationPanel::setSelection);
+ connect(this, &DolphinMainWindow::requestItemInfo, infoPanel, &InformationPanel::requestDelayedItemInfo);
+ connect(this, &DolphinMainWindow::fileItemsChanged, infoPanel, &InformationPanel::slotFilesItemChanged);
+ connect(this, &DolphinMainWindow::settingsChanged, infoPanel, &InformationPanel::readSettings);
#endif
// i18n: This is the last paragraph for the "What's This"-texts of all four panels.
- const QString panelWhatsThis = xi18nc("@info:whatsthis", "<para>To show or "
- "hide panels like this go to <interface>Menu|Panels</interface> "
- "or <interface>View|Panels</interface>.</para>");
+ const QString panelWhatsThis = xi18nc("@info:whatsthis",
+ "<para>To show or "
+ "hide panels like this go to <interface>Menu|Panels</interface> "
+ "or <interface>View|Panels</interface>.</para>");
#if HAVE_BALOO
- actionCollection()->action(QStringLiteral("show_information_panel"))
- ->setWhatsThis(xi18nc("@info:whatsthis", "<para> This toggles the "
- "<emphasis>information</emphasis> panel at the right side of the "
- "window.</para><para>The panel provides in-depth information "
- "about the items your mouse is hovering over or about the selected "
- "items. Otherwise it informs you about the currently viewed folder.<nl/>"
- "For single items a preview of their contents is provided.</para>"));
+ actionCollection()
+ ->action(QStringLiteral("show_information_panel"))
+ ->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para> This toggles the "
+ "<emphasis>information</emphasis> panel at the right side of the "
+ "window.</para><para>The panel provides in-depth information "
+ "about the items your mouse is hovering over or about the selected "
+ "items. Otherwise it informs you about the currently viewed folder.<nl/>"
+ "For single items a preview of their contents is provided.</para>"));
#endif
- infoDock->setWhatsThis(xi18nc("@info:whatsthis", "<para>This panel "
- "provides in-depth information about the items your mouse is "
- "hovering over or about the selected items. Otherwise it informs "
- "you about the currently viewed folder.<nl/>For single items a "
- "preview of their contents is provided.</para><para>You can configure "
- "which and how details are given here by right-clicking.</para>") + panelWhatsThis);
+ infoDock->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This panel "
+ "provides in-depth information about the items your mouse is "
+ "hovering over or about the selected items. Otherwise it informs "
+ "you about the currently viewed folder.<nl/>For single items a "
+ "preview of their contents is provided.</para><para>You can configure "
+ "which and how details are given here by right-clicking.</para>")
+ + panelWhatsThis);
// Setup "Folders"
- DolphinDockWidget* foldersDock = new DolphinDockWidget(i18nc("@title:window", "Folders"));
+ DolphinDockWidget *foldersDock = new DolphinDockWidget(i18nc("@title:window", "Folders"));
foldersDock->setLocked(lock);
foldersDock->setObjectName(QStringLiteral("foldersDock"));
foldersDock->setAllowedAreas(Qt::LeftDockWidgetArea | Qt::RightDockWidgetArea);
- FoldersPanel* foldersPanel = new FoldersPanel(foldersDock);
+ FoldersPanel *foldersPanel = new FoldersPanel(foldersDock);
foldersPanel->setCustomContextMenuActions({lockLayoutAction});
foldersDock->setWidget(foldersPanel);
- QAction* foldersAction = foldersDock->toggleViewAction();
- createPanelAction(QIcon::fromTheme(QStringLiteral("folder")), Qt::Key_F7, foldersAction, QStringLiteral("show_folders_panel"));
+ createPanelAction(QIcon::fromTheme(QStringLiteral("folder")), Qt::Key_F7, foldersDock, QStringLiteral("show_folders_panel"));
addDockWidget(Qt::LeftDockWidgetArea, foldersDock);
- connect(this, &DolphinMainWindow::urlChanged,
- foldersPanel, &FoldersPanel::setUrl);
- connect(foldersPanel, &FoldersPanel::folderActivated,
- this, &DolphinMainWindow::changeUrl);
- connect(foldersPanel, &FoldersPanel::folderInNewTab,
- this, &DolphinMainWindow::openNewTab);
- connect(foldersPanel, &FoldersPanel::folderInNewActiveTab,
- this, &DolphinMainWindow::openNewTabAndActivate);
- connect(foldersPanel, &FoldersPanel::errorMessage,
- this, &DolphinMainWindow::showErrorMessage);
-
- actionCollection()->action(QStringLiteral("show_folders_panel"))
- ->setWhatsThis(xi18nc("@info:whatsthis", "This toggles the "
- "<emphasis>folders</emphasis> panel at the left side of the window."
- "<nl/><nl/>It shows the folders of the <emphasis>file system"
- "</emphasis> in a <emphasis>tree view</emphasis>."));
- foldersDock->setWhatsThis(xi18nc("@info:whatsthis", "<para>This panel "
- "shows the folders of the <emphasis>file system</emphasis> in a "
- "<emphasis>tree view</emphasis>.</para><para>Click a folder to go "
- "there. Click the arrow to the left of a folder to see its subfolders. "
- "This allows quick switching between any folders.</para>") + panelWhatsThis);
+ connect(this, &DolphinMainWindow::urlChanged, foldersPanel, &FoldersPanel::setUrl);
+ connect(foldersPanel, &FoldersPanel::folderActivated, this, &DolphinMainWindow::changeUrl);
+ connect(foldersPanel, &FoldersPanel::folderInNewTab, this, &DolphinMainWindow::openNewTab);
+ connect(foldersPanel, &FoldersPanel::folderInNewActiveTab, this, &DolphinMainWindow::openNewTabAndActivate);
+ connect(foldersPanel, &FoldersPanel::errorMessage, this, &DolphinMainWindow::showErrorMessage);
+
+ actionCollection()
+ ->action(QStringLiteral("show_folders_panel"))
+ ->setWhatsThis(xi18nc("@info:whatsthis",
+ "This toggles the "
+ "<emphasis>folders</emphasis> panel at the left side of the window."
+ "<nl/><nl/>It shows the folders of the <emphasis>file system"
+ "</emphasis> in a <emphasis>tree view</emphasis>."));
+ foldersDock->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This panel "
+ "shows the folders of the <emphasis>file system</emphasis> in a "
+ "<emphasis>tree view</emphasis>.</para><para>Click a folder to go "
+ "there. Click the arrow to the left of a folder to see its subfolders. "
+ "This allows quick switching between any folders.</para>")
+ + panelWhatsThis);
// Setup "Terminal"
#if HAVE_TERMINAL
if (KAuthorized::authorize(QStringLiteral("shell_access"))) {
- DolphinDockWidget* terminalDock = new DolphinDockWidget(i18nc("@title:window Shell terminal", "Terminal"));
+ DolphinDockWidget *terminalDock = new DolphinDockWidget(i18nc("@title:window Shell terminal", "Terminal"));
terminalDock->setLocked(lock);
terminalDock->setObjectName(QStringLiteral("terminalDock"));
+ terminalDock->setContentsMargins(0, 0, 0, 0);
m_terminalPanel = new TerminalPanel(terminalDock);
m_terminalPanel->setCustomContextMenuActions({lockLayoutAction});
terminalDock->setWidget(m_terminalPanel);
connect(m_terminalPanel, &TerminalPanel::hideTerminalPanel, terminalDock, &DolphinDockWidget::hide);
connect(m_terminalPanel, &TerminalPanel::changeUrl, this, &DolphinMainWindow::slotTerminalDirectoryChanged);
- connect(terminalDock, &DolphinDockWidget::visibilityChanged,
- m_terminalPanel, &TerminalPanel::dockVisibilityChanged);
- connect(terminalDock, &DolphinDockWidget::visibilityChanged,
- this, &DolphinMainWindow::slotTerminalPanelVisibilityChanged);
+ connect(terminalDock, &DolphinDockWidget::visibilityChanged, m_terminalPanel, &TerminalPanel::dockVisibilityChanged);
+ connect(terminalDock, &DolphinDockWidget::visibilityChanged, this, &DolphinMainWindow::slotTerminalPanelVisibilityChanged);
- QAction* terminalAction = terminalDock->toggleViewAction();
- createPanelAction(QIcon::fromTheme(QStringLiteral("dialog-scripts")), Qt::Key_F4, terminalAction, QStringLiteral("show_terminal_panel"));
+ createPanelAction(QIcon::fromTheme(QStringLiteral("dialog-scripts")), Qt::Key_F4, terminalDock, QStringLiteral("show_terminal_panel"));
addDockWidget(Qt::BottomDockWidgetArea, terminalDock);
- connect(this, &DolphinMainWindow::urlChanged,
- m_terminalPanel, &TerminalPanel::setUrl);
+ connect(this, &DolphinMainWindow::urlChanged, m_terminalPanel, &TerminalPanel::setUrl);
if (GeneralSettings::version() < 200) {
terminalDock->hide();
}
- actionCollection()->action(QStringLiteral("show_terminal_panel"))
- ->setWhatsThis(xi18nc("@info:whatsthis", "<para>This toggles the "
- "<emphasis>terminal</emphasis> panel at the bottom of the window."
- "<nl/>The location in the terminal will always match the folder "
- "view so you can navigate using either.</para><para>The terminal "
- "panel is not needed for basic computer usage but can be useful "
- "for advanced tasks. To learn more about terminals use the help "
- "in a standalone terminal application like Konsole.</para>"));
- terminalDock->setWhatsThis(xi18nc("@info:whatsthis", "<para>This is "
- "the <emphasis>terminal</emphasis> panel. It behaves like a "
- "normal terminal but will match the location of the folder view "
- "so you can navigate using either.</para><para>The terminal panel "
- "is not needed for basic computer usage but can be useful for "
- "advanced tasks. To learn more about terminals use the help in a "
- "standalone terminal application like Konsole.</para>") + panelWhatsThis);
- }
-#endif
+ actionCollection()
+ ->action(QStringLiteral("show_terminal_panel"))
+ ->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This toggles the "
+ "<emphasis>terminal</emphasis> panel at the bottom of the window."
+ "<nl/>The location in the terminal will always match the folder "
+ "view so you can navigate using either.</para><para>The terminal "
+ "panel is not needed for basic computer usage but can be useful "
+ "for advanced tasks. To learn more about terminals use the help features "
+ "in a standalone terminal application like Konsole.</para>"));
+ terminalDock->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This is "
+ "the <emphasis>terminal</emphasis> panel. It behaves like a "
+ "normal terminal but will match the location of the folder view "
+ "so you can navigate using either.</para><para>The terminal panel "
+ "is not needed for basic computer usage but can be useful for "
+ "advanced tasks. To learn more about terminals use the help features in a "
+ "standalone terminal application like Konsole.</para>")
+ + panelWhatsThis);
+
+ QAction *focusTerminalPanel = actionCollection()->addAction(QStringLiteral("focus_terminal_panel"));
+ focusTerminalPanel->setText(i18nc("@action:inmenu Tools", "Focus Terminal Panel"));
+ focusTerminalPanel->setToolTip(i18nc("@info:tooltip", "Move keyboard focus to and from the Terminal panel."));
+ focusTerminalPanel->setIcon(QIcon::fromTheme(QStringLiteral("swap-panels")));
+ actionCollection()->setDefaultShortcut(focusTerminalPanel, Qt::CTRL | Qt::SHIFT | Qt::Key_F4);
+ connect(focusTerminalPanel, &QAction::triggered, this, &DolphinMainWindow::toggleTerminalPanelFocus);
+ } // endif "shell_access" allowed
+#endif // HAVE_TERMINAL
if (GeneralSettings::version() < 200) {
infoDock->hide();
}
// Setup "Places"
- DolphinDockWidget* placesDock = new DolphinDockWidget(i18nc("@title:window", "Places"));
+ DolphinDockWidget *placesDock = new DolphinDockWidget(i18nc("@title:window", "Places"));
placesDock->setLocked(lock);
placesDock->setObjectName(QStringLiteral("placesDock"));
placesDock->setAllowedAreas(Qt::LeftDockWidgetArea | Qt::RightDockWidgetArea);
m_placesPanel->setCustomContextMenuActions({lockLayoutAction});
placesDock->setWidget(m_placesPanel);
- QAction *placesAction = placesDock->toggleViewAction();
- createPanelAction(QIcon::fromTheme(QStringLiteral("compass")), Qt::Key_F9, placesAction, QStringLiteral("show_places_panel"));
+ createPanelAction(QIcon::fromTheme(QStringLiteral("compass")), Qt::Key_F9, placesDock, QStringLiteral("show_places_panel"));
addDockWidget(Qt::LeftDockWidgetArea, placesDock);
- connect(m_placesPanel, &PlacesPanel::placeActivated,
- this, &DolphinMainWindow::slotPlaceActivated);
- connect(m_placesPanel, &PlacesPanel::tabRequested,
- this, &DolphinMainWindow::openNewTab);
- connect(m_placesPanel, &PlacesPanel::activeTabRequested,
- this, &DolphinMainWindow::openNewTabAndActivate);
+ connect(m_placesPanel, &PlacesPanel::placeActivated, this, &DolphinMainWindow::slotPlaceActivated);
+ connect(m_placesPanel, &PlacesPanel::tabRequested, this, &DolphinMainWindow::openNewTab);
+ connect(m_placesPanel, &PlacesPanel::activeTabRequested, this, &DolphinMainWindow::openNewTabAndActivate);
connect(m_placesPanel, &PlacesPanel::newWindowRequested, this, [this](const QUrl &url) {
Dolphin::openNewWindow({url}, this);
});
- connect(m_placesPanel, &PlacesPanel::errorMessage,
- this, &DolphinMainWindow::showErrorMessage);
- connect(this, &DolphinMainWindow::urlChanged,
- m_placesPanel, &PlacesPanel::setUrl);
- connect(placesDock, &DolphinDockWidget::visibilityChanged,
- &DolphinUrlNavigatorsController::slotPlacesPanelVisibilityChanged);
- connect(this, &DolphinMainWindow::settingsChanged,
- m_placesPanel, &PlacesPanel::readSettings);
- connect(m_placesPanel, &PlacesPanel::storageTearDownRequested,
- this, &DolphinMainWindow::slotStorageTearDownFromPlacesRequested);
- connect(m_placesPanel, &PlacesPanel::storageTearDownExternallyRequested,
- this, &DolphinMainWindow::slotStorageTearDownExternallyRequested);
+ connect(m_placesPanel, &PlacesPanel::openInSplitViewRequested, this, &DolphinMainWindow::openInSplitView);
+ connect(m_placesPanel, &PlacesPanel::errorMessage, this, &DolphinMainWindow::showErrorMessage);
+ connect(this, &DolphinMainWindow::urlChanged, m_placesPanel, &PlacesPanel::setUrl);
+ connect(placesDock, &DolphinDockWidget::visibilityChanged, &DolphinUrlNavigatorsController::slotPlacesPanelVisibilityChanged);
+ connect(placesDock, &DolphinDockWidget::visibilityChanged, this, &DolphinMainWindow::slotPlacesPanelVisibilityChanged);
+ connect(this, &DolphinMainWindow::settingsChanged, m_placesPanel, &PlacesPanel::readSettings);
+ connect(m_placesPanel, &PlacesPanel::storageTearDownRequested, this, &DolphinMainWindow::slotStorageTearDownFromPlacesRequested);
+ connect(m_placesPanel, &PlacesPanel::storageTearDownExternallyRequested, this, &DolphinMainWindow::slotStorageTearDownExternallyRequested);
DolphinUrlNavigatorsController::slotPlacesPanelVisibilityChanged(m_placesPanel->isVisible());
auto actionShowAllPlaces = new QAction(QIcon::fromTheme(QStringLiteral("view-hidden")), i18nc("@item:inmenu", "Show Hidden Places"), this);
actionShowAllPlaces->setCheckable(true);
actionShowAllPlaces->setDisabled(true);
- actionShowAllPlaces->setWhatsThis(i18nc("@info:whatsthis", "This displays "
- "all places in the places panel that have been hidden. They will "
- "appear semi-transparent unless you uncheck their hide property."));
+ actionShowAllPlaces->setWhatsThis(i18nc("@info:whatsthis",
+ "This displays "
+ "all places in the places panel that have been hidden. They will "
+ "appear semi-transparent and allow you to uncheck their \"Hide\" property."));
- connect(actionShowAllPlaces, &QAction::triggered, this, [actionShowAllPlaces, this](bool checked){
+ connect(actionShowAllPlaces, &QAction::triggered, this, [this](bool checked) {
m_placesPanel->setShowAll(checked);
});
connect(m_placesPanel, &PlacesPanel::allPlacesShownChanged, actionShowAllPlaces, &QAction::setChecked);
- actionCollection()->action(QStringLiteral("show_places_panel"))
- ->setWhatsThis(xi18nc("@info:whatsthis", "<para>This toggles the "
- "<emphasis>places</emphasis> panel at the left side of the window."
- "</para><para>It allows you to go to locations you have "
- "bookmarked and to access disk or media attached to the computer "
- "or to the network. It also contains sections to find recently "
- "saved files or files of a certain type.</para>"));
- placesDock->setWhatsThis(xi18nc("@info:whatsthis", "<para>This is the "
- "<emphasis>Places</emphasis> panel. It allows you to go to locations "
- "you have bookmarked and to access disk or media attached to the "
- "computer or to the network. It also contains sections to find "
- "recently saved files or files of a certain type.</para><para>"
- "Click on an entry to go there. Click with the right mouse button "
- "instead to open any entry in a new tab or new window.</para>"
- "<para>New entries can be added by dragging folders onto this panel. "
- "Right-click any section or entry to hide it. Right-click an empty "
- "space on this panel and select <interface>Show Hidden Places"
- "</interface> to display it again.</para>") + panelWhatsThis);
+ actionCollection()
+ ->action(QStringLiteral("show_places_panel"))
+ ->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This toggles the "
+ "<emphasis>places</emphasis> panel at the left side of the window."
+ "</para><para>It allows you to go to locations you have "
+ "bookmarked and to access disk or media attached to the computer "
+ "or to the network. It also contains sections to find recently "
+ "saved files or files of a certain type.</para>"));
+ placesDock->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>This is the "
+ "<emphasis>Places</emphasis> panel. It allows you to go to locations "
+ "you have bookmarked and to access disk or media attached to the "
+ "computer or to the network. It also contains sections to find "
+ "recently saved files or files of a certain type.</para><para>"
+ "Click on an entry to go there. Click with the right mouse button "
+ "instead to open any entry in a new tab or new window.</para>"
+ "<para>New entries can be added by dragging folders onto this panel. "
+ "Right-click any section or entry to hide it. Right-click an empty "
+ "space on this panel and select <interface>Show Hidden Places"
+ "</interface> to display it again.</para>")
+ + panelWhatsThis);
+
+ QAction *focusPlacesPanel = actionCollection()->addAction(QStringLiteral("focus_places_panel"));
+ focusPlacesPanel->setText(i18nc("@action:inmenu View", "Focus Places Panel"));
+ focusPlacesPanel->setToolTip(i18nc("@info:tooltip", "Move keyboard focus to and from the Places panel."));
+ focusPlacesPanel->setIcon(QIcon::fromTheme(QStringLiteral("swap-panels")));
+ actionCollection()->setDefaultShortcut(focusPlacesPanel, Qt::CTRL | Qt::Key_P);
+ connect(focusPlacesPanel, &QAction::triggered, this, &DolphinMainWindow::togglePlacesPanelFocus);
// Add actions into the "Panels" menu
- KActionMenu* panelsMenu = new KActionMenu(i18nc("@action:inmenu View", "Show Panels"), this);
+ KActionMenu *panelsMenu = new KActionMenu(i18nc("@action:inmenu View", "Show Panels"), this);
actionCollection()->addAction(QStringLiteral("panels"), panelsMenu);
panelsMenu->setIcon(QIcon::fromTheme(QStringLiteral("view-sidetree")));
panelsMenu->setPopupMode(QToolButton::InstantPopup);
- const KActionCollection* ac = actionCollection();
+ const KActionCollection *ac = actionCollection();
panelsMenu->addAction(ac->action(QStringLiteral("show_places_panel")));
#if HAVE_BALOO
panelsMenu->addAction(ac->action(QStringLiteral("show_information_panel")));
panelsMenu->addAction(ac->action(QStringLiteral("show_folders_panel")));
panelsMenu->addAction(ac->action(QStringLiteral("show_terminal_panel")));
panelsMenu->addSeparator();
- panelsMenu->addAction(actionShowAllPlaces);
panelsMenu->addAction(lockLayoutAction);
+ panelsMenu->addSeparator();
+ panelsMenu->addAction(actionShowAllPlaces);
+ panelsMenu->addAction(focusPlacesPanel);
+ panelsMenu->addAction(ac->action(QStringLiteral("focus_terminal_panel")));
- connect(panelsMenu->menu(), &QMenu::aboutToShow, this, [actionShowAllPlaces, this]{
+ connect(panelsMenu->menu(), &QMenu::aboutToShow, this, [actionShowAllPlaces] {
actionShowAllPlaces->setEnabled(DolphinPlacesModelSingleton::instance().placesModel()->hiddenCount());
});
}
-
void DolphinMainWindow::updateFileAndEditActions()
{
const KFileItemList list = m_activeViewContainer->view()->selectedItems();
- const KActionCollection* col = actionCollection();
+ const KActionCollection *col = actionCollection();
KFileItemListProperties capabilitiesSource(list);
- QAction* renameAction = col->action(KStandardAction::name(KStandardAction::RenameFile));
- QAction* moveToTrashAction = col->action(KStandardAction::name(KStandardAction::MoveToTrash));
- QAction* deleteAction = col->action(KStandardAction::name(KStandardAction::DeleteFile));
- QAction* cutAction = col->action(KStandardAction::name(KStandardAction::Cut));
- QAction* duplicateAction = col->action(QStringLiteral("duplicate")); // see DolphinViewActionHandler
- QAction* addToPlacesAction = col->action(QStringLiteral("add_to_places"));
- QAction* copyToOtherViewAction = col->action(QStringLiteral("copy_to_inactive_split_view"));
- QAction* moveToOtherViewAction = col->action(QStringLiteral("move_to_inactive_split_view"));
- QAction* copyLocation = col->action(QString("copy_location"));
+ QAction *renameAction = col->action(KStandardAction::name(KStandardAction::RenameFile));
+ QAction *moveToTrashAction = col->action(KStandardAction::name(KStandardAction::MoveToTrash));
+ QAction *deleteAction = col->action(KStandardAction::name(KStandardAction::DeleteFile));
+ QAction *cutAction = col->action(KStandardAction::name(KStandardAction::Cut));
+ QAction *duplicateAction = col->action(QStringLiteral("duplicate")); // see DolphinViewActionHandler
+ QAction *addToPlacesAction = col->action(QStringLiteral("add_to_places"));
+ QAction *copyToOtherViewAction = col->action(QStringLiteral("copy_to_inactive_split_view"));
+ QAction *moveToOtherViewAction = col->action(QStringLiteral("move_to_inactive_split_view"));
+ QAction *copyLocation = col->action(QStringLiteral("copy_location"));
if (list.isEmpty()) {
stateChanged(QStringLiteral("has_no_selection"));
m_actionTextHelper->textsWhenNothingIsSelectedEnabled(false);
stateChanged(QStringLiteral("has_selection"));
- QAction* deleteWithTrashShortcut = col->action(QStringLiteral("delete_shortcut")); // see DolphinViewActionHandler
- QAction* showTarget = col->action(QStringLiteral("show_target"));
+ QAction *deleteWithTrashShortcut = col->action(QStringLiteral("delete_shortcut")); // see DolphinViewActionHandler
+ QAction *showTarget = col->action(QStringLiteral("show_target"));
if (list.length() == 1 && list.first().isDir()) {
addToPlacesAction->setEnabled(true);
const bool enableMoveToTrash = capabilitiesSource.isLocal() && capabilitiesSource.supportsMoving();
renameAction->setEnabled(capabilitiesSource.supportsMoving());
- moveToTrashAction->setEnabled(enableMoveToTrash);
+ m_disabledActionNotifier->setDisabledReason(renameAction, i18nc("@info", "Cannot rename: You do not have permission to rename items in this folder."));
deleteAction->setEnabled(capabilitiesSource.supportsDeleting());
- deleteWithTrashShortcut->setEnabled(capabilitiesSource.supportsDeleting() && !enableMoveToTrash);
+ m_disabledActionNotifier->setDisabledReason(deleteAction,
+ i18nc("@info", "Cannot delete: You do not have permission to remove items from this folder."));
cutAction->setEnabled(capabilitiesSource.supportsMoving());
+ m_disabledActionNotifier->setDisabledReason(cutAction, i18nc("@info", "Cannot cut: You do not have permission to move items from this folder."));
copyLocation->setEnabled(list.length() == 1);
showTarget->setEnabled(list.length() == 1 && list.at(0).isLink());
duplicateAction->setEnabled(capabilitiesSource.supportsWriting());
+ m_disabledActionNotifier->setDisabledReason(duplicateAction,
+ i18nc("@info", "Cannot duplicate here: You do not have permission to create items in this folder."));
+
+ if (enableMoveToTrash) {
+ moveToTrashAction->setEnabled(true);
+ deleteWithTrashShortcut->setEnabled(false);
+ m_disabledActionNotifier->clearDisabledReason(deleteWithTrashShortcut);
+ } else {
+ moveToTrashAction->setEnabled(false);
+ deleteWithTrashShortcut->setEnabled(capabilitiesSource.supportsDeleting());
+ m_disabledActionNotifier->setDisabledReason(deleteWithTrashShortcut,
+ i18nc("@info", "Cannot delete: You do not have permission to remove items from this folder."));
+ }
}
- if (m_tabWidget->currentTabPage()->splitViewEnabled()) {
- DolphinTabPage* tabPage = m_tabWidget->currentTabPage();
+ if (!m_tabWidget->currentTabPage()->splitViewEnabled()) {
+ // No need to set the disabled reason here, as it's obvious to the user that the reason is the split view being disabled.
+ copyToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->clearDisabledReason(copyToOtherViewAction);
+ moveToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->clearDisabledReason(moveToOtherViewAction);
+ } else if (list.isEmpty()) {
+ copyToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(copyToOtherViewAction, i18nc("@info", "Cannot copy to other view: No files selected."));
+ moveToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(moveToOtherViewAction, i18nc("@info", "Cannot move to other view: No files selected."));
+ } else {
+ DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
KFileItem capabilitiesDestination;
if (tabPage->primaryViewActive()) {
- capabilitiesDestination = tabPage->secondaryViewContainer()->url();
+ capabilitiesDestination = tabPage->secondaryViewContainer()->rootItem();
} else {
- capabilitiesDestination = tabPage->primaryViewContainer()->url();
+ capabilitiesDestination = tabPage->primaryViewContainer()->rootItem();
}
- copyToOtherViewAction->setEnabled(capabilitiesDestination.isWritable());
- moveToOtherViewAction->setEnabled((list.isEmpty() || capabilitiesSource.supportsMoving()) && capabilitiesDestination.isWritable());
- } else {
- copyToOtherViewAction->setEnabled(false);
- moveToOtherViewAction->setEnabled(false);
+ const auto destUrl = capabilitiesDestination.url();
+ const bool allNotTargetOrigin = std::all_of(list.cbegin(), list.cend(), [destUrl](const KFileItem &item) {
+ return item.url().adjusted(QUrl::RemoveFilename | QUrl::StripTrailingSlash) != destUrl;
+ });
+
+ if (!allNotTargetOrigin) {
+ copyToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(copyToOtherViewAction,
+ i18nc("@info", "Cannot copy to other view: The other view already contains these items."));
+ moveToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(moveToOtherViewAction,
+ i18nc("@info", "Cannot move to other view: The other view already contains these items."));
+ } else if (!capabilitiesDestination.isWritable()) {
+ copyToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(
+ copyToOtherViewAction,
+ i18nc("@info", "Cannot copy to other view: You do not have permission to write into the destination folder."));
+ moveToOtherViewAction->setEnabled(false);
+ m_disabledActionNotifier->setDisabledReason(
+ moveToOtherViewAction,
+ i18nc("@info", "Cannot move to other view: You do not have permission to write into the destination folder."));
+ } else {
+ copyToOtherViewAction->setEnabled(true);
+ moveToOtherViewAction->setEnabled(capabilitiesSource.supportsMoving());
+ m_disabledActionNotifier->setDisabledReason(
+ moveToOtherViewAction,
+ i18nc("@info", "Cannot move to other view: You do not have permission to move items from this folder."));
+ }
}
}
{
m_actionHandler->updateViewActions();
- QAction* toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
+ QAction *toggleFilterBarAction = actionCollection()->action(QStringLiteral("toggle_filter"));
toggleFilterBarAction->setChecked(m_activeViewContainer->isFilterBarVisible());
- updateSplitAction();
+ updateSplitActions();
}
void DolphinMainWindow::updateGoActions()
{
- QAction* goUpAction = actionCollection()->action(KStandardAction::name(KStandardAction::Up));
+ QAction *goUpAction = actionCollection()->action(KStandardAction::name(KStandardAction::Up));
const QUrl currentUrl = m_activeViewContainer->url();
// I think this is one of the best places to firstly be confronted
// with a file system and its hierarchy. Talking about the root
// directory might seem too much here but it is the question that
// naturally arises in this context.
- goUpAction->setWhatsThis(xi18nc("@info:whatsthis", "<para>Go to "
- "the folder that contains the currently viewed one.</para>"
- "<para>All files and folders are organized in a hierarchical "
- "<emphasis>file system</emphasis>. At the top of this hierarchy is "
- "a directory that contains all data connected to this computer"
- "—the <emphasis>root directory</emphasis>.</para>"));
+ goUpAction->setWhatsThis(xi18nc("@info:whatsthis",
+ "<para>Go to "
+ "the folder that contains the currently viewed one.</para>"
+ "<para>All files and folders are organized in a hierarchical "
+ "<emphasis>file system</emphasis>. At the top of this hierarchy is "
+ "a directory that contains all data connected to this computer"
+ "—the <emphasis>root directory</emphasis>.</para>"));
goUpAction->setEnabled(KIO::upUrl(currentUrl) != currentUrl);
}
updateWindowTitle();
}
- updateSplitAction();
+ updateSplitActions();
Q_EMIT settingsChanged();
}
m_activeViewContainer->statusBar()->resetToDefaultText();
}
-void DolphinMainWindow::connectViewSignals(DolphinViewContainer* container)
+void DolphinMainWindow::connectViewSignals(DolphinViewContainer *container)
{
- connect(container, &DolphinViewContainer::showFilterBarChanged,
- this, &DolphinMainWindow::updateFilterBarAction);
- connect(container, &DolphinViewContainer::writeStateChanged,
- this, &DolphinMainWindow::slotWriteStateChanged);
- connect(container, &DolphinViewContainer::searchModeEnabledChanged,
- this, &DolphinMainWindow::updateSearchAction);
- connect(container, &DolphinViewContainer::captionChanged,
- this, &DolphinMainWindow::updateWindowTitle);
- connect(container, &DolphinViewContainer::tabRequested,
- this, &DolphinMainWindow::openNewTab);
- connect(container, &DolphinViewContainer::activeTabRequested,
- this, &DolphinMainWindow::openNewTabAndActivate);
-
- const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
- connect(toggleSearchAction, &QAction::triggered, container, &DolphinViewContainer::setSearchModeEnabled);
+ connect(container, &DolphinViewContainer::showFilterBarChanged, this, &DolphinMainWindow::updateFilterBarAction);
+ connect(container, &DolphinViewContainer::writeStateChanged, this, &DolphinMainWindow::slotWriteStateChanged);
+ slotWriteStateChanged(container->view()->isFolderWritable());
+ connect(container, &DolphinViewContainer::searchBarVisibilityChanged, this, &DolphinMainWindow::updateSearchAction);
+ connect(container, &DolphinViewContainer::captionChanged, this, &DolphinMainWindow::updateWindowTitle);
+ connect(container, &DolphinViewContainer::tabRequested, this, &DolphinMainWindow::openNewTab);
+ connect(container, &DolphinViewContainer::activeTabRequested, this, &DolphinMainWindow::openNewTabAndActivate);
// Make the toggled state of the selection mode actions visually follow the selection mode state of the view.
auto toggleSelectionModeAction = actionCollection()->action(QStringLiteral("toggle_selection_mode"));
toggleSelectionModeAction->setChecked(m_activeViewContainer->isSelectionModeEnabled());
- connect(m_activeViewContainer, &DolphinViewContainer::selectionModeChanged,
- toggleSelectionModeAction, &QAction::setChecked);
-
- const DolphinView* view = container->view();
- connect(view, &DolphinView::selectionChanged,
- this, &DolphinMainWindow::slotSelectionChanged);
- connect(view, &DolphinView::requestItemInfo,
- this, &DolphinMainWindow::requestItemInfo);
- connect(view, &DolphinView::fileItemsChanged,
- this, &DolphinMainWindow::fileItemsChanged);
- connect(view, &DolphinView::tabRequested,
- this, &DolphinMainWindow::openNewTab);
- connect(view, &DolphinView::activeTabRequested,
- this, &DolphinMainWindow::openNewTabAndActivate);
- connect(view, &DolphinView::windowRequested,
- this, &DolphinMainWindow::openNewWindow);
- connect(view, &DolphinView::requestContextMenu,
- this, &DolphinMainWindow::openContextMenu);
- connect(view, &DolphinView::directoryLoadingStarted,
- this, &DolphinMainWindow::enableStopAction);
- connect(view, &DolphinView::directoryLoadingCompleted,
- this, &DolphinMainWindow::disableStopAction);
- connect(view, &DolphinView::directoryLoadingCompleted,
- this, &DolphinMainWindow::slotDirectoryLoadingCompleted);
- connect(view, &DolphinView::goBackRequested,
- this, &DolphinMainWindow::goBack);
- connect(view, &DolphinView::goForwardRequested,
- this, &DolphinMainWindow::goForward);
- connect(view, &DolphinView::urlActivated,
- this, &DolphinMainWindow::handleUrl);
- connect(view, &DolphinView::goUpRequested,
- this, &DolphinMainWindow::goUp);
-
- connect(container->urlNavigatorInternalWithHistory(), &KUrlNavigator::urlChanged,
- this, &DolphinMainWindow::changeUrl);
- connect(container->urlNavigatorInternalWithHistory(), &KUrlNavigator::historyChanged,
- this, &DolphinMainWindow::updateHistory);
-
- auto navigators = static_cast<DolphinNavigatorsWidgetAction *>
- (actionCollection()->action(QStringLiteral("url_navigators")));
- const KUrlNavigator *navigator = m_tabWidget->currentTabPage()->primaryViewActive() ?
- navigators->primaryUrlNavigator() :
- navigators->secondaryUrlNavigator();
+ connect(m_activeViewContainer, &DolphinViewContainer::selectionModeChanged, toggleSelectionModeAction, &QAction::setChecked);
+
+ const DolphinView *view = container->view();
+ connect(view, &DolphinView::selectionChanged, this, &DolphinMainWindow::slotSelectionChanged);
+ connect(view, &DolphinView::requestItemInfo, this, &DolphinMainWindow::requestItemInfo);
+ connect(view, &DolphinView::fileItemsChanged, this, &DolphinMainWindow::fileItemsChanged);
+ connect(view, &DolphinView::tabRequested, this, &DolphinMainWindow::openNewTab);
+ connect(view, &DolphinView::activeTabRequested, this, &DolphinMainWindow::openNewTabAndActivate);
+ connect(view, &DolphinView::windowRequested, this, &DolphinMainWindow::openNewWindow);
+ connect(view, &DolphinView::requestContextMenu, this, &DolphinMainWindow::openContextMenu);
+ connect(view, &DolphinView::directoryLoadingStarted, this, &DolphinMainWindow::enableStopAction);
+ connect(view, &DolphinView::directoryLoadingCompleted, this, &DolphinMainWindow::disableStopAction);
+ connect(view, &DolphinView::directoryLoadingCompleted, this, &DolphinMainWindow::slotDirectoryLoadingCompleted);
+ connect(view, &DolphinView::goBackRequested, this, &DolphinMainWindow::goBack);
+ connect(view, &DolphinView::goForwardRequested, this, &DolphinMainWindow::goForward);
+ connect(view, &DolphinView::urlActivated, this, &DolphinMainWindow::handleUrl);
+ connect(view, &DolphinView::goUpRequested, this, &DolphinMainWindow::goUp);
+ connect(view, &DolphinView::doubleClickViewBackground, this, &DolphinMainWindow::slotDoubleClickViewBackground);
+
+ connect(container->urlNavigatorInternalWithHistory(), &KUrlNavigator::urlChanged, this, &DolphinMainWindow::changeUrl);
+ connect(container->urlNavigatorInternalWithHistory(), &KUrlNavigator::historyChanged, this, &DolphinMainWindow::updateHistory);
+
+ auto navigators = static_cast<DolphinNavigatorsWidgetAction *>(actionCollection()->action(QStringLiteral("url_navigators")));
+ const KUrlNavigator *navigator =
+ m_tabWidget->currentTabPage()->primaryViewActive() ? navigators->primaryUrlNavigator() : navigators->secondaryUrlNavigator();
QAction *editableLocactionAction = actionCollection()->action(QStringLiteral("editable_location"));
editableLocactionAction->setChecked(navigator->isUrlEditable());
- connect(navigator, &KUrlNavigator::editableStateChanged,
- this, &DolphinMainWindow::slotEditableStateChanged);
- connect(navigator, &KUrlNavigator::tabRequested,
- this, &DolphinMainWindow::openNewTab);
- connect(navigator, &KUrlNavigator::activeTabRequested,
- this, &DolphinMainWindow::openNewTabAndActivate);
- connect(navigator, &KUrlNavigator::newWindowRequested,
- this, &DolphinMainWindow::openNewWindow);
-
+ connect(navigator, &KUrlNavigator::editableStateChanged, this, &DolphinMainWindow::slotEditableStateChanged);
+ connect(navigator, &KUrlNavigator::tabRequested, this, &DolphinMainWindow::openNewTab);
+ connect(navigator, &KUrlNavigator::activeTabRequested, this, &DolphinMainWindow::openNewTabAndActivate);
+ connect(navigator, &KUrlNavigator::newWindowRequested, this, &DolphinMainWindow::openNewWindow);
}
-void DolphinMainWindow::updateSplitAction()
+void DolphinMainWindow::updateSplitActions()
{
- QAction* splitAction = actionCollection()->action(QStringLiteral("split_view"));
- const DolphinTabPage* tabPage = m_tabWidget->currentTabPage();
+ QAction *popoutSplitAction = actionCollection()->action(QStringLiteral("popout_split_view"));
+
+ auto setActionPopupMode = [this](KActionMenu *action, QToolButton::ToolButtonPopupMode popupMode) {
+ action->setPopupMode(popupMode);
+ if (auto *buttonForAction = qobject_cast<QToolButton *>(toolBar()->widgetForAction(action))) {
+ buttonForAction->setPopupMode(popupMode);
+ }
+ };
+
+ const DolphinTabPage *tabPage = m_tabWidget->currentTabPage();
if (tabPage->splitViewEnabled()) {
if (GeneralSettings::closeActiveSplitView() ? tabPage->primaryViewActive() : !tabPage->primaryViewActive()) {
- splitAction->setText(i18nc("@action:intoolbar Close left view", "Close"));
- splitAction->setToolTip(i18nc("@info", "Close left view"));
- splitAction->setIcon(QIcon::fromTheme(QStringLiteral("view-left-close")));
+ m_splitViewAction->setText(i18nc("@action:intoolbar Close left view", "Close"));
+ m_splitViewAction->setToolTip(i18nc("@info", "Close left view"));
+ m_splitViewAction->setIcon(QIcon::fromTheme(QStringLiteral("view-left-close")));
+ m_splitViewMenuAction->setText(i18nc("@action:inmenu Close left view", "Close Left View"));
+
+ popoutSplitAction->setText(i18nc("@action:intoolbar Move left view to a new window", "Pop out Left View"));
+ popoutSplitAction->setToolTip(i18nc("@info", "Move left view to a new window"));
} else {
- splitAction->setText(i18nc("@action:intoolbar Close right view", "Close"));
- splitAction->setToolTip(i18nc("@info", "Close right view"));
- splitAction->setIcon(QIcon::fromTheme(QStringLiteral("view-right-close")));
+ m_splitViewAction->setText(i18nc("@action:intoolbar Close right view", "Close"));
+ m_splitViewAction->setToolTip(i18nc("@info", "Close right view"));
+ m_splitViewAction->setIcon(QIcon::fromTheme(QStringLiteral("view-right-close")));
+ m_splitViewMenuAction->setText(i18nc("@action:inmenu Close left view", "Close Right View"));
+
+ popoutSplitAction->setText(i18nc("@action:intoolbar Move right view to a new window", "Pop out Right View"));
+ popoutSplitAction->setToolTip(i18nc("@info", "Move right view to a new window"));
+ }
+ popoutSplitAction->setEnabled(true);
+ if (!m_splitViewAction->menu()) {
+ setActionPopupMode(m_splitViewAction, QToolButton::MenuButtonPopup);
+ m_splitViewAction->setMenu(new QMenu);
+ m_splitViewAction->addAction(popoutSplitAction);
}
} else {
- splitAction->setText(i18nc("@action:intoolbar Split view", "Split"));
- splitAction->setToolTip(i18nc("@info", "Split view"));
- splitAction->setIcon(QIcon::fromTheme(QStringLiteral("view-right-new")));
+ m_splitViewAction->setText(i18nc("@action:intoolbar Split view", "Split"));
+ m_splitViewMenuAction->setText(m_splitViewAction->text());
+ m_splitViewAction->setToolTip(i18nc("@info", "Split view"));
+ m_splitViewAction->setIcon(QIcon::fromTheme(QStringLiteral("view-split-left-right")));
+ popoutSplitAction->setText(i18nc("@action:intoolbar Move view in focus to a new window", "Pop out"));
+ popoutSplitAction->setEnabled(false);
+ if (m_splitViewAction->menu()) {
+ m_splitViewAction->removeAction(popoutSplitAction);
+ m_splitViewAction->menu()->deleteLater();
+ m_splitViewAction->setMenu(nullptr);
+ setActionPopupMode(m_splitViewAction, QToolButton::DelayedPopup);
+ }
}
+
+ // Update state from toolbar action
+ m_splitViewMenuAction->setToolTip(m_splitViewAction->toolTip());
+ m_splitViewMenuAction->setIcon(m_splitViewAction->icon());
}
void DolphinMainWindow::updateAllowedToolbarAreas()
{
- auto navigators = static_cast<DolphinNavigatorsWidgetAction *>
- (actionCollection()->action(QStringLiteral("url_navigators")));
+ auto navigators = static_cast<DolphinNavigatorsWidgetAction *>(actionCollection()->action(QStringLiteral("url_navigators")));
if (toolBar()->actions().contains(navigators)) {
toolBar()->setAllowedAreas(Qt::TopToolBarArea | Qt::BottomToolBarArea);
- if (toolBarArea(toolBar()) == Qt::LeftToolBarArea ||
- toolBarArea(toolBar()) == Qt::RightToolBarArea) {
+ if (toolBarArea(toolBar()) == Qt::LeftToolBarArea || toolBarArea(toolBar()) == Qt::RightToolBarArea) {
addToolBar(Qt::TopToolBarArea, toolBar());
}
} else {
}
}
+void DolphinMainWindow::updateNavigatorsBackground()
+{
+ auto navigators = static_cast<DolphinNavigatorsWidgetAction *>(actionCollection()->action(QStringLiteral("url_navigators")));
+ navigators->setBackgroundEnabled(navigators->isInToolbar());
+}
+
bool DolphinMainWindow::isKompareInstalled() const
{
static bool initialized = false;
return installed;
}
-void DolphinMainWindow::createPanelAction(const QIcon& icon,
- const QKeySequence& shortcut,
- QAction* dockAction,
- const QString& actionName)
+void DolphinMainWindow::createPanelAction(const QIcon &icon, const QKeySequence &shortcut, QDockWidget *dockWidget, const QString &actionName)
{
- QAction* panelAction = actionCollection()->addAction(actionName);
- panelAction->setCheckable(true);
- panelAction->setChecked(dockAction->isChecked());
- panelAction->setText(dockAction->text());
- panelAction->setIcon(icon);
+ auto dockAction = dockWidget->toggleViewAction();
dockAction->setIcon(icon);
- actionCollection()->setDefaultShortcut(panelAction, shortcut);
+ dockAction->setEnabled(true);
- connect(panelAction, &QAction::triggered, dockAction, &QAction::trigger);
- connect(dockAction, &QAction::toggled, panelAction, &QAction::setChecked);
+ QAction *panelAction = actionCollection()->addAction(actionName, dockAction);
+ actionCollection()->setDefaultShortcut(panelAction, shortcut);
}
-
+// clang-format off
void DolphinMainWindow::setupWhatsThis()
{
// main widgets
// Help menu
+ auto setStandardActionWhatsThis = [this](KStandardAction::StandardAction actionId,
+ const QString &whatsThis) {
+ // Check for the existence of an action since it can be restricted through the Kiosk system
+ if (auto *action = actionCollection()->action(KStandardAction::name(actionId))) {
+ action->setWhatsThis(whatsThis);
+ }
+ };
+
// i18n: If the external link isn't available in your language it might make
// sense to state the external link's language in brackets to not
// frustrate the user. If there are multiple languages that the user might
// know with a reasonable chance you might want to have 2 external links.
// The same might be true for any external link you translate.
-
actionCollection()->action(KStandardAction::name(KStandardAction::HelpContents))->setWhatsThis(xi18nc("@info:whatsthis handbook", "<para>This opens the Handbook for this application. It provides explanations for every part of <emphasis>Dolphin</emphasis>.</para><para>If you want more elaborate introductions to the different features of <emphasis>Dolphin</emphasis> <link url='https://userbase.kde.org/Dolphin/File_Management'>click here</link>. It will open the dedicated page in the KDE UserBase Wiki.</para>"));
+
setStandardActionWhatsThis(KStandardAction::HelpContents, xi18nc("@info:whatsthis handbook", "<para>This opens the Handbook for this application. It provides explanations for every part of <emphasis>Dolphin</emphasis>.</para><para>If you want more elaborate introductions to the different features of <emphasis>Dolphin</emphasis> <link url='https://userbase.kde.org/Dolphin/File_Management'>click here</link>. It will open the dedicated page in the KDE UserBase Wiki.</para>"));
// (The i18n call should be completely in the line following the i18n: comment without any line breaks within the i18n call or the comment might not be correctly extracted. See: https://commits.kde.org/kxmlgui/a31135046e1b3335b5d7bbbe6aa9a883ce3284c1 )
- actionCollection()->action(KStandardAction::name(KStandardAction::WhatsThis))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::WhatsThis,
xi18nc("@info:whatsthis whatsthis button",
"<para>This is the button that invokes the help feature you are "
"using right now! Click it, then click any component of this "
"UserBase Wiki</link>.</para><para>The \"What's this?\" help is "
"missing in most other windows so don't get too used to this.</para>"));
- actionCollection()->action(KStandardAction::name(KStandardAction::ReportBug))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::ReportBug,
xi18nc("@info:whatsthis","<para>This opens a "
"window that will guide you through reporting errors or flaws "
"in this application or in other KDE software.</para>"
"<link url='https://community.kde.org/Get_Involved/Bug_Reporting'>"
"click here</link>.</para>"));
- actionCollection()->action(KStandardAction::name(KStandardAction::Donate))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::Donate,
xi18nc("@info:whatsthis", "<para>This opens a "
"<emphasis>web page</emphasis> where you can donate to "
"support the continued work on this application and many "
"<para><emphasis>KDE e.V.</emphasis> is the non-profit "
"organization behind the KDE community.</para>"));
- actionCollection()->action(KStandardAction::name(KStandardAction::SwitchApplicationLanguage))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::SwitchApplicationLanguage,
xi18nc("@info:whatsthis",
"With this you can change the language this application uses."
"<nl/>You can even set secondary languages which will be used "
"if texts are not available in your preferred language."));
- actionCollection()->action(KStandardAction::name(KStandardAction::AboutApp))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::AboutApp,
xi18nc("@info:whatsthis","This opens a "
"window that informs you about the version, license, "
"used libraries and maintainers of this application."));
- actionCollection()->action(KStandardAction::name(KStandardAction::AboutKDE))->setWhatsThis(
+ setStandardActionWhatsThis(KStandardAction::AboutKDE,
xi18nc("@info:whatsthis","This opens a "
"window with information about <emphasis>KDE</emphasis>. "
"The KDE community are the people behind this free software."
"<nl/>If you like using this application but don't know "
"about KDE or want to see a cute dragon have a look!"));
}
+// clang-format on
bool DolphinMainWindow::addHamburgerMenuToToolbar()
{
KXmlGuiWindow::saveNewToolbarConfig(); // Applies the new config. This has to be called first
// because the rest of this method decides things
// based on the new config.
- auto navigators = static_cast<DolphinNavigatorsWidgetAction *>
- (actionCollection()->action(QStringLiteral("url_navigators")));
+ auto navigators = static_cast<DolphinNavigatorsWidgetAction *>(actionCollection()->action(QStringLiteral("url_navigators")));
if (!toolBar()->actions().contains(navigators)) {
m_tabWidget->currentTabPage()->insertNavigatorsWidget(navigators);
}
updateAllowedToolbarAreas();
- (static_cast<KHamburgerMenu *>(actionCollection()->action(KStandardAction::name(
- KStandardAction::HamburgerMenu))))->hideActionsOf(toolBar());
+ updateNavigatorsBackground();
+ (static_cast<KHamburgerMenu *>(actionCollection()->action(KStandardAction::name(KStandardAction::HamburgerMenu))))->hideActionsOf(toolBar());
}
-void DolphinMainWindow::focusTerminalPanel()
+void DolphinMainWindow::toggleTerminalPanelFocus()
{
- if (m_terminalPanel->isVisible()) {
- if (m_terminalPanel->terminalHasFocus()) {
- m_activeViewContainer->view()->setFocus(Qt::FocusReason::ShortcutFocusReason);
- actionCollection()->action(QStringLiteral("focus_terminal_panel"))->setText(i18nc("@action:inmenu Tools", "Focus Terminal Panel"));
- } else {
- m_terminalPanel->setFocus(Qt::FocusReason::ShortcutFocusReason);
- actionCollection()->action(QStringLiteral("focus_terminal_panel"))->setText(i18nc("@action:inmenu Tools", "Defocus Terminal Panel"));
- }
- } else {
- actionCollection()->action(QStringLiteral("show_terminal_panel"))->trigger();
+ if (!m_terminalPanel->isVisible()) {
+ actionCollection()->action(QStringLiteral("show_terminal_panel"))->trigger(); // Also moves focus to the panel.
actionCollection()->action(QStringLiteral("focus_terminal_panel"))->setText(i18nc("@action:inmenu Tools", "Defocus Terminal Panel"));
+ return;
}
+
+ if (m_terminalPanel->terminalHasFocus()) {
+ m_activeViewContainer->view()->setFocus(Qt::FocusReason::ShortcutFocusReason);
+ actionCollection()->action(QStringLiteral("focus_terminal_panel"))->setText(i18nc("@action:inmenu Tools", "Focus Terminal Panel"));
+ return;
+ }
+
+ m_terminalPanel->setFocus(Qt::FocusReason::ShortcutFocusReason);
+ actionCollection()->action(QStringLiteral("focus_terminal_panel"))->setText(i18nc("@action:inmenu Tools", "Defocus Terminal Panel"));
}
-DolphinMainWindow::UndoUiInterface::UndoUiInterface() :
- KIO::FileUndoManager::UiInterface()
+void DolphinMainWindow::togglePlacesPanelFocus()
+{
+ if (!m_placesPanel->isVisible()) {
+ actionCollection()->action(QStringLiteral("show_places_panel"))->trigger(); // Also moves focus to the panel.
+ actionCollection()->action(QStringLiteral("focus_places_panel"))->setText(i18nc("@action:inmenu View", "Defocus Terminal Panel"));
+ return;
+ }
+
+ if (m_placesPanel->hasFocus()) {
+ m_activeViewContainer->view()->setFocus(Qt::FocusReason::ShortcutFocusReason);
+ actionCollection()->action(QStringLiteral("focus_places_panel"))->setText(i18nc("@action:inmenu View", "Focus Places Panel"));
+ return;
+ }
+
+ m_placesPanel->setFocus(Qt::FocusReason::ShortcutFocusReason);
+ actionCollection()->action(QStringLiteral("focus_places_panel"))->setText(i18nc("@action:inmenu View", "Defocus Places Panel"));
+}
+
+DolphinMainWindow::UndoUiInterface::UndoUiInterface()
+ : KIO::FileUndoManager::UiInterface()
{
}
{
}
-void DolphinMainWindow::UndoUiInterface::jobError(KIO::Job* job)
+void DolphinMainWindow::UndoUiInterface::jobError(KIO::Job *job)
{
- DolphinMainWindow* mainWin= qobject_cast<DolphinMainWindow *>(parentWidget());
+ DolphinMainWindow *mainWin = qobject_cast<DolphinMainWindow *>(parentWidget());
if (mainWin) {
- DolphinViewContainer* container = mainWin->activeViewContainer();
- container->showMessage(job->errorString(), DolphinViewContainer::Error);
+ DolphinViewContainer *container = mainWin->activeViewContainer();
+ container->showMessage(job->errorString(), KMessageWidget::Error);
} else {
KIO::FileUndoManager::UiInterface::jobError(job);
}
{
return m_tabWidget->isItemVisibleInAnyView(QUrl::fromUserInput(urlOfItem));
}
+
+void DolphinMainWindow::slotDoubleClickViewBackground(Qt::MouseButton button)
+{
+ if (button != Qt::MouseButton::LeftButton) {
+ // only handle left mouse button for now
+ return;
+ }
+
+ GeneralSettings *settings = GeneralSettings::self();
+ QString clickAction = settings->doubleClickViewAction();
+
+ DolphinView *view = activeViewContainer()->view();
+ if (view == nullptr || clickAction == "none") {
+ return;
+ }
+
+ if (clickAction == customCommand) {
+ // run custom command set by the user
+ QString path = view->url().toLocalFile();
+ QString clickCustomAction = settings->doubleClickViewCustomAction();
+ clickCustomAction.replace("{path}", path.prepend('"').append('"'));
+
+ m_job = new KIO::CommandLauncherJob(clickCustomAction);
+ m_job->setUiDelegate(new KDialogJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
+ m_job->start();
+
+ } else {
+ // get the action set by the user and trigger it
+ const KActionCollection *actions = actionCollection();
+ QAction *action = actions->action(clickAction);
+ if (action == nullptr) {
+ qCWarning(DolphinDebug) << QStringLiteral("Double-click view: action `%1` was not found").arg(clickAction);
+ return;
+ }
+ action->trigger();
+ }
+}
+
+#include "moc_dolphinmainwindow.cpp"
projects / dolphin.git / blobdiff