-/***************************************************************************
- * Copyright (C) 2007-2011 by Peter Penz <peter.penz19@gmail.com> *
- * Copyright (C) 2007 by David Faure <faure@kde.org> *
- * *
- * This program is free software; you can redistribute it and/or modify *
- * it under the terms of the GNU General Public License as published by *
- * the Free Software Foundation; either version 2 of the License, or *
- * (at your option) any later version. *
- * *
- * This program is distributed in the hope that it will be useful, *
- * but WITHOUT ANY WARRANTY; without even the implied warranty of *
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
- * GNU General Public License for more details. *
- * *
- * You should have received a copy of the GNU General Public License *
- * along with this program; if not, write to the *
- * Free Software Foundation, Inc., *
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
- ***************************************************************************/
+/*
+ * SPDX-FileCopyrightText: 2007-2011 Peter Penz <peter.penz19@gmail.com>
+ * SPDX-FileCopyrightText: 2007 David Faure <faure@kde.org>
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
#include "draganddrophelper.h"
-#include <QUrl>
-#include <QDBusMessage>
+#include <KIO/DropJob>
+#include <KJobWidgets>
+
#include <QDBusConnection>
+#include <QDBusMessage>
#include <QDropEvent>
#include <QMimeData>
-#include <KFileItem>
-#include <KLocalizedString>
-#include <KUrlMimeData>
-#include <KIO/DropJob>
-#include <KJobWidgets>
+QHash<QUrl, bool> DragAndDropHelper::m_urlListMatchesUrlCache;
-KIO::DropJob* DragAndDropHelper::dropUrls(const QUrl& destUrl, QDropEvent* event, QWidget* window)
+bool DragAndDropHelper::urlListMatchesUrl(const QList<QUrl> &urls, const QUrl &destUrl)
{
- const QMimeData* mimeData = event->mimeData();
- if (mimeData->hasFormat("application/x-kde-ark-dndextract-service") &&
- mimeData->hasFormat("application/x-kde-ark-dndextract-path")) {
- const QString remoteDBusClient = mimeData->data("application/x-kde-ark-dndextract-service");
- const QString remoteDBusPath = mimeData->data("application/x-kde-ark-dndextract-path");
-
- QDBusMessage message = QDBusMessage::createMethodCall(remoteDBusClient, remoteDBusPath,
- "org.kde.ark.DndExtract", "extractSelectedFilesTo");
+ auto iteratorResult = m_urlListMatchesUrlCache.constFind(destUrl);
+ if (iteratorResult != m_urlListMatchesUrlCache.constEnd()) {
+ return *iteratorResult;
+ }
+
+ const bool destUrlMatches = std::find_if(urls.constBegin(),
+ urls.constEnd(),
+ [destUrl](const QUrl &url) {
+ return url.matches(destUrl, QUrl::StripTrailingSlash);
+ })
+ != urls.constEnd();
+
+ return *m_urlListMatchesUrlCache.insert(destUrl, destUrlMatches);
+}
+
+KIO::DropJob *DragAndDropHelper::dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window)
+{
+ const QMimeData *mimeData = event->mimeData();
+ if (isArkDndMimeType(mimeData)) {
+ const QString remoteDBusClient = QString::fromUtf8(mimeData->data(arkDndServiceMimeType()));
+ const QString remoteDBusPath = QString::fromUtf8(mimeData->data(arkDndPathMimeType()));
+
+ QDBusMessage message = QDBusMessage::createMethodCall(remoteDBusClient,
+ remoteDBusPath,
+ QStringLiteral("org.kde.ark.DndExtract"),
+ QStringLiteral("extractSelectedFilesTo"));
message.setArguments({destUrl.toDisplayString(QUrl::PreferLocalFile)});
QDBusConnection::sessionBus().call(message);
} else {
- // Drop into a directory or a desktop-file
- KIO::DropJob *job = KIO::drop(event, destUrl);
- KJobWidgets::setWindow(job, window);
- return job;
+ if (urlListMatchesUrl(event->mimeData()->urls(), destUrl)) {
+ return nullptr;
+ }
+
+ // TODO: remove this check once Qt is fixed so that it doesn't emit a QDropEvent on Wayland
+ // when we called QDragMoveEvent::ignore()
+ // https://codereview.qt-project.org/c/qt/qtwayland/+/541750
+ KFileItem item(destUrl);
+ // KFileItem(QUrl) only stat local URLs, so we always allow dropping on non-local URLs
+ if (!item.isLocalFile() || supportsDropping(item)) {
+ // Drop into a directory or a desktop-file
+ KIO::DropJob *job = KIO::drop(event, destUrl);
+ KJobWidgets::setWindow(job, window);
+ return job;
+ }
}
- return 0;
+ return nullptr;
}
+bool DragAndDropHelper::supportsDropping(const KFileItem &destItem)
+{
+ return (destItem.isDir() && destItem.isWritable()) || destItem.isDesktopFile();
+}
+
+void DragAndDropHelper::updateDropAction(QDropEvent *event, const QUrl &destUrl)
+{
+ if (urlListMatchesUrl(event->mimeData()->urls(), destUrl)) {
+ event->setDropAction(Qt::IgnoreAction);
+ event->ignore();
+ }
+ KFileItem item(destUrl);
+ if (!item.isLocalFile() || supportsDropping(item)) {
+ event->setDropAction(event->proposedAction());
+ event->accept();
+ } else {
+ event->setDropAction(Qt::IgnoreAction);
+ event->ignore();
+ }
+}
+
+void DragAndDropHelper::clearUrlListMatchesUrlCache()
+{
+ DragAndDropHelper::m_urlListMatchesUrlCache.clear();
+}
+
+bool DragAndDropHelper::isArkDndMimeType(const QMimeData *mimeData)
+{
+ return mimeData->hasFormat(arkDndServiceMimeType()) && mimeData->hasFormat(arkDndPathMimeType());
+}
projects / dolphin.git / blobdiff