[CLAZY] Fixed all level 1 and level 2 warnings with small exceptions

[dolphin.git] / src / settings / services / servicessettingspage.cpp

diff --git a/src/settings/services/servicessettingspage.cpp b/src/settings/services/servicessettingspage.cpp
index 4110d1f5e2792b01f9a32abf0820de8b40714e53..4cfa2327c9fa77a6124b4d90040a9784cc8180c5 100644 (file)
--- a/src/settings/services/servicessettingspage.cpp
+++ b/src/settings/services/servicessettingspage.cpp
@@ -26,13 +26,13 @@
 #include <KConfigGroup>
 #include <KDesktopFile>
 #include <kdesktopfileactions.h>
 #include <KConfigGroup>
 #include <KDesktopFile>
 #include <kdesktopfileactions.h>

-#include <KIcon>
-#include <KLocale>
+#include <QIcon>
+#include <KLocalizedString>

 #include <KMessageBox>
 #include <KNS3/Button>
 #include <KService>
 #include <KServiceTypeTrader>
 #include <KMessageBox>
 #include <KNS3/Button>
 #include <KService>
 #include <KServiceTypeTrader>

-#include <KStandardDirs>
+#include <QStandardPaths>

 
 #include <settings/serviceitemdelegate.h>
 #include <settings/servicemodel.h>
 
 #include <settings/serviceitemdelegate.h>
 #include <settings/servicemodel.h>


@@ -49,9 +49,9 @@
 namespace
 {
     const bool ShowDeleteDefault = false;
 namespace
 {
     const bool ShowDeleteDefault = false;

-    const char* VersionControlServicePrefix = "_version_control_";
-    const char* DeleteService = "_delete";
-    const char* CopyToMoveToService ="_copy_to_move_to";
+    const char VersionControlServicePrefix[] = "_version_control_";
+    const char DeleteService[] = "_delete";
+    const char CopyToMoveToService[] ="_copy_to_move_to";

 }
 
 ServicesSettingsPage::ServicesSettingsPage(QWidget* parent) :
 }
 
 ServicesSettingsPage::ServicesSettingsPage(QWidget* parent) :


@@ -81,7 +81,7 @@ ServicesSettingsPage::ServicesSettingsPage(QWidget* parent) :
     connect(m_listView, &QListView::clicked, this, &ServicesSettingsPage::changed);
 
     KNS3::Button* downloadButton = new KNS3::Button(i18nc("@action:button", "Download New Services..."),
     connect(m_listView, &QListView::clicked, this, &ServicesSettingsPage::changed);
 
     KNS3::Button* downloadButton = new KNS3::Button(i18nc("@action:button", "Download New Services..."),

-                                                    "servicemenu.knsrc",
+                                                    QStringLiteral("servicemenu.knsrc"),

                                                     this);
     connect(downloadButton, &KNS3::Button::dialogFinished, this, &ServicesSettingsPage::loadServices);
 
                                                     this);
     connect(downloadButton, &KNS3::Button::dialogFinished, this, &ServicesSettingsPage::loadServices);
 


@@ -103,7 +103,7 @@ void ServicesSettingsPage::applySettings()
         return;
     }
 
         return;
     }
 

-    KConfig config("kservicemenurc", KConfig::NoGlobals);
+    KConfig config(QStringLiteral("kservicemenurc"), KConfig::NoGlobals);

     KConfigGroup showGroup = config.group("Show");
 
     QStringList enabledPlugins;
     KConfigGroup showGroup = config.group("Show");
 
     QStringList enabledPlugins;


@@ -119,13 +119,13 @@ void ServicesSettingsPage::applySettings()
                 enabledPlugins.append(model->data(index, Qt::DisplayRole).toString());
             }
         } else if (service == QLatin1String(DeleteService)) {
                 enabledPlugins.append(model->data(index, Qt::DisplayRole).toString());
             }
         } else if (service == QLatin1String(DeleteService)) {

-            KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig("kdeglobals", KConfig::NoGlobals);
+            KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals);

             KConfigGroup configGroup(globalConfig, "KDE");
             configGroup.writeEntry("ShowDeleteCommand", checked);
             configGroup.sync();
         } else if (service == QLatin1String(CopyToMoveToService)) {
             GeneralSettings::setShowCopyMoveMenu(checked);
             KConfigGroup configGroup(globalConfig, "KDE");
             configGroup.writeEntry("ShowDeleteCommand", checked);
             configGroup.sync();
         } else if (service == QLatin1String(CopyToMoveToService)) {
             GeneralSettings::setShowCopyMoveMenu(checked);

-            GeneralSettings::self()->writeConfig();
+            GeneralSettings::self()->save();

         } else {
             showGroup.writeEntry(service, checked);
         }
         } else {
             showGroup.writeEntry(service, checked);
         }


@@ -135,13 +135,13 @@ void ServicesSettingsPage::applySettings()
 
     if (m_enabledVcsPlugins != enabledPlugins) {
         VersionControlSettings::setEnabledPlugins(enabledPlugins);
 
     if (m_enabledVcsPlugins != enabledPlugins) {
         VersionControlSettings::setEnabledPlugins(enabledPlugins);

-        VersionControlSettings::self()->writeConfig();
+        VersionControlSettings::self()->save();

 
         KMessageBox::information(window(),
                                  i18nc("@info", "Dolphin must be restarted to apply the "
                                                 "updated version control systems settings."),
                                  QString(), // default title
 
         KMessageBox::information(window(),
                                  i18nc("@info", "Dolphin must be restarted to apply the "
                                                 "updated version control systems settings."),
                                  QString(), // default title

-                                 QLatin1String("ShowVcsRestartInformation"));
+                                 QStringLiteral("ShowVcsRestartInformation"));

     }
 }
 
     }
 }
 


@@ -167,15 +167,15 @@ void ServicesSettingsPage::showEvent(QShowEvent* event)
         loadVersionControlSystems();
 
         // Add "Show 'Delete' command" as service
         loadVersionControlSystems();
 
         // Add "Show 'Delete' command" as service

-        KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig("kdeglobals", KConfig::IncludeGlobals);
+        KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::IncludeGlobals);

         KConfigGroup configGroup(globalConfig, "KDE");
         KConfigGroup configGroup(globalConfig, "KDE");

-        addRow("edit-delete",
+        addRow(QStringLiteral("edit-delete"),

                i18nc("@option:check", "Delete"),
                DeleteService,
                configGroup.readEntry("ShowDeleteCommand", ShowDeleteDefault));
 
         // Add "Show 'Copy To' and 'Move To' commands" as service
                i18nc("@option:check", "Delete"),
                DeleteService,
                configGroup.readEntry("ShowDeleteCommand", ShowDeleteDefault));
 
         // Add "Show 'Copy To' and 'Move To' commands" as service

-        addRow("edit-copy",
+        addRow(QStringLiteral("edit-copy"),

                i18nc("@option:check", "'Copy To' and 'Move To' commands"),
                CopyToMoveToService,
                GeneralSettings::showCopyMoveMenu());
                i18nc("@option:check", "'Copy To' and 'Move To' commands"),
                CopyToMoveToService,
                GeneralSettings::showCopyMoveMenu());


@@ -189,13 +189,13 @@ void ServicesSettingsPage::showEvent(QShowEvent* event)
 
 void ServicesSettingsPage::loadServices()
 {
 
 void ServicesSettingsPage::loadServices()
 {

-    const KConfig config("kservicemenurc", KConfig::NoGlobals);
+    const KConfig config(QStringLiteral("kservicemenurc"), KConfig::NoGlobals);

     const KConfigGroup showGroup = config.group("Show");
 
     // Load generic services
     const KConfigGroup showGroup = config.group("Show");
 
     // Load generic services

-    const KService::List entries = KServiceTypeTrader::self()->query("KonqPopupMenu/Plugin");
+    const KService::List entries = KServiceTypeTrader::self()->query(QStringLiteral("KonqPopupMenu/Plugin"));

     foreach (const KService::Ptr& service, entries) {
     foreach (const KService::Ptr& service, entries) {

-        const QString file = KStandardDirs::locate("services", service->entryPath());
+        const QString file = QStandardPaths::locate(QStandardPaths::GenericDataLocation, "kservices5/" % service->entryPath());

         const QList<KServiceAction> serviceActions =
                                     KDesktopFileActions::userDefinedServices(file, true);
 
         const QList<KServiceAction> serviceActions =
                                     KDesktopFileActions::userDefinedServices(file, true);
 


@@ -219,7 +219,7 @@ void ServicesSettingsPage::loadServices()
     }
 
     // Load service plugins that implement the KFileItemActionPlugin interface
     }
 
     // Load service plugins that implement the KFileItemActionPlugin interface

-    const KService::List pluginServices = KServiceTypeTrader::self()->query("KFileItemAction/Plugin");
+    const KService::List pluginServices = KServiceTypeTrader::self()->query(QStringLiteral("KFileItemAction/Plugin"));

     foreach (const KService::Ptr& service, pluginServices) {
         const QString desktopEntryName = service->desktopEntryName();
         if (!isInServicesList(desktopEntryName)) {
     foreach (const KService::Ptr& service, pluginServices) {
         const QString desktopEntryName = service->desktopEntryName();
         if (!isInServicesList(desktopEntryName)) {


@@ -236,10 +236,10 @@ void ServicesSettingsPage::loadVersionControlSystems()
     const QStringList enabledPlugins = VersionControlSettings::enabledPlugins();
 
     // Create a checkbox for each available version control plugin
     const QStringList enabledPlugins = VersionControlSettings::enabledPlugins();
 
     // Create a checkbox for each available version control plugin

-    const KService::List pluginServices = KServiceTypeTrader::self()->query("FileViewVersionControlPlugin");
+    const KService::List pluginServices = KServiceTypeTrader::self()->query(QStringLiteral("FileViewVersionControlPlugin"));

     for (KService::List::ConstIterator it = pluginServices.constBegin(); it != pluginServices.constEnd(); ++it) {
         const QString pluginName = (*it)->name();
     for (KService::List::ConstIterator it = pluginServices.constBegin(); it != pluginServices.constEnd(); ++it) {
         const QString pluginName = (*it)->name();

-        addRow("code-class",
+        addRow(QStringLiteral("code-class"),

                pluginName,
                VersionControlServicePrefix + pluginName,
                enabledPlugins.contains(pluginName));
                pluginName,
                VersionControlServicePrefix + pluginName,
                enabledPlugins.contains(pluginName));


@@ -273,4 +273,3 @@ void ServicesSettingsPage::addRow(const QString& icon,
     m_serviceModel->setData(index, checked, Qt::CheckStateRole);
 }
 
     m_serviceModel->setData(index, checked, Qt::CheckStateRole);
 }
 

-#include "servicessettingspage.moc"