The &-shortcut from another action is not set until the action has been shown at...

[dolphin.git] / src / views / viewproperties.cpp

diff --git a/src/views/viewproperties.cpp b/src/views/viewproperties.cpp
index 3e08358f7308cd21673ed8a659b3cc04fca8856e..d5330ffaaffa1e8bb84d4bc5f08c62bd8ef7327d 100644 (file)
--- a/src/views/viewproperties.cpp
+++ b/src/views/viewproperties.cpp
@@ -35,22 +35,33 @@
 
 #include "settings/dolphinsettings.h"
 
 
 #include "settings/dolphinsettings.h"
 

+namespace {
+    // String representation to mark the additional properties of
+    // the details view as customized by the user. See
+    // ViewProperties::additionalInfoV2() for more information.
+    const char* CustomizedDetailsString = "CustomizedDetails";
+}
+

 ViewProperties::ViewProperties(const KUrl& url) :
     m_changedProps(false),
     m_autoSave(true),
     m_node(0)
 {
 ViewProperties::ViewProperties(const KUrl& url) :
     m_changedProps(false),
     m_autoSave(true),
     m_node(0)
 {

+    GeneralSettings* settings = DolphinSettings::instance().generalSettings();
+    const bool useGlobalViewProps = settings->globalViewProps();
+

     // We try and save it to the file .directory in the directory being viewed.
     // If the directory is not writable by the user or the directory is not local,
     // we store the properties information in a local file.
     // We try and save it to the file .directory in the directory being viewed.
     // If the directory is not writable by the user or the directory is not local,
     // we store the properties information in a local file.

-    GeneralSettings* settings = DolphinSettings::instance().generalSettings();
-    const bool useGlobalViewProps = settings->globalViewProps();
-    if (useGlobalViewProps) {
+    const bool isSearchUrl = url.protocol().contains("search");
+    if (isSearchUrl) {
+        m_filePath = destinationDir("search");
+    } else if (useGlobalViewProps) {

         m_filePath = destinationDir("global");
     } else if (url.isLocalFile()) {
         m_filePath = url.toLocalFile();
         const QFileInfo info(m_filePath);
         m_filePath = destinationDir("global");
     } else if (url.isLocalFile()) {
         m_filePath = url.toLocalFile();
         const QFileInfo info(m_filePath);

-        if (!info.isWritable()) {
+        if (!info.isWritable() || !isPartOfHome(m_filePath)) {

             m_filePath = destinationDir("local") + m_filePath;
         }
     } else {
             m_filePath = destinationDir("local") + m_filePath;
         }
     } else {


@@ -60,20 +71,26 @@ ViewProperties::ViewProperties(const KUrl& url) :
     const QString file = m_filePath + QDir::separator() + QLatin1String(".directory");
     m_node = new ViewPropertySettings(KSharedConfig::openConfig(file));
 
     const QString file = m_filePath + QDir::separator() + QLatin1String(".directory");
     m_node = new ViewPropertySettings(KSharedConfig::openConfig(file));
 

-    const bool useDefaultProps = !useGlobalViewProps &&
+    // If the .directory file does not exist or the timestamp is too old,
+    // use default values instead.
+    const bool useDefaultProps = (!useGlobalViewProps || isSearchUrl) &&

                                  (!QFileInfo(file).exists() ||
                                   (m_node->timestamp() < settings->viewPropsTimestamp()));
     if (useDefaultProps) {
                                  (!QFileInfo(file).exists() ||
                                   (m_node->timestamp() < settings->viewPropsTimestamp()));
     if (useDefaultProps) {

-        // If the .directory file does not exist or the timestamp is too old,
-        // use the values from the global .directory file instead, which acts
-        // as default view for new folders in this case.
-        settings->setGlobalViewProps(true);
-
-        ViewProperties defaultProps(url);
-        setDirProperties(defaultProps);
-
-        settings->setGlobalViewProps(false);
-        m_changedProps = false;
+        if (isSearchUrl) {
+            setViewMode(DolphinView::DetailsView);
+            setAdditionalInfo(KFileItemDelegate::InformationList() << KFileItemDelegate::LocalPathOrUrl);
+        } else {
+            // The global view-properties act as default for directories without
+            // any view-property configuration
+            settings->setGlobalViewProps(true);
+
+            ViewProperties defaultProps(url);
+            setDirProperties(defaultProps);
+
+            settings->setGlobalViewProps(false);
+            m_changedProps = false;
+        }

     }
 }
 
     }
 }
 


@@ -91,7 +108,7 @@ void ViewProperties::setViewMode(DolphinView::Mode mode)
 {
     if (m_node->viewMode() != mode) {
         m_node->setViewMode(mode);
 {
     if (m_node->viewMode() != mode) {
         m_node->setViewMode(mode);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -104,7 +121,7 @@ void ViewProperties::setShowPreview(bool show)
 {
     if (m_node->showPreview() != show) {
         m_node->setShowPreview(show);
 {
     if (m_node->showPreview() != show) {
         m_node->setShowPreview(show);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -117,7 +134,7 @@ void ViewProperties::setShowHiddenFiles(bool show)
 {
     if (m_node->showHiddenFiles() != show) {
         m_node->setShowHiddenFiles(show);
 {
     if (m_node->showHiddenFiles() != show) {
         m_node->setShowHiddenFiles(show);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -125,7 +142,7 @@ void ViewProperties::setCategorizedSorting(bool categorized)
 {
     if (m_node->categorizedSorting() != categorized) {
         m_node->setCategorizedSorting(categorized);
 {
     if (m_node->categorizedSorting() != categorized) {
         m_node->setCategorizedSorting(categorized);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -143,7 +160,7 @@ void ViewProperties::setSorting(DolphinView::Sorting sorting)
 {
     if (m_node->sorting() != sorting) {
         m_node->setSorting(sorting);
 {
     if (m_node->sorting() != sorting) {
         m_node->setSorting(sorting);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -156,7 +173,7 @@ void ViewProperties::setSortOrder(Qt::SortOrder sortOrder)
 {
     if (m_node->sortOrder() != sortOrder) {
         m_node->setSortOrder(sortOrder);
 {
     if (m_node->sortOrder() != sortOrder) {
         m_node->setSortOrder(sortOrder);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -169,7 +186,7 @@ void ViewProperties::setSortFoldersFirst(bool foldersFirst)
 {
     if (m_node->sortFoldersFirst() != foldersFirst) {
         m_node->setSortFoldersFirst(foldersFirst);
 {
     if (m_node->sortFoldersFirst() != foldersFirst) {
         m_node->setSortFoldersFirst(foldersFirst);

-        updateTimeStamp();
+        update();

     }
 }
 
     }
 }
 


@@ -180,36 +197,67 @@ bool ViewProperties::sortFoldersFirst() const
 
 void ViewProperties::setAdditionalInfo(const KFileItemDelegate::InformationList& list)
 {
 
 void ViewProperties::setAdditionalInfo(const KFileItemDelegate::InformationList& list)
 {

+    // See ViewProperties::additionalInfoV2() for the storage format
+    // of the additional information.
+
+    // Remove the old values stored for the current view-mode
+    const QStringList oldInfoStringList = m_node->additionalInfoV2();
+    const QString prefix = viewModePrefix();
+    QStringList newInfoStringList = oldInfoStringList;
+    for (int i = newInfoStringList.count() - 1; i >= 0; --i) {
+        if (newInfoStringList.at(i).startsWith(prefix)) {
+            newInfoStringList.removeAt(i);
+        }
+    }
+
+    // Add the updated values for the current view-mode

     AdditionalInfoAccessor& infoAccessor = AdditionalInfoAccessor::instance();
     AdditionalInfoAccessor& infoAccessor = AdditionalInfoAccessor::instance();

+    foreach (KFileItemDelegate::Information info, list) {
+        newInfoStringList.append(prefix + infoAccessor.value(info));
+    }

 
 

-    int infoMask = 0;
-    foreach (KFileItemDelegate::Information currentInfo, list) {
-        infoMask = infoMask | infoAccessor.bitValue(currentInfo);
+    // Only update the information if it has been changed
+    bool changed = oldInfoStringList.count() != newInfoStringList.count();
+    if (!changed) {
+        foreach (const QString& oldInfoString, oldInfoStringList) {
+            if (!newInfoStringList.contains(oldInfoString)) {
+                changed = true;
+                break;
+            }
+        }

     }
 
     }
 

-    const int encodedInfo = encodedAdditionalInfo(infoMask);
-    if (m_node->additionalInfo() != encodedInfo) {
-        m_node->setAdditionalInfo(encodedInfo);
-        updateTimeStamp();
+    if (changed) {
+        if (m_node->version() < 2) {
+            m_node->setVersion(2);
+        }
+
+        const bool markCustomizedDetails = (m_node->viewMode() == DolphinView::DetailsView)
+                                           && !newInfoStringList.contains(CustomizedDetailsString);
+        if (markCustomizedDetails) {
+            // The additional information of the details-view has been modified. Set a marker,
+            // so that it is allowed to also show no additional information
+            // (see fallback in ViewProperties::additionalInfoV2, if no additional information is
+            // available).
+            newInfoStringList.append(CustomizedDetailsString);
+        }
+
+        m_node->setAdditionalInfoV2(newInfoStringList);
+        update();

     }
 }
 
 KFileItemDelegate::InformationList ViewProperties::additionalInfo() const
 {
     }
 }
 
 KFileItemDelegate::InformationList ViewProperties::additionalInfo() const
 {

-    KFileItemDelegate::InformationList usedInfos;
-
-    const int decodedInfo = decodedAdditionalInfo();
+    KFileItemDelegate::InformationList usedInfo;

 
 

-    AdditionalInfoAccessor& infoAccessor = AdditionalInfoAccessor::instance();
-    const KFileItemDelegate::InformationList infos = infoAccessor.keys();
-
-    foreach (const KFileItemDelegate::Information info, infos) {
-        if (decodedInfo & infoAccessor.bitValue(info)) {
-            usedInfos.append(info);
-        }
+    switch (m_node->version()) {
+    case 1: usedInfo = additionalInfoV1(); break;
+    case 2: usedInfo = additionalInfoV2(); break;
+    default: kWarning() << "Unknown version of the view properties";

     }
 
     }
 

-    return usedInfos;
+    return usedInfo;

 }
 
 
 }
 
 


@@ -235,10 +283,26 @@ bool ViewProperties::isAutoSaveEnabled() const
     return m_autoSave;
 }
 
     return m_autoSave;
 }
 

-void ViewProperties::updateTimeStamp()
+void ViewProperties::update()

 {
     m_changedProps = true;
     m_node->setTimestamp(QDateTime::currentDateTime());
 {
     m_changedProps = true;
     m_node->setTimestamp(QDateTime::currentDateTime());

+
+    // If the view-properties are stored in an older format, take
+    // care to update them to the current format.
+    switch (m_node->version()) {
+    case 1: {
+        const KFileItemDelegate::InformationList infoList = additionalInfoV1();
+        m_node->setVersion(2);
+        setAdditionalInfo(infoList);
+        break;
+    }
+    case 2:
+        // Current version. Nothing needs to get converted.
+        break;
+    default:
+        kWarning() << "Unknown version of the view properties";
+    }

 }
 
 void ViewProperties::save()
 }
 
 void ViewProperties::save()


@@ -262,28 +326,10 @@ QString ViewProperties::destinationDir(const QString& subDir) const
     return KStandardDirs::locateLocal("data", basePath);
 }
 
     return KStandardDirs::locateLocal("data", basePath);
 }
 

-int ViewProperties::encodedAdditionalInfo(int info) const
+KFileItemDelegate::InformationList ViewProperties::additionalInfoV1() const

 {
 {

-    int encodedInfo = m_node->additionalInfo();
-
-    switch (viewMode()) {
-    case DolphinView::DetailsView:
-        encodedInfo = (encodedInfo & 0xFFFF00) | info;
-        break;
-    case DolphinView::IconsView:
-        encodedInfo = (encodedInfo & 0xFF00FF) | (info << 8);
-        break;
-    case DolphinView::ColumnView:
-        encodedInfo = (encodedInfo & 0x00FFFF) | (info << 16);
-        break;
-    default: break;
-    }
+    KFileItemDelegate::InformationList usedInfo;

 
 

-    return encodedInfo;
-}
-
-int ViewProperties::decodedAdditionalInfo() const
-{

     int decodedInfo = m_node->additionalInfo();
 
     switch (viewMode()) {
     int decodedInfo = m_node->additionalInfo();
 
     switch (viewMode()) {


@@ -306,5 +352,96 @@ int ViewProperties::decodedAdditionalInfo() const
     default: break;
     }
 
     default: break;
     }
 

-    return decodedInfo;
+    AdditionalInfoAccessor& infoAccessor = AdditionalInfoAccessor::instance();
+    const KFileItemDelegate::InformationList infoKeys = infoAccessor.keys();
+
+    foreach (const KFileItemDelegate::Information info, infoKeys) {
+        if (decodedInfo & infoAccessor.bitValue(info)) {
+            usedInfo.append(info);
+        }
+    }
+
+    return usedInfo;
+}
+
+KFileItemDelegate::InformationList ViewProperties::additionalInfoV2() const
+{
+    // The shown additional information is stored for each view-mode separately as
+    // string with the view-mode as prefix. Example:
+    //
+    // AdditionalInfoV2=Details_Size,Details_Date,Details_Owner,Icon_Size
+    //
+    // To get the representation as KFileItemDelegate::InformationList, the current
+    // view-mode must be checked and the values of this mode added to the list.
+    //
+    // For the details-view a special case must be respected: Per default the size
+    // and date should be shown without creating a .directory file. Only if
+    // the user explictly has modified the properties of the details view (marked
+    // by "CustomizedDetails"), also a details-view with no additional information
+    // is accepted.
+
+    KFileItemDelegate::InformationList usedInfo;
+
+    // infoHash allows to get the mapped KFileItemDelegate::Information value
+    // for a stored string-value in a fast way
+    static QHash<QString, KFileItemDelegate::Information> infoHash;
+    if (infoHash.isEmpty()) {
+        AdditionalInfoAccessor& infoAccessor = AdditionalInfoAccessor::instance();
+        const KFileItemDelegate::InformationList keys = infoAccessor.keys();
+        foreach (const KFileItemDelegate::Information key, keys) {
+            infoHash.insert(infoAccessor.value(key), key);
+        }
+    }
+
+    // Iterate through all stored keys stored as strings and map them to
+    // the corresponding KFileItemDelegate::Information values.
+    const QString prefix = viewModePrefix();
+    const int prefixLength = prefix.length();
+    const QStringList infoStringList = m_node->additionalInfoV2();
+    foreach (const QString& infoString, infoStringList) {
+        if (infoString.startsWith(prefix)) {
+            const QString key = infoString.right(infoString.length() - prefixLength);
+            Q_ASSERT(infoHash.contains(key));
+            usedInfo.append(infoHash.value(key));
+        }
+    }
+
+    // For the details view the size and date should be shown per default
+    // until the additional information has been explicitly changed by the user
+    const bool useDefaultValues = usedInfo.isEmpty()
+                                  && (m_node->viewMode() == DolphinView::DetailsView)
+                                  && !infoStringList.contains(CustomizedDetailsString);
+    if (useDefaultValues) {
+        usedInfo.append(KFileItemDelegate::Size);
+        usedInfo.append(KFileItemDelegate::ModificationTime);
+    }
+
+    return usedInfo;
+}
+
+QString ViewProperties::viewModePrefix() const
+{
+    QString prefix;
+
+    switch (m_node->viewMode()) {
+    case DolphinView::DetailsView: prefix = "Details_"; break;
+    case DolphinView::IconsView:   prefix = "Icons_"; break;
+    case DolphinView::ColumnView:  prefix = "Column_"; break;
+    default: kWarning() << "Unknown view-mode of the view properties";
+    }
+
+    return prefix;
+}
+
+bool ViewProperties::isPartOfHome(const QString& filePath)
+{
+    // For performance reasons cache the path in a static QString
+    // (see QDir::homePath() for more details)
+    static QString homePath;
+    if (homePath.isEmpty()) {
+        homePath = QDir::homePath();
+        Q_ASSERT(!homePath.isEmpty());
+    }
+
+    return filePath.startsWith(homePath);

 }
 }