Move "Show in Groups" toggle action into Sort menu

[dolphin.git] / src / dolphincontextmenu.cpp

diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index 69b551493c4077bce748fb4347892740579276a9..8372060aade9a5d30fc884eccecaafc36a770ff5 100644 (file)
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -1,94 +1,86 @@
-/***************************************************************************
- *   Copyright (C) 2006 by Peter Penz (peter.penz@gmx.at) and              *
- *   Cvetoslav Ludmiloff                                                   *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
- ***************************************************************************/
+/*
+ * SPDX-FileCopyrightText: 2006 Peter Penz (peter.penz@gmx.at) and Cvetoslav Ludmiloff
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */

 
 #include "dolphincontextmenu.h"
 
 
 #include "dolphincontextmenu.h"
 

+#include "dolphin_contextmenusettings.h"
+#include "dolphin_generalsettings.h"

 #include "dolphinmainwindow.h"
 #include "dolphinmainwindow.h"

-#include "dolphinnewmenu.h"
-#include "settings/dolphinsettings.h"
-#include "dolphinview.h"
+#include "dolphinnewfilemenu.h"
+#include "dolphinplacesmodelsingleton.h"
+#include "dolphinremoveaction.h"

 #include "dolphinviewcontainer.h"
 #include "dolphinviewcontainer.h"

-#include "dolphin_generalsettings.h"
-
-#include <kactioncollection.h>
-#include <kdesktopfile.h>
-#include <kfileitemlistproperties.h>
-#include <kfileplacesmodel.h>
-#include <kglobal.h>
-#include <kiconloader.h>
-#include <kio/netaccess.h>
-#include <kmenu.h>
-#include <kmenubar.h>
-#include <kmessagebox.h>
-#include <kmimetypetrader.h>
-#include <knewmenu.h>
-#include <konqmimedata.h>
-#include <konq_operations.h>
-#include <konq_menuactions.h>
-#include <klocale.h>
-#include <kpropertiesdialog.h>
-#include <krun.h>
-#include <kstandardaction.h>
-#include <kstandarddirs.h>
-
-#include <QtGui/QApplication>
-#include <QtGui/QClipboard>
-#include <QtCore/QDir>
-
-DolphinContextMenu::DolphinContextMenu(DolphinMainWindow* parent,
-                                       const KFileItem& fileInfo,
-                                       const KUrl& baseUrl) :
-    m_mainWindow(parent),
-    m_capabilities(0),
-    m_fileInfo(fileInfo),
-    m_baseUrl(baseUrl),
-    m_context(NoContext),
-    m_copyToMenu(parent),
-    m_customActions()
+#include "global.h"
+#include "trash/dolphintrash.h"
+#include "views/dolphinview.h"
+
+#include <KActionCollection>
+#include <KFileItemListProperties>
+#include <KHamburgerMenu>
+#include <KIO/EmptyTrashJob>
+#include <KIO/JobUiDelegate>
+#include <KIO/Paste>
+#include <KIO/RestoreJob>
+#include <KJobWidgets>
+#include <KLocalizedString>
+#include <KNewFileMenu>
+#include <KStandardAction>
+
+#include <QApplication>
+#include <QClipboard>
+#include <QKeyEvent>
+#include <QAction>
+
+DolphinContextMenu::DolphinContextMenu(DolphinMainWindow *parent,
+                                       const KFileItem &fileInfo,
+                                       const KFileItemList &selectedItems,
+                                       const QUrl &baseUrl,
+                                       KFileItemActions *fileItemActions)
+    : QMenu(parent)
+    , m_mainWindow(parent)
+    , m_fileInfo(fileInfo)
+    , m_baseUrl(baseUrl)
+    , m_baseFileItem(nullptr)
+    , m_selectedItems(selectedItems)
+    , m_selectedItemsProperties(nullptr)
+    , m_context(NoContext)
+    , m_copyToMenu(parent)
+    , m_removeAction(nullptr)
+    , m_fileItemActions(fileItemActions)

 {
 {

-    // The context menu either accesses the URLs of the selected items
-    // or the items itself. To increase the performance both lists are cached.
-    DolphinView* view = m_mainWindow->activeViewContainer()->view();
-    m_selectedUrls = view->selectedUrls();
-    m_selectedItems = view->selectedItems();
+    QApplication::instance()->installEventFilter(this);
+
+    addAllActions();

 }
 
 DolphinContextMenu::~DolphinContextMenu()
 {
 }
 
 DolphinContextMenu::~DolphinContextMenu()
 {

-    delete m_capabilities;
-    m_capabilities = 0;
+    delete m_baseFileItem;
+    m_baseFileItem = nullptr;
+    delete m_selectedItemsProperties;
+    m_selectedItemsProperties = nullptr;

 }
 
 }
 

-void DolphinContextMenu::setCustomActions(const QList<QAction*>& actions)
+void DolphinContextMenu::addAllActions()

 {
 {

-    m_customActions = actions;
-}
+    static_cast<KHamburgerMenu *>(m_mainWindow->actionCollection()->action(QStringLiteral("hamburger_menu")))->addToMenu(this);

 
 

-void DolphinContextMenu::open()
-{

     // get the context information
     // get the context information

-    if (m_baseUrl.protocol() == "trash") {
+    const auto scheme = m_baseUrl.scheme();
+    if (scheme == QLatin1String("trash")) {

         m_context |= TrashContext;
         m_context |= TrashContext;

+    } else if (scheme.contains(QLatin1String("search"))) {
+        m_context |= SearchContext;
+    } else if (scheme.contains(QLatin1String("timeline"))) {
+        m_context |= TimelineContext;
+    } else if (scheme == QStringLiteral("recentlyused")) {
+        m_context |= RecentlyUsedContext;

     }
 
     }
 

-    if (!m_fileInfo.isNull() && (m_selectedItems.count() > 0)) {
+    if (!m_fileInfo.isNull() && !m_selectedItems.isEmpty()) {

         m_context |= ItemContext;
         // TODO: handle other use cases like devices + desktop files
     }
         m_context |= ItemContext;
         // TODO: handle other use cases like devices + desktop files
     }


@@ -96,310 +88,426 @@ void DolphinContextMenu::open()
     // open the corresponding popup for the context
     if (m_context & TrashContext) {
         if (m_context & ItemContext) {
     // open the corresponding popup for the context
     if (m_context & TrashContext) {
         if (m_context & ItemContext) {

-            openTrashItemContextMenu();
+            addTrashItemContextMenu();

         } else {
         } else {

-            openTrashContextMenu();
+            addTrashContextMenu();

         }
     } else if (m_context & ItemContext) {
         }
     } else if (m_context & ItemContext) {

-        openItemContextMenu();
+        addItemContextMenu();

     } else {
     } else {

-        Q_ASSERT(m_context == NoContext);
-        openViewportContextMenu();
+        addViewportContextMenu();

     }
 }
 
     }
 }
 

-void DolphinContextMenu::openTrashContextMenu()
+bool DolphinContextMenu::eventFilter(QObject *object, QEvent *event)

 {
 {

-    Q_ASSERT(m_context & TrashContext);
-
-    KMenu* popup = new KMenu(m_mainWindow);
+    Q_UNUSED(object)

 
 

-    addShowMenubarAction(popup);
+    if (event->type() == QEvent::KeyPress || event->type() == QEvent::KeyRelease) {
+        QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

 
 

-    QAction* emptyTrashAction = new QAction(KIcon("trash-empty"), i18nc("@action:inmenu", "Empty Trash"), popup);
-    KConfig trashConfig("trashrc", KConfig::SimpleConfig);
-    emptyTrashAction->setEnabled(!trashConfig.group("Status").readEntry("Empty", true));
-    popup->addAction(emptyTrashAction);
+        if (m_removeAction && keyEvent->key() == Qt::Key_Shift) {
+            if (event->type() == QEvent::KeyPress) {
+                m_removeAction->update(DolphinRemoveAction::ShiftState::Pressed);
+            } else {
+                m_removeAction->update(DolphinRemoveAction::ShiftState::Released);
+            }
+        }
+    }

 
 

-    QAction* addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
-                                                  i18nc("@action:inmenu Add current folder to places", "Add to Places"));
+    return false;
+}

 
 

-    addCustomActions(popup);
+void DolphinContextMenu::addTrashContextMenu()
+{
+    Q_ASSERT(m_context & TrashContext);

 
 

-    QAction* propertiesAction = m_mainWindow->actionCollection()->action("properties");
-    popup->addAction(propertiesAction);
+    QAction *emptyTrashAction = addAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18nc("@action:inmenu", "Empty Trash"), [this]() {
+        Trash::empty(m_mainWindow);
+    });
+    emptyTrashAction->setEnabled(!Trash::isEmpty());

 
 

-    QAction *action = popup->exec(QCursor::pos());
-    if (action == emptyTrashAction) {
-        const QString text(i18nc("@info", "Do you really want to empty the Trash? All items will be deleted."));
-        const bool del = KMessageBox::warningContinueCancel(m_mainWindow,
-                                                            text,
-                                                            QString(),
-                                                            KGuiItem(i18nc("@action:button", "Empty Trash"),
-                                                                     KIcon("user-trash"))
-                                                           ) == KMessageBox::Continue;
-        if (del) {
-            KonqOperations::emptyTrash(m_mainWindow);
-        }
-    } else if (action == addToPlacesAction) {
-        const KUrl& url = m_mainWindow->activeViewContainer()->url();
-        if (url.isValid()) {
-            DolphinSettings::instance().placesModel()->addPlace(i18nc("@label", "Trash"), url);
-        }
+    // Insert 'Sort By' and 'View Mode'
+    if (ContextMenuSettings::showSortBy() || ContextMenuSettings::showViewMode()) {
+        addSeparator();
+    }
+    if (ContextMenuSettings::showSortBy()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("sort")));
+    }
+    if (ContextMenuSettings::showViewMode()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("view_mode")));

     }
 
     }
 

-    popup->deleteLater();
+    addSeparator();
+    QAction *propertiesAction = m_mainWindow->actionCollection()->action(QStringLiteral("properties"));
+    addAction(propertiesAction);

 }
 
 }
 

-void DolphinContextMenu::openTrashItemContextMenu()
+void DolphinContextMenu::addTrashItemContextMenu()

 {
     Q_ASSERT(m_context & TrashContext);
     Q_ASSERT(m_context & ItemContext);
 
 {
     Q_ASSERT(m_context & TrashContext);
     Q_ASSERT(m_context & ItemContext);
 

-    KMenu* popup = new KMenu(m_mainWindow);
+    addAction(QIcon::fromTheme(QStringLiteral("edit-reset")),
+              i18ncp("@action:inmenu Restore the selected files that are in the trash to the place they lived at the moment they were trashed. Minimize the "
+                     "length of this string if possible.",
+                     "Restore to Former Location",
+                     "Restore to Former Locations",
+                     m_selectedItems.count()),
+              [this]() {
+                  QList<QUrl> selectedUrls;
+                  selectedUrls.reserve(m_selectedItems.count());
+                  for (const KFileItem &item : std::as_const(m_selectedItems)) {
+                      selectedUrls.append(item.url());
+                  }

 
 

-    addShowMenubarAction(popup);
+                  KIO::RestoreJob *job = KIO::restoreFromTrash(selectedUrls);
+                  KJobWidgets::setWindow(job, m_mainWindow);
+                  job->uiDelegate()->setAutoErrorHandlingEnabled(true);
+              });

 
 

-    QAction* restoreAction = new QAction(i18nc("@action:inmenu", "Restore"), m_mainWindow);
-    popup->addAction(restoreAction);
+    addSeparator();

 
 

-    QAction* deleteAction = m_mainWindow->actionCollection()->action("delete");
-    popup->addAction(deleteAction);
+    addAction(m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Cut)));
+    addAction(m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Copy)));

 
 

-    QAction* propertiesAction = m_mainWindow->actionCollection()->action("properties");
-    popup->addAction(propertiesAction);
+    addSeparator();

 
 

-    if (popup->exec(QCursor::pos()) == restoreAction) {
-        KonqOperations::restoreTrashedItems(m_selectedUrls, m_mainWindow);
-    }
+    QAction *deleteAction = m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::DeleteFile));
+    addAction(deleteAction);
+
+    addSeparator();

 
 

-    popup->deleteLater();
+    addAction(m_mainWindow->actionCollection()->action(QStringLiteral("properties")));

 }
 
 }
 

-void DolphinContextMenu::openItemContextMenu()
+void DolphinContextMenu::addDirectoryItemContextMenu()

 {
 {

-    Q_ASSERT(!m_fileInfo.isNull());
+    // insert 'Open in new window' and 'Open in new tab' entries
+    const KFileItemListProperties &selectedItemsProps = selectedItemsProperties();
+    if (ContextMenuSettings::showOpenInNewTab()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("open_in_new_tab")));
+    }
+    if (ContextMenuSettings::showOpenInNewWindow()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("open_in_new_window")));
+    }

 
 

-    KMenu* popup = new KMenu(m_mainWindow);
-    if (m_fileInfo.isDir() && (m_selectedUrls.count() == 1)) {
-        // setup 'Create New' menu
-        DolphinNewMenu* newMenu = new DolphinNewMenu(popup, m_mainWindow);
-        newMenu->slotCheckUpToDate();
-        newMenu->setPopupFiles(m_fileInfo.url());
-        newMenu->setEnabled(capabilities().supportsWriting());
-
-        KMenu* menu = newMenu->menu();
-        menu->setTitle(i18nc("@title:menu Create new folder, file, link, etc.", "Create New"));
-        menu->setIcon(KIcon("document-new"));
-        popup->addMenu(newMenu->menu());
-        popup->addSeparator();
-
-        // insert 'Open in new window' and 'Open in new tab' entries
-        popup->addAction(m_mainWindow->actionCollection()->action("open_in_new_window"));
-        popup->addAction(m_mainWindow->actionCollection()->action("open_in_new_tab"));
-        popup->addSeparator();
+    if (ContextMenuSettings::showOpenInSplitView()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("open_in_split_view")));

     }
     }

-    addShowMenubarAction(popup);
-    insertDefaultItemActions(popup);

 
 

-    popup->addSeparator();
+    // Insert 'Open With' entries
+    addOpenWithActions();
+
+    // set up 'Create New' menu
+    QAction *newDirAction = m_mainWindow->actionCollection()->action(QStringLiteral("create_dir"));
+    QAction *newFileAction = m_mainWindow->actionCollection()->action(QStringLiteral("create_file"));
+    DolphinNewFileMenu *newFileMenu = new DolphinNewFileMenu(newDirAction, newFileAction, m_mainWindow);
+    newFileMenu->checkUpToDate();
+    newFileMenu->setWorkingDirectory(m_fileInfo.url());
+    newFileMenu->setEnabled(selectedItemsProps.supportsWriting());
+    connect(newFileMenu, &DolphinNewFileMenu::fileCreated, newFileMenu, &DolphinNewFileMenu::deleteLater);
+    connect(newFileMenu, &DolphinNewFileMenu::directoryCreated, newFileMenu, &DolphinNewFileMenu::deleteLater);
+
+    QMenu *menu = newFileMenu->menu();
+    menu->setTitle(i18nc("@title:menu Create new folder, file, link, etc.", "Create New"));
+    menu->setIcon(QIcon::fromTheme(QStringLiteral("list-add")));
+    addMenu(menu);
+
+    addSeparator();
+}

 
 

-    // insert 'Bookmark This Folder' entry if exactly one item is selected
-    QAction* addToPlacesAction = 0;
-    if (m_fileInfo.isDir() && (m_selectedUrls.count() == 1)) {
-        addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
-                                             i18nc("@action:inmenu Add selected folder to places", "Add to Places"));
-    }
+void DolphinContextMenu::addOpenParentFolderActions()
+{
+    addAction(QIcon::fromTheme(QStringLiteral("document-open-folder")), i18nc("@action:inmenu", "Open Path"), [this]() {
+        const QUrl url = m_fileInfo.targetUrl();
+        const QUrl parentUrl = KIO::upUrl(url);
+        m_mainWindow->changeUrl(parentUrl);
+        m_mainWindow->activeViewContainer()->view()->markUrlsAsSelected({url});
+        m_mainWindow->activeViewContainer()->view()->markUrlAsCurrent(url);
+    });
+
+    addAction(QIcon::fromTheme(QStringLiteral("tab-new")), i18nc("@action:inmenu", "Open Path in New Tab"), [this]() {
+        const QUrl url = m_fileInfo.targetUrl();
+        const QUrl parentUrl = KIO::upUrl(url);
+        DolphinTabPage *tabPage = m_mainWindow->openNewTab(parentUrl);
+        tabPage->activeViewContainer()->view()->markUrlsAsSelected({url});
+        tabPage->activeViewContainer()->view()->markUrlAsCurrent(url);
+    });
+
+    addAction(QIcon::fromTheme(QStringLiteral("window-new")), i18nc("@action:inmenu", "Open Path in New Window"), [this]() {
+        Dolphin::openNewWindow({m_fileInfo.targetUrl()}, m_mainWindow, Dolphin::OpenNewWindowFlag::Select);
+    });
+}
+
+void DolphinContextMenu::addItemContextMenu()
+{
+    Q_ASSERT(!m_fileInfo.isNull());

 
 

-    KonqMenuActions menuActions;
-    menuActions.setParentWidget(m_mainWindow);
-    menuActions.setItemListProperties(m_selectedItems);
+    const KFileItemListProperties &selectedItemsProps = selectedItemsProperties();

 
 

-    // insert 'Open With...' action or sub menu
-    menuActions.addOpenWithActionsTo(popup, "DesktopEntryName != 'dolphin'");
+    m_fileItemActions->setItemListProperties(selectedItemsProps);

 
 

-    // insert 'Actions' sub menu
-    if (menuActions.addActionsTo(popup)) {
-        popup->addSeparator();
-    }
+    if (m_selectedItems.count() == 1) {
+        // single files
+        if (m_fileInfo.isDir()) {
+            addDirectoryItemContextMenu();
+        } else if (m_context & TimelineContext || m_context & SearchContext || m_context & RecentlyUsedContext) {
+            addOpenWithActions();
+
+            addOpenParentFolderActions();
+
+            addSeparator();
+        } else {
+            // Insert 'Open With" entries
+            addOpenWithActions();
+        }
+        if (m_fileInfo.isLink()) {
+            addAction(m_mainWindow->actionCollection()->action(QStringLiteral("show_target")));
+            addSeparator();
+        }
+    } else {
+        // multiple files
+        bool selectionHasOnlyDirs = true;
+        for (const auto &item : std::as_const(m_selectedItems)) {
+            const QUrl &url = DolphinView::openItemAsFolderUrl(item);
+            if (url.isEmpty()) {
+                selectionHasOnlyDirs = false;
+                break;
+            }
+        }

 
 

-    // insert revision control actions
-    DolphinView* view = m_mainWindow->activeViewContainer()->view();
-    const QList<QAction*> revControlActions = view->revisionControlActions(m_selectedItems);
-    if (revControlActions.count() > 0) {
-        foreach (QAction* action, revControlActions) {
-            popup->addAction(action);
+        if (selectionHasOnlyDirs && ContextMenuSettings::showOpenInNewTab()) {
+            // insert 'Open in new tab' entry
+            addAction(m_mainWindow->actionCollection()->action(QStringLiteral("open_in_new_tabs")));

         }
         }

-        popup->addSeparator();
+        // Insert 'Open With" entries
+        addOpenWithActions();

     }
 
     }
 

+    insertDefaultItemActions(selectedItemsProps);
+
+    addAdditionalActions(selectedItemsProps);
+

     // insert 'Copy To' and 'Move To' sub menus
     // insert 'Copy To' and 'Move To' sub menus

-    if (DolphinSettings::instance().generalSettings()->showCopyMoveMenu()) {
-        m_copyToMenu.setItems(m_selectedItems);
-        m_copyToMenu.setReadOnly(!capabilities().supportsWriting());
-        m_copyToMenu.addActionsTo(popup);
-        popup->addSeparator();
+    if (ContextMenuSettings::showCopyMoveMenu()) {
+        m_copyToMenu.setUrls(m_selectedItems.urlList());
+        m_copyToMenu.setReadOnly(!selectedItemsProps.supportsWriting());
+        m_copyToMenu.setAutoErrorHandlingEnabled(true);
+        m_copyToMenu.addActionsTo(this);

     }
 
     }
 

-    // insert 'Properties...' entry
-    QAction* propertiesAction = m_mainWindow->actionCollection()->action("properties");
-    popup->addAction(propertiesAction);
-
-    QAction* activatedAction = popup->exec(QCursor::pos());
+    if (m_mainWindow->isSplitViewEnabledInCurrentTab()) {
+        if (ContextMenuSettings::showCopyToOtherSplitView()) {
+            addAction(m_mainWindow->actionCollection()->action(QStringLiteral("copy_to_inactive_split_view")));
+        }

 
 

-    if ((addToPlacesAction != 0) && (activatedAction == addToPlacesAction)) {
-        const KUrl selectedUrl(m_fileInfo.url());
-        if (selectedUrl.isValid()) {
-            DolphinSettings::instance().placesModel()->addPlace(placesName(selectedUrl),
-                                                                selectedUrl);
+        if (ContextMenuSettings::showMoveToOtherSplitView()) {
+            addAction(m_mainWindow->actionCollection()->action(QStringLiteral("move_to_inactive_split_view")));

         }
     }
 
         }
     }
 

-    popup->deleteLater();
+    // insert 'Properties...' entry
+    addSeparator();
+    QAction *propertiesAction = m_mainWindow->actionCollection()->action(QStringLiteral("properties"));
+    addAction(propertiesAction);

 }
 
 }
 

-void DolphinContextMenu::openViewportContextMenu()
+void DolphinContextMenu::addViewportContextMenu()

 {
 {

-    KMenu* popup = new KMenu(m_mainWindow);
-
-    addShowMenubarAction(popup);
+    const KFileItemListProperties baseUrlProperties(KFileItemList() << baseFileItem());
+    m_fileItemActions->setItemListProperties(baseUrlProperties);
+
+    // Set up and insert 'Create New' menu
+    KNewFileMenu *newFileMenu = m_mainWindow->newFileMenu();
+    newFileMenu->checkUpToDate();
+    newFileMenu->setWorkingDirectory(m_baseUrl);
+    addMenu(newFileMenu->menu());
+
+    // Show "open with" menu items even if the dir is empty, because there are legitimate
+    // use cases for this, such as opening an empty dir in Kate or VSCode or something
+    addOpenWithActions();
+
+    QAction *pasteAction = createPasteAction();
+    if (pasteAction) {
+        addAction(pasteAction);
+    }

 
 

-    // setup 'Create New' menu
-    KNewMenu* newMenu = m_mainWindow->newMenu();
-    newMenu->slotCheckUpToDate();
-    newMenu->setPopupFiles(m_baseUrl);
-    popup->addMenu(newMenu->menu());
-    popup->addSeparator();
+    // Insert 'Add to Places' entry if it's not already in the places panel
+    if (ContextMenuSettings::showAddToPlaces() && !placeExists(m_mainWindow->activeViewContainer()->url())) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("add_to_places")));
+    }
+    addSeparator();

 
 

-    QAction* pasteAction = createPasteAction();
-    popup->addAction(pasteAction);
+    // Insert 'Sort By' and 'View Mode'
+    if (ContextMenuSettings::showSortBy()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("sort")));
+    }
+    if (ContextMenuSettings::showViewMode()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("view_mode")));
+    }
+    if (ContextMenuSettings::showSortBy() || ContextMenuSettings::showViewMode()) {
+        addSeparator();
+    }

 
 

-    // setup 'View Mode' menu
-    KMenu* viewModeMenu = new KMenu(i18nc("@title:menu", "View Mode"));
+    addAdditionalActions(baseUrlProperties);

 
 

-    QAction* iconsMode = m_mainWindow->actionCollection()->action("icons");
-    viewModeMenu->addAction(iconsMode);
+    addSeparator();

 
 

-    QAction* detailsMode = m_mainWindow->actionCollection()->action("details");
-    viewModeMenu->addAction(detailsMode);
+    QAction *propertiesAction = m_mainWindow->actionCollection()->action(QStringLiteral("properties"));
+    addAction(propertiesAction);
+}

 
 

-    QAction* columnsMode = m_mainWindow->actionCollection()->action("columns");
-    viewModeMenu->addAction(columnsMode);
+void DolphinContextMenu::insertDefaultItemActions(const KFileItemListProperties &properties)
+{
+    const KActionCollection *collection = m_mainWindow->actionCollection();
+
+    // Insert 'Cut', 'Copy', 'Copy Location' and 'Paste'
+    addAction(collection->action(KStandardAction::name(KStandardAction::Cut)));
+    addAction(collection->action(KStandardAction::name(KStandardAction::Copy)));
+    if (ContextMenuSettings::showCopyLocation()) {
+        QAction *copyPathAction = collection->action(QStringLiteral("copy_location"));
+        copyPathAction->setEnabled(m_selectedItems.size() == 1);
+        addAction(copyPathAction);
+    }
+    QAction *pasteAction = createPasteAction();
+    if (pasteAction) {
+        addAction(pasteAction);
+    }

 
 

-    popup->addMenu(viewModeMenu);
+    // Insert 'Duplicate Here'
+    if (ContextMenuSettings::showDuplicateHere()) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("duplicate")));
+    }

 
 

-    popup->addSeparator();
+    // Insert 'Rename'
+    addAction(collection->action(KStandardAction::name(KStandardAction::RenameFile)));

 
 

-    QAction* addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
-                                                  i18nc("@action:inmenu Add current folder to places", "Add to Places"));
+    // Insert 'Add to Places' entry if appropriate
+    if (ContextMenuSettings::showAddToPlaces() && m_selectedItems.count() == 1 && m_fileInfo.isDir() && !placeExists(m_fileInfo.url())) {
+        addAction(m_mainWindow->actionCollection()->action(QStringLiteral("add_to_places")));
+    }

 
 

-    addCustomActions(popup);
+    addSeparator();

 
 

-    QAction* propertiesAction = popup->addAction(i18nc("@action:inmenu", "Properties"));
-    propertiesAction->setIcon(KIcon("document-properties"));
-    QAction* action = popup->exec(QCursor::pos());
-    if (action == propertiesAction) {
-        const KUrl& url = m_mainWindow->activeViewContainer()->url();
+    // Insert 'Move to Trash' and/or 'Delete'
+    const bool showDeleteAction = (KSharedConfig::openConfig()->group(QStringLiteral("KDE")).readEntry("ShowDeleteCommand", false) || !properties.isLocal());
+    const bool showMoveToTrashAction = (properties.isLocal() && properties.supportsMoving());

 
 

-        KPropertiesDialog* dialog = new KPropertiesDialog(url, m_mainWindow);
-        dialog->setAttribute(Qt::WA_DeleteOnClose);
-        dialog->show();
-    } else if (action == addToPlacesAction) {
-        const KUrl& url = m_mainWindow->activeViewContainer()->url();
-        if (url.isValid()) {
-            DolphinSettings::instance().placesModel()->addPlace(placesName(url), url);
+    if (showDeleteAction && showMoveToTrashAction) {
+        delete m_removeAction;
+        m_removeAction = nullptr;
+        addAction(m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::MoveToTrash)));
+        addAction(m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::DeleteFile)));
+    } else if (showDeleteAction && !showMoveToTrashAction) {
+        addAction(m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::DeleteFile)));
+    } else {
+        if (!m_removeAction) {
+            m_removeAction = new DolphinRemoveAction(this, m_mainWindow->actionCollection());

         }
         }

+        addAction(m_removeAction);
+        m_removeAction->update();

     }
     }

+}

 
 

-    popup->deleteLater();
+bool DolphinContextMenu::placeExists(const QUrl &url) const
+{
+    const KFilePlacesModel *placesModel = DolphinPlacesModelSingleton::instance().placesModel();
+
+    QModelIndex url_index = placesModel->closestItem(url);
+    return url_index.isValid() && placesModel->url(url_index).matches(url, QUrl::StripTrailingSlash);

 }
 
 }
 

-void DolphinContextMenu::insertDefaultItemActions(KMenu* popup)
+QAction *DolphinContextMenu::createPasteAction()

 {
 {

-    Q_ASSERT(popup != 0);
-    const KActionCollection* collection = m_mainWindow->actionCollection();
-
-    // insert 'Cut', 'Copy' and 'Paste'
-    QAction* cutAction = collection->action(KStandardAction::name(KStandardAction::Cut));
-    QAction* copyAction  = collection->action(KStandardAction::name(KStandardAction::Copy));
-    QAction* pasteAction = createPasteAction();
-
-    popup->addAction(cutAction);
-    popup->addAction(copyAction);
-    popup->addAction(pasteAction);
-    popup->addSeparator();
-
-    // insert 'Rename'
-    QAction* renameAction = collection->action("rename");
-    popup->addAction(renameAction);
-
-    // insert 'Move to Trash' and (optionally) 'Delete'
-    KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig("kdeglobals", KConfig::IncludeGlobals);
-    KConfigGroup configGroup(globalConfig, "KDE");
-    bool showDeleteCommand = configGroup.readEntry("ShowDeleteCommand", false);
-
-    const KUrl& url = m_mainWindow->activeViewContainer()->url();
-    if (url.isLocalFile()) {
-        QAction* moveToTrashAction = collection->action("move_to_trash");
-        popup->addAction(moveToTrashAction);
+    QAction *action = nullptr;
+    KFileItem destItem;
+    if (!m_fileInfo.isNull() && m_selectedItems.count() <= 1) {
+        destItem = m_fileInfo;

     } else {
     } else {

-        showDeleteCommand = true;
+        destItem = baseFileItem();

     }
 
     }
 

-    if (showDeleteCommand) {
-        QAction* deleteAction = collection->action("delete");
-        popup->addAction(deleteAction);
+    if (!destItem.isNull() && destItem.isDir()) {
+        const QMimeData *mimeData = QApplication::clipboard()->mimeData();
+        bool canPaste;
+        const QString text = KIO::pasteActionText(mimeData, &canPaste, destItem);
+        if (canPaste) {
+            if (destItem == m_fileInfo) {
+                // if paste destination is a selected folder
+                action = new QAction(QIcon::fromTheme(QStringLiteral("edit-paste")), text, this);
+                connect(action, &QAction::triggered, m_mainWindow, &DolphinMainWindow::pasteIntoFolder);
+            } else {
+                action = m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Paste));
+            }
+        }

     }
     }

-}

 
 

-void DolphinContextMenu::addShowMenubarAction(KMenu* menu)
-{
-    KAction* showMenuBar = m_mainWindow->showMenuBarAction();
-    if (!m_mainWindow->menuBar()->isVisible()) {
-        menu->addAction(showMenuBar);
-        menu->addSeparator();
-    }
+    return action;

 }
 
 }
 

-QString DolphinContextMenu::placesName(const KUrl& url) const
+KFileItemListProperties &DolphinContextMenu::selectedItemsProperties() const

 {
 {

-    QString name = url.fileName();
-    if (name.isEmpty()) {
-        name = url.host();
+    if (!m_selectedItemsProperties) {
+        m_selectedItemsProperties = new KFileItemListProperties(m_selectedItems);

     }
     }

-    return name;
+    return *m_selectedItemsProperties;

 }
 
 }
 

-QAction* DolphinContextMenu::createPasteAction()
+KFileItem DolphinContextMenu::baseFileItem()

 {
 {

-    QAction* action = 0;
-    const bool isDir = !m_fileInfo.isNull() && m_fileInfo.isDir();
-    if (isDir && (m_selectedItems.count() == 1)) {
-        action = new QAction(KIcon("edit-paste"), i18nc("@action:inmenu", "Paste Into Folder"), this);
-        const QMimeData* mimeData = QApplication::clipboard()->mimeData();
-        const KUrl::List pasteData = KUrl::List::fromMimeData(mimeData);
-        action->setEnabled(!pasteData.isEmpty() && capabilities().supportsWriting());
-        connect(action, SIGNAL(triggered()), m_mainWindow, SLOT(pasteIntoFolder()));
-    } else {
-        action = m_mainWindow->actionCollection()->action(KStandardAction::name(KStandardAction::Paste));
+    if (!m_baseFileItem) {
+        const DolphinView *view = m_mainWindow->activeViewContainer()->view();
+        KFileItem baseItem = view->rootItem();
+        if (baseItem.isNull() || baseItem.url() != m_baseUrl) {
+            m_baseFileItem = new KFileItem(m_baseUrl);
+        } else {
+            m_baseFileItem = new KFileItem(baseItem);
+        }

     }
     }

-
-    return action;
+    return *m_baseFileItem;

 }
 
 }
 

-KFileItemListProperties& DolphinContextMenu::capabilities()
+void DolphinContextMenu::addOpenWithActions()

 {
 {

-    if (m_capabilities == 0) {
-        m_capabilities = new KFileItemListProperties(m_selectedItems);
+    // insert 'Open With...' action or sub menu
+    m_fileItemActions->insertOpenWithActionsTo(nullptr, this, QStringList{qApp->desktopFileName()});
+
+    // For a single file, hint in "Open with" menu that middle-clicking would open it in the secondary app.
+    // (Unless middle-clicking would open it as a folder in a new tab (e.g. archives).)
+    const QUrl &url = DolphinView::openItemAsFolderUrl(m_fileInfo, GeneralSettings::browseThroughArchives());
+    if (m_selectedItems.count() == 1 && url.isEmpty()) {
+        if (QAction *openWithSubMenu = findChild<QAction *>(QStringLiteral("openWith_submenu"))) {
+            Q_ASSERT(openWithSubMenu->menu());
+            Q_ASSERT(!openWithSubMenu->menu()->isEmpty());
+
+            auto *secondaryApp = openWithSubMenu->menu()->actions().first();
+            // Add it like a keyboard shortcut, Qt uses \t as a separator.
+            if (!secondaryApp->text().contains(QLatin1Char('\t'))) {
+                secondaryApp->setText(secondaryApp->text() + QLatin1Char('\t')
+                                      + i18nc("@action:inmenu Shortcut, middle click to trigger menu item, keep short", "Middle Click"));
+            }
+        }

     }
     }

-    return *m_capabilities;

 }
 
 }
 

-void DolphinContextMenu::addCustomActions(KMenu* menu)
+void DolphinContextMenu::addAdditionalActions(const KFileItemListProperties &props)

 {
 {

-    foreach (QAction* action, m_customActions) {
-        menu->addAction(action);
+    addSeparator();
+
+    QList<QAction *> additionalActions;
+    if (props.isLocal() && ContextMenuSettings::showOpenTerminal()) {
+        additionalActions << m_mainWindow->actionCollection()->action(QStringLiteral("open_terminal_here"));
+    }
+    m_fileItemActions->addActionsTo(this, KFileItemActions::MenuActionSource::All, additionalActions);
+
+    const DolphinView *view = m_mainWindow->activeViewContainer()->view();
+    const QList<QAction *> versionControlActions = view->versionControlActions(m_selectedItems);
+    if (!versionControlActions.isEmpty()) {
+        addSeparator();
+        addActions(versionControlActions);
+        addSeparator();

     }
 }
 
     }
 }
 

-#include "dolphincontextmenu.moc"
+#include "moc_dolphincontextmenu.cpp"