use "Sort by" instead of "Sort By"

[dolphin.git] / src / dolphinview.cpp

diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp
index 6177643358409d56371d5c59c91a2ef5e591511a..7339b82272f37cf6653045323aa5c4ce98748aea 100644 (file)
--- a/src/dolphinview.cpp
+++ b/src/dolphinview.cpp
@@ -28,10 +28,10 @@
 #include <QTimer>
 #include <QScrollBar>
 
 #include <QTimer>
 #include <QScrollBar>
 

+#include <kcolorscheme.h>

 #include <kdirmodel.h>
 #include <kdirlister.h>
 #include <kfileitemdelegate.h>
 #include <kdirmodel.h>
 #include <kdirlister.h>
 #include <kfileitemdelegate.h>

-#include <kglobalsettings.h>

 #include <klocale.h>
 #include <kiconeffect.h>
 #include <kio/netaccess.h>
 #include <klocale.h>
 #include <kiconeffect.h>
 #include <kio/netaccess.h>


@@ -57,14 +57,12 @@ DolphinView::DolphinView(QWidget* parent,
                          const KUrl& url,
                          KDirLister* dirLister,
                          KDirModel* dirModel,
                          const KUrl& url,
                          KDirLister* dirLister,
                          KDirModel* dirModel,

-                         DolphinSortFilterProxyModel* proxyModel,
-                         Mode mode,
-                         bool showHiddenFiles) :
+                         DolphinSortFilterProxyModel* proxyModel) :

     QWidget(parent),
     m_active(true),
     QWidget(parent),
     m_active(true),

-    m_blockContentsMovedSignal(false),
+    m_loadingDirectory(false),

     m_initializeColumnView(false),
     m_initializeColumnView(false),

-    m_mode(mode),
+    m_mode(DolphinView::IconsView),

     m_topLayout(0),
     m_controller(0),
     m_iconsView(0),
     m_topLayout(0),
     m_controller(0),
     m_iconsView(0),


@@ -84,15 +82,15 @@ DolphinView::DolphinView(QWidget* parent,
     connect(clipboard, SIGNAL(dataChanged()),
             this, SLOT(updateCutItems()));
 
     connect(clipboard, SIGNAL(dataChanged()),
             this, SLOT(updateCutItems()));
 

-    connect(m_dirLister, SIGNAL(completed()),
-            this, SLOT(restoreContentsPos()));

     connect(m_dirLister, SIGNAL(completed()),
             this, SLOT(updateCutItems()));
     connect(m_dirLister, SIGNAL(completed()),
             this, SLOT(updateCutItems()));

-    connect(m_dirLister, SIGNAL(newItems(const KFileItemList&)),
-            this, SLOT(generatePreviews(const KFileItemList&)));
+    connect(m_dirLister, SIGNAL(newItems(const QList<KFileItem>&)),
+            this, SLOT(generatePreviews(const QList<KFileItem>&)));

 
     m_controller = new DolphinController(this);
     m_controller->setUrl(url);
 
     m_controller = new DolphinController(this);
     m_controller->setUrl(url);

+    connect(m_controller, SIGNAL(urlChanged(const KUrl&)),
+            this, SIGNAL(urlChanged(const KUrl&)));

     connect(m_controller, SIGNAL(requestContextMenu(const QPoint&)),
             this, SLOT(openContextMenu(const QPoint&)));
     connect(m_controller, SIGNAL(urlsDropped(const KUrl::List&, const QModelIndex&, QWidget*)),
     connect(m_controller, SIGNAL(requestContextMenu(const QPoint&)),
             this, SLOT(openContextMenu(const QPoint&)));
     connect(m_controller, SIGNAL(urlsDropped(const KUrl::List&, const QModelIndex&, QWidget*)),


@@ -110,7 +108,7 @@ DolphinView::DolphinView(QWidget* parent,
     connect(m_controller, SIGNAL(viewportEntered()),
             this, SLOT(clearHoverInformation()));
 
     connect(m_controller, SIGNAL(viewportEntered()),
             this, SLOT(clearHoverInformation()));
 

-    createView();
+    applyViewProperties(url);

     m_topLayout->addWidget(itemView());
 }
 
     m_topLayout->addWidget(itemView());
 }
 


@@ -136,19 +134,7 @@ void DolphinView::setActive(bool active)
 
     m_active = active;
 
 
     m_active = active;
 

-    QColor color = KGlobalSettings::baseColor();
-    if (active) {
-        emit urlChanged(url());
-        emit selectionChanged(selectedItems());
-    } else {
-        color.setAlpha(0);
-    }
-
-    QWidget* viewport = itemView()->viewport();
-    QPalette palette;
-    palette.setColor(viewport->backgroundRole(), color);
-    viewport->setPalette(palette);
-
+    updateViewportColor();

     update();
 
     if (active) {
     update();
 
     if (active) {


@@ -174,16 +160,16 @@ void DolphinView::setMode(Mode mode)
         // to go back to the root URL of the column view automatically.
         // Otherwise there it would not be possible to turn off the column view
         // without focusing the first column.
         // to go back to the root URL of the column view automatically.
         // Otherwise there it would not be possible to turn off the column view
         // without focusing the first column.

-        // TODO: reactivate again after DolphinView/DolphinViewController split works
-        //setUrl(m_dirLister->url());
-        //m_controller->setUrl(m_dirLister->url());
+        setUrl(m_dirLister->url());
+        m_controller->setUrl(m_dirLister->url());

     }
 
     }
 

-    ViewProperties props(url());
+    const KUrl viewPropsUrl = viewPropertiesUrl();
+    ViewProperties props(viewPropsUrl);

     props.setViewMode(m_mode);
 
     createView();
     props.setViewMode(m_mode);
 
     createView();

-    startDirLister(url());
+    startDirLister(viewPropsUrl);

 
     emit modeChanged();
 }
 
     emit modeChanged();
 }


@@ -195,13 +181,14 @@ DolphinView::Mode DolphinView::mode() const
 
 void DolphinView::setShowPreview(bool show)
 {
 
 void DolphinView::setShowPreview(bool show)
 {

-    ViewProperties props(url());
+    const KUrl viewPropsUrl = viewPropertiesUrl();
+    ViewProperties props(viewPropsUrl);

     props.setShowPreview(show);
 
     m_controller->setShowPreview(show);
     emit showPreviewChanged();
 
     props.setShowPreview(show);
 
     m_controller->setShowPreview(show);
     emit showPreviewChanged();
 

-    startDirLister(url(), true);
+    startDirLister(viewPropsUrl, true);

 }
 
 bool DolphinView::showPreview() const
 }
 
 bool DolphinView::showPreview() const


@@ -215,13 +202,14 @@ void DolphinView::setShowHiddenFiles(bool show)
         return;
     }
 
         return;
     }
 

-    ViewProperties props(url());
+    const KUrl viewPropsUrl = viewPropertiesUrl();
+    ViewProperties props(viewPropsUrl);

     props.setShowHiddenFiles(show);
 
     m_dirLister->setShowingDotFiles(show);
     emit showHiddenFilesChanged();
 
     props.setShowHiddenFiles(show);
 
     m_dirLister->setShowingDotFiles(show);
     emit showHiddenFilesChanged();
 

-    startDirLister(url(), true);
+    startDirLister(viewPropsUrl, true);

 }
 
 bool DolphinView::showHiddenFiles() const
 }
 
 bool DolphinView::showHiddenFiles() const


@@ -245,7 +233,7 @@ void DolphinView::setCategorizedSorting(bool categorized)
         delete categorizer;
     }
 
         delete categorizer;
     }
 

-    ViewProperties props(url());
+    ViewProperties props(viewPropertiesUrl());

     props.setCategorizedSorting(categorized);
     props.save();
 
     props.setCategorizedSorting(categorized);
     props.save();
 


@@ -269,22 +257,92 @@ bool DolphinView::supportsCategorizedSorting() const
 
 void DolphinView::selectAll()
 {
 
 void DolphinView::selectAll()
 {

-    selectAll(QItemSelectionModel::Select);
+    itemView()->selectAll();

 }
 
 void DolphinView::invertSelection()
 {
 }
 
 void DolphinView::invertSelection()
 {

-    selectAll(QItemSelectionModel::Toggle);
+    if (isColumnViewActive()) {
+        // In opposite to QAbstractItemView::selectAll() there is no virtual method
+        // for adjusting the invertion of a selection. As the generic approach by using
+        // the selection model does not work for the column view, we delegate this task:
+        m_columnView->invertSelection();
+    } else {
+        QItemSelectionModel* selectionModel = itemView()->selectionModel();
+        const QAbstractItemModel* itemModel = selectionModel->model();
+
+        const QModelIndex topLeft = itemModel->index(0, 0);
+        const QModelIndex bottomRight = itemModel->index(itemModel->rowCount() - 1,
+                                                         itemModel->columnCount() - 1);
+
+        QItemSelection selection(topLeft, bottomRight);
+        selectionModel->select(selection, QItemSelectionModel::Toggle);
+    }

 }
 
 }
 

-int DolphinView::contentsX() const
+bool DolphinView::hasSelection() const

 {
 {

-    return itemView()->horizontalScrollBar()->value();
+    return itemView()->selectionModel()->hasSelection();

 }
 
 }
 

-int DolphinView::contentsY() const
+void DolphinView::clearSelection()

 {
 {

-    return itemView()->verticalScrollBar()->value();
+    itemView()->selectionModel()->clear();
+}
+
+QList<KFileItem> DolphinView::selectedItems() const
+{
+    const QAbstractItemView* view = itemView();
+
+    // Our view has a selection, we will map them back to the DirModel
+    // and then fill the KFileItemList.
+    Q_ASSERT((view != 0) && (view->selectionModel() != 0));
+
+    const QItemSelection selection = m_proxyModel->mapSelectionToSource(view->selectionModel()->selection());
+    QList<KFileItem> itemList;
+
+    const QModelIndexList indexList = selection.indexes();
+    foreach (QModelIndex index, indexList) {
+        KFileItem item = m_dirModel->itemForIndex(index);
+        if (!item.isNull()) {
+            itemList.append(item);
+        }
+    }
+
+    return itemList;
+}
+
+KUrl::List DolphinView::selectedUrls() const
+{
+    KUrl::List urls;
+    const QList<KFileItem> list = selectedItems();
+    for ( QList<KFileItem>::const_iterator it = list.begin(), end = list.end();
+          it != end; ++it ) {
+        urls.append((*it).url());
+    }
+    return urls;
+}
+
+KFileItem DolphinView::fileItem(const QModelIndex& index) const
+{
+    const QModelIndex dirModelIndex = m_proxyModel->mapToSource(index);
+    return m_dirModel->itemForIndex(dirModelIndex);
+}
+
+void DolphinView::setContentsPosition(int x, int y)
+{
+    QAbstractItemView* view = itemView();
+    view->horizontalScrollBar()->setValue(x);
+    view->verticalScrollBar()->setValue(y);
+
+    m_loadingDirectory = false;
+}
+
+QPoint DolphinView::contentsPosition() const
+{
+    const int x = itemView()->horizontalScrollBar()->value();
+    const int y = itemView()->verticalScrollBar()->value();
+    return QPoint(x, y);

 }
 
 void DolphinView::zoomIn()
 }
 
 void DolphinView::zoomIn()


@@ -333,14 +391,15 @@ Qt::SortOrder DolphinView::sortOrder() const
 
 void DolphinView::setAdditionalInfo(KFileItemDelegate::AdditionalInformation info)
 {
 
 void DolphinView::setAdditionalInfo(KFileItemDelegate::AdditionalInformation info)
 {

-    ViewProperties props(url());
+    const KUrl viewPropsUrl = viewPropertiesUrl();
+    ViewProperties props(viewPropsUrl);

     props.setAdditionalInfo(info);
 
     m_controller->setShowAdditionalInfo(info != KFileItemDelegate::NoInformation);
     m_fileItemDelegate->setAdditionalInformation(info);
 
     emit additionalInfoChanged(info);
     props.setAdditionalInfo(info);
 
     m_controller->setShowAdditionalInfo(info != KFileItemDelegate::NoInformation);
     m_fileItemDelegate->setAdditionalInformation(info);
 
     emit additionalInfoChanged(info);

-    startDirLister(url(), true);
+    startDirLister(viewPropsUrl, true);

 }
 
 KFileItemDelegate::AdditionalInformation DolphinView::additionalInfo() const
 }
 
 KFileItemDelegate::AdditionalInformation DolphinView::additionalInfo() const


@@ -348,73 +407,31 @@ KFileItemDelegate::AdditionalInformation DolphinView::additionalInfo() const
     return m_fileItemDelegate->additionalInformation();
 }
 
     return m_fileItemDelegate->additionalInformation();
 }
 

-bool DolphinView::hasSelection() const
-{
-    return itemView()->selectionModel()->hasSelection();
-}
-
-void DolphinView::clearSelection()
+void DolphinView::reload()

 {
 {

-    itemView()->selectionModel()->clear();
+    setUrl(url());
+    startDirLister(url(), true);

 }
 
 }
 

-KFileItemList DolphinView::selectedItems() const
+void DolphinView::refresh()

 {
 {

-    const QAbstractItemView* view = itemView();
-
-    // Our view has a selection, we will map them back to the DirModel
-    // and then fill the KFileItemList.
-    Q_ASSERT((view != 0) && (view->selectionModel() != 0));
-
-    const QItemSelection selection = m_proxyModel->mapSelectionToSource(view->selectionModel()->selection());
-    KFileItemList itemList;
-
-    const QModelIndexList indexList = selection.indexes();
-    QModelIndexList::const_iterator end = indexList.end();
-    for (QModelIndexList::const_iterator it = indexList.begin(); it != end; ++it) {
-        Q_ASSERT((*it).isValid());
-
-        KFileItem* item = m_dirModel->itemForIndex(*it);
-        if (item != 0) {
-            itemList.append(item);
-        }
-    }
-
-    return itemList;
+    createView();
+    applyViewProperties(m_controller->url());
+    reload();
+    updateViewportColor();

 }
 
 }
 

-KUrl::List DolphinView::selectedUrls() const
+void DolphinView::setUrl(const KUrl& url)

 {
 {

-    KUrl::List urls;
-
-    const KFileItemList list = selectedItems();
-    KFileItemList::const_iterator it = list.begin();
-    const KFileItemList::const_iterator end = list.end();
-    while (it != end) {
-        KFileItem* item = *it;
-        urls.append(item->url());
-        ++it;
+    if (m_controller->url() == url) {
+        return;

     }
 
     }
 

-    return urls;
-}
+    m_controller->setUrl(url); // emits urlChanged, which we forward

 
 

-KFileItem* DolphinView::fileItem(const QModelIndex index) const
-{
-    const QModelIndex dirModelIndex = m_proxyModel->mapToSource(index);
-    return m_dirModel->itemForIndex(dirModelIndex);
-}
+    applyViewProperties(url);

 
 

-void DolphinView::reload()
-{
-    setUrl(url());
-    startDirLister(url(), true);
-}
-
-void DolphinView::refresh()
-{
-    createView();
-    reload();
+    startDirLister(url);

 }
 
 void DolphinView::mouseReleaseEvent(QMouseEvent* event)
 }
 
 void DolphinView::mouseReleaseEvent(QMouseEvent* event)


@@ -429,11 +446,7 @@ void DolphinView::activate()
 
 void DolphinView::triggerItem(const QModelIndex& index)
 {
 
 void DolphinView::triggerItem(const QModelIndex& index)
 {

-    if (!isValidNameIndex(index)) {
-        clearSelection();
-        showHoverInformation(index);
-        return;
-    }
+    Q_ASSERT(index.isValid());

 
     const Qt::KeyboardModifiers modifier = QApplication::keyboardModifiers();
     if ((modifier & Qt::ShiftModifier) || (modifier & Qt::ControlModifier)) {
 
     const Qt::KeyboardModifiers modifier = QApplication::keyboardModifiers();
     if ((modifier & Qt::ShiftModifier) || (modifier & Qt::ControlModifier)) {


@@ -442,57 +455,18 @@ void DolphinView::triggerItem(const QModelIndex& index)
         return;
     }
 
         return;
     }
 

-    KFileItem* item = m_dirModel->itemForIndex(m_proxyModel->mapToSource(index));
-    if (item == 0) {
+    const KFileItem item = m_dirModel->itemForIndex(m_proxyModel->mapToSource(index));
+    if (item.isNull()) {

         return;
     }
 
         return;
     }
 

-    // Prefer the local path over the URL. This assures that the
-    // volume space information is correct. Assuming that the URL is media:/sda1,
-    // and the local path is /windows/C: For the URL the space info is related
-    // to the root partition (and hence wrong) and for the local path the space
-    // info is related to the windows partition (-> correct).
-    const QString localPath(item->localPath());
-    KUrl url;
-    if (localPath.isEmpty()) {
-        url = item->url();
-    } else {
-        url = localPath;
-    }
-
-    if (item->isDir()) {
-        setUrl(url);
-    } else if (item->isFile()) {
-        // allow to browse through ZIP and tar files
-        KMimeType::Ptr mime = item->mimeTypePtr();
-        if (mime->is("application/zip")) {
-            url.setProtocol("zip");
-            setUrl(url);
-        } else if (mime->is("application/x-tar") ||
-                   mime->is("application/x-tarz") ||
-                   mime->is("application/x-bzip-compressed-tar") ||
-                   mime->is("application/x-compressed-tar") ||
-                   mime->is("application/x-tzo")) {
-            url.setProtocol("tar");
-            setUrl(url);
-        } else {
-            item->run();
-        }
-    } else {
-        item->run();
-    }
+    emit itemTriggered(item); // caught by DolphinViewContainer or DolphinPart

 }
 
 }
 

-void DolphinView::generatePreviews(const KFileItemList& items)
+void DolphinView::generatePreviews(const QList<KFileItem>& items)

 {
     if (m_controller->showPreview()) {
 {
     if (m_controller->showPreview()) {

-
-        // Must turn QList<KFileItem *> to QList<KFileItem>...
-        QList<KFileItem> itemsToPreview;
-        foreach( KFileItem* it, items )
-            itemsToPreview.append( *it );
-
-        KIO::PreviewJob* job = KIO::filePreview(itemsToPreview, 128);
+        KIO::PreviewJob* job = KIO::filePreview(items, 128);

         connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
                 this, SLOT(showPreview(const KFileItem&, const QPixmap&)));
     }
         connect(job, SIGNAL(gotPreview(const KFileItem&, const QPixmap&)),
                 this, SLOT(showPreview(const KFileItem&, const QPixmap&)));
     }


@@ -520,20 +494,6 @@ void DolphinView::showPreview(const KFileItem& item, const QPixmap& pixmap)
     }
 }
 
     }
 }
 

-void DolphinView::restoreContentsPos()
-{
-    m_blockContentsMovedSignal = false;
-    if (!url().isEmpty()) {
-        QAbstractItemView* view = itemView();
-        // TODO #1: view->setCurrentItem(m_urlNavigator->currentFileName());
-        // TODO #2: temporary deactivated due to DolphinView/DolphinViewController split
-        //QPoint pos = m_urlNavigator->savedPosition();
-        QPoint pos(0, 0);
-        view->horizontalScrollBar()->setValue(pos.x());
-        view->verticalScrollBar()->setValue(pos.y());
-    }
-}
-

 void DolphinView::emitSelectionChangedSignal()
 {
     emit selectionChanged(DolphinView::selectedItems());
 void DolphinView::emitSelectionChangedSignal()
 {
     emit selectionChanged(DolphinView::selectedItems());


@@ -542,33 +502,18 @@ void DolphinView::emitSelectionChangedSignal()
 void DolphinView::startDirLister(const KUrl& url, bool reload)
 {
     if (!url.isValid()) {
 void DolphinView::startDirLister(const KUrl& url, bool reload)
 {
     if (!url.isValid()) {

-        // TODO: temporary deactivated due to DolphinView/DolphinViewController split
-
-        //const QString location(url.pathOrUrl());
-        //if (location.isEmpty()) {
-        //    m_statusBar->setMessage(i18n("The location is empty."), DolphinStatusBar::Error);
-        //} else {
-        //    m_statusBar->setMessage(i18n("The location '%1' is invalid.", location),
-        //                            DolphinStatusBar::Error);
-        //}
+        const QString location(url.pathOrUrl());
+        if (location.isEmpty()) {
+            emit errorMessage(i18nc("@info:status", "The location is empty."));
+        } else {
+            emit errorMessage(i18nc("@info:status", "The location '%1' is invalid.", location));
+        }

         return;
     }
 
         return;
     }
 

-    // Only show the directory loading progress if the status bar does
-    // not contain another progress information. This means that
-    // the directory loading progress information has the lowest priority.
-
-    // TODO: temporary deactivated due to DolphinView/DolphinViewController split
-    //const QString progressText(m_statusBar->progressText());
-    //m_showProgress = progressText.isEmpty() ||
-    //                 (progressText == i18n("Loading folder..."));
-    //if (m_showProgress) {
-    //    m_statusBar->setProgressText(i18n("Loading folder..."));
-    //    m_statusBar->setProgress(0);
-    //}
-

     m_cutItemsCache.clear();
     m_cutItemsCache.clear();

-    m_blockContentsMovedSignal = true;
+    m_loadingDirectory = true;
+

     m_dirLister->stop();
 
     bool openDir = true;
     m_dirLister->stop();
 
     bool openDir = true;


@@ -597,7 +542,7 @@ void DolphinView::startDirLister(const KUrl& url, bool reload)
             const KUrl& dirListerUrl = m_dirLister->url();
             if ((dirListerUrl == url) || !m_dirLister->url().isParentOf(url)) {
                 // The current URL is not a child of the dir lister
             const KUrl& dirListerUrl = m_dirLister->url();
             if ((dirListerUrl == url) || !m_dirLister->url().isParentOf(url)) {
                 // The current URL is not a child of the dir lister

-                // URL. This may happen when e. g. a bookmark has been selected
+                // URL. This may happen when e. g. a place has been selected

                 // and hence the view must be reset.
                 keepOldDirs = false;
             }
                 // and hence the view must be reset.
                 keepOldDirs = false;
             }


@@ -609,27 +554,28 @@ void DolphinView::startDirLister(const KUrl& url, bool reload)
     }
 }
 
     }
 }
 

-void DolphinView::setUrl(const KUrl& url)
+KUrl DolphinView::viewPropertiesUrl() const

 {
 {

-    if (m_controller->url() == url) {
-        return;
+    if (isColumnViewActive()) {
+        return m_dirLister->url();

     }
 
     }
 

-    m_controller->setUrl(url);
+    return url();
+}
+
+void DolphinView::applyViewProperties(const KUrl& url)
+{
+    if (isColumnViewActive() && m_dirLister->url().isParentOf(url)) {
+        // The column view is active, hence don't apply the view properties
+        // of sub directories (represented by columns) to the view. The
+        // view always represents the properties of the first column.
+        return;
+    }

 
     const ViewProperties props(url);
 
     const Mode mode = props.viewMode();
 
     const ViewProperties props(url);
 
     const Mode mode = props.viewMode();

-    bool changeMode = (m_mode != mode);
-    if (changeMode && isColumnViewActive()) {
-        // The column view is active. Only change the
-        // mode if the current URL is no child of the column view.
-        if (m_dirLister->url().isParentOf(url)) {
-            changeMode = false;
-        }
-    }
-
-    if (changeMode) {
+    if (m_mode != mode) {

         m_mode = mode;
         createView();
         emit modeChanged();
         m_mode = mode;
         createView();
         emit modeChanged();


@@ -642,6 +588,11 @@ void DolphinView::setUrl(const KUrl& url)
             m_initializeColumnView = true;
         }
     }
             m_initializeColumnView = true;
         }
     }

+    if (itemView() == 0) {
+        createView();
+    }
+    Q_ASSERT(itemView() != 0);
+    Q_ASSERT(m_fileItemDelegate != 0);

 
     const bool showHiddenFiles = props.showHiddenFiles();
     if (showHiddenFiles != m_dirLister->showingDotFiles()) {
 
     const bool showHiddenFiles = props.showHiddenFiles();
     if (showHiddenFiles != m_dirLister->showingDotFiles()) {


@@ -689,15 +640,9 @@ void DolphinView::setUrl(const KUrl& url)
         m_controller->setShowPreview(showPreview);
         emit showPreviewChanged();
     }
         m_controller->setShowPreview(showPreview);
         emit showPreviewChanged();
     }

-
-    startDirLister(url);
-    emit urlChanged(url);
-
-    // TODO: temporary deactivated due to DolphinView/DolphinViewController split
-    //m_statusBar->clear();

 }
 
 }
 

-void DolphinView::changeSelection(const KFileItemList& selection)
+void DolphinView::changeSelection(const QList<KFileItem>& selection)

 {
     clearSelection();
     if (selection.isEmpty()) {
 {
     clearSelection();
     if (selection.isEmpty()) {


@@ -706,10 +651,10 @@ void DolphinView::changeSelection(const KFileItemList& selection)
     const KUrl& baseUrl = url();
     KUrl url;
     QItemSelection new_selection;
     const KUrl& baseUrl = url();
     KUrl url;
     QItemSelection new_selection;

-    foreach(KFileItem* item, selection) {
-        url = item->url().upUrl();
+    foreach(const KFileItem& item, selection) {
+        url = item.url().upUrl();

         if (baseUrl.equals(url, KUrl::CompareWithoutTrailingSlash)) {
         if (baseUrl.equals(url, KUrl::CompareWithoutTrailingSlash)) {

-            QModelIndex index = m_proxyModel->mapFromSource(m_dirModel->indexForItem(*item));
+            QModelIndex index = m_proxyModel->mapFromSource(m_dirModel->indexForItem(item));

             new_selection.select(index, index);
         }
     }
             new_selection.select(index, index);
         }
     }


@@ -720,7 +665,7 @@ void DolphinView::changeSelection(const KFileItemList& selection)
 
 void DolphinView::openContextMenu(const QPoint& pos)
 {
 
 void DolphinView::openContextMenu(const QPoint& pos)
 {

-    KFileItem* item = 0;
+    KFileItem item;

 
     const QModelIndex index = itemView()->indexAt(pos);
     if (isValidNameIndex(index)) {
 
     const QModelIndex index = itemView()->indexAt(pos);
     if (isValidNameIndex(index)) {


@@ -734,24 +679,24 @@ void DolphinView::dropUrls(const KUrl::List& urls,
                            const QModelIndex& index,
                            QWidget* source)
 {
                            const QModelIndex& index,
                            QWidget* source)
 {

-    KFileItem* directory = 0;
+    KFileItem directory;

     if (isValidNameIndex(index)) {
     if (isValidNameIndex(index)) {

-        KFileItem* item = fileItem(index);
-        Q_ASSERT(item != 0);
-        if (item->isDir()) {
+        KFileItem item = fileItem(index);
+        Q_ASSERT(!item.isNull());
+        if (item.isDir()) {

             // the URLs are dropped above a directory
             directory = item;
         }
     }
 
             // the URLs are dropped above a directory
             directory = item;
         }
     }
 

-    if ((directory == 0) && (source == itemView())) {
+    if ((directory.isNull()) && (source == itemView())) {

         // The dropping is done into the same viewport where
         // the dragging has been started. Just ignore this...
         return;
     }
 
         // The dropping is done into the same viewport where
         // the dragging has been started. Just ignore this...
         return;
     }
 

-    const KUrl& destination = (directory == 0) ?
-                              url() : directory->url();
+    const KUrl& destination = (directory.isNull()) ?
+                              url() : directory.url();

     dropUrls(urls, destination);
 }
 
     dropUrls(urls, destination);
 }
 


@@ -763,7 +708,7 @@ void DolphinView::dropUrls(const KUrl::List& urls,
 
 void DolphinView::updateSorting(DolphinView::Sorting sorting)
 {
 
 void DolphinView::updateSorting(DolphinView::Sorting sorting)
 {

-    ViewProperties props(url());
+    ViewProperties props(viewPropertiesUrl());

     props.setSorting(sorting);
 
     m_proxyModel->setSorting(sorting);
     props.setSorting(sorting);
 
     m_proxyModel->setSorting(sorting);


@@ -773,7 +718,7 @@ void DolphinView::updateSorting(DolphinView::Sorting sorting)
 
 void DolphinView::updateSortOrder(Qt::SortOrder order)
 {
 
 void DolphinView::updateSortOrder(Qt::SortOrder order)
 {

-    ViewProperties props(url());
+    ViewProperties props(viewPropertiesUrl());

     props.setSortOrder(order);
 
     m_proxyModel->setSortOrder(order);
     props.setSortOrder(order);
 
     m_proxyModel->setSortOrder(order);


@@ -783,8 +728,14 @@ void DolphinView::updateSortOrder(Qt::SortOrder order)
 
 void DolphinView::emitContentsMoved()
 {
 
 void DolphinView::emitContentsMoved()
 {

-    if (!m_blockContentsMovedSignal) {
-        emit contentsMoved(contentsX(), contentsY());
+    // only emit the contents moved signal if:
+    // - no directory loading is ongoing (this would reset the contents position
+    //   always to (0, 0))
+    // - if the Column View is active: the column view does an automatic
+    //   positioning during the loading operation, which must be remembered
+    if (!m_loadingDirectory || isColumnViewActive()) {
+        const QPoint pos(contentsPosition());
+        emit contentsMoved(pos.x(), pos.y());

     }
 }
 
     }
 }
 


@@ -813,19 +764,15 @@ void DolphinView::showHoverInformation(const QModelIndex& index)
         return;
     }
 
         return;
     }
 

-    const KFileItem* item = fileItem(index);
-    if (item != 0) {
-        // TODO: temporary deactivated due to DolphinView/DolphinViewController split
-        //m_statusBar->setMessage(item->getStatusBarInfo(), DolphinStatusBar::Default);
-        emit requestItemInfo(item->url());
+    const KFileItem item = fileItem(index);
+    if (!item.isNull()) {
+        emit requestItemInfo(item);

     }
 }
 
 void DolphinView::clearHoverInformation()
 {
     }
 }
 
 void DolphinView::clearHoverInformation()
 {

-    // TODO: temporary deactivated due to DolphinView/DolphinViewController split
-    //m_statusBar->clear();
-    emit requestItemInfo(KUrl());
+    emit requestItemInfo(KFileItem());

 }
 
 
 }
 
 


@@ -890,19 +837,6 @@ void DolphinView::createView()
             this, SLOT(emitContentsMoved()));
 }
 
             this, SLOT(emitContentsMoved()));
 }
 

-void DolphinView::selectAll(QItemSelectionModel::SelectionFlags flags)
-{
-    QItemSelectionModel* selectionModel = itemView()->selectionModel();
-    const QAbstractItemModel* itemModel = selectionModel->model();
-
-    const QModelIndex topLeft = itemModel->index(0, 0);
-    const QModelIndex bottomRight = itemModel->index(itemModel->rowCount() - 1,
-                                    itemModel->columnCount() - 1);
-
-    QItemSelection selection(topLeft, bottomRight);
-    selectionModel->select(selection, flags);
-}
-

 QAbstractItemView* DolphinView::itemView() const
 {
     if (m_detailsView != 0) {
 QAbstractItemView* DolphinView::itemView() const
 {
     if (m_detailsView != 0) {


@@ -951,9 +885,10 @@ void DolphinView::applyCutItemEffect()
         KFileItem* item = *it;
         if (isCutItem(*item)) {
             const QModelIndex index = m_dirModel->indexForItem(*item);
         KFileItem* item = *it;
         if (isCutItem(*item)) {
             const QModelIndex index = m_dirModel->indexForItem(*item);

-            const KFileItem* item = m_dirModel->itemForIndex(index);
+            // Huh? the item is already known
+            //const KFileItem item = m_dirModel->itemForIndex(index);

             const QVariant value = m_dirModel->data(index, Qt::DecorationRole);
             const QVariant value = m_dirModel->data(index, Qt::DecorationRole);

-            if ((value.type() == QVariant::Icon) && (item != 0)) {
+            if (value.type() == QVariant::Icon) {

                 const QIcon icon(qvariant_cast<QIcon>(value));
                 QPixmap pixmap = icon.pixmap(128, 128);
 
                 const QIcon icon(qvariant_cast<QIcon>(value));
                 QPixmap pixmap = icon.pixmap(128, 128);
 


@@ -974,4 +909,20 @@ void DolphinView::applyCutItemEffect()
     }
 }
 
     }
 }
 

+void DolphinView::updateViewportColor()
+{
+    QColor color = KColorScheme(KColorScheme::View).background();
+    if (m_active) {
+        emit urlChanged(url()); // Hmm, this is a hack; the url hasn't really changed.
+        emit selectionChanged(selectedItems());
+    } else {
+        color.setAlpha(0);
+    }
+
+    QWidget* viewport = itemView()->viewport();
+    QPalette palette;
+    palette.setColor(viewport->backgroundRole(), color);
+    viewport->setPalette(palette);
+}
+

 #include "dolphinview.moc"
 #include "dolphinview.moc"