lessons learned from the column view: never invoke KDirModel::expandToUrl() when...

[dolphin.git] / src / dolphindetailsview.cpp

diff --git a/src/dolphindetailsview.cpp b/src/dolphindetailsview.cpp
index defe93192fc6cc377405fd1253f3ea4368fcbb95..2eca0860cc90c3601661c677eab2d1cf0969c9dc 100644 (file)
--- a/src/dolphindetailsview.cpp
+++ b/src/dolphindetailsview.cpp
@@ -52,6 +52,11 @@ DolphinDetailsView::DolphinDetailsView(QWidget* parent, DolphinController* contr
     setDragDropMode(QAbstractItemView::DragDrop);
     setDropIndicatorShown(false);
     setAlternatingRowColors(true);
+    // TODO: enable ScrollPerPixel again as soon as a Qt-patch
+    // is supplied which fixes a possible crash
+    // (see http://lists.kde.org/?l=kde-core-devel&m=119077433611662&w=2)
+    //setHorizontalScrollMode(QAbstractItemView::ScrollPerPixel);
+    //setVerticalScrollMode(QAbstractItemView::ScrollPerPixel);
 
     setMouseTracking(true);
     viewport()->setAttribute(Qt::WA_Hover);
@@ -139,6 +144,9 @@ bool DolphinDetailsView::event(QEvent* event)
         if (!settings->showType()) {
             hideColumn(DolphinModel::Type);
         }
+
+        hideColumn(DolphinModel::Rating);
+        hideColumn(DolphinModel::Tags);
     }
 
     return QTreeView::event(event);
@@ -241,6 +249,7 @@ void DolphinDetailsView::dropEvent(QDropEvent* event)
     if (!urls.isEmpty()) {
         event->acceptProposedAction();
         m_controller->indicateDroppedUrls(urls,
+                                          m_controller->url(),
                                           indexAt(event->pos()),
                                           event->source());
     }