include cleanup

[dolphin.git] / src / dolphinmainwindow.cpp

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 2057c05d5ba6b8aa05bc24d2d3da683d3c19fe80..d84775d59dadeb42edcc8fe13ebcd86cefaa7571 100644 (file)
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -30,6 +30,7 @@
 #include "infosidebarpage.h"
 #include "metadatawidget.h"
 #include "mainwindowadaptor.h"
+#include "terminalsidebarpage.h"
 #include "treeviewsidebarpage.h"
 #include "kurlnavigator.h"
 #include "viewpropertiesdialog.h"
@@ -67,17 +68,17 @@
 #include <kstandardaction.h>
 #include <kurl.h>
 
-#include <QCloseEvent>
-#include <QClipboard>
-#include <QSplitter>
-#include <QDockWidget>
+#include <QtGui/QKeyEvent>
+#include <QtGui/QClipboard>
+#include <QtGui/QSplitter>
+#include <QtGui/QDockWidget>
 
 DolphinMainWindow::DolphinMainWindow(int id) :
-        KXmlGuiWindow(0),
-        m_newMenu(0),
-        m_splitter(0),
-        m_activeView(0),
-        m_id(id)
+    KXmlGuiWindow(0),
+    m_newMenu(0),
+    m_splitter(0),
+    m_activeView(0),
+    m_id(id)
 {
     setObjectName("Dolphin");
     m_view[PrimaryIdx] = 0;
@@ -813,7 +814,7 @@ void DolphinMainWindow::toggleShowHiddenFiles()
     m_activeView->setShowHiddenFiles(show);
 }
 
-void DolphinMainWindow::showFilterBar()
+void DolphinMainWindow::toggleFilterBarVisibility()
 {
     const KToggleAction* showFilterBarAction =
         static_cast<KToggleAction*>(actionCollection()->action("show_filter_bar"));
@@ -879,18 +880,9 @@ void DolphinMainWindow::goHome()
     m_activeView->goHome();
 }
 
-void DolphinMainWindow::openTerminal()
-{
-    QString command("konsole --workdir \"");
-    command.append(m_activeView->url().path());
-    command.append('\"');
-
-    KRun::runCommand(command, "Konsole", "konsole");
-}
-
 void DolphinMainWindow::findFile()
 {
-    KRun::run("kfind", m_activeView->url());
+    KRun::run("kfind", m_activeView->url(), this);
 }
 
 void DolphinMainWindow::compareFiles()
@@ -944,13 +936,14 @@ void DolphinMainWindow::compareFiles()
     command.append("\" \"");
     command.append(urlB.pathOrUrl());
     command.append('\"');
-    KRun::runCommand(command, "Kompare", "kompare");
+    KRun::runCommand(command, "Kompare", "kompare", this);
 
 }
 
 void DolphinMainWindow::editSettings()
 {
-    DolphinSettingsDialog::instance(this).exec();
+    DolphinSettingsDialog dialog(this);
+    dialog.exec();
 }
 
 void DolphinMainWindow::init()
@@ -1236,12 +1229,6 @@ void DolphinMainWindow::setupActions()
     KStandardAction::home(this, SLOT(goHome()), actionCollection());
 
     // setup 'Tools' menu
-    QAction* openTerminal = actionCollection()->addAction("open_terminal");
-    openTerminal->setText(i18n("Open Terminal"));
-    openTerminal->setShortcut(Qt::Key_F4);
-    openTerminal->setIcon(KIcon("konsole"));
-    connect(openTerminal, SIGNAL(triggered()), this, SLOT(openTerminal()));
-
     QAction* findFile = actionCollection()->addAction("find_file");
     findFile->setText(i18n("Find File..."));
     findFile->setShortcut(Qt::CTRL | Qt::Key_F);
@@ -1250,8 +1237,8 @@ void DolphinMainWindow::setupActions()
 
     KToggleAction* showFilterBar = actionCollection()->add<KToggleAction>("show_filter_bar");
     showFilterBar->setText(i18n("Show Filter Bar"));
-    showFilterBar->setShortcut(Qt::Key_Slash);
-    connect(showFilterBar, SIGNAL(triggered()), this, SLOT(showFilterBar()));
+    showFilterBar->setShortcut(Qt::CTRL | Qt::Key_I);
+    connect(showFilterBar, SIGNAL(triggered()), this, SLOT(toggleFilterBarVisibility()));
 
     QAction* compareFiles = actionCollection()->addAction("compare_files");
     compareFiles->setText(i18n("Compare Files"));
@@ -1272,7 +1259,7 @@ void DolphinMainWindow::setupDockWidgets()
     SidebarPage* infoWidget = new InfoSidebarPage(infoDock);
     infoDock->setWidget(infoWidget);
 
-    infoDock->toggleViewAction()->setText(i18n("Show Information Panel"));
+    infoDock->toggleViewAction()->setText(i18n("Information"));
     actionCollection()->addAction("show_info_panel", infoDock->toggleViewAction());
 
     addDockWidget(Qt::RightDockWidgetArea, infoDock);
@@ -1288,7 +1275,7 @@ void DolphinMainWindow::setupDockWidgets()
     TreeViewSidebarPage* treeWidget = new TreeViewSidebarPage(treeViewDock);
     treeViewDock->setWidget(treeWidget);
 
-    treeViewDock->toggleViewAction()->setText(i18n("Show Folders Panel"));
+    treeViewDock->toggleViewAction()->setText(i18n("Folders"));
     actionCollection()->addAction("show_folders_panel", treeViewDock->toggleViewAction());
 
     addDockWidget(Qt::LeftDockWidgetArea, treeViewDock);
@@ -1301,10 +1288,25 @@ void DolphinMainWindow::setupDockWidgets()
     connect(treeWidget, SIGNAL(urlsDropped(KUrl::List, KUrl)),
             this, SLOT(dropUrls(KUrl::List, KUrl)));
 
+    // setup "Terminal"
+    QDockWidget* terminalDock = new QDockWidget(i18n("Terminal"));
+    terminalDock->setObjectName("terminalDock");
+    terminalDock->setAllowedAreas(Qt::TopDockWidgetArea | Qt::BottomDockWidgetArea);
+    SidebarPage* terminalWidget = new TerminalSidebarPage(terminalDock);
+    terminalDock->setWidget(terminalWidget);
+
+    terminalDock->toggleViewAction()->setText(i18n("Terminal"));
+    actionCollection()->addAction("show_terminal_panel", terminalDock->toggleViewAction());
+
+    addDockWidget(Qt::RightDockWidgetArea, terminalDock);
+    connect(this, SIGNAL(urlChanged(KUrl)),
+            terminalWidget, SLOT(setUrl(KUrl)));
+
     const bool firstRun = DolphinSettings::instance().generalSettings()->firstRun();
     if (firstRun) {
         infoDock->hide();
         treeViewDock->hide();
+        terminalDock->hide();
     }
 
     QDockWidget *placesDock = new QDockWidget(i18n("Places"));