Fix view mode-specific settings not always applying

[dolphin.git] / src / dbusinterface.cpp

diff --git a/src/dbusinterface.cpp b/src/dbusinterface.cpp
index 2b674b96888382b5497e0fd639c8c9fd6f7a0788..8d5bf7645b9feeeba326f8f00908c2b520445339 100644 (file)
--- a/src/dbusinterface.cpp
+++ b/src/dbusinterface.cpp
@@ -9,10 +9,9 @@
 #include "dolphin_generalsettings.h"
 
 #include <KPropertiesDialog>
 #include "dolphin_generalsettings.h"
 
 #include <KPropertiesDialog>

+#include <KWindowSystem>

 
 

-#include <QApplication>

 #include <QDBusConnection>
 #include <QDBusConnection>

-#include <QDBusInterface>

 #include <QDBusConnectionInterface>
 
 DBusInterface::DBusInterface() :
 #include <QDBusConnectionInterface>
 
 DBusInterface::DBusInterface() :


@@ -28,35 +27,33 @@ DBusInterface::DBusInterface() :
 
 void DBusInterface::ShowFolders(const QStringList& uriList, const QString& startUpId)
 {
 
 void DBusInterface::ShowFolders(const QStringList& uriList, const QString& startUpId)
 {

-    Q_UNUSED(startUpId)

     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (urls.isEmpty()) {
         return;
     }
     const auto serviceName = isDaemon() ? QString() : QStringLiteral("org.kde.dolphin-%1").arg(QCoreApplication::applicationPid());
     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (urls.isEmpty()) {
         return;
     }
     const auto serviceName = isDaemon() ? QString() : QStringLiteral("org.kde.dolphin-%1").arg(QCoreApplication::applicationPid());

-    if(!Dolphin::attachToExistingInstance(urls, false, GeneralSettings::splitView(), serviceName)) {
+    if(!Dolphin::attachToExistingInstance(urls, false, GeneralSettings::splitView(), serviceName, startUpId)) {

         Dolphin::openNewWindow(urls);
     }
 }
 
 void DBusInterface::ShowItems(const QStringList& uriList, const QString& startUpId)
 {
         Dolphin::openNewWindow(urls);
     }
 }
 
 void DBusInterface::ShowItems(const QStringList& uriList, const QString& startUpId)
 {

-    Q_UNUSED(startUpId)

     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (urls.isEmpty()) {
         return;
     }
     const auto serviceName = isDaemon() ? QString() : QStringLiteral("org.kde.dolphin-%1").arg(QCoreApplication::applicationPid());
     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (urls.isEmpty()) {
         return;
     }
     const auto serviceName = isDaemon() ? QString() : QStringLiteral("org.kde.dolphin-%1").arg(QCoreApplication::applicationPid());

-    if(!Dolphin::attachToExistingInstance(urls, true, GeneralSettings::splitView(), serviceName)) {
+    if(!Dolphin::attachToExistingInstance(urls, true, GeneralSettings::splitView(), serviceName, startUpId)) {

         Dolphin::openNewWindow(urls, nullptr, Dolphin::OpenNewWindowFlag::Select);
     };
 }
 
 void DBusInterface::ShowItemProperties(const QStringList& uriList, const QString& startUpId)
 {
         Dolphin::openNewWindow(urls, nullptr, Dolphin::OpenNewWindowFlag::Select);
     };
 }
 
 void DBusInterface::ShowItemProperties(const QStringList& uriList, const QString& startUpId)
 {

-    Q_UNUSED(startUpId)

     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (!urls.isEmpty()) {
     const QList<QUrl> urls = Dolphin::validateUris(uriList);
     if (!urls.isEmpty()) {

+        KWindowSystem::setCurrentXdgActivationToken(startUpId);

         KPropertiesDialog::showDialog(urls);
     }
 }
         KPropertiesDialog::showDialog(urls);
     }
 }