Hide search extra options when not available

[dolphin.git] / src / search / dolphinsearchbox.cpp

diff --git a/src/search/dolphinsearchbox.cpp b/src/search/dolphinsearchbox.cpp
index 6a87edc9e05b43c7c1bc27839c7bbb22e2b5f0c3..838a8b38cd21669c1caa39bea692efe837bdb42f 100644 (file)
--- a/src/search/dolphinsearchbox.cpp
+++ b/src/search/dolphinsearchbox.cpp
@@ -107,12 +107,7 @@ void DolphinSearchBox::setSearchPath(const QUrl& url)
     m_fromHereButton->setText(i18nc("action:button", "From Here (%1)", elidedLocation));
     m_fromHereButton->setToolTip(i18nc("action:button", "Limit search to '%1' and its subfolders", cleanedUrl.toString(QUrl::PreferLocalFile)));
 
-    bool hasFacetsSupport = false;
-#ifdef HAVE_BALOO
-    const Baloo::IndexerConfig searchInfo;
-    hasFacetsSupport = searchInfo.fileIndexingEnabled() && searchInfo.shouldBeIndexed(m_searchPath.toLocalFile());
-#endif
-    m_facetsWidget->setEnabled(hasFacetsSupport);
+    setFacetsVisible(SearchSettings::showFacetsWidget());
 }
 
 QUrl DolphinSearchBox::searchPath() const
@@ -123,12 +118,8 @@ QUrl DolphinSearchBox::searchPath() const
 QUrl DolphinSearchBox::urlForSearching() const
 {
     QUrl url;
-    bool useBalooSearch = false;
-#ifdef HAVE_BALOO
-    const Baloo::IndexerConfig searchInfo;
-    useBalooSearch = searchInfo.fileIndexingEnabled() && searchInfo.shouldBeIndexed(m_searchPath.toLocalFile());
-#endif
-    if (useBalooSearch) {
+
+    if (isIndexingEnabled()) {
         url = balooUrlForSearching();
     } else {
         url.setScheme(QStringLiteral("filenamesearch"));
@@ -203,6 +194,7 @@ void DolphinSearchBox::showEvent(QShowEvent* event)
         m_searchInput->setFocus();
         m_startedSearching = false;
     }
+    updateFacetsToggleButton();
 }
 
 void DolphinSearchBox::hideEvent(QHideEvent* event)
@@ -291,9 +283,7 @@ void DolphinSearchBox::slotReturnPressed()
 
 void DolphinSearchBox::slotFacetsButtonToggled()
 {
-    const bool facetsIsVisible = !m_facetsWidget->isVisible();
-    m_facetsWidget->setVisible(facetsIsVisible);
-    updateFacetsToggleButton();
+    setFacetsVisible(m_facetsToggleButton->isChecked());
 }
 
 void DolphinSearchBox::slotFacetChanged()
@@ -338,14 +328,16 @@ void DolphinSearchBox::loadSettings()
         m_fileNameButton->setChecked(true);
     }
 
-    m_facetsWidget->setVisible(SearchSettings::showFacetsWidget());
+    setFacetsVisible(SearchSettings::showFacetsWidget());
 }
 
 void DolphinSearchBox::saveSettings()
 {
     SearchSettings::setLocation(m_fromHereButton->isChecked() ? QStringLiteral("FromHere") : QStringLiteral("Everywhere"));
     SearchSettings::setWhat(m_fileNameButton->isChecked() ? QStringLiteral("FileName") : QStringLiteral("Content"));
-    SearchSettings::setShowFacetsWidget(m_facetsToggleButton->isChecked());
+    if (isIndexingEnabled()) {
+        SearchSettings::setShowFacetsWidget(m_facetsToggleButton->isChecked());
+    }
     SearchSettings::self()->save();
 }
 
@@ -481,8 +473,6 @@ void DolphinSearchBox::init()
     m_startSearchTimer->setSingleShot(true);
     m_startSearchTimer->setInterval(1000);
     connect(m_startSearchTimer, &QTimer::timeout, this, &DolphinSearchBox::emitSearchRequest);
-
-    updateFacetsToggleButton();
 }
 
 QUrl DolphinSearchBox::balooUrlForSearching() const
@@ -558,11 +548,52 @@ void DolphinSearchBox::fromBalooSearchUrl(const QUrl& url)
 #endif
 }
 
+void DolphinSearchBox::setFacetsVisible(bool visible)
+{
+    const bool indexingEnabled = isIndexingEnabled();
+    m_facetsWidget->setEnabled(indexingEnabled);
+    m_facetsWidget->setVisible(indexingEnabled && visible);
+    updateFacetsToggleButton();
+}
+
 void DolphinSearchBox::updateFacetsToggleButton()
 {
-    const bool facetsIsVisible = SearchSettings::showFacetsWidget();
-    m_facetsToggleButton->setChecked(facetsIsVisible ? true : false);
-    m_facetsToggleButton->setIcon(QIcon::fromTheme(facetsIsVisible ? QStringLiteral("arrow-up-double") : QStringLiteral("arrow-down-double")));
-    m_facetsToggleButton->setText(facetsIsVisible ? i18nc("action:button", "Fewer Options") : i18nc("action:button", "More Options"));
+    const bool facetsEnabled = m_facetsWidget->isEnabled();
+    const bool facetsVisible = m_facetsWidget->isVisible();
+
+    m_facetsToggleButton->setEnabled(facetsEnabled);
+    m_facetsToggleButton->setChecked(facetsVisible);
+
+    m_facetsToggleButton->setIcon(QIcon::fromTheme(
+           facetsVisible ? QStringLiteral("arrow-up-double") :
+                           QStringLiteral("arrow-down-double")));
+
+    m_facetsToggleButton->setText(
+           facetsVisible ? i18nc("@action:button", "Fewer Options") :
+                           i18nc("@action:button", "More Options"));
+
+    if (facetsEnabled) {
+        m_facetsToggleButton->setToolTip(QString());
+    } else {
+#ifdef HAVE_BALOO
+        const Baloo::IndexerConfig searchInfo;
+        if (!searchInfo.fileIndexingEnabled()) {
+            m_facetsToggleButton->setToolTip(i18nc("@info:tooltip", "Advanced search options are not available because the file indexing service is disabled."));
+        } else {
+            m_facetsToggleButton->setToolTip(i18nc("@info:tooltip", "Advanced search options are not available because this location is not indexed."));
+        }
+#else
+        m_facetsToggleButton->setToolTip(i18nc("@info:tooltip", "Advanced search options are not available because this version of Dolphin does not support the Baloo file indexer."));
+#endif
+    }
 }
 
+bool DolphinSearchBox::isIndexingEnabled() const
+{
+#ifdef HAVE_BALOO
+    const Baloo::IndexerConfig searchInfo;
+    return searchInfo.fileIndexingEnabled() && searchInfo.shouldBeIndexed(m_searchPath.toLocalFile());
+#else
+    return false;
+#endif
+}