Konq popupmenu fix: we don't show the "Create new" submenu over subdirs in an iconvie...

[dolphin.git] / src / treeviewsidebarpage.cpp

diff --git a/src/treeviewsidebarpage.cpp b/src/treeviewsidebarpage.cpp
index 8258fbfc8d390b3896edde13937e693324220524..4e591a127fca182a5c8c2f6dc5fd6eea83e62659 100644 (file)
--- a/src/treeviewsidebarpage.cpp
+++ b/src/treeviewsidebarpage.cpp
@@ -19,12 +19,14 @@
 
 #include "treeviewsidebarpage.h"
 
+#include "dolphindropcontroller.h"
 #include "dolphinmodel.h"
 #include "dolphinsortfilterproxymodel.h"
 #include "dolphinview.h"
 #include "dolphinsettings.h"
 #include "dolphin_folderspanelsettings.h"
 #include "dolphin_generalsettings.h"
+#include "folderexpander.h"
 #include "renamedialog.h"
 #include "sidebartreeview.h"
 #include "treeviewcontextmenu.h"
@@ -52,6 +54,7 @@ TreeViewSidebarPage::TreeViewSidebarPage(QWidget* parent) :
     m_treeView(0),
     m_leafDir()
 {
+    setLayoutDirection(Qt::LeftToRight);
 }
 
 TreeViewSidebarPage::~TreeViewSidebarPage()
@@ -84,7 +87,6 @@ bool TreeViewSidebarPage::showHiddenFiles() const
     return FoldersPanelSettings::showHiddenFiles();
 }
 
-
 void TreeViewSidebarPage::rename(const KFileItem& item)
 {
     if (DolphinSettings::instance().generalSettings()->renameInline()) {
@@ -138,15 +140,12 @@ void TreeViewSidebarPage::showEvent(QShowEvent* event)
         m_dirLister->setAutoErrorHandlingEnabled(false, this);
         m_dirLister->setShowingDotFiles(FoldersPanelSettings::showHiddenFiles());
 
-        connect(m_dirLister, SIGNAL(completed()),
-                this, SLOT(triggerLoadSubTree()));
-
         Q_ASSERT(m_dolphinModel == 0);
         m_dolphinModel = new DolphinModel(this);
         m_dolphinModel->setDirLister(m_dirLister);
         m_dolphinModel->setDropsAllowed(DolphinModel::DropOnDirectory);
         connect(m_dolphinModel, SIGNAL(expand(const QModelIndex&)),
-                this, SLOT(triggerExpanding()));
+                this, SLOT(expandToDir(const QModelIndex&)));
 
         Q_ASSERT(m_proxyModel == 0);
         m_proxyModel = new DolphinSortFilterProxyModel(this);
@@ -157,11 +156,13 @@ void TreeViewSidebarPage::showEvent(QShowEvent* event)
         m_treeView->setModel(m_proxyModel);
         m_proxyModel->setSorting(DolphinView::SortByName);
         m_proxyModel->setSortOrder(Qt::AscendingOrder);
+        
+        new FolderExpander(m_treeView, m_proxyModel);
 
         connect(m_treeView, SIGNAL(clicked(const QModelIndex&)),
                 this, SLOT(updateActiveView(const QModelIndex&)));
-        connect(m_treeView, SIGNAL(urlsDropped(const KUrl::List&, const QModelIndex&)),
-                this, SLOT(dropUrls(const KUrl::List&, const QModelIndex&)));
+        connect(m_treeView, SIGNAL(urlsDropped(const QModelIndex&, QDropEvent*)),
+                this, SLOT(dropUrls(const QModelIndex&, QDropEvent*)));
         connect(m_treeView, SIGNAL(pressed(const QModelIndex&)),
                 this, SLOT(updateMouseButtons()));
 
@@ -199,65 +200,24 @@ void TreeViewSidebarPage::updateActiveView(const QModelIndex& index)
     }
 }
 
-void TreeViewSidebarPage::dropUrls(const KUrl::List& urls,
-                                   const QModelIndex& index)
+void TreeViewSidebarPage::dropUrls(const QModelIndex& index, QDropEvent* event)
 {
     if (index.isValid()) {
         const QModelIndex dirIndex = m_proxyModel->mapToSource(index);
         KFileItem item = m_dolphinModel->itemForIndex(dirIndex);
         Q_ASSERT(!item.isNull());
         if (item.isDir()) {
-            emit urlsDropped(urls, item.url());
+            DolphinDropController::dropUrls(item, item.url(), event, this);
         }
     }
 }
 
-void TreeViewSidebarPage::triggerExpanding()
-{
-    // the expanding of the folders may not be done in the context
-    // of this slot
-    QMetaObject::invokeMethod(this, "expandToLeafDir", Qt::QueuedConnection);
-}
-
-void TreeViewSidebarPage::triggerLoadSubTree()
+void TreeViewSidebarPage::expandToDir(const QModelIndex& index)
 {
-    // the loading of the sub tree may not be done in the context
-    // of this slot
-    QMetaObject::invokeMethod(this, "loadSubTree", Qt::QueuedConnection);
-}
-
-void TreeViewSidebarPage::expandToLeafDir()
-{
-    // expand all directories until the parent directory of m_leafDir
-    const KUrl parentUrl = m_leafDir.upUrl();
-    QModelIndex dirIndex = m_dolphinModel->indexForUrl(parentUrl);
-    QModelIndex proxyIndex = m_proxyModel->mapFromSource(dirIndex);
-    m_treeView->setExpanded(proxyIndex, true);
+    m_treeView->setExpanded(index, true);
     selectLeafDirectory();
 }
 
-
-void TreeViewSidebarPage::loadSubTree()
-{
-    m_treeView->selectionModel()->clearSelection();
-
-    if (m_leafDir.isParentOf(m_dirLister->url())) {
-        // The leaf directory is not a child of the base URL, hence
-        // no sub directory must be loaded or selected.
-        return;
-    }
-
-    const QModelIndex index = m_dolphinModel->indexForUrl(m_leafDir);
-    if (index.isValid()) {
-        selectLeafDirectory();
-    } else {
-        // Load all sub directories that need to get expanded for making
-        // the leaf directory visible. The slot triggerExpanding() will
-        // get invoked if the expanding has been finished.
-        m_dolphinModel->expandToUrl(m_leafDir);
-    }
-}
-
 void TreeViewSidebarPage::scrollToLeaf()
 {
     const QModelIndex dirIndex = m_dolphinModel->indexForUrl(m_leafDir);
@@ -290,9 +250,8 @@ void TreeViewSidebarPage::loadTree(const KUrl& url)
     if (m_dirLister->url() != baseUrl) {
         m_dirLister->stop();
         m_dirLister->openUrl(baseUrl, KDirLister::Reload);
-    } else {
-        loadSubTree();
     }
+    m_dolphinModel->expandToUrl(m_leafDir);
 }
 
 void TreeViewSidebarPage::selectLeafDirectory()
@@ -313,7 +272,7 @@ void TreeViewSidebarPage::selectLeafDirectory()
     }
 
     QItemSelectionModel* selModel = m_treeView->selectionModel();
-    selModel->setCurrentIndex(proxyIndex, QItemSelectionModel::Select);
+    selModel->setCurrentIndex(proxyIndex, QItemSelectionModel::ClearAndSelect);
 }
 
 #include "treeviewsidebarpage.moc"