Full row highlight implementation

[dolphin.git] / src / panels / places / placespanel.cpp

diff --git a/src/panels/places/placespanel.cpp b/src/panels/places/placespanel.cpp
index 216b760381270ae87f309dd9199b2b896f592e22..8fc81bb326a0bd49298384c41fa87644e2a0412a 100644 (file)
--- a/src/panels/places/placespanel.cpp
+++ b/src/panels/places/placespanel.cpp
@@ -1,523 +1,313 @@
-/***************************************************************************
- *   Copyright (C) 2008-2012 by Peter Penz <peter.penz19@gmail.com>        *
- *                                                                         *
- *   Based on KFilePlacesView from kdelibs:                                *
- *   Copyright (C) 2007 Kevin Ottens <ervin@kde.org>                       *
- *   Copyright (C) 2007 David Faure <faure@kde.org>                        *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
- ***************************************************************************/
+/*
+ * SPDX-FileCopyrightText: 2008-2012 Peter Penz <peter.penz19@gmail.com>
+ * SPDX-FileCopyrightText: 2021 Kai Uwe Broulik <kde@broulik.de>
+ *
+ * Based on KFilePlacesView from kdelibs:
+ * SPDX-FileCopyrightText: 2007 Kevin Ottens <ervin@kde.org>
+ * SPDX-FileCopyrightText: 2007 David Faure <faure@kde.org>
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */

 
 #include "placespanel.h"
 
 
 #include "placespanel.h"
 

+#include "dolphinplacesmodelsingleton.h"

 #include "dolphin_generalsettings.h"
 #include "dolphin_generalsettings.h"

+#include "dolphin_placespanelsettings.h"

 #include "global.h"
 #include "global.h"

-#include "kitemviews/kitemlistcontainer.h"
-#include "kitemviews/kitemlistcontroller.h"
-#include "kitemviews/kitemlistselectionmanager.h"
-#include "kitemviews/kstandarditem.h"
-#include "placesitem.h"
-#include "placesitemeditdialog.h"
-#include "placesitemlistgroupheader.h"
-#include "placesitemlistwidget.h"
-#include "placesitemmodel.h"
-#include "placesview.h"
-#include "trash/dolphintrash.h"

 #include "views/draganddrophelper.h"
 #include "views/draganddrophelper.h"

+#include "settings/dolphinsettingsdialog.h"

 
 

-#include <KDirNotify>
-#include <KFileItem>

 #include <KFilePlacesModel>
 #include <KIO/DropJob>
 #include <KFilePlacesModel>
 #include <KIO/DropJob>

-#include <KIO/EmptyTrashJob>

 #include <KIO/Job>
 #include <KIO/Job>

-#include <KIO/JobUiDelegate>
-#include <KIconLoader>
-#include <KJobWidgets>
+#include <KListOpenFilesJob>

 #include <KLocalizedString>
 #include <KLocalizedString>

-#include <KMessageBox>
-#include <KNotification>

 
 

-#include <QGraphicsSceneDragDropEvent>

 #include <QIcon>
 #include <QMenu>
 #include <QIcon>
 #include <QMenu>

-#include <QVBoxLayout>
-
-PlacesPanel::PlacesPanel(QWidget* parent) :
-    Panel(parent),
-    m_controller(nullptr),
-    m_model(nullptr),
-    m_view(nullptr),
-    m_storageSetupFailedUrl(),
-    m_triggerStorageSetupButton(),
-    m_itemDropEventIndex(-1),
-    m_itemDropEventMimeData(nullptr),
-    m_itemDropEvent(nullptr)
-{
-}
-
-PlacesPanel::~PlacesPanel()
-{
-}
-
-void PlacesPanel::proceedWithTearDown()
-{
-    m_model->proceedWithTearDown();
-}
-
-bool PlacesPanel::urlChanged()
-{
-    if (!url().isValid() || url().scheme().contains(QStringLiteral("search"))) {
-        // Skip results shown by a search, as possible identical
-        // directory names are useless without parent-path information.
-        return false;
-    }
-
-    if (m_controller) {
-        selectClosestItem();
-    }
+#include <QShowEvent>
+#include <QTimer>

 
 

-    return true;
-}
+#include <Solid/StorageAccess>

 
 

-void PlacesPanel::readSettings()
-{
-    if (m_controller) {
-       const int delay = GeneralSettings::autoExpandFolders() ? 750 : -1;
-       m_controller->setAutoActivationDelay(delay);
-    }
-}
-
-void PlacesPanel::showEvent(QShowEvent* event)
+PlacesPanel::PlacesPanel(QWidget* parent)
+    : KFilePlacesView(parent)

 {
 {

-    if (event->spontaneous()) {
-        Panel::showEvent(event);
-        return;
-    }
+    setDropOnPlaceEnabled(true);
+    connect(this, &PlacesPanel::urlsDropped,
+            this, &PlacesPanel::slotUrlsDropped);

 
 

-    if (!m_controller) {
-        // Postpone the creating of the controller to the first show event.
-        // This assures that no performance and memory overhead is given when the folders panel is not
-        // used at all and stays invisible.
-        m_model = new PlacesItemModel(this);
-        m_model->setGroupedSorting(true);
-        connect(m_model, &PlacesItemModel::errorMessage,
-                this, &PlacesPanel::errorMessage);
-        connect(m_model, &PlacesItemModel::storageTearDownRequested,
-                this, &PlacesPanel::storageTearDownRequested);
-        connect(m_model, &PlacesItemModel::storageTearDownExternallyRequested,
-                this, &PlacesPanel::storageTearDownExternallyRequested);
-
-        m_view = new PlacesView();
-        m_view->setWidgetCreator(new KItemListWidgetCreator<PlacesItemListWidget>());
-        m_view->setGroupHeaderCreator(new KItemListGroupHeaderCreator<PlacesItemListGroupHeader>());
-
-        m_controller = new KItemListController(m_model, m_view, this);
-        m_controller->setSelectionBehavior(KItemListController::SingleSelection);
-        m_controller->setSingleClickActivationEnforced(true);
+    setAutoResizeItemsEnabled(false);

 
 

-        readSettings();
+    setTeardownFunction([this](const QModelIndex &index) {
+        slotTearDownRequested(index);
+    });

 
 

-        connect(m_controller, &KItemListController::itemActivated, this, &PlacesPanel::slotItemActivated);
-        connect(m_controller, &KItemListController::itemMiddleClicked, this, &PlacesPanel::slotItemMiddleClicked);
-        connect(m_controller, &KItemListController::itemContextMenuRequested, this, &PlacesPanel::slotItemContextMenuRequested);
-        connect(m_controller, &KItemListController::viewContextMenuRequested, this, &PlacesPanel::slotViewContextMenuRequested);
-        connect(m_controller, &KItemListController::itemDropEvent, this, &PlacesPanel::slotItemDropEvent);
-        connect(m_controller, &KItemListController::aboveItemDropEvent, this, &PlacesPanel::slotAboveItemDropEvent);
+    m_configureTrashAction = new QAction(QIcon::fromTheme(QStringLiteral("configure")), i18nc("@action:inmenu", "Configure Trash…"));
+    m_configureTrashAction->setPriority(QAction::HighPriority);
+    connect(m_configureTrashAction, &QAction::triggered, this, &PlacesPanel::slotConfigureTrash);
+    addAction(m_configureTrashAction);

 
 

-        KItemListContainer* container = new KItemListContainer(m_controller, this);
-        container->setEnabledFrame(false);
+    connect(this, &PlacesPanel::contextMenuAboutToShow, this, &PlacesPanel::slotContextMenuAboutToShow);

 
 

-        QVBoxLayout* layout = new QVBoxLayout(this);
-        layout->setMargin(0);
-        layout->addWidget(container);
+    connect(this, &PlacesPanel::iconSizeChanged, this, [this](const QSize &newSize) {
+        int iconSize = qMin(newSize.width(), newSize.height());
+        if (iconSize == 0) {
+            // Don't store 0 size, let's keep -1 for default/small/automatic
+            iconSize = -1;
+        }
+        PlacesPanelSettings* settings = PlacesPanelSettings::self();
+        settings->setIconSize(iconSize);
+        settings->save();
+    });
+}

 
 

-        selectClosestItem();
-    }
+PlacesPanel::~PlacesPanel() = default;

 
 

-    Panel::showEvent(event);
+void PlacesPanel::setUrl(const QUrl &url)
+{
+    // KFilePlacesView::setUrl no-ops when no model is set but we only set it in showEvent()
+    // Remember the URL and set it in showEvent
+    m_url = url;
+    KFilePlacesView::setUrl(url);

 }
 
 }
 

-void PlacesPanel::slotItemActivated(int index)
+QList<QAction*> PlacesPanel::customContextMenuActions() const

 {
 {

-    triggerItem(index, Qt::LeftButton);
+    return m_customContextMenuActions;

 }
 
 }
 

-void PlacesPanel::slotItemMiddleClicked(int index)
+void PlacesPanel::setCustomContextMenuActions(const QList<QAction *> &actions)

 {
 {

-    triggerItem(index, Qt::MiddleButton);
+    m_customContextMenuActions = actions;

 }
 
 }
 

-void PlacesPanel::slotItemContextMenuRequested(int index, const QPointF& pos)
+void PlacesPanel::proceedWithTearDown()

 {
 {

-    PlacesItem* item = m_model->placesItem(index);
-    if (!item) {
-        return;
-    }
-
-    QMenu menu(this);
-
-    QAction* emptyTrashAction = nullptr;
-    QAction* editAction = nullptr;
-    QAction* teardownAction = nullptr;
-    QAction* ejectAction = nullptr;
+    Q_ASSERT(m_deviceToTearDown);

 
 

-    const QString label = item->text();
-
-    const bool isDevice = !item->udi().isEmpty();
-    const bool isTrash = (item->url().scheme() == QLatin1String("trash"));
-    if (isDevice) {
-        ejectAction = m_model->ejectAction(index);
-        if (ejectAction) {
-            ejectAction->setParent(&menu);
-            menu.addAction(ejectAction);
-        }
-
-        teardownAction = m_model->teardownAction(index);
-        if (teardownAction) {
-            teardownAction->setParent(&menu);
-            menu.addAction(teardownAction);
-        }
+    connect(m_deviceToTearDown, &Solid::StorageAccess::teardownDone,
+            this, &PlacesPanel::slotTearDownDone);
+    m_deviceToTearDown->teardown();
+}

 
 

-        if (teardownAction || ejectAction) {
-            menu.addSeparator();
+void PlacesPanel::readSettings()
+{
+    if (GeneralSettings::autoExpandFolders()) {
+        if (!m_dragActivationTimer) {
+            m_dragActivationTimer = new QTimer(this);
+            m_dragActivationTimer->setInterval(750);
+            m_dragActivationTimer->setSingleShot(true);
+            connect(m_dragActivationTimer, &QTimer::timeout,
+                    this, &PlacesPanel::slotDragActivationTimeout);

         }
     } else {
         }
     } else {

-        if (isTrash) {
-            emptyTrashAction = menu.addAction(QIcon::fromTheme(QStringLiteral("trash-empty")), i18nc("@action:inmenu", "Empty Trash"));
-            emptyTrashAction->setEnabled(item->icon() == QLatin1String("user-trash-full"));
-            menu.addSeparator();
-        }
-    }
-
-    QAction* openInNewWindowAction = menu.addAction(QIcon::fromTheme("window-new"), i18nc("@item:inmenu", "Open in New Window"));
-    QAction* openInNewTabAction = menu.addAction(QIcon::fromTheme("tab-new"), i18nc("@item:inmenu", "Open in New Tab"));
-    if (!isDevice && !isTrash) {
-        menu.addSeparator();
+        delete m_dragActivationTimer;
+        m_dragActivationTimer = nullptr;
+        m_pendingDragActivation = QPersistentModelIndex();

     }
 
     }
 

-    if (!isDevice) {
-        editAction = menu.addAction(QIcon::fromTheme("document-properties"), i18nc("@item:inmenu", "Edit..."));
-    }
+    const int iconSize = qMax(0, PlacesPanelSettings::iconSize());
+    setIconSize(QSize(iconSize, iconSize));
+}

 
 

-    QAction* removeAction = nullptr;
-    if (!isDevice && !item->isSystemItem()) {
-        removeAction = menu.addAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18nc("@item:inmenu", "Remove"));
-    }
+void PlacesPanel::showEvent(QShowEvent* event)
+{
+    if (!event->spontaneous() && !model()) {
+        readSettings();

 
 

-    QAction* hideAction = menu.addAction(i18nc("@item:inmenu", "Hide"));
-    hideAction->setCheckable(true);
-    hideAction->setChecked(item->isHidden());
+        auto *placesModel = DolphinPlacesModelSingleton::instance().placesModel();
+        setModel(placesModel);

 
 

-    buildGroupContextMenu(&menu, index);
+        connect(placesModel, &KFilePlacesModel::errorMessage, this, &PlacesPanel::errorMessage);

 
 

-    QAction* action = menu.exec(pos.toPoint());
-    if (action) {
-        if (action == emptyTrashAction) {
-            Trash::empty(this);
-        } else {
-            // The index might have changed if devices were added/removed while
-            // the context menu was open.
-            index = m_model->index(item);
-            if (index < 0) {
-                // The item is not in the model any more, probably because it was an
-                // external device that has been removed while the context menu was open.
-                return;
-            }
+        connect(placesModel, &QAbstractItemModel::rowsInserted, this, &PlacesPanel::slotRowsInserted);
+        connect(placesModel, &QAbstractItemModel::rowsAboutToBeRemoved, this, &PlacesPanel::slotRowsAboutToBeRemoved);

 
 

-            if (action == editAction) {
-                editEntry(index);
-            } else if (action == removeAction) {
-                m_model->deleteItem(index);
-            } else if (action == hideAction) {
-                item->setHidden(hideAction->isChecked());
-            } else if (action == openInNewWindowAction) {
-                Dolphin::openNewWindow({KFilePlacesModel::convertedUrl(m_model->data(index).value("url").toUrl())}, this);
-            } else if (action == openInNewTabAction) {
-                // TriggerItem does set up the storage first and then it will
-                // emit the slotItemMiddleClicked signal, because of Qt::MiddleButton.
-                triggerItem(index, Qt::MiddleButton);
-            } else if (action == teardownAction) {
-                m_model->requestTearDown(index);
-            } else if (action == ejectAction) {
-                m_model->requestEject(index);
-            }
+        for (int i = 0; i < model()->rowCount(); ++i) {
+            connectDeviceSignals(model()->index(i, 0, QModelIndex()));

         }
         }

+
+        setUrl(m_url);

     }
 
     }
 

-    selectClosestItem();
+    KFilePlacesView::showEvent(event);

 }
 
 }
 

-void PlacesPanel::slotViewContextMenuRequested(const QPointF& pos)
+void PlacesPanel::dragMoveEvent(QDragMoveEvent *event)

 {
 {

-    QMenu menu(this);
-
-    QAction* addAction = menu.addAction(QIcon::fromTheme(QStringLiteral("document-new")), i18nc("@item:inmenu", "Add Entry..."));
+    KFilePlacesView::dragMoveEvent(event);

 
 

-    QAction* showAllAction = nullptr;
-    if (m_model->hiddenCount() > 0) {
-        showAllAction = menu.addAction(i18nc("@item:inmenu", "Show All Entries"));
-        showAllAction->setCheckable(true);
-        showAllAction->setChecked(m_model->hiddenItemsShown());
-    }
-
-    buildGroupContextMenu(&menu, m_controller->indexCloseToMousePressedPosition());
-
-    QMenu* iconSizeSubMenu = new QMenu(i18nc("@item:inmenu", "Icon Size"), &menu);
-
-    struct IconSizeInfo
-    {
-        int size;
-        const char* context;
-        const char* text;
-    };
-
-    const int iconSizeCount = 4;
-    static const IconSizeInfo iconSizes[iconSizeCount] = {
-        {KIconLoader::SizeSmall,        I18N_NOOP2_NOSTRIP("Small icon size", "Small (%1x%2)")},
-        {KIconLoader::SizeSmallMedium,  I18N_NOOP2_NOSTRIP("Medium icon size", "Medium (%1x%2)")},
-        {KIconLoader::SizeMedium,       I18N_NOOP2_NOSTRIP("Large icon size", "Large (%1x%2)")},
-        {KIconLoader::SizeLarge,        I18N_NOOP2_NOSTRIP("Huge icon size", "Huge (%1x%2)")}
-    };
-
-    QMap<QAction*, int> iconSizeActionMap;
-    QActionGroup* iconSizeGroup = new QActionGroup(iconSizeSubMenu);
-
-    for (int i = 0; i < iconSizeCount; ++i) {
-        const int size = iconSizes[i].size;
-        const QString text = i18nc(iconSizes[i].context, iconSizes[i].text,
-                                   size, size);
-
-        QAction* action = iconSizeSubMenu->addAction(text);
-        iconSizeActionMap.insert(action, size);
-        action->setActionGroup(iconSizeGroup);
-        action->setCheckable(true);
-        action->setChecked(m_view->iconSize() == size);
+    if (!m_dragActivationTimer) {
+        return;

     }
 
     }
 

-    menu.addMenu(iconSizeSubMenu);
-
-    menu.addSeparator();
-    foreach (QAction* action, customContextMenuActions()) {
-        menu.addAction(action);
+    const QModelIndex index = indexAt(event->pos());
+    if (!index.isValid()) {
+        return;

     }
 
     }
 

-    QAction* action = menu.exec(pos.toPoint());
-    if (action) {
-        if (action == addAction) {
-            addEntry();
-        } else if (action == showAllAction) {
-            m_model->setHiddenItemsShown(showAllAction->isChecked());
-        } else if (iconSizeActionMap.contains(action)) {
-            m_view->setIconSize(iconSizeActionMap.value(action));
-        }
+    QPersistentModelIndex persistentIndex(index);
+    if (!m_pendingDragActivation.isValid() || m_pendingDragActivation != persistentIndex) {
+        m_pendingDragActivation = persistentIndex;
+        m_dragActivationTimer->start();

     }
     }

-
-    selectClosestItem();

 }
 
 }
 

-QAction *PlacesPanel::buildGroupContextMenu(QMenu *menu, int index)
+void PlacesPanel::dragLeaveEvent(QDragLeaveEvent *event)

 {
 {

-    if (index == -1) {
-        return nullptr;
-    }
+    KFilePlacesView::dragLeaveEvent(event);

 
 

-    KFilePlacesModel::GroupType groupType = m_model->groupType(index);
-    QAction *hideGroupAction = menu->addAction(i18nc("@item:inmenu", "Hide Section '%1'", m_model->item(index)->group()));
-    hideGroupAction->setCheckable(true);
-    hideGroupAction->setChecked(m_model->isGroupHidden(groupType));
+    if (m_dragActivationTimer) {
+        m_dragActivationTimer->stop();
+        m_pendingDragActivation = QPersistentModelIndex();
+    }
+}

 
 

-    connect(hideGroupAction, &QAction::triggered, this, [this, groupType, hideGroupAction]{
-        m_model->setGroupHidden(groupType, hideGroupAction->isChecked());
-    });
+void PlacesPanel::slotConfigureTrash()
+{
+    const QUrl url = currentIndex().data(KFilePlacesModel::UrlRole).toUrl();

 
 

-    return hideGroupAction;
+    DolphinSettingsDialog* settingsDialog = new DolphinSettingsDialog(url, this);
+    settingsDialog->setCurrentPage(settingsDialog->trashSettings);
+    settingsDialog->setAttribute(Qt::WA_DeleteOnClose);
+    settingsDialog->show();

 }
 
 }
 

-void PlacesPanel::slotItemDropEvent(int index, QGraphicsSceneDragDropEvent* event)
+void PlacesPanel::slotDragActivationTimeout()

 {
 {

-    if (index < 0) {
+    if (!m_pendingDragActivation.isValid()) {

         return;
     }
 
         return;
     }
 

-    const PlacesItem* destItem = m_model->placesItem(index);
+    auto *placesModel = static_cast<KFilePlacesModel *>(model());
+    Q_EMIT placeActivated(KFilePlacesModel::convertedUrl(placesModel->url(m_pendingDragActivation)));
+}

 
 

-    if (destItem->isSearchOrTimelineUrl()) {
-        return;
+void PlacesPanel::slotUrlsDropped(const QUrl& dest, QDropEvent* event, QWidget* parent)
+{
+    KIO::DropJob *job = DragAndDropHelper::dropUrls(dest, event, parent);
+    if (job) {
+        connect(job, &KIO::DropJob::result, this, [this](KJob *job) { if (job->error()) Q_EMIT errorMessage(job->errorString()); });

     }
     }

+}

 
 

-    if (m_model->storageSetupNeeded(index)) {
-        connect(m_model, &PlacesItemModel::storageSetupDone,
-                this, &PlacesPanel::slotItemDropEventStorageSetupDone);
-
-        m_itemDropEventIndex = index;
+void PlacesPanel::slotContextMenuAboutToShow(const QModelIndex &index, QMenu *menu)
+{
+    Q_UNUSED(menu);

 
 

-        // Make a full copy of the Mime-Data
-        m_itemDropEventMimeData = new QMimeData;
-        m_itemDropEventMimeData->setText(event->mimeData()->text());
-        m_itemDropEventMimeData->setHtml(event->mimeData()->html());
-        m_itemDropEventMimeData->setUrls(event->mimeData()->urls());
-        m_itemDropEventMimeData->setImageData(event->mimeData()->imageData());
-        m_itemDropEventMimeData->setColorData(event->mimeData()->colorData());
+    auto *placesModel = static_cast<KFilePlacesModel *>(model());
+    const QUrl url = placesModel->url(index);
+    const Solid::Device device = placesModel->deviceForIndex(index);

 
 

-        m_itemDropEvent = new QDropEvent(event->pos().toPoint(),
-                                         event->possibleActions(),
-                                         m_itemDropEventMimeData,
-                                         event->buttons(),
-                                         event->modifiers());
+    m_configureTrashAction->setVisible(url.scheme() == QLatin1String("trash"));

 
 

-        m_model->requestStorageSetup(index);
-        return;
+    // show customContextMenuActions only on the view's context menu
+    if (!url.isValid() && !device.isValid()) {
+        addActions(m_customContextMenuActions);
+    } else {
+        const auto actions = this->actions();
+        for (QAction *action : actions) {
+            if (m_customContextMenuActions.contains(action)) {
+                removeAction(action);
+            }
+        }

     }
     }

-
-    QUrl destUrl = destItem->url();
-    QDropEvent dropEvent(event->pos().toPoint(),
-                         event->possibleActions(),
-                         event->mimeData(),
-                         event->buttons(),
-                         event->modifiers());
-
-    slotUrlsDropped(destUrl, &dropEvent, this);

 }
 
 }
 

-void PlacesPanel::slotItemDropEventStorageSetupDone(int index, bool success)
+void PlacesPanel::slotTearDownRequested(const QModelIndex &index)

 {
 {

-    disconnect(m_model, &PlacesItemModel::storageSetupDone,
-               this, &PlacesPanel::slotItemDropEventStorageSetupDone);
+    auto *placesModel = static_cast<KFilePlacesModel *>(model());

 
 

-    if ((index == m_itemDropEventIndex) && m_itemDropEvent && m_itemDropEventMimeData) {
-        if (success) {
-            QUrl destUrl = m_model->placesItem(index)->url();
-            slotUrlsDropped(destUrl, m_itemDropEvent, this);
-        }
+    Solid::StorageAccess *storageAccess = placesModel->deviceForIndex(index).as<Solid::StorageAccess>();
+    if (!storageAccess) {
+        return;
+    }

 
 

-        delete m_itemDropEventMimeData;
-        delete m_itemDropEvent;
+    m_deviceToTearDown = storageAccess;

 
 

-        m_itemDropEventIndex = -1;
-        m_itemDropEventMimeData = nullptr;
-        m_itemDropEvent = nullptr;
-    }
+    // disconnect the Solid::StorageAccess::teardownRequested
+    // to prevent emitting PlacesPanel::storageTearDownExternallyRequested
+    // after we have emitted PlacesPanel::storageTearDownRequested
+    disconnect(storageAccess, &Solid::StorageAccess::teardownRequested, this, &PlacesPanel::slotTearDownRequestedExternally);
+    Q_EMIT storageTearDownRequested(storageAccess->filePath());

 }
 
 }
 

-void PlacesPanel::slotAboveItemDropEvent(int index, QGraphicsSceneDragDropEvent* event)
+void PlacesPanel::slotTearDownRequestedExternally(const QString &udi)

 {
 {

-    m_model->dropMimeDataBefore(index, event->mimeData());
-}
+    Q_UNUSED(udi);
+    auto *storageAccess = static_cast<Solid::StorageAccess*>(sender());

 
 

-void PlacesPanel::slotUrlsDropped(const QUrl& dest, QDropEvent* event, QWidget* parent)
-{
-    KIO::DropJob *job = DragAndDropHelper::dropUrls(dest, event, parent);
-    if (job) {
-        connect(job, &KIO::DropJob::result, this, [this](KJob *job) { if (job->error()) emit errorMessage(job->errorString()); });
-    }
+    Q_EMIT storageTearDownExternallyRequested(storageAccess->filePath());

 }
 
 }
 

-void PlacesPanel::slotStorageSetupDone(int index, bool success)
+void PlacesPanel::slotTearDownDone(Solid::ErrorType error, const QVariant& errorData)

 {
 {

-    disconnect(m_model, &PlacesItemModel::storageSetupDone,
-               this, &PlacesPanel::slotStorageSetupDone);
-
-    if (m_triggerStorageSetupButton == Qt::NoButton) {
-        return;
-    }
-
-    if (success) {
-        Q_ASSERT(!m_model->storageSetupNeeded(index));
-        triggerItem(index, m_triggerStorageSetupButton);
-        m_triggerStorageSetupButton = Qt::NoButton;
+    if (error && errorData.isValid()) {
+        if (error == Solid::ErrorType::DeviceBusy) {
+            KListOpenFilesJob* listOpenFilesJob = new KListOpenFilesJob(m_deviceToTearDown->filePath());
+            connect(listOpenFilesJob, &KIO::Job::result, this, [this, listOpenFilesJob](KJob*) {
+                const KProcessList::KProcessInfoList blockingProcesses = listOpenFilesJob->processInfoList();
+                QString errorString;
+                if (blockingProcesses.isEmpty()) {
+                    errorString = i18n("One or more files on this device are open within an application.");
+                } else {
+                    QStringList blockingApps;
+                    for (const auto& process : blockingProcesses) {
+                        blockingApps << process.name();
+                    }
+                    blockingApps.removeDuplicates();
+                    errorString = xi18np("One or more files on this device are opened in application <application>\"%2\"</application>.",
+                            "One or more files on this device are opened in following applications: <application>%2</application>.",
+                            blockingApps.count(), blockingApps.join(i18nc("separator in list of apps blocking device unmount", ", ")));
+                }
+                Q_EMIT errorMessage(errorString);
+            });
+            listOpenFilesJob->start();
+        } else {
+            Q_EMIT errorMessage(errorData.toString());
+        }

     } else {
     } else {

-        setUrl(m_storageSetupFailedUrl);
-        m_storageSetupFailedUrl = QUrl();
+        // No error; it must have been unmounted successfully
+        Q_EMIT storageTearDownSuccessful();

     }
     }

+    disconnect(m_deviceToTearDown, &Solid::StorageAccess::teardownDone,
+               this, &PlacesPanel::slotTearDownDone);
+    m_deviceToTearDown = nullptr;

 }
 
 }
 

-void PlacesPanel::addEntry()
+void PlacesPanel::slotRowsInserted(const QModelIndex &parent, int first, int last)

 {
 {

-    const int index = m_controller->selectionManager()->currentItem();
-    const QUrl url = m_model->data(index).value("url").toUrl();
-
-    QPointer<PlacesItemEditDialog> dialog = new PlacesItemEditDialog(this);
-    dialog->setWindowTitle(i18nc("@title:window", "Add Places Entry"));
-    dialog->setAllowGlobal(true);
-    dialog->setUrl(url);
-    if (dialog->exec() == QDialog::Accepted) {
-        m_model->createPlacesItem(dialog->text(), dialog->url(), dialog->icon());
+    for (int i = first; i <= last; ++i) {
+        connectDeviceSignals(model()->index(first, 0, parent));

     }
     }

-
-    delete dialog;

 }
 
 }
 

-void PlacesPanel::editEntry(int index)
+void PlacesPanel::slotRowsAboutToBeRemoved(const QModelIndex &parent, int first, int last)

 {
 {

-    QHash<QByteArray, QVariant> data = m_model->data(index);
-
-    QPointer<PlacesItemEditDialog> dialog = new PlacesItemEditDialog(this);
-    dialog->setWindowTitle(i18nc("@title:window", "Edit Places Entry"));
-    dialog->setIcon(data.value("iconName").toString());
-    dialog->setText(data.value("text").toString());
-    dialog->setUrl(data.value("url").toUrl());
-    dialog->setAllowGlobal(true);
-    if (dialog->exec() == QDialog::Accepted) {
-        PlacesItem* oldItem = m_model->placesItem(index);
-        if (oldItem) {
-            oldItem->setText(dialog->text());
-            oldItem->setUrl(dialog->url());
-            oldItem->setIcon(dialog->icon());
-            m_model->refresh();
+    auto *placesModel = static_cast<KFilePlacesModel *>(model());
+
+    for (int i = first; i <= last; ++i) {
+        const QModelIndex index = placesModel->index(i, 0, parent);
+
+        Solid::StorageAccess *storageAccess = placesModel->deviceForIndex(index).as<Solid::StorageAccess>();
+        if (!storageAccess) {
+            continue;

         }
         }

-    }

 
 

-    delete dialog;
+        disconnect(storageAccess, &Solid::StorageAccess::teardownRequested, this, nullptr);
+    }

 }
 
 }
 

-void PlacesPanel::selectClosestItem()
+void PlacesPanel::connectDeviceSignals(const QModelIndex &index)

 {
 {

-    const int index = m_model->closestItem(url());
-    KItemListSelectionManager* selectionManager = m_controller->selectionManager();
-    selectionManager->setCurrentItem(index);
-    selectionManager->clearSelection();
-    selectionManager->setSelected(index);
-}
+    auto *placesModel = static_cast<KFilePlacesModel *>(model());

 
 

-void PlacesPanel::triggerItem(int index, Qt::MouseButton button)
-{
-    const PlacesItem* item = m_model->placesItem(index);
-    if (!item) {
+    Solid::StorageAccess *storageAccess = placesModel->deviceForIndex(index).as<Solid::StorageAccess>();
+    if (!storageAccess) {

         return;
     }
 
         return;
     }
 

-    if (m_model->storageSetupNeeded(index)) {
-        m_triggerStorageSetupButton = button;
-        m_storageSetupFailedUrl = url();
-
-        connect(m_model, &PlacesItemModel::storageSetupDone,
-                this, &PlacesPanel::slotStorageSetupDone);
-
-        m_model->requestStorageSetup(index);
-    } else {
-        m_triggerStorageSetupButton = Qt::NoButton;
-
-        const QUrl url = m_model->data(index).value("url").toUrl();
-        if (!url.isEmpty()) {
-            if (button == Qt::MiddleButton) {
-                emit placeMiddleClicked(KFilePlacesModel::convertedUrl(url));
-            } else {
-                emit placeActivated(KFilePlacesModel::convertedUrl(url));
-            }
-        }
-    }
+    connect(storageAccess, &Solid::StorageAccess::teardownRequested, this, &PlacesPanel::slotTearDownRequestedExternally);

 }
 }