Fix dolphin to only enable the Cut context menu option if the file capabilites suppor...

[dolphin.git] / src / iconmanager.cpp

diff --git a/src/iconmanager.cpp b/src/iconmanager.cpp
index 72549d71b196aec20b78ae17abb35ca91718658c..a8ccc9ed1d090ac9b018162117a96dbce2e95955 100644 (file)
--- a/src/iconmanager.cpp
+++ b/src/iconmanager.cpp
@@ -84,8 +84,9 @@ void IconManager::updatePreviews()
     }
 
     killJobs();
-    KFileItemList itemList;
+    m_cutItemsCache.clear();
 
+    KFileItemList itemList;
     const int rowCount = m_dolphinModel->rowCount();
     for (int row = 0; row < rowCount; ++row) {
         const QModelIndex index = m_dolphinModel->index(row, 0);
@@ -94,10 +95,13 @@ void IconManager::updatePreviews()
     }
 
     generatePreviews(itemList);
+    updateCutItems();
 }
 
-void IconManager::generatePreviews(const KFileItemList &items)
+void IconManager::generatePreviews(const KFileItemList& items)
 {
+    applyCutItemEffect();
+
     if (!m_showPreview) {
         return;
     }
@@ -131,8 +135,8 @@ void IconManager::generatePreviews(const KFileItemList &items)
 
 void IconManager::addToPreviewQueue(const KFileItem& item, const QPixmap& pixmap)
 {
-    Preview preview;
-    preview.item = item;
+    ItemInfo preview;
+    preview.url = item.url();
     preview.pixmap = pixmap;
     m_previews.append(preview);
 }
@@ -147,7 +151,7 @@ void IconManager::updateCutItems()
 {
     // restore the icons of all previously selected items to the
     // original state...
-    foreach (const CutItem &cutItem, m_cutItemsCache) {
+    foreach (const ItemInfo& cutItem, m_cutItemsCache) {
         const QModelIndex index = m_dolphinModel->indexForUrl(cutItem.url);
         if (index.isValid()) {
             m_dolphinModel->setData(index, QIcon(cutItem.pixmap), Qt::DecorationRole);
@@ -169,13 +173,13 @@ void IconManager::dispatchPreviewQueue()
         // of the view would be triggered for each single preview.
 
         int dispatchCount = 30;
-        if (dispatchCount > m_previews.count()) {
-            dispatchCount = m_previews.count();
+        if (dispatchCount > previewsCount) {
+            dispatchCount = previewsCount;
         }
 
         for (int i = 0; i < dispatchCount; ++i) {
-            const Preview& preview = m_previews.first();
-            replaceIcon(preview.item, preview.pixmap);
+            const ItemInfo& preview = m_previews.first();
+            replaceIcon(preview.url, preview.pixmap);
             m_previews.pop_front();
         }
 
@@ -193,9 +197,9 @@ void IconManager::dispatchPreviewQueue()
     }
 }
 
-void IconManager::replaceIcon(const KFileItem& item, const QPixmap& pixmap)
+void IconManager::replaceIcon(const KUrl& url, const QPixmap& pixmap)
 {
-    Q_ASSERT(!item.isNull());
+    Q_ASSERT(url.isValid());
     if (!m_showPreview) {
         // the preview has been canceled in the meantime
         return;
@@ -206,8 +210,8 @@ void IconManager::replaceIcon(const KFileItem& item, const QPixmap& pixmap)
     KDirLister* dirLister = m_dolphinModel->dirLister();
     bool isOldPreview = true;
     const KUrl::List dirs = dirLister->directories();
-    const QString itemDir = item.url().directory();
-    foreach (const KUrl &url, dirs) {
+    const QString itemDir = url.directory();
+    foreach (const KUrl& url, dirs) {
         if (url.path() == itemDir) {
             isOldPreview = false;
             break;
@@ -217,10 +221,11 @@ void IconManager::replaceIcon(const KFileItem& item, const QPixmap& pixmap)
         return;
     }
 
-    const QModelIndex idx = m_dolphinModel->indexForItem(item);
+    const QModelIndex idx = m_dolphinModel->indexForUrl(url);
     if (idx.isValid() && (idx.column() == 0)) {
         QPixmap icon = pixmap;
 
+        const KFileItem item = m_dolphinModel->itemForIndex(idx);
         const QString mimeType = item.mimetype();
         const QString mimeTypeGroup = mimeType.left(mimeType.indexOf('/'));
         if ((mimeTypeGroup != "image") || !applyImageFrame(icon)) {
@@ -229,6 +234,20 @@ void IconManager::replaceIcon(const KFileItem& item, const QPixmap& pixmap)
 
         const QMimeData* mimeData = QApplication::clipboard()->mimeData();
         if (KonqMimeData::decodeIsCutSelection(mimeData) && isCutItem(item)) {
+            // Remember the current icon in the cache for cut items before
+            // the disabled effect is applied. This makes it possible restoring
+            // the uncut version again when cutting other items.
+            QList<ItemInfo>::iterator begin = m_cutItemsCache.begin();
+            QList<ItemInfo>::iterator end   = m_cutItemsCache.end();
+            for (QList<ItemInfo>::iterator it = begin; it != end; ++it) {
+                if ((*it).url == item.url()) {
+                    (*it).pixmap = icon;
+                    break;
+                }
+            }
+
+            // apply the disabled effect to the icon for marking it as "cut item"
+            // and apply the icon to the item
             KIconEffect iconEffect;
             icon = iconEffect.apply(icon, KIconLoader::Desktop, KIconLoader::DisabledState);
             m_dolphinModel->setData(idx, QIcon(icon), Qt::DecorationRole);
@@ -243,8 +262,8 @@ bool IconManager::isCutItem(const KFileItem& item) const
     const QMimeData* mimeData = QApplication::clipboard()->mimeData();
     const KUrl::List cutUrls = KUrl::List::fromMimeData(mimeData);
 
-    const KUrl& itemUrl = item.url();
-    foreach (const KUrl &url, cutUrls) {
+    const KUrl itemUrl = item.url();
+    foreach (const KUrl& url, cutUrls) {
         if (url == itemUrl) {
             return true;
         }
@@ -263,21 +282,22 @@ void IconManager::applyCutItemEffect()
     KFileItemList items;
     KDirLister* dirLister = m_dolphinModel->dirLister();
     const KUrl::List dirs = dirLister->directories();
-    foreach (const KUrl &url, dirs) {
+    foreach (const KUrl& url, dirs) {
         items << dirLister->itemsForDir(url);
     }
 
-    foreach (const KFileItem &item, items) {
+    foreach (const KFileItem& item, items) {
         if (isCutItem(item)) {
             const QModelIndex index = m_dolphinModel->indexForItem(item);
             const QVariant value = m_dolphinModel->data(index, Qt::DecorationRole);
             if (value.type() == QVariant::Icon) {
                 const QIcon icon(qvariant_cast<QIcon>(value));
-                QPixmap pixmap = icon.pixmap(m_view->iconSize());
+                const QSize actualSize = icon.actualSize(m_view->iconSize());
+                QPixmap pixmap = icon.pixmap(actualSize);
 
                 // remember current pixmap for the item to be able
                 // to restore it when other items get cut
-                CutItem cutItem;
+                ItemInfo cutItem;
                 cutItem.url = item.url();
                 cutItem.pixmap = pixmap;
                 m_cutItemsCache.append(cutItem);