Fix for crash which was introduced by commit

[dolphin.git] / src / kitemviews / kfileitemmodel.cpp

diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index 27265487214efdb4eb98316c9d235f3bd447e624..98249dbd982d39ee796bd3bb4e6554a58a8725b6 100644 (file)
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -1,162 +1,272 @@
-/***************************************************************************
- *   Copyright (C) 2011 by Peter Penz <peter.penz19@gmail.com>             *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
- ***************************************************************************/
+/*****************************************************************************
+ *   Copyright (C) 2011 by Peter Penz <peter.penz19@gmail.com>               *
+ *   Copyright (C) 2013 by Frank Reininghaus <frank78ac@googlemail.com>      *
+ *   Copyright (C) 2013 by Emmanuel Pescosta <emmanuelpescosta099@gmail.com> *
+ *                                                                           *
+ *   This program is free software; you can redistribute it and/or modify    *
+ *   it under the terms of the GNU General Public License as published by    *
+ *   the Free Software Foundation; either version 2 of the License, or       *
+ *   (at your option) any later version.                                     *
+ *                                                                           *
+ *   This program is distributed in the hope that it will be useful,         *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of          *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the           *
+ *   GNU General Public License for more details.                            *
+ *                                                                           *
+ *   You should have received a copy of the GNU General Public License       *
+ *   along with this program; if not, write to the                           *
+ *   Free Software Foundation, Inc.,                                         *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA              *
+ *****************************************************************************/

 
 #include "kfileitemmodel.h"
 
 
 #include "kfileitemmodel.h"
 

-#include <KDirLister>
-#include <KDirModel>
-#include <KLocale>
+#include <KGlobalSettings>
+#include <KLocalizedString>

 #include <KStringHandler>
 #include <KDebug>
 
 #include <KStringHandler>
 #include <KDebug>
 

+#include "private/kfileitemmodelsortalgorithm.h"
+#include "private/kfileitemmodeldirlister.h"
+

 #include <QMimeData>
 #include <QTimer>
 #include <QMimeData>
 #include <QTimer>

+#include <QWidget>
+
+#include <algorithm>
+#include <vector>

 
 

-#define KFILEITEMMODEL_DEBUG
+// #define KFILEITEMMODEL_DEBUG

 
 

-KFileItemModel::KFileItemModel(KDirLister* dirLister, QObject* parent) :
-    KItemModelBase("name", parent),
-    m_dirLister(dirLister),
-    m_naturalSorting(true),
-    m_sortFoldersFirst(true),
+KFileItemModel::KFileItemModel(QObject* parent) :
+    KItemModelBase("text", parent),
+    m_dirLister(0),
+    m_naturalSorting(KGlobalSettings::naturalSorting()),
+    m_sortDirsFirst(true),

     m_sortRole(NameRole),
     m_sortRole(NameRole),

-    m_caseSensitivity(Qt::CaseInsensitive),
-    m_sortedItems(),
+    m_sortingProgressPercent(-1),
+    m_roles(),
+    m_itemData(),

     m_items(),
     m_items(),

-    m_data(),
+    m_filter(),
+    m_filteredItems(),

     m_requestRole(),
     m_requestRole(),

-    m_minimumUpdateIntervalTimer(0),

     m_maximumUpdateIntervalTimer(0),
     m_maximumUpdateIntervalTimer(0),

+    m_resortAllItemsTimer(0),

     m_pendingItemsToInsert(),
     m_pendingItemsToInsert(),

-    m_pendingEmitLoadingCompleted(false),

     m_groups(),
     m_groups(),

-    m_rootExpansionLevel(-1),
-    m_expandedUrls(),
-    m_restoredExpandedUrls()
+    m_expandedDirs(),
+    m_urlsToExpand()

 {
 {

+    m_collator.setCaseSensitivity(Qt::CaseInsensitive);
+    m_collator.setNumericMode(true);
+
+    m_dirLister = new KFileItemModelDirLister(this);
+    m_dirLister->setDelayedMimeTypes(true);
+
+    const QWidget* parentWidget = qobject_cast<QWidget*>(parent);
+    if (parentWidget) {
+        m_dirLister->setMainWindow(parentWidget->window());
+    }
+
+    connect(m_dirLister, &KFileItemModelDirLister::started, this, &KFileItemModel::directoryLoadingStarted);
+    connect(m_dirLister, static_cast<void(KFileItemModelDirLister::*)()>(&KFileItemModelDirLister::canceled), this, &KFileItemModel::slotCanceled);
+    connect(m_dirLister, static_cast<void(KFileItemModelDirLister::*)(const QUrl&)>(&KFileItemModelDirLister::completed), this, &KFileItemModel::slotCompleted);
+    connect(m_dirLister, &KFileItemModelDirLister::itemsAdded, this, &KFileItemModel::slotItemsAdded);
+    connect(m_dirLister, &KFileItemModelDirLister::itemsDeleted, this, &KFileItemModel::slotItemsDeleted);
+    connect(m_dirLister, &KFileItemModelDirLister::refreshItems, this, &KFileItemModel::slotRefreshItems);
+    connect(m_dirLister, static_cast<void(KFileItemModelDirLister::*)()>(&KFileItemModelDirLister::clear), this, &KFileItemModel::slotClear);
+    connect(m_dirLister, &KFileItemModelDirLister::infoMessage, this, &KFileItemModel::infoMessage);
+    connect(m_dirLister, &KFileItemModelDirLister::errorMessage, this, &KFileItemModel::errorMessage);
+    connect(m_dirLister, static_cast<void(KFileItemModelDirLister::*)(const QUrl&, const QUrl&)>(&KFileItemModelDirLister::redirection), this, &KFileItemModel::directoryRedirection);
+    connect(m_dirLister, &KFileItemModelDirLister::urlIsFileError, this, &KFileItemModel::urlIsFileError);
+
+    // Apply default roles that should be determined

     resetRoles();
     m_requestRole[NameRole] = true;
     m_requestRole[IsDirRole] = true;
     resetRoles();
     m_requestRole[NameRole] = true;
     m_requestRole[IsDirRole] = true;

-
-    Q_ASSERT(dirLister);
-
-    connect(dirLister, SIGNAL(canceled()), this, SLOT(slotCanceled()));
-    connect(dirLister, SIGNAL(completed()), this, SLOT(slotCompleted()));
-    connect(dirLister, SIGNAL(newItems(KFileItemList)), this, SLOT(slotNewItems(KFileItemList)));
-    connect(dirLister, SIGNAL(itemsDeleted(KFileItemList)), this, SLOT(slotItemsDeleted(KFileItemList)));
-    connect(dirLister, SIGNAL(refreshItems(QList<QPair<KFileItem,KFileItem> >)), this, SLOT(slotRefreshItems(QList<QPair<KFileItem,KFileItem> >)));
-    connect(dirLister, SIGNAL(clear()), this, SLOT(slotClear()));
-    connect(dirLister, SIGNAL(clear(KUrl)), this, SLOT(slotClear(KUrl)));
-
-    // Although the layout engine of KItemListView is fast it is very inefficient to e.g.
-    // emit 50 itemsInserted()-signals each 100 ms. m_minimumUpdateIntervalTimer assures that updates
-    // are done in 1 second intervals for equal operations.
-    m_minimumUpdateIntervalTimer = new QTimer(this);
-    m_minimumUpdateIntervalTimer->setInterval(1000);
-    m_minimumUpdateIntervalTimer->setSingleShot(true);
-    connect(m_minimumUpdateIntervalTimer, SIGNAL(timeout()), this, SLOT(dispatchPendingItemsToInsert()));
+    m_requestRole[IsLinkRole] = true;
+    m_roles.insert("text");
+    m_roles.insert("isDir");
+    m_roles.insert("isLink");

 
     // For slow KIO-slaves like used for searching it makes sense to show results periodically even
     // before the completed() or canceled() signal has been emitted.
     m_maximumUpdateIntervalTimer = new QTimer(this);
     m_maximumUpdateIntervalTimer->setInterval(2000);
     m_maximumUpdateIntervalTimer->setSingleShot(true);
 
     // For slow KIO-slaves like used for searching it makes sense to show results periodically even
     // before the completed() or canceled() signal has been emitted.
     m_maximumUpdateIntervalTimer = new QTimer(this);
     m_maximumUpdateIntervalTimer->setInterval(2000);
     m_maximumUpdateIntervalTimer->setSingleShot(true);

-    connect(m_maximumUpdateIntervalTimer, SIGNAL(timeout()), this, SLOT(dispatchPendingItemsToInsert()));
-
-    Q_ASSERT(m_minimumUpdateIntervalTimer->interval() <= m_maximumUpdateIntervalTimer->interval());
+    connect(m_maximumUpdateIntervalTimer, &QTimer::timeout, this, &KFileItemModel::dispatchPendingItemsToInsert);
+
+    // When changing the value of an item which represents the sort-role a resorting must be
+    // triggered. Especially in combination with KFileItemModelRolesUpdater this might be done
+    // for a lot of items within a quite small timeslot. To prevent expensive resortings the
+    // resorting is postponed until the timer has been exceeded.
+    m_resortAllItemsTimer = new QTimer(this);
+    m_resortAllItemsTimer->setInterval(500);
+    m_resortAllItemsTimer->setSingleShot(true);
+    connect(m_resortAllItemsTimer, &QTimer::timeout, this, &KFileItemModel::resortAllItems);
+
+    connect(KGlobalSettings::self(), &KGlobalSettings::naturalSortingChanged,
+            this, &KFileItemModel::slotNaturalSortingChanged);

 }
 
 KFileItemModel::~KFileItemModel()
 {
 }
 
 KFileItemModel::~KFileItemModel()
 {

+    qDeleteAll(m_itemData);
+    qDeleteAll(m_filteredItems.values());
+    qDeleteAll(m_pendingItemsToInsert);
+}
+
+void KFileItemModel::loadDirectory(const QUrl &url)
+{
+    m_dirLister->openUrl(url);
+}
+
+void KFileItemModel::refreshDirectory(const QUrl &url)
+{
+    // Refresh all expanded directories first (Bug 295300)
+    QHashIterator<QUrl, QUrl> expandedDirs(m_expandedDirs);
+    while (expandedDirs.hasNext()) {
+        expandedDirs.next();
+        m_dirLister->openUrl(expandedDirs.value(), KDirLister::Reload);
+    }
+
+    m_dirLister->openUrl(url, KDirLister::Reload);
+}
+
+QUrl KFileItemModel::directory() const
+{
+    return m_dirLister->url();
+}
+
+void KFileItemModel::cancelDirectoryLoading()
+{
+    m_dirLister->stop();

 }
 
 int KFileItemModel::count() const
 {
 }
 
 int KFileItemModel::count() const
 {

-    return m_data.count();
+    return m_itemData.count();

 }
 
 QHash<QByteArray, QVariant> KFileItemModel::data(int index) const
 {
     if (index >= 0 && index < count()) {
 }
 
 QHash<QByteArray, QVariant> KFileItemModel::data(int index) const
 {
     if (index >= 0 && index < count()) {

-        return m_data.at(index);
+        ItemData* data = m_itemData.at(index);
+        if (data->values.isEmpty()) {
+            data->values = retrieveData(data->item, data->parent);
+        }
+
+        return data->values;

     }
     return QHash<QByteArray, QVariant>();
 }
 
 bool KFileItemModel::setData(int index, const QHash<QByteArray, QVariant>& values)
 {
     }
     return QHash<QByteArray, QVariant>();
 }
 
 bool KFileItemModel::setData(int index, const QHash<QByteArray, QVariant>& values)
 {

-    if (index >= 0 && index < count()) {
-        QHash<QByteArray, QVariant> currentValue = m_data.at(index);
-
-        QSet<QByteArray> changedRoles;
-        QHashIterator<QByteArray, QVariant> it(values);
-        while (it.hasNext()) {
-            it.next();
-            const QByteArray role = it.key();
-            const QVariant value = it.value();
-
-            if (currentValue[role] != value) {
-                currentValue[role] = value;
-                changedRoles.insert(role);
-            }
-        }
+    if (index < 0 || index >= count()) {
+        return false;
+    }
+
+    QHash<QByteArray, QVariant> currentValues = data(index);

 
 

-        if (!changedRoles.isEmpty()) {
-            m_data[index] = currentValue;
-            emit itemsChanged(KItemRangeList() << KItemRange(index, 1), changedRoles);
+    // Determine which roles have been changed
+    QSet<QByteArray> changedRoles;
+    QHashIterator<QByteArray, QVariant> it(values);
+    while (it.hasNext()) {
+        it.next();
+        const QByteArray role = sharedValue(it.key());
+        const QVariant value = it.value();
+
+        if (currentValues[role] != value) {
+            currentValues[role] = value;
+            changedRoles.insert(role);

         }
         }

+    }
+
+    if (changedRoles.isEmpty()) {
+        return false;
+    }

 
 

-        return true;
+    m_itemData[index]->values = currentValues;
+    if (changedRoles.contains("text")) {
+        QUrl url = m_itemData[index]->item.url();
+        url = url.adjusted(QUrl::RemoveFilename);
+        url.setPath(url.path() + currentValues["text"].toString());
+        m_itemData[index]->item.setUrl(url);

     }
     }

-    return false;
+
+    emitItemsChangedAndTriggerResorting(KItemRangeList() << KItemRange(index, 1), changedRoles);
+
+    return true;

 }
 
 }
 

-void KFileItemModel::setSortFoldersFirst(bool foldersFirst)
+void KFileItemModel::setSortDirectoriesFirst(bool dirsFirst)

 {
 {

-    if (foldersFirst != m_sortFoldersFirst) {
-        m_sortFoldersFirst = foldersFirst;
+    if (dirsFirst != m_sortDirsFirst) {
+        m_sortDirsFirst = dirsFirst;

         resortAllItems();
     }
 }
 
         resortAllItems();
     }
 }
 

-bool KFileItemModel::sortFoldersFirst() const
+bool KFileItemModel::sortDirectoriesFirst() const
+{
+    return m_sortDirsFirst;
+}
+
+void KFileItemModel::setShowHiddenFiles(bool show)
+{
+    m_dirLister->setShowingDotFiles(show);
+    m_dirLister->emitChanges();
+    if (show) {
+        dispatchPendingItemsToInsert();
+    }
+}
+
+bool KFileItemModel::showHiddenFiles() const
+{
+    return m_dirLister->showingDotFiles();
+}
+
+void KFileItemModel::setShowDirectoriesOnly(bool enabled)
+{
+    m_dirLister->setDirOnlyMode(enabled);
+}
+
+bool KFileItemModel::showDirectoriesOnly() const

 {
 {

-    return m_sortFoldersFirst;
+    return m_dirLister->dirOnlyMode();

 }
 
 }
 

-QMimeData* KFileItemModel::createMimeData(const QSet<int>& indexes) const
+QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const

 {
     QMimeData* data = new QMimeData();
 
     // The following code has been taken from KDirModel::mimeData()
     // (kdelibs/kio/kio/kdirmodel.cpp)
     // Copyright (C) 2006 David Faure <faure@kde.org>
 {
     QMimeData* data = new QMimeData();
 
     // The following code has been taken from KDirModel::mimeData()
     // (kdelibs/kio/kio/kdirmodel.cpp)
     // Copyright (C) 2006 David Faure <faure@kde.org>

-    KUrl::List urls;
-    KUrl::List mostLocalUrls;
+    QList<QUrl> urls;
+    QList<QUrl> mostLocalUrls;

     bool canUseMostLocalUrls = true;
     bool canUseMostLocalUrls = true;

+    const ItemData* lastAddedItem = 0;

 
 

-    QSetIterator<int> it(indexes);
-    while (it.hasNext()) {
-        const int index = it.next();
-        const KFileItem item = fileItem(index);
+    foreach (int index, indexes) {
+        const ItemData* itemData = m_itemData.at(index);
+        const ItemData* parent = itemData->parent;
+
+        while (parent && parent != lastAddedItem) {
+            parent = parent->parent;
+        }
+
+        if (parent && parent == lastAddedItem) {
+            // A parent of 'itemData' has been added already.
+            continue;
+        }
+
+        lastAddedItem = itemData;
+        const KFileItem& item = itemData->item;

         if (!item.isNull()) {
         if (!item.isNull()) {

-            urls << item.url();
+            urls << item.targetUrl();

 
             bool isLocal;
             mostLocalUrls << item.mostLocalUrl(isLocal);
 
             bool isLocal;
             mostLocalUrls << item.mostLocalUrl(isLocal);


@@ -167,12 +277,10 @@ QMimeData* KFileItemModel::createMimeData(const QSet<int>& indexes) const
     }
 
     const bool different = canUseMostLocalUrls && mostLocalUrls != urls;
     }
 
     const bool different = canUseMostLocalUrls && mostLocalUrls != urls;

-    urls = KDirModel::simplifiedUrlList(urls); // TODO: Check if we still need KDirModel for this in KDE 5.0

     if (different) {
     if (different) {

-        mostLocalUrls = KDirModel::simplifiedUrlList(mostLocalUrls);
-        urls.populateMimeData(mostLocalUrls, data);
+        data->setUrls(mostLocalUrls);

     } else {
     } else {

-        urls.populateMimeData(data);
+        data->setUrls(urls);

     }
 
     return data;
     }
 
     return data;


@@ -182,12 +290,12 @@ int KFileItemModel::indexForKeyboardSearch(const QString& text, int startFromInd
 {
     startFromIndex = qMax(0, startFromIndex);
     for (int i = startFromIndex; i < count(); ++i) {
 {
     startFromIndex = qMax(0, startFromIndex);
     for (int i = startFromIndex; i < count(); ++i) {

-        if (data(i)["name"].toString().startsWith(text, Qt::CaseInsensitive)) {
+        if (fileItem(i).text().startsWith(text, Qt::CaseInsensitive)) {

             return i;
         }
     }
     for (int i = 0; i < startFromIndex; ++i) {
             return i;
         }
     }
     for (int i = 0; i < startFromIndex; ++i) {

-        if (data(i)["name"].toString().startsWith(text, Qt::CaseInsensitive)) {
+        if (fileItem(i).text().startsWith(text, Qt::CaseInsensitive)) {

             return i;
         }
     }
             return i;
         }
     }


@@ -197,55 +305,37 @@ int KFileItemModel::indexForKeyboardSearch(const QString& text, int startFromInd
 bool KFileItemModel::supportsDropping(int index) const
 {
     const KFileItem item = fileItem(index);
 bool KFileItemModel::supportsDropping(int index) const
 {
     const KFileItem item = fileItem(index);

-    return item.isNull() ? false : item.isDir();
+    return !item.isNull() && (item.isDir() || item.isDesktopFile());

 }
 
 QString KFileItemModel::roleDescription(const QByteArray& role) const
 {
 }
 
 QString KFileItemModel::roleDescription(const QByteArray& role) const
 {

-    QString descr;
-
-    switch (roleIndex(role)) {
-    case NameRole:           descr = i18nc("@item:intable", "Name"); break;
-    case SizeRole:           descr = i18nc("@item:intable", "Size"); break;
-    case DateRole:           descr = i18nc("@item:intable", "Date"); break;
-    case PermissionsRole:    descr = i18nc("@item:intable", "Permissions"); break;
-    case OwnerRole:          descr = i18nc("@item:intable", "Owner"); break;
-    case GroupRole:          descr = i18nc("@item:intable", "Group"); break;
-    case TypeRole:           descr = i18nc("@item:intable", "Type"); break;
-    case DestinationRole:    descr = i18nc("@item:intable", "Destination"); break;
-    case PathRole:           descr = i18nc("@item:intable", "Path"); break;
-    case NoRole:             break;
-    case IsDirRole:          break;
-    case IsExpandedRole:     break;
-    case ExpansionLevelRole: break;
-    default:                 Q_ASSERT(false); break;
+    static QHash<QByteArray, QString> description;
+    if (description.isEmpty()) {
+        int count = 0;
+        const RoleInfoMap* map = rolesInfoMap(count);
+        for (int i = 0; i < count; ++i) {
+            description.insert(map[i].role, i18nc(map[i].roleTranslationContext, map[i].roleTranslation));
+        }

     }
 
     }
 

-    return descr;
+    return description.value(role);

 }
 
 QList<QPair<int, QVariant> > KFileItemModel::groups() const
 {
 }
 
 QList<QPair<int, QVariant> > KFileItemModel::groups() const
 {

-    if (!m_data.isEmpty() && m_groups.isEmpty()) {
+    if (!m_itemData.isEmpty() && m_groups.isEmpty()) {

 #ifdef KFILEITEMMODEL_DEBUG
         QElapsedTimer timer;
         timer.start();
 #endif
 #ifdef KFILEITEMMODEL_DEBUG
         QElapsedTimer timer;
         timer.start();
 #endif

-        switch (roleIndex(sortRole())) {
-        case NameRole:           m_groups = nameRoleGroups(); break;
-        case SizeRole:           m_groups = sizeRoleGroups(); break;
-        case DateRole:           m_groups = dateRoleGroups(); break;
-        case PermissionsRole:    m_groups = permissionRoleGroups(); break;
-        case OwnerRole:          m_groups = ownerRoleGroups(); break;
-        case GroupRole:          m_groups = groupRoleGroups(); break;
-        case TypeRole:           m_groups = typeRoleGroups(); break;
-        case DestinationRole:    m_groups = destinationRoleGroups(); break;
-        case PathRole:           m_groups = pathRoleGroups(); break;
-        case NoRole:             break;
-        case IsDirRole:          break;
-        case IsExpandedRole:     break;
-        case ExpansionLevelRole: break;
-        default:                 Q_ASSERT(false); break;
+        switch (typeForRole(sortRole())) {
+        case NameRole:        m_groups = nameRoleGroups(); break;
+        case SizeRole:        m_groups = sizeRoleGroups(); break;
+        case DateRole:        m_groups = dateRoleGroups(); break;
+        case PermissionsRole: m_groups = permissionRoleGroups(); break;
+        case RatingRole:      m_groups = ratingRoleGroups(); break;
+        default:              m_groups = genericStringRoleGroups(sortRole()); break;

         }
 
 #ifdef KFILEITEMMODEL_DEBUG
         }
 
 #ifdef KFILEITEMMODEL_DEBUG


@@ -259,44 +349,96 @@ QList<QPair<int, QVariant> > KFileItemModel::groups() const
 KFileItem KFileItemModel::fileItem(int index) const
 {
     if (index >= 0 && index < count()) {
 KFileItem KFileItemModel::fileItem(int index) const
 {
     if (index >= 0 && index < count()) {

-        return m_sortedItems.at(index);
+        return m_itemData.at(index)->item;

     }
 
     return KFileItem();
 }
 
     }
 
     return KFileItem();
 }
 

-KFileItem KFileItemModel::fileItem(const KUrl& url) const
+KFileItem KFileItemModel::fileItem(const QUrl &url) const

 {
 {

-    const int index = m_items.value(url, -1);
-    if (index >= 0) {
-        return m_sortedItems.at(index);
+    const int indexForUrl = index(url);
+    if (indexForUrl >= 0) {
+        return m_itemData.at(indexForUrl)->item;

     }
     return KFileItem();
 }
 
 int KFileItemModel::index(const KFileItem& item) const
 {
     }
     return KFileItem();
 }
 
 int KFileItemModel::index(const KFileItem& item) const
 {

-    if (item.isNull()) {
-        return -1;
-    }
-
-    return m_items.value(item.url(), -1);
+    return index(item.url());

 }
 
 }
 

-int KFileItemModel::index(const KUrl& url) const
+int KFileItemModel::index(const QUrl& url) const

 {
 {

-    KUrl urlToFind = url;
-    urlToFind.adjustPath(KUrl::RemoveTrailingSlash);
-    return m_items.value(urlToFind, -1);
+    const QUrl urlToFind = url.adjusted(QUrl::StripTrailingSlash);
+
+    const int itemCount = m_itemData.count();
+    int itemsInHash = m_items.count();
+
+    int index = m_items.value(urlToFind, -1);
+    while (index < 0 && itemsInHash < itemCount) {
+        // Not all URLs are stored yet in m_items. We grow m_items until either
+        // urlToFind is found, or all URLs have been stored in m_items.
+        // Note that we do not add the URLs to m_items one by one, but in
+        // larger blocks. After each block, we check if urlToFind is in
+        // m_items. We could in principle compare urlToFind with each URL while
+        // we are going through m_itemData, but comparing two QUrls will,
+        // unlike calling qHash for the URLs, trigger a parsing of the URLs
+        // which costs both CPU cycles and memory.
+        const int blockSize = 1000;
+        const int currentBlockEnd = qMin(itemsInHash + blockSize, itemCount);
+        for (int i = itemsInHash; i < currentBlockEnd; ++i) {
+            const QUrl nextUrl = m_itemData.at(i)->item.url();
+            m_items.insert(nextUrl, i);
+        }
+
+        itemsInHash = currentBlockEnd;
+        index = m_items.value(urlToFind, -1);
+    }
+
+    if (index < 0) {
+        // The item could not be found, even though all items from m_itemData
+        // should be in m_items now. We print some diagnostic information which
+        // might help to find the cause of the problem, but only once. This
+        // prevents that obtaining and printing the debugging information
+        // wastes CPU cycles and floods the shell or .xsession-errors.
+        static bool printDebugInfo = true;
+
+        if (m_items.count() != m_itemData.count() && printDebugInfo) {
+            printDebugInfo = false;
+
+            kWarning() << "The model is in an inconsistent state.";
+            kWarning() << "m_items.count()    ==" << m_items.count();
+            kWarning() << "m_itemData.count() ==" << m_itemData.count();
+
+            // Check if there are multiple items with the same URL.
+            QMultiHash<QUrl, int> indexesForUrl;
+            for (int i = 0; i < m_itemData.count(); ++i) {
+                indexesForUrl.insert(m_itemData.at(i)->item.url(), i);
+            }
+
+            foreach (const QUrl& url, indexesForUrl.uniqueKeys()) {
+                if (indexesForUrl.count(url) > 1) {
+                    kWarning() << "Multiple items found with the URL" << url;
+                    foreach (int index, indexesForUrl.values(url)) {
+                        const ItemData* data = m_itemData.at(index);
+                        kWarning() << "index" << index << ":" << data->item;
+                        if (data->parent) {
+                            kWarning() << "parent" << data->parent->item;
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    return index;

 }
 
 KFileItem KFileItemModel::rootItem() const
 {
 }
 
 KFileItem KFileItemModel::rootItem() const
 {

-    const KDirLister* dirLister = m_dirLister.data();
-    if (dirLister) {
-        return dirLister->rootItem();
-    }
-    return KFileItem();
+    return m_dirLister->rootItem();

 }
 
 void KFileItemModel::clear()
 }
 
 void KFileItemModel::clear()


@@ -306,9 +448,16 @@ void KFileItemModel::clear()
 
 void KFileItemModel::setRoles(const QSet<QByteArray>& roles)
 {
 
 void KFileItemModel::setRoles(const QSet<QByteArray>& roles)
 {

+    if (m_roles == roles) {
+        return;
+    }
+
+    const QSet<QByteArray> changedRoles = (roles - m_roles) + (m_roles - roles);
+    m_roles = roles;
+

     if (count() > 0) {
     if (count() > 0) {

-        const bool supportedExpanding = m_requestRole[IsExpandedRole] && m_requestRole[ExpansionLevelRole];
-        const bool willSupportExpanding = roles.contains("isExpanded") && roles.contains("expansionLevel");
+        const bool supportedExpanding = m_requestRole[ExpandedParentsCountRole];
+        const bool willSupportExpanding = roles.contains("expandedParentsCount");

         if (supportedExpanding && !willSupportExpanding) {
             // No expanding is supported anymore. Take care to delete all items that have an expansion level
             // that is not 0 (and hence are part of an expanded item).
         if (supportedExpanding && !willSupportExpanding) {
             // No expanding is supported anymore. Take care to delete all items that have an expansion level
             // that is not 0 (and hence are part of an expanded item).


@@ -316,93 +465,112 @@ void KFileItemModel::setRoles(const QSet<QByteArray>& roles)
         }
     }
 
         }
     }
 

+    m_groups.clear();

     resetRoles();
     resetRoles();

+

     QSetIterator<QByteArray> it(roles);
     while (it.hasNext()) {
         const QByteArray& role = it.next();
     QSetIterator<QByteArray> it(roles);
     while (it.hasNext()) {
         const QByteArray& role = it.next();

-        m_requestRole[roleIndex(role)] = true;
+        m_requestRole[typeForRole(role)] = true;

     }
 
     if (count() > 0) {
         // Update m_data with the changed requested roles
         const int maxIndex = count() - 1;
         for (int i = 0; i <= maxIndex; ++i) {
     }
 
     if (count() > 0) {
         // Update m_data with the changed requested roles
         const int maxIndex = count() - 1;
         for (int i = 0; i <= maxIndex; ++i) {

-            m_data[i] = retrieveData(m_sortedItems.at(i));
+            m_itemData[i]->values = retrieveData(m_itemData.at(i)->item, m_itemData.at(i)->parent);

         }
 
         }
 

-        kWarning() << "TODO: Emitting itemsChanged() with no information what has changed!";
-        emit itemsChanged(KItemRangeList() << KItemRange(0, count()), QSet<QByteArray>());
+        emit itemsChanged(KItemRangeList() << KItemRange(0, count()), changedRoles);
+    }
+
+    // Clear the 'values' of all filtered items. They will be re-populated with the
+    // correct roles the next time 'values' will be accessed via data(int).
+    QHash<KFileItem, ItemData*>::iterator filteredIt = m_filteredItems.begin();
+    const QHash<KFileItem, ItemData*>::iterator filteredEnd = m_filteredItems.end();
+    while (filteredIt != filteredEnd) {
+        (*filteredIt)->values.clear();
+        ++filteredIt;

     }
 }
 
 QSet<QByteArray> KFileItemModel::roles() const
 {
     }
 }
 
 QSet<QByteArray> KFileItemModel::roles() const
 {

-    QSet<QByteArray> roles;
-    for (int i = 0; i < RolesCount; ++i) {
-        if (m_requestRole[i]) {
-            switch (i) {
-            case NoRole:             break;
-            case NameRole:           roles.insert("name"); break;
-            case SizeRole:           roles.insert("size"); break;
-            case DateRole:           roles.insert("date"); break;
-            case PermissionsRole:    roles.insert("permissions"); break;
-            case OwnerRole:          roles.insert("owner"); break;
-            case GroupRole:          roles.insert("group"); break;
-            case TypeRole:           roles.insert("type"); break;
-            case DestinationRole:    roles.insert("destination"); break;
-            case PathRole:           roles.insert("path"); break;
-            case IsDirRole:          roles.insert("isDir"); break;
-            case IsExpandedRole:     roles.insert("isExpanded"); break;
-            case ExpansionLevelRole: roles.insert("expansionLevel"); break;
-            default:                 Q_ASSERT(false); break;
-            }
-        }
-    }
-    return roles;
+    return m_roles;

 }
 
 bool KFileItemModel::setExpanded(int index, bool expanded)
 {
 }
 
 bool KFileItemModel::setExpanded(int index, bool expanded)
 {

-    if (isExpanded(index) == expanded || index < 0 || index >= count()) {
+    if (!isExpandable(index) || isExpanded(index) == expanded) {

         return false;
     }
 
     QHash<QByteArray, QVariant> values;
         return false;
     }
 
     QHash<QByteArray, QVariant> values;

-    values.insert("isExpanded", expanded);
+    values.insert(sharedValue("isExpanded"), expanded);

     if (!setData(index, values)) {
         return false;
     }
 
     if (!setData(index, values)) {
         return false;
     }
 

-    const KUrl url = m_sortedItems.at(index).url();
+    const KFileItem item = m_itemData.at(index)->item;
+    const QUrl url = item.url();
+    const QUrl targetUrl = item.targetUrl();

     if (expanded) {
     if (expanded) {

-        m_expandedUrls.insert(url);
+        m_expandedDirs.insert(targetUrl, url);
+        m_dirLister->openUrl(url, KDirLister::Keep);

 
 

-        KDirLister* dirLister = m_dirLister.data();
-        if (dirLister) {
-            dirLister->openUrl(url, KDirLister::Keep);
-            return true;
+        const QVariantList previouslyExpandedChildren = m_itemData.at(index)->values.value("previouslyExpandedChildren").value<QVariantList>();
+        foreach (const QVariant& var, previouslyExpandedChildren) {
+            m_urlsToExpand.insert(var.toUrl());

         }
     } else {
         }
     } else {

-        m_expandedUrls.remove(url);
+        // Note that there might be (indirect) children of the folder which is to be collapsed in
+        // m_pendingItemsToInsert. To prevent that they will be inserted into the model later,
+        // possibly without a parent, which might result in a crash, we insert all pending items
+        // right now. All new items which would be without a parent will then be removed.
+        dispatchPendingItemsToInsert();
+
+        // Check if the index of the collapsed folder has changed. If that is the case, then items
+        // were inserted before the collapsed folder, and its index needs to be updated.
+        if (m_itemData.at(index)->item != item) {
+            index = this->index(item);
+        }

 
 

-        KFileItemList itemsToRemove;
-        const int expansionLevel = data(index)["expansionLevel"].toInt();
-        ++index;
-        while (index < count() && data(index)["expansionLevel"].toInt() > expansionLevel) {
-            itemsToRemove.append(m_sortedItems.at(index));
-            ++index;
+        m_expandedDirs.remove(targetUrl);
+        m_dirLister->stop(url);
+
+        const int parentLevel = expandedParentsCount(index);
+        const int itemCount = m_itemData.count();
+        const int firstChildIndex = index + 1;
+
+        QVariantList expandedChildren;
+
+        int childIndex = firstChildIndex;
+        while (childIndex < itemCount && expandedParentsCount(childIndex) > parentLevel) {
+            ItemData* itemData = m_itemData.at(childIndex);
+            if (itemData->values.value("isExpanded").toBool()) {
+                const QUrl targetUrl = itemData->item.targetUrl();
+                const QUrl url = itemData->item.url();
+                m_expandedDirs.remove(targetUrl);
+                m_dirLister->stop(url);     // TODO: try to unit-test this, see https://bugs.kde.org/show_bug.cgi?id=332102#c11
+                expandedChildren.append(targetUrl);
+            }
+            ++childIndex;

         }
         }

-        removeItems(itemsToRemove);
-        return true;
+        const int childrenCount = childIndex - firstChildIndex;
+
+        removeFilteredChildren(KItemRangeList() << KItemRange(index, 1 + childrenCount));
+        removeItems(KItemRangeList() << KItemRange(firstChildIndex, childrenCount), DeleteItemData);
+
+        m_itemData.at(index)->values.insert("previouslyExpandedChildren", expandedChildren);

     }
 
     }
 

-    return false;
+    return true;

 }
 
 bool KFileItemModel::isExpanded(int index) const
 {
     if (index >= 0 && index < count()) {
 }
 
 bool KFileItemModel::isExpanded(int index) const
 {
     if (index >= 0 && index < count()) {

-        return m_data.at(index).value("isExpanded").toBool();
+        return m_itemData.at(index)->values.value("isExpanded").toBool();

     }
     return false;
 }
     }
     return false;
 }


@@ -410,19 +578,182 @@ bool KFileItemModel::isExpanded(int index) const
 bool KFileItemModel::isExpandable(int index) const
 {
     if (index >= 0 && index < count()) {
 bool KFileItemModel::isExpandable(int index) const
 {
     if (index >= 0 && index < count()) {

-        return m_sortedItems.at(index).isDir();
+        // Call data (instead of accessing m_itemData directly)
+        // to ensure that the value is initialized.
+        return data(index).value("isExpandable").toBool();

     }
     return false;
 }
 
     }
     return false;
 }
 

-QSet<KUrl> KFileItemModel::expandedUrls() const
+int KFileItemModel::expandedParentsCount(int index) const
+{
+    if (index >= 0 && index < count()) {
+        return expandedParentsCount(m_itemData.at(index));
+    }
+    return 0;
+}
+
+QSet<QUrl> KFileItemModel::expandedDirectories() const
+{
+    return m_expandedDirs.values().toSet();
+}
+
+void KFileItemModel::restoreExpandedDirectories(const QSet<QUrl> &urls)
+{
+    m_urlsToExpand = urls;
+}
+
+void KFileItemModel::expandParentDirectories(const QUrl &url)
+{
+    const int pos = m_dirLister->url().path().length();
+
+    // Assure that each sub-path of the URL that should be
+    // expanded is added to m_urlsToExpand. KDirLister
+    // does not care whether the parent-URL has already been
+    // expanded.
+    QUrl urlToExpand = m_dirLister->url();
+    const QStringList subDirs = url.path().mid(pos).split(QDir::separator());
+    for (int i = 0; i < subDirs.count() - 1; ++i) {
+        urlToExpand.setPath(urlToExpand.path() + '/' + subDirs.at(i));
+        m_urlsToExpand.insert(urlToExpand);
+    }
+
+    // KDirLister::open() must called at least once to trigger an initial
+    // loading. The pending URLs that must be restored are handled
+    // in slotCompleted().
+    QSetIterator<QUrl> it2(m_urlsToExpand);
+    while (it2.hasNext()) {
+        const int idx = index(it2.next());
+        if (idx >= 0 && !isExpanded(idx)) {
+            setExpanded(idx, true);
+            break;
+        }
+    }
+}
+
+void KFileItemModel::setNameFilter(const QString& nameFilter)
+{
+    if (m_filter.pattern() != nameFilter) {
+        dispatchPendingItemsToInsert();
+        m_filter.setPattern(nameFilter);
+        applyFilters();
+    }
+}
+
+QString KFileItemModel::nameFilter() const
+{
+    return m_filter.pattern();
+}
+
+void KFileItemModel::setMimeTypeFilters(const QStringList& filters)
+{
+    if (m_filter.mimeTypes() != filters) {
+        dispatchPendingItemsToInsert();
+        m_filter.setMimeTypes(filters);
+        applyFilters();
+    }
+}
+
+QStringList KFileItemModel::mimeTypeFilters() const
+{
+    return m_filter.mimeTypes();
+}
+
+
+void KFileItemModel::applyFilters()
+{
+    // Check which shown items from m_itemData must get
+    // hidden and hence moved to m_filteredItems.
+    QVector<int> newFilteredIndexes;
+
+    const int itemCount = m_itemData.count();
+    for (int index = 0; index < itemCount; ++index) {
+        ItemData* itemData = m_itemData.at(index);
+
+        // Only filter non-expanded items as child items may never
+        // exist without a parent item
+        if (!itemData->values.value("isExpanded").toBool()) {
+            const KFileItem item = itemData->item;
+            if (!m_filter.matches(item)) {
+                newFilteredIndexes.append(index);
+                m_filteredItems.insert(item, itemData);
+            }
+        }
+    }
+
+    const KItemRangeList removedRanges = KItemRangeList::fromSortedContainer(newFilteredIndexes);
+    removeItems(removedRanges, KeepItemData);
+
+    // Check which hidden items from m_filteredItems should
+    // get visible again and hence removed from m_filteredItems.
+    QList<ItemData*> newVisibleItems;
+
+    QHash<KFileItem, ItemData*>::iterator it = m_filteredItems.begin();
+    while (it != m_filteredItems.end()) {
+        if (m_filter.matches(it.key())) {
+            newVisibleItems.append(it.value());
+            it = m_filteredItems.erase(it);
+        } else {
+            ++it;
+        }
+    }
+
+    insertItems(newVisibleItems);
+}
+
+void KFileItemModel::removeFilteredChildren(const KItemRangeList& itemRanges)

 {
 {

-    return m_expandedUrls;
+    if (m_filteredItems.isEmpty() || !m_requestRole[ExpandedParentsCountRole]) {
+        // There are either no filtered items, or it is not possible to expand
+        // folders -> there cannot be any filtered children.
+        return;
+    }
+
+    QSet<ItemData*> parents;
+    foreach (const KItemRange& range, itemRanges) {
+        for (int index = range.index; index < range.index + range.count; ++index) {
+            parents.insert(m_itemData.at(index));
+        }
+    }
+
+    QHash<KFileItem, ItemData*>::iterator it = m_filteredItems.begin();
+    while (it != m_filteredItems.end()) {
+        if (parents.contains(it.value()->parent)) {
+            delete it.value();
+            it = m_filteredItems.erase(it);
+        } else {
+            ++it;
+        }
+    }

 }
 
 }
 

-void KFileItemModel::restoreExpandedUrls(const QSet<KUrl>& urls)
+QList<KFileItemModel::RoleInfo> KFileItemModel::rolesInformation()

 {
 {

-    m_restoredExpandedUrls = urls;
+    static QList<RoleInfo> rolesInfo;
+    if (rolesInfo.isEmpty()) {
+        int count = 0;
+        const RoleInfoMap* map = rolesInfoMap(count);
+        for (int i = 0; i < count; ++i) {
+            if (map[i].roleType != NoRole) {
+                RoleInfo info;
+                info.role = map[i].role;
+                info.translation = i18nc(map[i].roleTranslationContext, map[i].roleTranslation);
+                if (map[i].groupTranslation) {
+                    info.group = i18nc(map[i].groupTranslationContext, map[i].groupTranslation);
+                } else {
+                    // For top level roles, groupTranslation is 0. We must make sure that
+                    // info.group is an empty string then because the code that generates
+                    // menus tries to put the actions into sub menus otherwise.
+                    info.group = QString();
+                }
+                info.requiresBaloo = map[i].requiresBaloo;
+                info.requiresIndexer = map[i].requiresIndexer;
+                rolesInfo.append(info);
+            }
+        }
+    }
+
+    return rolesInfo;

 }
 
 void KFileItemModel::onGroupedSortingChanged(bool current)
 }
 
 void KFileItemModel::onGroupedSortingChanged(bool current)


@@ -434,7 +765,14 @@ void KFileItemModel::onGroupedSortingChanged(bool current)
 void KFileItemModel::onSortRoleChanged(const QByteArray& current, const QByteArray& previous)
 {
     Q_UNUSED(previous);
 void KFileItemModel::onSortRoleChanged(const QByteArray& current, const QByteArray& previous)
 {
     Q_UNUSED(previous);

-    m_sortRole = roleIndex(current);
+    m_sortRole = typeForRole(current);
+
+    if (!m_requestRole[m_sortRole]) {
+        QSet<QByteArray> newRoles = m_roles;
+        newRoles << current;
+        setRoles(newRoles);
+    }
+

     resortAllItems();
 }
 
     resortAllItems();
 }
 


@@ -445,53 +783,176 @@ void KFileItemModel::onSortOrderChanged(Qt::SortOrder current, Qt::SortOrder pre
     resortAllItems();
 }
 
     resortAllItems();
 }
 

-void KFileItemModel::slotCompleted()
+void KFileItemModel::resortAllItems()

 {
 {

-    if (m_restoredExpandedUrls.isEmpty() && m_minimumUpdateIntervalTimer->isActive()) {
-        // dispatchPendingItems() will be called when the timer
-        // has been expired.
-        m_pendingEmitLoadingCompleted = true;
+    m_resortAllItemsTimer->stop();
+
+    const int itemCount = count();
+    if (itemCount <= 0) {

         return;
     }
 
         return;
     }
 

-    m_pendingEmitLoadingCompleted = false;
+#ifdef KFILEITEMMODEL_DEBUG
+    QElapsedTimer timer;
+    timer.start();
+    kDebug() << "===========================================================";
+    kDebug() << "Resorting" << itemCount << "items";
+#endif
+
+    // Remember the order of the current URLs so
+    // that it can be determined which indexes have
+    // been moved because of the resorting.
+    QList<QUrl> oldUrls;
+    oldUrls.reserve(itemCount);
+    foreach (const ItemData* itemData, m_itemData) {
+        oldUrls.append(itemData->item.url());
+    }
+
+    m_items.clear();
+    m_items.reserve(itemCount);
+
+    // Resort the items
+    sort(m_itemData.begin(), m_itemData.end());
+    for (int i = 0; i < itemCount; ++i) {
+        m_items.insert(m_itemData.at(i)->item.url(), i);
+    }
+
+    // Determine the first index that has been moved.
+    int firstMovedIndex = 0;
+    while (firstMovedIndex < itemCount
+           && firstMovedIndex == m_items.value(oldUrls.at(firstMovedIndex))) {
+        ++firstMovedIndex;
+    }
+
+    const bool itemsHaveMoved = firstMovedIndex < itemCount;
+    if (itemsHaveMoved) {
+        m_groups.clear();
+
+        int lastMovedIndex = itemCount - 1;
+        while (lastMovedIndex > firstMovedIndex
+               && lastMovedIndex == m_items.value(oldUrls.at(lastMovedIndex))) {
+            --lastMovedIndex;
+        }
+
+        Q_ASSERT(firstMovedIndex <= lastMovedIndex);
+
+        // Create a list movedToIndexes, which has the property that
+        // movedToIndexes[i] is the new index of the item with the old index
+        // firstMovedIndex + i.
+        const int movedItemsCount = lastMovedIndex - firstMovedIndex + 1;
+        QList<int> movedToIndexes;
+        movedToIndexes.reserve(movedItemsCount);
+        for (int i = firstMovedIndex; i <= lastMovedIndex; ++i) {
+            const int newIndex = m_items.value(oldUrls.at(i));
+            movedToIndexes.append(newIndex);
+        }
+
+        emit itemsMoved(KItemRange(firstMovedIndex, movedItemsCount), movedToIndexes);
+    } else if (groupedSorting()) {
+        // The groups might have changed even if the order of the items has not.
+        const QList<QPair<int, QVariant> > oldGroups = m_groups;
+        m_groups.clear();
+        if (groups() != oldGroups) {
+            emit groupsChanged();
+        }
+    }
+
+#ifdef KFILEITEMMODEL_DEBUG
+    kDebug() << "[TIME] Resorting of" << itemCount << "items:" << timer.elapsed();
+#endif
+}
+
+void KFileItemModel::slotCompleted()
+{

     dispatchPendingItemsToInsert();
 
     dispatchPendingItemsToInsert();
 

-    if (!m_restoredExpandedUrls.isEmpty()) {
+    if (!m_urlsToExpand.isEmpty()) {

         // Try to find a URL that can be expanded.
         // Note that the parent folder must be expanded before any of its subfolders become visible.
         // Therefore, some URLs in m_restoredExpandedUrls might not be visible yet
         // -> we expand the first visible URL we find in m_restoredExpandedUrls.
         // Try to find a URL that can be expanded.
         // Note that the parent folder must be expanded before any of its subfolders become visible.
         // Therefore, some URLs in m_restoredExpandedUrls might not be visible yet
         // -> we expand the first visible URL we find in m_restoredExpandedUrls.

-        foreach(const KUrl& url, m_restoredExpandedUrls) {
-            const int index = m_items.value(url, -1);
-            if (index >= 0) {
-                // We have found an expandable URL. Expand it and return - when
-                // the dir lister has finished, this slot will be called again.
-                m_restoredExpandedUrls.remove(url);
-                setExpanded(index, true);
-                return;
+        foreach (const QUrl& url, m_urlsToExpand) {
+            const int indexForUrl = index(url);
+            if (indexForUrl >= 0) {
+                m_urlsToExpand.remove(url);
+                if (setExpanded(indexForUrl, true)) {
+                    // The dir lister has been triggered. This slot will be called
+                    // again after the directory has been expanded.
+                    return;
+                }

             }
         }
 
         // None of the URLs in m_restoredExpandedUrls could be found in the model. This can happen
         // if these URLs have been deleted in the meantime.
             }
         }
 
         // None of the URLs in m_restoredExpandedUrls could be found in the model. This can happen
         // if these URLs have been deleted in the meantime.

-        m_restoredExpandedUrls.clear();
+        m_urlsToExpand.clear();

     }
 
     }
 

-    emit loadingCompleted();
-    m_minimumUpdateIntervalTimer->start();
+    emit directoryLoadingCompleted();

 }
 
 void KFileItemModel::slotCanceled()
 {
 }
 
 void KFileItemModel::slotCanceled()
 {

-    m_minimumUpdateIntervalTimer->stop();

     m_maximumUpdateIntervalTimer->stop();
     dispatchPendingItemsToInsert();
     m_maximumUpdateIntervalTimer->stop();
     dispatchPendingItemsToInsert();

+
+    emit directoryLoadingCanceled();

 }
 
 }
 

-void KFileItemModel::slotNewItems(const KFileItemList& items)
+void KFileItemModel::slotItemsAdded(const QUrl &directoryUrl, const KFileItemList& items)

 {
 {

-    m_pendingItemsToInsert.append(items);
+    Q_ASSERT(!items.isEmpty());
+
+    QUrl parentUrl;
+    if (m_expandedDirs.contains(directoryUrl)) {
+        parentUrl = m_expandedDirs.value(directoryUrl);
+    } else {
+        parentUrl = directoryUrl.adjusted(QUrl::StripTrailingSlash);
+    }
+
+    if (m_requestRole[ExpandedParentsCountRole]) {
+        // If the expanding of items is enabled, the call
+        // dirLister->openUrl(url, KDirLister::Keep) in KFileItemModel::setExpanded()
+        // might result in emitting the same items twice due to the Keep-parameter.
+        // This case happens if an item gets expanded, collapsed and expanded again
+        // before the items could be loaded for the first expansion.
+        if (index(items.first().url()) >= 0) {
+            // The items are already part of the model.
+            return;
+        }
+
+        if (directoryUrl != directory()) {
+            // To be able to compare whether the new items may be inserted as children
+            // of a parent item the pending items must be added to the model first.
+            dispatchPendingItemsToInsert();
+        }
+
+        // KDirLister keeps the children of items that got expanded once even if
+        // they got collapsed again with KFileItemModel::setExpanded(false). So it must be
+        // checked whether the parent for new items is still expanded.
+        const int parentIndex = index(parentUrl);
+        if (parentIndex >= 0 && !m_itemData[parentIndex]->values.value("isExpanded").toBool()) {
+            // The parent is not expanded.
+            return;
+        }
+    }
+
+    QList<ItemData*> itemDataList = createItemDataList(parentUrl, items);
+
+    if (!m_filter.hasSetFilters()) {
+        m_pendingItemsToInsert.append(itemDataList);
+    } else {
+        // The name or type filter is active. Hide filtered items
+        // before inserting them into the model and remember
+        // the filtered items in m_filteredItems.
+        foreach (ItemData* itemData, itemDataList) {
+            if (m_filter.matches(itemData->item)) {
+                m_pendingItemsToInsert.append(itemData);
+            } else {
+                m_filteredItems.insert(itemData->item, itemData);
+            }
+        }
+    }

 
     if (useMaximumUpdateInterval() && !m_maximumUpdateIntervalTimer->isActive()) {
         // Assure that items get dispatched if no completed() or canceled() signal is
 
     if (useMaximumUpdateInterval() && !m_maximumUpdateIntervalTimer->isActive()) {
         // Assure that items get dispatched if no completed() or canceled() signal is


@@ -502,11 +963,50 @@ void KFileItemModel::slotNewItems(const KFileItemList& items)
 
 void KFileItemModel::slotItemsDeleted(const KFileItemList& items)
 {
 
 void KFileItemModel::slotItemsDeleted(const KFileItemList& items)
 {

-    if (!m_pendingItemsToInsert.isEmpty()) {
-        insertItems(m_pendingItemsToInsert);
-        m_pendingItemsToInsert.clear();
+    dispatchPendingItemsToInsert();
+
+    QVector<int> indexesToRemove;
+    indexesToRemove.reserve(items.count());
+
+    foreach (const KFileItem& item, items) {
+        const int indexForItem = index(item);
+        if (indexForItem >= 0) {
+            indexesToRemove.append(indexForItem);
+        } else {
+            // Probably the item has been filtered.
+            QHash<KFileItem, ItemData*>::iterator it = m_filteredItems.find(item);
+            if (it != m_filteredItems.end()) {
+                delete it.value();
+                m_filteredItems.erase(it);
+            }
+        }
+    }
+
+    std::sort(indexesToRemove.begin(), indexesToRemove.end());
+
+    if (m_requestRole[ExpandedParentsCountRole] && !m_expandedDirs.isEmpty()) {
+        // Assure that removing a parent item also results in removing all children
+        QVector<int> indexesToRemoveWithChildren;
+        indexesToRemoveWithChildren.reserve(m_itemData.count());
+
+        const int itemCount = m_itemData.count();
+        foreach (int index, indexesToRemove) {
+            indexesToRemoveWithChildren.append(index);
+
+            const int parentLevel = expandedParentsCount(index);
+            int childIndex = index + 1;
+            while (childIndex < itemCount && expandedParentsCount(childIndex) > parentLevel) {
+                indexesToRemoveWithChildren.append(childIndex);
+                ++childIndex;
+            }
+        }
+
+        indexesToRemove = indexesToRemoveWithChildren;

     }
     }

-    removeItems(items);
+
+    const KItemRangeList itemRanges = KItemRangeList::fromSortedContainer(indexesToRemove);
+    removeFilteredChildren(itemRanges);
+    removeItems(itemRanges, DeleteItemData);

 }
 
 void KFileItemModel::slotRefreshItems(const QList<QPair<KFileItem, KFileItem> >& items)
 }
 
 void KFileItemModel::slotRefreshItems(const QList<QPair<KFileItem, KFileItem> >& items)


@@ -516,18 +1016,51 @@ void KFileItemModel::slotRefreshItems(const QList<QPair<KFileItem, KFileItem> >&
     kDebug() << "Refreshing" << items.count() << "items";
 #endif
 
     kDebug() << "Refreshing" << items.count() << "items";
 #endif
 

-    m_groups.clear();
-

     // Get the indexes of all items that have been refreshed
     QList<int> indexes;
     indexes.reserve(items.count());
 
     // Get the indexes of all items that have been refreshed
     QList<int> indexes;
     indexes.reserve(items.count());
 

+    QSet<QByteArray> changedRoles;
+

     QListIterator<QPair<KFileItem, KFileItem> > it(items);
     while (it.hasNext()) {
         const QPair<KFileItem, KFileItem>& itemPair = it.next();
     QListIterator<QPair<KFileItem, KFileItem> > it(items);
     while (it.hasNext()) {
         const QPair<KFileItem, KFileItem>& itemPair = it.next();

-        const int index = m_items.value(itemPair.second.url(), -1);
-        if (index >= 0) {
-            indexes.append(index);
+        const KFileItem& oldItem = itemPair.first;
+        const KFileItem& newItem = itemPair.second;
+        const int indexForItem = index(oldItem);
+        if (indexForItem >= 0) {
+            m_itemData[indexForItem]->item = newItem;
+
+            // Keep old values as long as possible if they could not retrieved synchronously yet.
+            // The update of the values will be done asynchronously by KFileItemModelRolesUpdater.
+            QHashIterator<QByteArray, QVariant> it(retrieveData(newItem, m_itemData.at(indexForItem)->parent));
+            QHash<QByteArray, QVariant>& values = m_itemData[indexForItem]->values;
+            while (it.hasNext()) {
+                it.next();
+                const QByteArray& role = it.key();
+                if (values.value(role) != it.value()) {
+                    values.insert(role, it.value());
+                    changedRoles.insert(role);
+                }
+            }
+
+            m_items.remove(oldItem.url());
+            m_items.insert(newItem.url(), indexForItem);
+            indexes.append(indexForItem);
+        } else {
+            // Check if 'oldItem' is one of the filtered items.
+            QHash<KFileItem, ItemData*>::iterator it = m_filteredItems.find(oldItem);
+            if (it != m_filteredItems.end()) {
+                ItemData* itemData = it.value();
+                itemData->item = newItem;
+
+                // The data stored in 'values' might have changed. Therefore, we clear
+                // 'values' and re-populate it the next time it is requested via data(int).
+                itemData->values.clear();
+
+                m_filteredItems.erase(it);
+                m_filteredItems.insert(newItem, itemData);
+            }

         }
     }
 
         }
     }
 


@@ -539,31 +1072,8 @@ void KFileItemModel::slotRefreshItems(const QList<QPair<KFileItem, KFileItem> >&
 
     // Extract the item-ranges out of the changed indexes
     qSort(indexes);
 
     // Extract the item-ranges out of the changed indexes
     qSort(indexes);

-
-    KItemRangeList itemRangeList;
-    int rangeIndex = 0;
-    int rangeCount = 1;
-    int previousIndex = indexes.at(0);
-
-    const int maxIndex = indexes.count() - 1;
-    for (int i = 1; i <= maxIndex; ++i) {
-        const int currentIndex = indexes.at(i);
-        if (currentIndex == previousIndex + 1) {
-            ++rangeCount;
-        } else {
-            itemRangeList.append(KItemRange(rangeIndex, rangeCount));
-
-            rangeIndex = currentIndex;
-            rangeCount = 1;
-        }
-        previousIndex = currentIndex;
-    }
-
-    if (rangeCount > 0) {
-        itemRangeList.append(KItemRange(rangeIndex, rangeCount));
-    }
-
-    emit itemsChanged(itemRangeList, QSet<QByteArray>());
+    const KItemRangeList itemRangeList = KItemRangeList::fromSortedContainer(indexes);
+    emitItemsChangedAndTriggerResorting(itemRangeList, changedRoles);

 }
 
 void KFileItemModel::slotClear()
 }
 
 void KFileItemModel::slotClear()


@@ -572,28 +1082,31 @@ void KFileItemModel::slotClear()
     kDebug() << "Clearing all items";
 #endif
 
     kDebug() << "Clearing all items";
 #endif
 

+    qDeleteAll(m_filteredItems.values());
+    m_filteredItems.clear();

     m_groups.clear();
 
     m_groups.clear();
 

-    m_minimumUpdateIntervalTimer->stop();

     m_maximumUpdateIntervalTimer->stop();
     m_maximumUpdateIntervalTimer->stop();

-    m_pendingItemsToInsert.clear();
+    m_resortAllItemsTimer->stop();

 
 

-    m_rootExpansionLevel = -1;
+    qDeleteAll(m_pendingItemsToInsert);
+    m_pendingItemsToInsert.clear();

 
 

-    const int removedCount = m_data.count();
+    const int removedCount = m_itemData.count();

     if (removedCount > 0) {
     if (removedCount > 0) {

-        m_sortedItems.clear();
+        qDeleteAll(m_itemData);
+        m_itemData.clear();

         m_items.clear();
         m_items.clear();

-        m_data.clear();

         emit itemsRemoved(KItemRangeList() << KItemRange(0, removedCount));
     }
 
         emit itemsRemoved(KItemRangeList() << KItemRange(0, removedCount));
     }
 

-    m_expandedUrls.clear();
+    m_expandedDirs.clear();

 }
 
 }
 

-void KFileItemModel::slotClear(const KUrl& url)
+void KFileItemModel::slotNaturalSortingChanged()

 {
 {

-    Q_UNUSED(url);
+    m_naturalSorting = KGlobalSettings::naturalSorting();
+    resortAllItems();

 }
 
 void KFileItemModel::dispatchPendingItemsToInsert()
 }
 
 void KFileItemModel::dispatchPendingItemsToInsert()


@@ -602,15 +1115,11 @@ void KFileItemModel::dispatchPendingItemsToInsert()
         insertItems(m_pendingItemsToInsert);
         m_pendingItemsToInsert.clear();
     }
         insertItems(m_pendingItemsToInsert);
         m_pendingItemsToInsert.clear();
     }

+}

 
 

-    if (m_pendingEmitLoadingCompleted) {
-        emit loadingCompleted();
-    }
-}
-
-void KFileItemModel::insertItems(const KFileItemList& items)
+void KFileItemModel::insertItems(QList<ItemData*>& newItems)

 {
 {

-    if (items.isEmpty()) {
+    if (newItems.isEmpty()) {

         return;
     }
 
         return;
     }
 


@@ -618,205 +1127,300 @@ void KFileItemModel::insertItems(const KFileItemList& items)
     QElapsedTimer timer;
     timer.start();
     kDebug() << "===========================================================";
     QElapsedTimer timer;
     timer.start();
     kDebug() << "===========================================================";

-    kDebug() << "Inserting" << items.count() << "items";
+    kDebug() << "Inserting" << newItems.count() << "items";

 #endif
 
     m_groups.clear();
 #endif
 
     m_groups.clear();

+    prepareItemsForSorting(newItems);

 
 

-    KFileItemList sortedItems = items;
-    sort(sortedItems.begin(), sortedItems.end());
+    if (m_sortRole == NameRole && m_naturalSorting) {
+        // Natural sorting of items can be very slow. However, it becomes much
+        // faster if the input sequence is already mostly sorted. Therefore, we
+        // first sort 'newItems' according to the QStrings returned by
+        // KFileItem::text() using QString::operator<(), which is quite fast.
+        parallelMergeSort(newItems.begin(), newItems.end(), nameLessThan, QThread::idealThreadCount());
+    }
+
+    sort(newItems.begin(), newItems.end());

 
 #ifdef KFILEITEMMODEL_DEBUG
     kDebug() << "[TIME] Sorting:" << timer.elapsed();
 #endif
 
     KItemRangeList itemRanges;
 
 #ifdef KFILEITEMMODEL_DEBUG
     kDebug() << "[TIME] Sorting:" << timer.elapsed();
 #endif
 
     KItemRangeList itemRanges;

-    int targetIndex = 0;
-    int sourceIndex = 0;
-    int insertedAtIndex = -1;         // Index for the current item-range
-    int insertedCount = 0;            // Count for the current item-range
-    int previouslyInsertedCount = 0;  // Sum of previously inserted items for all ranges
-    while (sourceIndex < sortedItems.count()) {
-        // Find target index from m_items to insert the current item
-        // in a sorted order
-        const int previousTargetIndex = targetIndex;
-        while (targetIndex < m_sortedItems.count()) {
-            if (!lessThan(m_sortedItems.at(targetIndex), sortedItems.at(sourceIndex))) {
-                break;
-            }
-            ++targetIndex;
+    const int existingItemCount = m_itemData.count();
+    const int newItemCount = newItems.count();
+    const int totalItemCount = existingItemCount + newItemCount;
+
+    if (existingItemCount == 0) {
+        // Optimization for the common special case that there are no
+        // items in the model yet. Happens, e.g., when entering a folder.
+        m_itemData = newItems;
+        itemRanges << KItemRange(0, newItemCount);
+    } else {
+        m_itemData.reserve(totalItemCount);
+        for (int i = existingItemCount; i < totalItemCount; ++i) {
+            m_itemData.append(0);

         }
 
         }
 

-        if (targetIndex - previousTargetIndex > 0 && insertedAtIndex >= 0) {
-            itemRanges << KItemRange(insertedAtIndex, insertedCount);
-            previouslyInsertedCount += insertedCount;
-            insertedAtIndex = targetIndex - previouslyInsertedCount;
-            insertedCount = 0;
-        }
+        // We build the new list m_itemData in reverse order to minimize
+        // the number of moves and guarantee O(N) complexity.
+        int targetIndex = totalItemCount - 1;
+        int sourceIndexExistingItems = existingItemCount - 1;
+        int sourceIndexNewItems = newItemCount - 1;
+
+        int rangeCount = 0;
+
+        while (sourceIndexNewItems >= 0) {
+            ItemData* newItem = newItems.at(sourceIndexNewItems);
+            if (sourceIndexExistingItems >= 0 && lessThan(newItem, m_itemData.at(sourceIndexExistingItems), m_collator)) {
+                // Move an existing item to its new position. If any new items
+                // are behind it, push the item range to itemRanges.
+                if (rangeCount > 0) {
+                    itemRanges << KItemRange(sourceIndexExistingItems + 1, rangeCount);
+                    rangeCount = 0;
+                }

 
 

-        // Insert item at the position targetIndex
-        const KFileItem item = sortedItems.at(sourceIndex);
-        m_sortedItems.insert(targetIndex, item);
-        m_data.insert(targetIndex, retrieveData(item));
-        // m_items will be inserted after the loop (see comment below)
-        ++insertedCount;
+                m_itemData[targetIndex] = m_itemData.at(sourceIndexExistingItems);
+                --sourceIndexExistingItems;
+            } else {
+                // Insert a new item into the list.
+                ++rangeCount;
+                m_itemData[targetIndex] = newItem;
+                --sourceIndexNewItems;
+            }
+            --targetIndex;
+        }

 
 

-        if (insertedAtIndex < 0) {
-            insertedAtIndex = targetIndex;
-            Q_ASSERT(previouslyInsertedCount == 0);
+        // Push the final item range to itemRanges.
+        if (rangeCount > 0) {
+            itemRanges << KItemRange(sourceIndexExistingItems + 1, rangeCount);

         }
         }

-        ++targetIndex;
-        ++sourceIndex;
-    }

 
 

-    // The indexes of all m_items must be adjusted, not only the index
-    // of the new items
-    for (int i = 0; i < m_sortedItems.count(); ++i) {
-        m_items.insert(m_sortedItems.at(i).url(), i);
+        // Note that itemRanges is still sorted in reverse order.
+        std::reverse(itemRanges.begin(), itemRanges.end());

     }
 
     }
 

-    itemRanges << KItemRange(insertedAtIndex, insertedCount);
+    // The indexes in m_items are not correct anymore. Therefore, we clear m_items.
+    // It will be re-populated with the updated indices if index(const QUrl&) is called.
+    m_items.clear();
+

     emit itemsInserted(itemRanges);
 
 #ifdef KFILEITEMMODEL_DEBUG
     emit itemsInserted(itemRanges);
 
 #ifdef KFILEITEMMODEL_DEBUG

-    kDebug() << "[TIME] Inserting of" << items.count() << "items:" << timer.elapsed();
+    kDebug() << "[TIME] Inserting of" << newItems.count() << "items:" << timer.elapsed();

 #endif
 }
 
 #endif
 }
 

-void KFileItemModel::removeItems(const KFileItemList& items)
+void KFileItemModel::removeItems(const KItemRangeList& itemRanges, RemoveItemsBehavior behavior)

 {
 {

-    if (items.isEmpty()) {
+    if (itemRanges.isEmpty()) {

         return;
     }
 
         return;
     }
 

-#ifdef KFILEITEMMODEL_DEBUG
-    kDebug() << "Removing " << items.count() << "items";
-#endif
-

     m_groups.clear();
 
     m_groups.clear();
 

-    KFileItemList sortedItems = items;
-    sort(sortedItems.begin(), sortedItems.end());
-
-    QList<int> indexesToRemove;
-    indexesToRemove.reserve(items.count());
+    // Step 1: Remove the items from m_itemData, and free the ItemData.
+    int removedItemsCount = 0;
+    foreach (const KItemRange& range, itemRanges) {
+        removedItemsCount += range.count;

 
 

-    // Calculate the item ranges that will get deleted
-    KItemRangeList itemRanges;
-    int removedAtIndex = -1;
-    int removedCount = 0;
-    int targetIndex = 0;
-    foreach (const KFileItem& itemToRemove, sortedItems) {
-        const int previousTargetIndex = targetIndex;
-        while (targetIndex < m_sortedItems.count()) {
-            if (m_sortedItems.at(targetIndex).url() == itemToRemove.url()) {
-                break;
+        for (int index = range.index; index < range.index + range.count; ++index) {
+            if (behavior == DeleteItemData) {
+                delete m_itemData.at(index);

             }
             }

-            ++targetIndex;
-        }
-        if (targetIndex >= m_sortedItems.count()) {
-            kWarning() << "Item that should be deleted has not been found!";
-            return;
-        }

 
 

-        if (targetIndex - previousTargetIndex > 0 && removedAtIndex >= 0) {
-            itemRanges << KItemRange(removedAtIndex, removedCount);
-            removedAtIndex = targetIndex;
-            removedCount = 0;
+            m_itemData[index] = 0;

         }
         }

-
-        indexesToRemove.append(targetIndex);
-        if (removedAtIndex < 0) {
-            removedAtIndex = targetIndex;
-        }
-        ++removedCount;
-        ++targetIndex;

     }
 
     }
 

-    // Delete the items
-    for (int i = indexesToRemove.count() - 1; i >= 0; --i) {
-        const int indexToRemove = indexesToRemove.at(i);
-        m_items.remove(m_sortedItems.at(indexToRemove).url());
-        m_sortedItems.removeAt(indexToRemove);
-        m_data.removeAt(indexToRemove);
-    }
+    // Step 2: Remove the ItemData pointers from the list m_itemData.
+    int target = itemRanges.at(0).index;
+    int source = itemRanges.at(0).index + itemRanges.at(0).count;
+    int nextRange = 1;

 
 

-    // The indexes of all m_items must be adjusted, not only the index
-    // of the removed items
-    for (int i = 0; i < m_sortedItems.count(); ++i) {
-        m_items.insert(m_sortedItems.at(i).url(), i);
-    }
+    const int oldItemDataCount = m_itemData.count();
+    while (source < oldItemDataCount) {
+        m_itemData[target] = m_itemData[source];
+        ++target;
+        ++source;

 
 

-    if (count() <= 0) {
-        m_rootExpansionLevel = -1;
+        if (nextRange < itemRanges.count() && source == itemRanges.at(nextRange).index) {
+            // Skip the items in the next removed range.
+            source += itemRanges.at(nextRange).count;
+            ++nextRange;
+        }

     }
 
     }
 

-    itemRanges << KItemRange(removedAtIndex, removedCount);
+    m_itemData.erase(m_itemData.end() - removedItemsCount, m_itemData.end());
+
+    // The indexes in m_items are not correct anymore. Therefore, we clear m_items.
+    // It will be re-populated with the updated indices if index(const QUrl&) is called.
+    m_items.clear();
+

     emit itemsRemoved(itemRanges);
 }
 
     emit itemsRemoved(itemRanges);
 }
 

-void KFileItemModel::resortAllItems()
+QList<KFileItemModel::ItemData*> KFileItemModel::createItemDataList(const QUrl& parentUrl, const KFileItemList& items) const

 {
 {

-    const int itemCount = count();
-    if (itemCount <= 0) {
-        return;
+    if (m_sortRole == TypeRole) {
+        // Try to resolve the MIME-types synchronously to prevent a reordering of
+        // the items when sorting by type (per default MIME-types are resolved
+        // asynchronously by KFileItemModelRolesUpdater).
+        determineMimeTypes(items, 200);

     }
 
     }
 

-    m_groups.clear();
+    const int parentIndex = index(parentUrl);
+    ItemData* parentItem = parentIndex < 0 ? 0 : m_itemData.at(parentIndex);

 
 

-    const KFileItemList oldSortedItems = m_sortedItems;
-    const QHash<KUrl, int> oldItems = m_items;
-    const QList<QHash<QByteArray, QVariant> > oldData = m_data;
+    QList<ItemData*> itemDataList;
+    itemDataList.reserve(items.count());

 
 

-    m_items.clear();
-    m_data.clear();
-
-    sort(m_sortedItems.begin(), m_sortedItems.end());
-    int index = 0;
-    foreach (const KFileItem& item, m_sortedItems) {
-        m_items.insert(item.url(), index);
+    foreach (const KFileItem& item, items) {
+        ItemData* itemData = new ItemData();
+        itemData->item = item;
+        itemData->parent = parentItem;
+        itemDataList.append(itemData);
+    }

 
 

-        const int oldItemIndex = oldItems.value(item.url());
-        m_data.append(oldData.at(oldItemIndex));
+    return itemDataList;
+}

 
 

-        ++index;
-    }
+void KFileItemModel::prepareItemsForSorting(QList<ItemData*>& itemDataList)
+{
+    switch (m_sortRole) {
+    case PermissionsRole:
+    case OwnerRole:
+    case GroupRole:
+    case DestinationRole:
+    case PathRole:
+        // These roles can be determined with retrieveData, and they have to be stored
+        // in the QHash "values" for the sorting.
+        foreach (ItemData* itemData, itemDataList) {
+            if (itemData->values.isEmpty()) {
+                itemData->values = retrieveData(itemData->item, itemData->parent);
+            }
+        }
+        break;

 
 

-    bool emitItemsMoved = false;
-    QList<int> movedToIndexes;
-    movedToIndexes.reserve(m_sortedItems.count());
-    for (int i = 0; i < itemCount; i++) {
-        const int newIndex = m_items.value(oldSortedItems.at(i).url());
-        movedToIndexes.append(newIndex);
-        if (!emitItemsMoved && newIndex != i) {
-            emitItemsMoved = true;
+    case TypeRole:
+        // At least store the data including the file type for items with known MIME type.
+        foreach (ItemData* itemData, itemDataList) {
+            if (itemData->values.isEmpty()) {
+                const KFileItem item = itemData->item;
+                if (item.isDir() || item.isMimeTypeKnown()) {
+                    itemData->values = retrieveData(itemData->item, itemData->parent);
+                }
+            }

         }
         }

+        break;
+
+    default:
+        // The other roles are either resolved by KFileItemModelRolesUpdater
+        // (this includes the SizeRole for directories), or they do not need
+        // to be stored in the QHash "values" for sorting because the data can
+        // be retrieved directly from the KFileItem (NameRole, SizeRole for files,
+        // DateRole).
+        break;

     }
     }

+}

 
 

-    if (emitItemsMoved) {
-        emit itemsMoved(KItemRange(0, itemCount), movedToIndexes);
+int KFileItemModel::expandedParentsCount(const ItemData* data)
+{
+    // The hash 'values' is only guaranteed to contain the key "expandedParentsCount"
+    // if the corresponding item is expanded, and it is not a top-level item.
+    const ItemData* parent = data->parent;
+    if (parent) {
+        if (parent->parent) {
+            Q_ASSERT(parent->values.contains("expandedParentsCount"));
+            return parent->values.value("expandedParentsCount").toInt() + 1;
+        } else {
+            return 1;
+        }
+    } else {
+        return 0;

     }
 }
 
 void KFileItemModel::removeExpandedItems()
 {
     }
 }
 
 void KFileItemModel::removeExpandedItems()
 {

-    KFileItemList expandedItems;
+    QVector<int> indexesToRemove;

 
 

-    const int maxIndex = m_data.count() - 1;
+    const int maxIndex = m_itemData.count() - 1;

     for (int i = 0; i <= maxIndex; ++i) {
     for (int i = 0; i <= maxIndex; ++i) {

-        if (m_data.at(i).value("expansionLevel").toInt() > 0) {
-            const KFileItem fileItem = m_sortedItems.at(i);
-            expandedItems.append(fileItem);
+        const ItemData* itemData = m_itemData.at(i);
+        if (itemData->parent) {
+            indexesToRemove.append(i);

         }
     }
 
         }
     }
 

-    // The m_rootExpansionLevel may not get reset before all items with
-    // a bigger expansionLevel have been removed.
-    Q_ASSERT(m_rootExpansionLevel >= 0);
-    removeItems(expandedItems);
+    removeItems(KItemRangeList::fromSortedContainer(indexesToRemove), DeleteItemData);
+    m_expandedDirs.clear();

 
 

-    m_rootExpansionLevel = -1;
-    m_expandedUrls.clear();
+    // Also remove all filtered items which have a parent.
+    QHash<KFileItem, ItemData*>::iterator it = m_filteredItems.begin();
+    const QHash<KFileItem, ItemData*>::iterator end = m_filteredItems.end();
+
+    while (it != end) {
+        if (it.value()->parent) {
+            delete it.value();
+            it = m_filteredItems.erase(it);
+        } else {
+            ++it;
+        }
+    }
+}
+
+void KFileItemModel::emitItemsChangedAndTriggerResorting(const KItemRangeList& itemRanges, const QSet<QByteArray>& changedRoles)
+{
+    emit itemsChanged(itemRanges, changedRoles);
+
+    // Trigger a resorting if necessary. Note that this can happen even if the sort
+    // role has not changed at all because the file name can be used as a fallback.
+    if (changedRoles.contains(sortRole()) || changedRoles.contains(roleForType(NameRole))) {
+        foreach (const KItemRange& range, itemRanges) {
+            bool needsResorting = false;
+
+            const int first = range.index;
+            const int last = range.index + range.count - 1;
+
+            // Resorting the model is necessary if
+            // (a)  The first item in the range is "lessThan" its predecessor,
+            // (b)  the successor of the last item is "lessThan" the last item, or
+            // (c)  the internal order of the items in the range is incorrect.
+            if (first > 0
+                && lessThan(m_itemData.at(first), m_itemData.at(first - 1), m_collator)) {
+                needsResorting = true;
+            } else if (last < count() - 1
+                && lessThan(m_itemData.at(last + 1), m_itemData.at(last), m_collator)) {
+                needsResorting = true;
+            } else {
+                for (int index = first; index < last; ++index) {
+                    if (lessThan(m_itemData.at(index + 1), m_itemData.at(index), m_collator)) {
+                        needsResorting = true;
+                        break;
+                    }
+                }
+            }
+
+            if (needsResorting) {
+                m_resortAllItemsTimer->start();
+                return;
+            }
+        }
+    }
+
+    if (groupedSorting() && changedRoles.contains(sortRole())) {
+        // The position is still correct, but the groups might have changed
+        // if the changed item is either the first or the last item in a
+        // group.
+        // In principle, we could try to find out if the item really is the
+        // first or last one in its group and then update the groups
+        // (possibly with a delayed timer to make sure that we don't
+        // re-calculate the groups very often if items are updated one by
+        // one), but starting m_resortAllItemsTimer is easier.
+        m_resortAllItemsTimer->start();
+    }

 }
 
 void KFileItemModel::resetRoles()
 }
 
 void KFileItemModel::resetRoles()


@@ -826,126 +1430,197 @@ void KFileItemModel::resetRoles()
     }
 }
 
     }
 }
 

-KFileItemModel::Role KFileItemModel::roleIndex(const QByteArray& role) const
+KFileItemModel::RoleType KFileItemModel::typeForRole(const QByteArray& role) const

 {
 {

-    static QHash<QByteArray, Role> rolesHash;
-    if (rolesHash.isEmpty()) {
-        rolesHash.insert("name", NameRole);
-        rolesHash.insert("size", SizeRole);
-        rolesHash.insert("date", DateRole);
-        rolesHash.insert("permissions", PermissionsRole);
-        rolesHash.insert("owner", OwnerRole);
-        rolesHash.insert("group", GroupRole);
-        rolesHash.insert("type", TypeRole);
-        rolesHash.insert("destination", DestinationRole);
-        rolesHash.insert("path", PathRole);
-        rolesHash.insert("isDir", IsDirRole);
-        rolesHash.insert("isExpanded", IsExpandedRole);
-        rolesHash.insert("expansionLevel", ExpansionLevelRole);
+    static QHash<QByteArray, RoleType> roles;
+    if (roles.isEmpty()) {
+        // Insert user visible roles that can be accessed with
+        // KFileItemModel::roleInformation()
+        int count = 0;
+        const RoleInfoMap* map = rolesInfoMap(count);
+        for (int i = 0; i < count; ++i) {
+            roles.insert(map[i].role, map[i].roleType);
+        }
+
+        // Insert internal roles (take care to synchronize the implementation
+        // with KFileItemModel::roleForType() in case if a change is done).
+        roles.insert("isDir", IsDirRole);
+        roles.insert("isLink", IsLinkRole);
+        roles.insert("isExpanded", IsExpandedRole);
+        roles.insert("isExpandable", IsExpandableRole);
+        roles.insert("expandedParentsCount", ExpandedParentsCountRole);
+
+        Q_ASSERT(roles.count() == RolesCount);

     }
     }

-    return rolesHash.value(role, NoRole);
+
+    return roles.value(role, NoRole);

 }
 
 }
 

-QHash<QByteArray, QVariant> KFileItemModel::retrieveData(const KFileItem& item) const
+QByteArray KFileItemModel::roleForType(RoleType roleType) const
+{
+    static QHash<RoleType, QByteArray> roles;
+    if (roles.isEmpty()) {
+        // Insert user visible roles that can be accessed with
+        // KFileItemModel::roleInformation()
+        int count = 0;
+        const RoleInfoMap* map = rolesInfoMap(count);
+        for (int i = 0; i < count; ++i) {
+            roles.insert(map[i].roleType, map[i].role);
+        }
+
+        // Insert internal roles (take care to synchronize the implementation
+        // with KFileItemModel::typeForRole() in case if a change is done).
+        roles.insert(IsDirRole, "isDir");
+        roles.insert(IsLinkRole, "isLink");
+        roles.insert(IsExpandedRole, "isExpanded");
+        roles.insert(IsExpandableRole, "isExpandable");
+        roles.insert(ExpandedParentsCountRole, "expandedParentsCount");
+
+        Q_ASSERT(roles.count() == RolesCount);
+    };
+
+    return roles.value(roleType);
+}
+
+QHash<QByteArray, QVariant> KFileItemModel::retrieveData(const KFileItem& item, const ItemData* parent) const

 {
     // It is important to insert only roles that are fast to retrieve. E.g.
     // KFileItem::iconName() can be very expensive if the MIME-type is unknown
     // and hence will be retrieved asynchronously by KFileItemModelRolesUpdater.
     QHash<QByteArray, QVariant> data;
 {
     // It is important to insert only roles that are fast to retrieve. E.g.
     // KFileItem::iconName() can be very expensive if the MIME-type is unknown
     // and hence will be retrieved asynchronously by KFileItemModelRolesUpdater.
     QHash<QByteArray, QVariant> data;

-    data.insert("iconPixmap", QPixmap());
+    data.insert(sharedValue("url"), item.url());

 
     const bool isDir = item.isDir();
 
     const bool isDir = item.isDir();

-    if (m_requestRole[IsDirRole]) {
-        data.insert("isDir", isDir);
+    if (m_requestRole[IsDirRole] && isDir) {
+        data.insert(sharedValue("isDir"), true);
+    }
+
+    if (m_requestRole[IsLinkRole] && item.isLink()) {
+        data.insert(sharedValue("isLink"), true);

     }
 
     if (m_requestRole[NameRole]) {
     }
 
     if (m_requestRole[NameRole]) {

-        data.insert("name", item.name());
+        data.insert(sharedValue("text"), item.text());

     }
 
     }
 

-    if (m_requestRole[SizeRole]) {
-        if (isDir) {
-            data.insert("size", QVariant());
-        } else {
-            data.insert("size", item.size());
-        }
+    if (m_requestRole[SizeRole] && !isDir) {
+        data.insert(sharedValue("size"), item.size());

     }
 
     if (m_requestRole[DateRole]) {
         // Don't use KFileItem::timeString() as this is too expensive when
         // having several thousands of items. Instead the formatting of the
         // date-time will be done on-demand by the view when the date will be shown.
     }
 
     if (m_requestRole[DateRole]) {
         // Don't use KFileItem::timeString() as this is too expensive when
         // having several thousands of items. Instead the formatting of the
         // date-time will be done on-demand by the view when the date will be shown.

-        const KDateTime dateTime = item.time(KFileItem::ModificationTime);
-        data.insert("date", dateTime.dateTime());
+        const QDateTime dateTime = item.time(KFileItem::ModificationTime);
+        data.insert(sharedValue("date"), dateTime);

     }
 
     if (m_requestRole[PermissionsRole]) {
     }
 
     if (m_requestRole[PermissionsRole]) {

-        data.insert("permissions", item.permissionsString());
+        data.insert(sharedValue("permissions"), item.permissionsString());

     }
 
     if (m_requestRole[OwnerRole]) {
     }
 
     if (m_requestRole[OwnerRole]) {

-        data.insert("owner", item.user());
+        data.insert(sharedValue("owner"), item.user());

     }
 
     if (m_requestRole[GroupRole]) {
     }
 
     if (m_requestRole[GroupRole]) {

-        data.insert("group", item.group());
+        data.insert(sharedValue("group"), item.group());

     }
 
     if (m_requestRole[DestinationRole]) {
         QString destination = item.linkDest();
         if (destination.isEmpty()) {
     }
 
     if (m_requestRole[DestinationRole]) {
         QString destination = item.linkDest();
         if (destination.isEmpty()) {

-            destination = i18nc("@item:intable", "No destination");
+            destination = QLatin1String("-");

         }
         }

-        data.insert("destination", destination);
+        data.insert(sharedValue("destination"), destination);

     }
 
     if (m_requestRole[PathRole]) {
     }
 
     if (m_requestRole[PathRole]) {

-        data.insert("path", item.localPath());
+        QString path;
+        if (item.url().scheme() == QLatin1String("trash")) {
+            path = item.entry().stringValue(KIO::UDSEntry::UDS_EXTRA);
+        } else {
+            // For performance reasons cache the home-path in a static QString
+            // (see QDir::homePath() for more details)
+            static QString homePath;
+            if (homePath.isEmpty()) {
+                homePath = QDir::homePath();
+            }
+
+            path = item.localPath();
+            if (path.startsWith(homePath)) {
+                path.replace(0, homePath.length(), QLatin1Char('~'));
+            }
+        }
+
+        const int index = path.lastIndexOf(item.text());
+        path = path.mid(0, index - 1);
+        data.insert(sharedValue("path"), path);

     }
 
     }
 

-    if (m_requestRole[IsExpandedRole]) {
-        data.insert("isExpanded", false);
+    if (m_requestRole[IsExpandableRole] && isDir) {
+        data.insert(sharedValue("isExpandable"), true);

     }
 
     }
 

-    if (m_requestRole[ExpansionLevelRole]) {
-        if (m_rootExpansionLevel < 0) {
-            KDirLister* dirLister = m_dirLister.data();
-            if (dirLister) {
-                const QString rootDir = dirLister->url().directory(KUrl::AppendTrailingSlash);
-                m_rootExpansionLevel = rootDir.count('/');
-            }
+    if (m_requestRole[ExpandedParentsCountRole]) {
+        if (parent) {
+            const int level = expandedParentsCount(parent) + 1;
+            data.insert(sharedValue("expandedParentsCount"), level);

         }
         }

-        const QString dir = item.url().directory(KUrl::AppendTrailingSlash);
-        const int level = dir.count('/') - m_rootExpansionLevel - 1;
-        data.insert("expansionLevel", level);

     }
 
     if (item.isMimeTypeKnown()) {
     }
 
     if (item.isMimeTypeKnown()) {

-        data.insert("iconName", item.iconName());
+        data.insert(sharedValue("iconName"), item.iconName());

 
         if (m_requestRole[TypeRole]) {
 
         if (m_requestRole[TypeRole]) {

-            data.insert("type", item.mimeComment());
+            data.insert(sharedValue("type"), item.mimeComment());

         }
         }

+    } else if (m_requestRole[TypeRole] && isDir) {
+        static const QString folderMimeType = item.mimeComment();
+        data.insert(sharedValue("type"), folderMimeType);

     }
 
     return data;
 }
 
     }
 
     return data;
 }
 

-bool KFileItemModel::lessThan(const KFileItem& a, const KFileItem& b) const
+bool KFileItemModel::lessThan(const ItemData* a, const ItemData* b, const QCollator& collator) const

 {
     int result = 0;
 
 {
     int result = 0;
 

-    if (m_rootExpansionLevel >= 0) {
-        result = expansionLevelsCompare(a, b);
-        if (result != 0) {
-            // The items have parents with different expansion levels
-            return (sortOrder() == Qt::AscendingOrder) ? result < 0 : result > 0;
+    if (a->parent != b->parent) {
+        const int expansionLevelA = expandedParentsCount(a);
+        const int expansionLevelB = expandedParentsCount(b);
+
+        // If b has a higher expansion level than a, check if a is a parent
+        // of b, and make sure that both expansion levels are equal otherwise.
+        for (int i = expansionLevelB; i > expansionLevelA; --i) {
+            if (b->parent == a) {
+                return true;
+            }
+            b = b->parent;
+        }
+
+        // If a has a higher expansion level than a, check if b is a parent
+        // of a, and make sure that both expansion levels are equal otherwise.
+        for (int i = expansionLevelA; i > expansionLevelB; --i) {
+            if (a->parent == b) {
+                return false;
+            }
+            a = a->parent;
+        }
+
+        Q_ASSERT(expandedParentsCount(a) == expandedParentsCount(b));
+
+        // Compare the last parents of a and b which are different.
+        while (a->parent != b->parent) {
+            a = a->parent;
+            b = b->parent;

         }
     }
 
         }
     }
 

-    if (m_sortFoldersFirst || m_sortRole == SizeRole) {
-        const bool isDirA = a.isDir();
-        const bool isDirB = b.isDir();
+    if (m_sortDirsFirst || m_sortRole == SizeRole) {
+        const bool isDirA = a->item.isDir();
+        const bool isDirB = b->item.isDir();

         if (isDirA && !isDirB) {
             return true;
         } else if (!isDirA && isDirB) {
         if (isDirA && !isDirB) {
             return true;
         } else if (!isDirA && isDirB) {


@@ -953,263 +1628,236 @@ bool KFileItemModel::lessThan(const KFileItem& a, const KFileItem& b) const
         }
     }
 
         }
     }
 

-    switch (m_sortRole) {
-    case NameRole: {
-        result = stringCompare(a.text(), b.text());
-        if (result == 0) {
-            // KFileItem::text() may not be unique in case UDS_DISPLAY_NAME is used
-            result = stringCompare(a.name(m_caseSensitivity == Qt::CaseInsensitive),
-                                   b.name(m_caseSensitivity == Qt::CaseInsensitive));
-        }
-        break;
-    }
+    result = sortRoleCompare(a, b, collator);

 
 

-    case DateRole: {
-        const KDateTime dateTimeA = a.time(KFileItem::ModificationTime);
-        const KDateTime dateTimeB = b.time(KFileItem::ModificationTime);
-        if (dateTimeA < dateTimeB) {
-            result = -1;
-        } else if (dateTimeA > dateTimeB) {
-            result = +1;
-        }
-        break;
-    }
+    return (sortOrder() == Qt::AscendingOrder) ? result < 0 : result > 0;
+}

 
 

-    case SizeRole: {
-        // TODO: Implement sorting folders by the number of items inside.
-        // This is more tricky to get right because this number is retrieved
-        // asynchronously by KFileItemModelRolesUpdater.
-        const KIO::filesize_t sizeA = a.size();
-        const KIO::filesize_t sizeB = b.size();
-        if (sizeA < sizeB) {
-            result = -1;
-        } else if (sizeA > sizeB) {
-            result = +1;
-        }
-        break;
+/**
+ * Helper class for KFileItemModel::sort().
+ */
+class KFileItemModelLessThan
+{
+public:
+    KFileItemModelLessThan(const KFileItemModel* model, const QCollator& collator) :
+        m_model(model),
+        m_collator(collator)
+    {

     }
 
     }
 

-    default:
-        break;
+    KFileItemModelLessThan(const KFileItemModelLessThan& other) :
+        m_model(other.m_model),
+        m_collator()
+    {
+        m_collator.setCaseSensitivity(other.m_collator.caseSensitivity());
+        m_collator.setIgnorePunctuation(other.m_collator.ignorePunctuation());
+        m_collator.setLocale(other.m_collator.locale());
+        m_collator.setNumericMode(other.m_collator.numericMode());

     }
 
     }
 

-    if (result == 0) {
-        // It must be assured that the sort order is always unique even if two values have been
-        // equal. In this case a comparison of the URL is done which is unique in all cases
-        // within KDirLister.
-        result = QString::compare(a.url().url(), b.url().url(), Qt::CaseSensitive);
+    bool operator()(const KFileItemModel::ItemData* a, const KFileItemModel::ItemData* b) const
+    {
+        return m_model->lessThan(a, b, m_collator);

     }
 
     }
 

-    return (sortOrder() == Qt::AscendingOrder) ? result < 0 : result > 0;
-}
+private:
+    const KFileItemModel* m_model;
+    QCollator m_collator;
+};

 
 

-void KFileItemModel::sort(const KFileItemList::iterator& startIterator, const KFileItemList::iterator& endIterator)
+void KFileItemModel::sort(QList<KFileItemModel::ItemData*>::iterator begin,
+                          QList<KFileItemModel::ItemData*>::iterator end) const

 {
 {

-    KFileItemList::iterator start = startIterator;
-    KFileItemList::iterator end = endIterator;
+    KFileItemModelLessThan lessThan(this, m_collator);

 
 

-    // The implementation is based on qSortHelper() from qalgorithms.h
-    // Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies).
-    // In opposite to qSort() it allows to use a member-function for the comparison of elements.
-    while (1) {
-        int span = int(end - start);
-        if (span < 2) {
-            return;
-        }
-
-        --end;
-        KFileItemList::iterator low = start, high = end - 1;
-        KFileItemList::iterator pivot = start + span / 2;
-
-        if (lessThan(*end, *start)) {
-            qSwap(*end, *start);
-        }
-        if (span == 2) {
-            return;
-        }
+    if (m_sortRole == NameRole) {
+        // Sorting by name can be expensive, in particular if natural sorting is
+        // enabled. Use all CPU cores to speed up the sorting process.
+        static const int numberOfThreads = QThread::idealThreadCount();
+        parallelMergeSort(begin, end, lessThan, numberOfThreads);
+    } else {
+        // Sorting by other roles is quite fast. Use only one thread to prevent
+        // problems caused by non-reentrant comparison functions, see
+        // https://bugs.kde.org/show_bug.cgi?id=312679
+        mergeSort(begin, end, lessThan);
+    }
+}

 
 

-        if (lessThan(*pivot, *start)) {
-            qSwap(*pivot, *start);
-        }
-        if (lessThan(*end, *pivot)) {
-            qSwap(*end, *pivot);
-        }
-        if (span == 3) {
-            return;
-        }
+int KFileItemModel::sortRoleCompare(const ItemData* a, const ItemData* b, const QCollator& collator) const
+{
+    const KFileItem& itemA = a->item;
+    const KFileItem& itemB = b->item;

 
 

-        qSwap(*pivot, *end);
+    int result = 0;

 
 

-        while (low < high) {
-            while (low < high && lessThan(*low, *end)) {
-                ++low;
-            }
+    switch (m_sortRole) {
+    case NameRole:
+        // The name role is handled as default fallback after the switch
+        break;

 
 

-            while (high > low && lessThan(*end, *high)) {
-                --high;
+    case SizeRole: {
+        if (itemA.isDir()) {
+            // See "if (m_sortFoldersFirst || m_sortRole == SizeRole)" in KFileItemModel::lessThan():
+            Q_ASSERT(itemB.isDir());
+
+            const QVariant valueA = a->values.value("size");
+            const QVariant valueB = b->values.value("size");
+            if (valueA.isNull() && valueB.isNull()) {
+                result = 0;
+            } else if (valueA.isNull()) {
+                result = -1;
+            } else if (valueB.isNull()) {
+                result = +1;
+            } else {
+                result = valueA.toInt() - valueB.toInt();

             }
             }

-            if (low < high) {
-                qSwap(*low, *high);
-                ++low;
-                --high;
+        } else {
+            // See "if (m_sortFoldersFirst || m_sortRole == SizeRole)" in KFileItemModel::lessThan():
+            Q_ASSERT(!itemB.isDir());
+            const KIO::filesize_t sizeA = itemA.size();
+            const KIO::filesize_t sizeB = itemB.size();
+            if (sizeA > sizeB) {
+                result = +1;
+            } else if (sizeA < sizeB) {
+                result = -1;

             } else {
             } else {

-                break;
+                result = 0;

             }
         }
             }
         }

-
-        if (lessThan(*low, *end)) {
-            ++low;
-        }
-
-        qSwap(*end, *low);
-        sort(start, low);
-
-        start = low + 1;
-        ++end;
+        break;

     }
     }

-}

 
 

-int KFileItemModel::stringCompare(const QString& a, const QString& b) const
-{
-    // Taken from KDirSortFilterProxyModel (kdelibs/kfile/kdirsortfilterproxymodel.*)
-    // Copyright (C) 2006 by Peter Penz <peter.penz@gmx.at>
-    // Copyright (C) 2006 by Dominic Battre <dominic@battre.de>
-    // Copyright (C) 2006 by Martin Pool <mbp@canonical.com>
-
-    if (m_caseSensitivity == Qt::CaseInsensitive) {
-        const int result = m_naturalSorting ? KStringHandler::naturalCompare(a, b, Qt::CaseInsensitive)
-                                            : QString::compare(a, b, Qt::CaseInsensitive);
-        if (result != 0) {
-            // Only return the result, if the strings are not equal. If they are equal by a case insensitive
-            // comparison, still a deterministic sort order is required. A case sensitive
-            // comparison is done as fallback.
-            return result;
+    case DateRole: {
+        const QDateTime dateTimeA = itemA.time(KFileItem::ModificationTime);
+        const QDateTime dateTimeB = itemB.time(KFileItem::ModificationTime);
+        if (dateTimeA < dateTimeB) {
+            result = -1;
+        } else if (dateTimeA > dateTimeB) {
+            result = +1;

         }
         }

+        break;

     }
 
     }
 

-    return m_naturalSorting ? KStringHandler::naturalCompare(a, b, Qt::CaseSensitive)
-                            : QString::compare(a, b, Qt::CaseSensitive);
-}
-
-int KFileItemModel::expansionLevelsCompare(const KFileItem& a, const KFileItem& b) const
-{
-    const KUrl urlA = a.url();
-    const KUrl urlB = b.url();
-    if (urlA.directory() == urlB.directory()) {
-        // Both items have the same directory as parent
-        return 0;
+    case RatingRole: {
+        result = a->values.value("rating").toInt() - b->values.value("rating").toInt();
+        break;

     }
 
     }
 

-    // Check whether one item is the parent of the other item
-    if (urlA.isParentOf(urlB)) {
-        return -1;
-    } else if (urlB.isParentOf(urlA)) {
-        return +1;
+    case ImageSizeRole: {
+        // Alway use a natural comparing to interpret the numbers of a string like
+        // "1600 x 1200" for having a correct sorting.
+        result = collator.compare(a->values.value("imageSize").toString(),
+                                  b->values.value("imageSize").toString());
+        break;

     }
 
     }
 

-    // Determine the maximum common path of both items and
-    // remember the index in 'index'
-    const QString pathA = urlA.path();
-    const QString pathB = urlB.path();
-
-    const int maxIndex = qMin(pathA.length(), pathB.length()) - 1;
-    int index = 0;
-    while (index <= maxIndex && pathA.at(index) == pathB.at(index)) {
-        ++index;
+    default: {
+        const QByteArray role = roleForType(m_sortRole);
+        result = QString::compare(a->values.value(role).toString(),
+                                  b->values.value(role).toString());
+        break;

     }
     }

-    if (index > maxIndex) {
-        index = maxIndex;
+

     }
     }

-    while ((pathA.at(index) != QLatin1Char('/') || pathB.at(index) != QLatin1Char('/')) && index > 0) {
-        --index;
+
+    if (result != 0) {
+        // The current sort role was sufficient to define an order
+        return result;

     }
 
     }
 

-    // Determine the first sub-path after the common path and
-    // check whether it represents a directory or already a file
-    bool isDirA = true;
-    const QString subPathA = subPath(a, pathA, index, &isDirA);
-    bool isDirB = true;
-    const QString subPathB = subPath(b, pathB, index, &isDirB);
+    // Fallback #1: Compare the text of the items
+    result = stringCompare(itemA.text(), itemB.text(), collator);
+    if (result != 0) {
+        return result;
+    }

 
 

-    if (isDirA && !isDirB) {
-        return -1;
-    } else if (!isDirA && isDirB) {
-        return +1;
+    // Fallback #2: KFileItem::text() may not be unique in case UDS_DISPLAY_NAME is used
+    result = stringCompare(itemA.name(), itemB.name(), collator);
+    if (result != 0) {
+        return result;

     }
 
     }
 

-    return stringCompare(subPathA, subPathB);
+    // Fallback #3: It must be assured that the sort order is always unique even if two values have been
+    // equal. In this case a comparison of the URL is done which is unique in all cases
+    // within KDirLister.
+    return QString::compare(itemA.url().url(), itemB.url().url(), Qt::CaseSensitive);

 }
 
 }
 

-QString KFileItemModel::subPath(const KFileItem& item,
-                                const QString& itemPath,
-                                int start,
-                                bool* isDir) const
+int KFileItemModel::stringCompare(const QString& a, const QString& b, const QCollator& collator) const

 {
 {

-    Q_ASSERT(isDir);
-    const int pathIndex = itemPath.indexOf('/', start + 1);
-    *isDir = (pathIndex > 0) || item.isDir();
-    return itemPath.mid(start, pathIndex - start);
+    if (m_naturalSorting) {
+        return collator.compare(a, b);
+    }
+
+    const int result = QString::compare(a, b, collator.caseSensitivity());
+    if (result != 0 || collator.caseSensitivity() == Qt::CaseSensitive) {
+        // Only return the result, if the strings are not equal. If they are equal by a case insensitive
+        // comparison, still a deterministic sort order is required. A case sensitive
+        // comparison is done as fallback.
+        return result;
+    }
+
+    return QString::compare(a, b, Qt::CaseSensitive);

 }
 
 bool KFileItemModel::useMaximumUpdateInterval() const
 {
 }
 
 bool KFileItemModel::useMaximumUpdateInterval() const
 {

-    const KDirLister* dirLister = m_dirLister.data();
-    return dirLister && !dirLister->url().isLocalFile();
+    return !m_dirLister->url().isLocalFile();

 }
 
 QList<QPair<int, QVariant> > KFileItemModel::nameRoleGroups() const
 {
 }
 
 QList<QPair<int, QVariant> > KFileItemModel::nameRoleGroups() const
 {

-    Q_ASSERT(!m_data.isEmpty());
+    Q_ASSERT(!m_itemData.isEmpty());

 
     const int maxIndex = count() - 1;
     QList<QPair<int, QVariant> > groups;
 
     QString groupValue;
     QChar firstChar;
 
     const int maxIndex = count() - 1;
     QList<QPair<int, QVariant> > groups;
 
     QString groupValue;
     QChar firstChar;

-    bool isLetter = false;

     for (int i = 0; i <= maxIndex; ++i) {
     for (int i = 0; i <= maxIndex; ++i) {

-        if (m_requestRole[ExpansionLevelRole] && m_data.at(i).value("expansionLevel").toInt() > 0) {
-            // KItemListView would be capable to show sub-groups in groups but
-            // in typical usecases this results in visual clutter, hence we
-            // just ignore sub-groups.
+        if (isChildItem(i)) {

             continue;
         }
 
             continue;
         }
 

-        const QString name = m_data.at(i).value("name").toString();
+        const QString name = m_itemData.at(i)->item.text();

 
         // Use the first character of the name as group indication
         QChar newFirstChar = name.at(0).toUpper();
         if (newFirstChar == QLatin1Char('~') && name.length() > 1) {
 
         // Use the first character of the name as group indication
         QChar newFirstChar = name.at(0).toUpper();
         if (newFirstChar == QLatin1Char('~') && name.length() > 1) {

-            newFirstChar = name.at(1);
+            newFirstChar = name.at(1).toUpper();

         }
 
         if (firstChar != newFirstChar) {
             QString newGroupValue;
         }
 
         if (firstChar != newFirstChar) {
             QString newGroupValue;

-            if (newFirstChar >= QLatin1Char('A') && newFirstChar <= QLatin1Char('Z')) {
-                // Apply group 'A' - 'Z'
-                newGroupValue = newFirstChar;
-                isLetter = true;
+            if (newFirstChar.isLetter()) {
+                // Try to find a matching group in the range 'A' to 'Z'.
+                static std::vector<QChar> lettersAtoZ;
+                if (lettersAtoZ.empty()) {
+                    for (char c = 'A'; c <= 'Z'; ++c) {
+                        lettersAtoZ.push_back(QLatin1Char(c));
+                    }
+                }
+
+                auto localeAwareLessThan = [this](const QChar& c1, const QChar& c2) -> bool {
+                    return m_collator.compare(c1, c2) < 0;
+                };
+
+                std::vector<QChar>::iterator it = std::lower_bound(lettersAtoZ.begin(), lettersAtoZ.end(), newFirstChar, localeAwareLessThan);
+                if (it != lettersAtoZ.end()) {
+                    if (localeAwareLessThan(newFirstChar, *it) && it != lettersAtoZ.begin()) {
+                        // newFirstChar belongs to the group preceding *it.
+                        // Example: for an umlaut 'A' in the German locale, *it would be 'B' now.
+                        --it;
+                    }
+                    newGroupValue = *it;
+                } else {
+                    newGroupValue = newFirstChar;
+                }

             } else if (newFirstChar >= QLatin1Char('0') && newFirstChar <= QLatin1Char('9')) {
                 // Apply group '0 - 9' for any name that starts with a digit
                 newGroupValue = i18nc("@title:group Groups that start with a digit", "0 - 9");
             } else if (newFirstChar >= QLatin1Char('0') && newFirstChar <= QLatin1Char('9')) {
                 // Apply group '0 - 9' for any name that starts with a digit
                 newGroupValue = i18nc("@title:group Groups that start with a digit", "0 - 9");

-                isLetter = false;

             } else {
             } else {

-                if (isLetter) {
-                    // If the current group is 'A' - 'Z' check whether a locale character
-                    // fits into the existing group.
-                    // TODO: This does not work in the case if e.g. the group 'O' starts with
-                    // an umlaut 'O' -> provide unit-test to document this known issue
-                    const QChar prevChar(firstChar.unicode() - ushort(1));
-                    const QChar nextChar(firstChar.unicode() + ushort(1));
-                    const QString currChar(newFirstChar);
-                    const bool partOfCurrentGroup = currChar.localeAwareCompare(prevChar) > 0 &&
-                                                    currChar.localeAwareCompare(nextChar) < 0;
-                    if (partOfCurrentGroup) {
-                        continue;
-                    }
-                }

                 newGroupValue = i18nc("@title:group", "Others");
                 newGroupValue = i18nc("@title:group", "Others");

-                isLetter = false;

             }
 
             if (newGroupValue != groupValue) {
             }
 
             if (newGroupValue != groupValue) {


@@ -1225,51 +1873,380 @@ QList<QPair<int, QVariant> > KFileItemModel::nameRoleGroups() const
 
 QList<QPair<int, QVariant> > KFileItemModel::sizeRoleGroups() const
 {
 
 QList<QPair<int, QVariant> > KFileItemModel::sizeRoleGroups() const
 {

-    Q_ASSERT(!m_data.isEmpty());
+    Q_ASSERT(!m_itemData.isEmpty());
+
+    const int maxIndex = count() - 1;
+    QList<QPair<int, QVariant> > groups;
+
+    QString groupValue;
+    for (int i = 0; i <= maxIndex; ++i) {
+        if (isChildItem(i)) {
+            continue;
+        }
+
+        const KFileItem& item = m_itemData.at(i)->item;
+        const KIO::filesize_t fileSize = !item.isNull() ? item.size() : ~0U;
+        QString newGroupValue;
+        if (!item.isNull() && item.isDir()) {
+            newGroupValue = i18nc("@title:group Size", "Folders");
+        } else if (fileSize < 5 * 1024 * 1024) {
+            newGroupValue = i18nc("@title:group Size", "Small");
+        } else if (fileSize < 10 * 1024 * 1024) {
+            newGroupValue = i18nc("@title:group Size", "Medium");
+        } else {
+            newGroupValue = i18nc("@title:group Size", "Big");
+        }
+
+        if (newGroupValue != groupValue) {
+            groupValue = newGroupValue;
+            groups.append(QPair<int, QVariant>(i, newGroupValue));
+        }
+    }

 
 

-    return QList<QPair<int, QVariant> >();
+    return groups;

 }
 
 QList<QPair<int, QVariant> > KFileItemModel::dateRoleGroups() const
 {
 }
 
 QList<QPair<int, QVariant> > KFileItemModel::dateRoleGroups() const
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    Q_ASSERT(!m_itemData.isEmpty());
+
+    const int maxIndex = count() - 1;
+    QList<QPair<int, QVariant> > groups;
+
+    const QDate currentDate = QDate::currentDate();
+
+    QDate previousModifiedDate;
+    QString groupValue;
+    for (int i = 0; i <= maxIndex; ++i) {
+        if (isChildItem(i)) {
+            continue;
+        }
+
+        const QDateTime modifiedTime = m_itemData.at(i)->item.time(KFileItem::ModificationTime);
+        const QDate modifiedDate = modifiedTime.date();
+        if (modifiedDate == previousModifiedDate) {
+            // The current item is in the same group as the previous item
+            continue;
+        }
+        previousModifiedDate = modifiedDate;
+
+        const int daysDistance = modifiedDate.daysTo(currentDate);
+
+        QString newGroupValue;
+        if (currentDate.year() == modifiedDate.year() && currentDate.month() == modifiedDate.month()) {
+            switch (daysDistance / 7) {
+            case 0:
+                switch (daysDistance) {
+                case 0:  newGroupValue = i18nc("@title:group Date", "Today"); break;
+                case 1:  newGroupValue = i18nc("@title:group Date", "Yesterday"); break;
+                default: newGroupValue = modifiedTime.toString(i18nc("@title:group The week day name: %A", "%A"));
+                }
+                break;
+            case 1:
+                newGroupValue = i18nc("@title:group Date", "One Week Ago");
+                break;
+            case 2:
+                newGroupValue = i18nc("@title:group Date", "Two Weeks Ago");
+                break;
+            case 3:
+                newGroupValue = i18nc("@title:group Date", "Three Weeks Ago");
+                break;
+            case 4:
+            case 5:
+                newGroupValue = i18nc("@title:group Date", "Earlier this Month");
+                break;
+            default:
+                Q_ASSERT(false);
+            }
+        } else {
+            const QDate lastMonthDate = currentDate.addMonths(-1);
+            if  (lastMonthDate.year() == modifiedDate.year() && lastMonthDate.month() == modifiedDate.month()) {
+                if (daysDistance == 1) {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group Date: %B is full month name in current locale, and %Y is full year number", "Yesterday (%B, %Y)"));
+                } else if (daysDistance <= 7) {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group The week day name: %A, %B is full month name in current locale, and %Y is full year number", "%A (%B, %Y)"));
+                } else if (daysDistance <= 7 * 2) {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group Date: %B is full month name in current locale, and %Y is full year number", "One Week Ago (%B, %Y)"));
+                } else if (daysDistance <= 7 * 3) {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group Date: %B is full month name in current locale, and %Y is full year number", "Two Weeks Ago (%B, %Y)"));
+                } else if (daysDistance <= 7 * 4) {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group Date: %B is full month name in current locale, and %Y is full year number", "Three Weeks Ago (%B, %Y)"));
+                } else {
+                    newGroupValue = modifiedTime.toString(i18nc("@title:group Date: %B is full month name in current locale, and %Y is full year number", "Earlier on %B, %Y"));
+                }
+            } else {
+                newGroupValue = modifiedTime.toString(i18nc("@title:group The month and year: %B is full month name in current locale, and %Y is full year number", "%B, %Y"));
+            }
+        }
+
+        if (newGroupValue != groupValue) {
+            groupValue = newGroupValue;
+            groups.append(QPair<int, QVariant>(i, newGroupValue));
+        }
+    }
+
+    return groups;

 }
 
 QList<QPair<int, QVariant> > KFileItemModel::permissionRoleGroups() const
 {
 }
 
 QList<QPair<int, QVariant> > KFileItemModel::permissionRoleGroups() const
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    Q_ASSERT(!m_itemData.isEmpty());
+
+    const int maxIndex = count() - 1;
+    QList<QPair<int, QVariant> > groups;
+
+    QString permissionsString;
+    QString groupValue;
+    for (int i = 0; i <= maxIndex; ++i) {
+        if (isChildItem(i)) {
+            continue;
+        }
+
+        const ItemData* itemData = m_itemData.at(i);
+        const QString newPermissionsString = itemData->values.value("permissions").toString();
+        if (newPermissionsString == permissionsString) {
+            continue;
+        }
+        permissionsString = newPermissionsString;
+
+        const QFileInfo info(itemData->item.url().toLocalFile());
+
+        // Set user string
+        QString user;
+        if (info.permission(QFile::ReadUser)) {
+            user = i18nc("@item:intext Access permission, concatenated", "Read, ");
+        }
+        if (info.permission(QFile::WriteUser)) {
+            user += i18nc("@item:intext Access permission, concatenated", "Write, ");
+        }
+        if (info.permission(QFile::ExeUser)) {
+            user += i18nc("@item:intext Access permission, concatenated", "Execute, ");
+        }
+        user = user.isEmpty() ? i18nc("@item:intext Access permission, concatenated", "Forbidden") : user.mid(0, user.count() - 2);
+
+        // Set group string
+        QString group;
+        if (info.permission(QFile::ReadGroup)) {
+            group = i18nc("@item:intext Access permission, concatenated", "Read, ");
+        }
+        if (info.permission(QFile::WriteGroup)) {
+            group += i18nc("@item:intext Access permission, concatenated", "Write, ");
+        }
+        if (info.permission(QFile::ExeGroup)) {
+            group += i18nc("@item:intext Access permission, concatenated", "Execute, ");
+        }
+        group = group.isEmpty() ? i18nc("@item:intext Access permission, concatenated", "Forbidden") : group.mid(0, group.count() - 2);
+
+        // Set others string
+        QString others;
+        if (info.permission(QFile::ReadOther)) {
+            others = i18nc("@item:intext Access permission, concatenated", "Read, ");
+        }
+        if (info.permission(QFile::WriteOther)) {
+            others += i18nc("@item:intext Access permission, concatenated", "Write, ");
+        }
+        if (info.permission(QFile::ExeOther)) {
+            others += i18nc("@item:intext Access permission, concatenated", "Execute, ");
+        }
+        others = others.isEmpty() ? i18nc("@item:intext Access permission, concatenated", "Forbidden") : others.mid(0, others.count() - 2);
+
+        const QString newGroupValue = i18nc("@title:group Files and folders by permissions", "User: %1 | Group: %2 | Others: %3", user, group, others);
+        if (newGroupValue != groupValue) {
+            groupValue = newGroupValue;
+            groups.append(QPair<int, QVariant>(i, newGroupValue));
+        }
+    }
+
+    return groups;
+}
+
+QList<QPair<int, QVariant> > KFileItemModel::ratingRoleGroups() const
+{
+    Q_ASSERT(!m_itemData.isEmpty());
+
+    const int maxIndex = count() - 1;
+    QList<QPair<int, QVariant> > groups;
+
+    int groupValue = -1;
+    for (int i = 0; i <= maxIndex; ++i) {
+        if (isChildItem(i)) {
+            continue;
+        }
+        const int newGroupValue = m_itemData.at(i)->values.value("rating", 0).toInt();
+        if (newGroupValue != groupValue) {
+            groupValue = newGroupValue;
+            groups.append(QPair<int, QVariant>(i, newGroupValue));
+        }
+    }
+
+    return groups;
+}
+
+QList<QPair<int, QVariant> > KFileItemModel::genericStringRoleGroups(const QByteArray& role) const
+{
+    Q_ASSERT(!m_itemData.isEmpty());
+
+    const int maxIndex = count() - 1;
+    QList<QPair<int, QVariant> > groups;
+
+    bool isFirstGroupValue = true;
+    QString groupValue;
+    for (int i = 0; i <= maxIndex; ++i) {
+        if (isChildItem(i)) {
+            continue;
+        }
+        const QString newGroupValue = m_itemData.at(i)->values.value(role).toString();
+        if (newGroupValue != groupValue || isFirstGroupValue) {
+            groupValue = newGroupValue;
+            groups.append(QPair<int, QVariant>(i, newGroupValue));
+            isFirstGroupValue = false;
+        }
+    }
+
+    return groups;

 }
 
 }
 

-QList<QPair<int, QVariant> > KFileItemModel::ownerRoleGroups() const
+void KFileItemModel::emitSortProgress(int resolvedCount)

 {
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    // Be tolerant against a resolvedCount with a wrong range.
+    // Although there should not be a case where KFileItemModelRolesUpdater
+    // (= caller) provides a wrong range, it is important to emit
+    // a useful progress information even if there is an unexpected
+    // implementation issue.
+
+    const int itemCount = count();
+    if (resolvedCount >= itemCount) {
+        m_sortingProgressPercent = -1;
+        if (m_resortAllItemsTimer->isActive()) {
+            m_resortAllItemsTimer->stop();
+            resortAllItems();
+        }
+
+        emit directorySortingProgress(100);
+    } else if (itemCount > 0) {
+        resolvedCount = qBound(0, resolvedCount, itemCount);
+
+        const int progress = resolvedCount * 100 / itemCount;
+        if (m_sortingProgressPercent != progress) {
+            m_sortingProgressPercent = progress;
+            emit directorySortingProgress(progress);
+        }
+    }

 }
 
 }
 

-QList<QPair<int, QVariant> > KFileItemModel::groupRoleGroups() const
+const KFileItemModel::RoleInfoMap* KFileItemModel::rolesInfoMap(int& count)

 {
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    static const RoleInfoMap rolesInfoMap[] = {
+    //  | role         | roleType       | role translation                                | group translation           | requires Baloo   | requires indexer
+        { 0,             NoRole,          0, 0,                                             0, 0,                                     false, false },
+        { "text",        NameRole,        I18N_NOOP2_NOSTRIP("@label", "Name"),             0, 0,                                     false, false },
+        { "size",        SizeRole,        I18N_NOOP2_NOSTRIP("@label", "Size"),             0, 0,                                     false, false },
+        { "date",        DateRole,        I18N_NOOP2_NOSTRIP("@label", "Date"),             0, 0,                                     false, false },
+        { "type",        TypeRole,        I18N_NOOP2_NOSTRIP("@label", "Type"),             0, 0,                                     false, false },
+        { "rating",      RatingRole,      I18N_NOOP2_NOSTRIP("@label", "Rating"),           0, 0,                                     true,  false },
+        { "tags",        TagsRole,        I18N_NOOP2_NOSTRIP("@label", "Tags"),             0, 0,                                     true,  false },
+        { "comment",     CommentRole,     I18N_NOOP2_NOSTRIP("@label", "Comment"),          0, 0,                                     true,  false },
+        { "wordCount",   WordCountRole,   I18N_NOOP2_NOSTRIP("@label", "Word Count"),       I18N_NOOP2_NOSTRIP("@label", "Document"), true,  true  },
+        { "lineCount",   LineCountRole,   I18N_NOOP2_NOSTRIP("@label", "Line Count"),       I18N_NOOP2_NOSTRIP("@label", "Document"), true,  true  },
+        { "imageSize",   ImageSizeRole,   I18N_NOOP2_NOSTRIP("@label", "Image Size"),       I18N_NOOP2_NOSTRIP("@label", "Image"),    true,  true  },
+        { "orientation", OrientationRole, I18N_NOOP2_NOSTRIP("@label", "Orientation"),      I18N_NOOP2_NOSTRIP("@label", "Image"),    true,  true  },
+        { "artist",      ArtistRole,      I18N_NOOP2_NOSTRIP("@label", "Artist"),           I18N_NOOP2_NOSTRIP("@label", "Audio"),    true,  true  },
+        { "album",       AlbumRole,       I18N_NOOP2_NOSTRIP("@label", "Album"),            I18N_NOOP2_NOSTRIP("@label", "Audio"),    true,  true  },
+        { "duration",    DurationRole,    I18N_NOOP2_NOSTRIP("@label", "Duration"),         I18N_NOOP2_NOSTRIP("@label", "Audio"),    true,  true  },
+        { "track",       TrackRole,       I18N_NOOP2_NOSTRIP("@label", "Track"),            I18N_NOOP2_NOSTRIP("@label", "Audio"),    true,  true  },
+        { "path",        PathRole,        I18N_NOOP2_NOSTRIP("@label", "Path"),             I18N_NOOP2_NOSTRIP("@label", "Other"),    false, false },
+        { "destination", DestinationRole, I18N_NOOP2_NOSTRIP("@label", "Link Destination"), I18N_NOOP2_NOSTRIP("@label", "Other"),    false, false },
+        { "copiedFrom",  CopiedFromRole,  I18N_NOOP2_NOSTRIP("@label", "Copied From"),      I18N_NOOP2_NOSTRIP("@label", "Other"),    true,  false },
+        { "permissions", PermissionsRole, I18N_NOOP2_NOSTRIP("@label", "Permissions"),      I18N_NOOP2_NOSTRIP("@label", "Other"),    false, false },
+        { "owner",       OwnerRole,       I18N_NOOP2_NOSTRIP("@label", "Owner"),            I18N_NOOP2_NOSTRIP("@label", "Other"),    false, false },
+        { "group",       GroupRole,       I18N_NOOP2_NOSTRIP("@label", "User Group"),       I18N_NOOP2_NOSTRIP("@label", "Other"),    false, false },
+    };
+
+    count = sizeof(rolesInfoMap) / sizeof(RoleInfoMap);
+    return rolesInfoMap;

 }
 
 }
 

-QList<QPair<int, QVariant> > KFileItemModel::typeRoleGroups() const
+void KFileItemModel::determineMimeTypes(const KFileItemList& items, int timeout)

 {
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    QElapsedTimer timer;
+    timer.start();
+    foreach (const KFileItem& item, items) { // krazy:exclude=foreach
+        // Only determine mime types for files here. For directories,
+        // KFileItem::determineMimeType() reads the .directory file inside to
+        // load the icon, but this is not necessary at all if we just need the
+        // type. Some special code for setting the correct mime type for
+        // directories is in retrieveData().
+        if (!item.isDir()) {
+            item.determineMimeType();
+        }
+
+        if (timer.elapsed() > timeout) {
+            // Don't block the user interface, let the remaining items
+            // be resolved asynchronously.
+            return;
+        }
+    }

 }
 
 }
 

-QList<QPair<int, QVariant> > KFileItemModel::destinationRoleGroups() const
+QByteArray KFileItemModel::sharedValue(const QByteArray& value)

 {
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    static QSet<QByteArray> pool;
+    const QSet<QByteArray>::const_iterator it = pool.constFind(value);
+
+    if (it != pool.constEnd()) {
+        return *it;
+    } else {
+        pool.insert(value);
+        return value;
+    }

 }
 
 }
 

-QList<QPair<int, QVariant> > KFileItemModel::pathRoleGroups() const
+bool KFileItemModel::isConsistent() const

 {
 {

-    Q_ASSERT(!m_data.isEmpty());
-    return QList<QPair<int, QVariant> >();
+    // m_items may contain less items than m_itemData because m_items
+    // is populated lazily, see KFileItemModel::index(const QUrl& url).
+    if (m_items.count() > m_itemData.count()) {
+        return false;
+    }
+
+    for (int i = 0; i < count(); ++i) {
+        // Check if m_items and m_itemData are consistent.
+        const KFileItem item = fileItem(i);
+        if (item.isNull()) {
+            qWarning() << "Item" << i << "is null";
+            return false;
+        }
+
+        const int itemIndex = index(item);
+        if (itemIndex != i) {
+            qWarning() << "Item" << i << "has a wrong index:" << itemIndex;
+            return false;
+        }
+
+        // Check if the items are sorted correctly.
+        if (i > 0 && !lessThan(m_itemData.at(i - 1), m_itemData.at(i), m_collator)) {
+            qWarning() << "The order of items" << i - 1 << "and" << i << "is wrong:"
+                << fileItem(i - 1) << fileItem(i);
+            return false;
+        }
+
+        // Check if all parent-child relationships are consistent.
+        const ItemData* data = m_itemData.at(i);
+        const ItemData* parent = data->parent;
+        if (parent) {
+            if (expandedParentsCount(data) != expandedParentsCount(parent) + 1) {
+                qWarning() << "expandedParentsCount is inconsistent for parent" << parent->item << "and child" << data->item;
+                return false;
+            }
+
+            const int parentIndex = index(parent->item);
+            if (parentIndex >= i) {
+                qWarning() << "Index" << parentIndex << "of parent" << parent->item << "is not smaller than index" << i << "of child" << data->item;
+                return false;
+            }
+        }
+    }
+
+    return true;

 }
 
 }
 

-#include "kfileitemmodel.moc"