X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/48b58f830a585b773435c9af5ee2fe8f0c7c641d..b734386cbc8436a239d20df31253a870c4e6c936:/src/main.cpp diff --git a/src/main.cpp b/src/main.cpp index db52e11be..a46b5e2d8 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -43,10 +43,15 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) { #ifndef Q_OS_WIN - // Check whether we are running as root + // Prohibit using sudo or kdesu (but allow using the root user directly) if (getuid() == 0) { - std::cout << "Executing Dolphin as root is not possible." << std::endl; - return EXIT_FAILURE; + if (!qEnvironmentVariableIsEmpty("SUDO_USER")) { + std::cout << "Executing Dolphin with sudo is not possible due to unfixable security vulnerabilities." << std::endl; + return EXIT_FAILURE; + } else if (!qEnvironmentVariableIsEmpty("KDESU_USER")) { + std::cout << "Executing Dolphin with kdesu is not possible due to unfixable security vulnerabilities." << std::endl; + return EXIT_FAILURE; + } } #endif @@ -108,8 +113,6 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) DBusInterface interface; QCommandLineParser parser; - parser.addVersionOption(); - parser.addHelpOption(); aboutData.setupCommandLine(&parser); // command line options