X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/5acfb27760f3da1d4f794e820008f8a4c8ff7533..17af8ae0ad9092e2f64f8fb612ac39d3b078a266:/src/main.cpp diff --git a/src/main.cpp b/src/main.cpp index cbfc6b72f..08405d007 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -19,69 +19,96 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * ***************************************************************************/ -#include "dolphinmainwindow.h" -#include "dolphin_generalsettings.h" #include "dbusinterface.h" +#include "dolphin_generalsettings.h" +#include "dolphin_version.h" +#include "dolphindebug.h" +#include "dolphinmainwindow.h" #include "global.h" -#include #include -#include -#include -#include +#include +#include #include -#include "dolphindebug.h" -#include +#include + +#include +#include + +#ifndef Q_OS_WIN +#include +#endif +#include extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) { +#ifndef Q_OS_WIN + // Prohibit using sudo or kdesu (but allow using the root user directly) + if (getuid() == 0) { + if (!qEnvironmentVariableIsEmpty("SUDO_USER")) { + std::cout << "Executing Dolphin with sudo is not possible due to unfixable security vulnerabilities." << std::endl; + return EXIT_FAILURE; + } else if (!qEnvironmentVariableIsEmpty("KDESU_USER")) { + std::cout << "Executing Dolphin with kdesu is not possible due to unfixable security vulnerabilities." << std::endl; + return EXIT_FAILURE; + } + } +#endif + QApplication app(argc, argv); app.setAttribute(Qt::AA_UseHighDpiPixmaps, true); + app.setWindowIcon(QIcon::fromTheme(QStringLiteral("system-file-manager"), app.windowIcon())); + + KCrash::initialize(); + Kdelibs4ConfigMigrator migrate(QStringLiteral("dolphin")); migrate.setConfigFiles(QStringList() << QStringLiteral("dolphinrc")); migrate.setUiFiles(QStringList() << QStringLiteral("dolphinpart.rc") << QStringLiteral("dolphinui.rc")); migrate.migrate(); - app.setWindowIcon(QIcon::fromTheme("system-file-manager")); + KLocalizedString::setApplicationDomain("dolphin"); - KAboutData aboutData("dolphin", i18n("Dolphin"), "14.12.95", + KAboutData aboutData(QStringLiteral("dolphin"), i18n("Dolphin"), QStringLiteral(DOLPHIN_VERSION_STRING), i18nc("@title", "File Manager"), KAboutLicense::GPL, - i18nc("@info:credit", "(C) 2006-2014 Peter Penz, Frank Reininghaus, and Emmanuel Pescosta")); - aboutData.setHomepage("http://dolphin.kde.org"); + i18nc("@info:credit", "(C) 2006-2018 Peter Penz, Frank Reininghaus, Emmanuel Pescosta and Elvis Angelaccio")); + aboutData.setHomepage(QStringLiteral("https://dolphin.kde.org")); + aboutData.addAuthor(i18nc("@info:credit", "Elvis Angelaccio"), + i18nc("@info:credit", "Maintainer (since 2018) and developer"), + QStringLiteral("elvis.angelaccio@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Emmanuel Pescosta"), - i18nc("@info:credit", "Maintainer (since 2014) and developer"), - "emmanuelpescosta099@gmail.com"); + i18nc("@info:credit", "Maintainer (2014-2018) and developer"), + QStringLiteral("emmanuelpescosta099@gmail.com")); aboutData.addAuthor(i18nc("@info:credit", "Frank Reininghaus"), i18nc("@info:credit", "Maintainer (2012-2014) and developer"), - "frank78ac@googlemail.com"); + QStringLiteral("frank78ac@googlemail.com")); aboutData.addAuthor(i18nc("@info:credit", "Peter Penz"), i18nc("@info:credit", "Maintainer and developer (2006-2012)"), - "peter.penz19@gmail.com"); + QStringLiteral("peter.penz19@gmail.com")); aboutData.addAuthor(i18nc("@info:credit", "Sebastian Trüg"), i18nc("@info:credit", "Developer"), - "trueg@kde.org"); + QStringLiteral("trueg@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "David Faure"), i18nc("@info:credit", "Developer"), - "faure@kde.org"); + QStringLiteral("faure@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Aaron J. Seigo"), i18nc("@info:credit", "Developer"), - "aseigo@kde.org"); + QStringLiteral("aseigo@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Rafael Fernández López"), i18nc("@info:credit", "Developer"), - "ereslibre@kde.org"); + QStringLiteral("ereslibre@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Kevin Ottens"), i18nc("@info:credit", "Developer"), - "ervin@kde.org"); + QStringLiteral("ervin@kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Holger Freyther"), i18nc("@info:credit", "Developer"), - "freyther@gmx.net"); + QStringLiteral("freyther@gmx.net")); aboutData.addAuthor(i18nc("@info:credit", "Max Blazejak"), i18nc("@info:credit", "Developer"), - "m43ksrocks@gmail.com"); + QStringLiteral("m43ksrocks@gmail.com")); aboutData.addAuthor(i18nc("@info:credit", "Michael Austin"), i18nc("@info:credit", "Documentation"), - "tuxedup@users.sourceforge.net"); + QStringLiteral("tuxedup@users.sourceforge.net")); KAboutData::setApplicationData(aboutData); @@ -89,54 +116,50 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) DBusInterface interface; QCommandLineParser parser; - parser.addVersionOption(); - parser.addHelpOption(); aboutData.setupCommandLine(&parser); // command line options - parser.addOption(QCommandLineOption(QStringList() << QLatin1String("select"), i18nc("@info:shell", "The files and directories passed as arguments " + parser.addOption(QCommandLineOption(QStringList() << QStringLiteral("select"), i18nc("@info:shell", "The files and folders passed as arguments " "will be selected."))); - parser.addOption(QCommandLineOption(QStringList() << QLatin1String("split"), i18nc("@info:shell", "Dolphin will get started with a split view."))); - parser.addOption(QCommandLineOption(QStringList() << QLatin1String("daemon"), i18nc("@info:shell", "Start Dolphin Daemon (only required for DBus Interface)"))); - parser.addPositionalArgument(QLatin1String("+[Url]"), i18nc("@info:shell", "Document to open")); + parser.addOption(QCommandLineOption(QStringList() << QStringLiteral("split"), i18nc("@info:shell", "Dolphin will get started with a split view."))); + parser.addOption(QCommandLineOption(QStringList() << QStringLiteral("daemon"), i18nc("@info:shell", "Start Dolphin Daemon (only required for DBus Interface)"))); + parser.addPositionalArgument(QStringLiteral("+[Url]"), i18nc("@info:shell", "Document to open")); parser.process(app); aboutData.processCommandLine(&parser); - if (parser.isSet("daemon")) { + if (parser.isSet(QStringLiteral("daemon"))) { return app.exec(); } - DolphinMainWindow* m_mainWindow = new DolphinMainWindow(); - m_mainWindow->setAttribute(Qt::WA_DeleteOnClose); - const QStringList args = parser.positionalArguments(); QList urls = Dolphin::validateUris(args); if (urls.isEmpty()) { // We need at least one URL to open Dolphin - const QUrl homeUrl(QUrl::fromLocalFile(GeneralSettings::homeUrl())); - urls.append(homeUrl); + urls.append(Dolphin::homeUrl()); } - const bool splitView = parser.isSet("split") || GeneralSettings::splitView(); + const bool splitView = parser.isSet(QStringLiteral("split")) || GeneralSettings::splitView(); if (splitView && urls.size() < 2) { // Split view does only make sense if we have at least 2 URLs urls.append(urls.last()); } - if (parser.isSet("select")) { - m_mainWindow->openFiles(urls, splitView); + DolphinMainWindow* mainWindow = new DolphinMainWindow(); + + if (parser.isSet(QStringLiteral("select"))) { + mainWindow->openFiles(urls, splitView); } else { - m_mainWindow->openDirectories(urls, splitView); + mainWindow->openDirectories(urls, splitView); } - m_mainWindow->show(); + mainWindow->show(); if (app.isSessionRestored()) { const QString className = KXmlGuiWindow::classNameOfToplevel(1); if (className == QLatin1String("DolphinMainWindow")) { - m_mainWindow->restore(1); + mainWindow->restore(1); } else { qCWarning(DolphinDebug) << "Unknown class " << className << " in session saved data!"; }