X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/7904ae417af2b7b59ee54a9f875191e9e4802492..bff373d598c031cb1:/src/tests/dolphinmainwindowtest.cpp diff --git a/src/tests/dolphinmainwindowtest.cpp b/src/tests/dolphinmainwindowtest.cpp index 027ab3e89..9cc6b84e8 100644 --- a/src/tests/dolphinmainwindowtest.cpp +++ b/src/tests/dolphinmainwindowtest.cpp @@ -40,6 +40,7 @@ private slots: void testActiveViewAfterClosingSplitView_data(); void testActiveViewAfterClosingSplitView(); void testUpdateWindowTitleAfterClosingSplitView(); + void testUpdateWindowTitleAfterChangingSplitView(); void testOpenInNewTabTitle(); void testNewFileMenuEnabled_data(); void testNewFileMenuEnabled(); @@ -175,6 +176,36 @@ void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView() QCOMPARE(currentUrlChangedSpy.count(), 1); } +// Test case for bug #402641 +void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView() +{ + m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false); + m_mainWindow->show(); + QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data())); + QVERIFY(m_mainWindow->isVisible()); + + auto tabWidget = m_mainWindow->findChild("tabWidget"); + QVERIFY(tabWidget); + + // Open split view. + m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger(); + QVERIFY(tabWidget->currentTabPage()->splitViewEnabled()); + + auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer(); + auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer(); + + // Store old window title. + const auto oldTitle = m_mainWindow->windowTitle(); + + // Change URL in the right view and make sure the title gets updated. + rightViewContainer->setUrl(QUrl::fromLocalFile(QDir::rootPath())); + QVERIFY(m_mainWindow->windowTitle() != oldTitle); + + // Activate back the left view and check whether the old title gets restored. + leftViewContainer->setActive(true); + QCOMPARE(m_mainWindow->windowTitle(), oldTitle); +} + // Test case for bug #397910 void DolphinMainWindowTest::testOpenInNewTabTitle() { @@ -188,8 +219,10 @@ void DolphinMainWindowTest::testOpenInNewTabTitle() tabWidget->openNewTab(QUrl::fromLocalFile(QDir::tempPath())); QCOMPARE(tabWidget->count(), 2); - QVERIFY(tabWidget->tabIcon(0).name() != tabWidget->tabIcon(1).name()); QVERIFY(tabWidget->tabText(0) != tabWidget->tabText(1)); + if (!tabWidget->tabIcon(0).isNull() && !tabWidget->tabIcon(1).isNull()) { + QVERIFY(tabWidget->tabIcon(0).name() != tabWidget->tabIcon(1).name()); + } } void DolphinMainWindowTest::testNewFileMenuEnabled_data()