X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/7cd33328af96e461a872a5b09c9f7568e0d8337c..846b21edf57e7aeb83e84ee68e9f61c5981fbacd:/src/infosidebarpage.cpp diff --git a/src/infosidebarpage.cpp b/src/infosidebarpage.cpp index cbd3bb439..30c4467b4 100644 --- a/src/infosidebarpage.cpp +++ b/src/infosidebarpage.cpp @@ -48,7 +48,9 @@ InfoSidebarPage::InfoSidebarPage(QWidget* parent) : SidebarPage(parent), m_pendingPreview(false), - m_timer(0), + m_shownUrl(), + m_urlCandidate(), + m_fileItem(), m_preview(0), m_nameLabel(0), m_infoLabel(0), @@ -66,8 +68,8 @@ InfoSidebarPage::InfoSidebarPage(QWidget* parent) : // preview m_preview = new PixmapViewer(this); - m_preview->setMinimumWidth(K3Icon::SizeEnormous); - m_preview->setFixedHeight(K3Icon::SizeEnormous); + m_preview->setMinimumWidth(KIconLoader::SizeEnormous); + m_preview->setMinimumHeight(KIconLoader::SizeEnormous); // name m_nameLabel = new QLabel(this); @@ -77,8 +79,10 @@ InfoSidebarPage::InfoSidebarPage(QWidget* parent) : // general information m_infoLabel = new QLabel(this); - m_infoLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed); + m_infoLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum); m_infoLabel->setTextFormat(Qt::RichText); + m_infoLabel->setWordWrap(true); + m_infoLabel->setFont(KGlobalSettings::smallestReadableFont()); if (MetaDataWidget::metaDataAvailable()) { m_metadataWidget = new MetaDataWidget(this); @@ -89,8 +93,8 @@ InfoSidebarPage::InfoSidebarPage(QWidget* parent) : layout->addWidget(m_nameLabel); layout->addWidget(new KSeparator(this)); layout->addWidget(m_infoLabel); - layout->addWidget(new KSeparator(this)); - if (m_metadataWidget) { + if (m_metadataWidget != 0) { + layout->addWidget(new KSeparator(this)); layout->addWidget(m_metadataWidget); } // ensure that widgets in the information side bar are aligned towards the top @@ -102,6 +106,13 @@ InfoSidebarPage::~InfoSidebarPage() { } +QSize InfoSidebarPage::sizeHint() const +{ + QSize size = SidebarPage::sizeHint(); + size.setWidth(minimumSizeHint().width()); + return size; +} + void InfoSidebarPage::setUrl(const KUrl& url) { if (url.isValid() && !m_shownUrl.equals(url, KUrl::CompareWithoutTrailingSlash)) { @@ -114,16 +125,28 @@ void InfoSidebarPage::setUrl(const KUrl& url) void InfoSidebarPage::setSelection(const KFileItemList& selection) { SidebarPage::setSelection(selection); + if (selection.size() == 1) { + const KUrl url = selection.first().url(); + if (!url.isEmpty()) { + m_urlCandidate = url; + } + } m_timer->start(TimerDelay); } -void InfoSidebarPage::requestDelayedItemInfo(const KUrl& url) +void InfoSidebarPage::requestDelayedItemInfo(const KFileItem& item) { cancelRequest(); - if (!url.isEmpty() && (selection().size() <= 1)) { - m_urlCandidate = url; - m_timer->start(TimerDelay); + m_fileItem = KFileItem(); + + if (!item.isNull() && (selection().size() <= 1)) { + const KUrl url = item.url(); + if (!url.isEmpty()) { + m_urlCandidate = url; + m_fileItem = item; + m_timer->start(TimerDelay); + } } } @@ -146,6 +169,12 @@ void InfoSidebarPage::resizeEvent(QResizeEvent* event) const int maxWidth = event->size().width() - KDialog::spacingHint() * 4; m_nameLabel->setMaximumWidth(maxWidth); m_infoLabel->setMaximumWidth(maxWidth); + + // try to increase the preview as large as possible + m_preview->setSizeHint(QSize(maxWidth, maxWidth)); + m_urlCandidate = m_shownUrl; // reset the URL candidate if a resizing is done + m_timer->start(TimerDelay); + SidebarPage::resizeEvent(event); } @@ -160,20 +189,23 @@ void InfoSidebarPage::showItemInfo() const KFileItemList& selectedItems = selection(); KUrl file; - const int itemCount = selectedItems.count(); - if (selectedItems.count() == 0) { + if (selectedItems.isEmpty()) { file = m_shownUrl; } else { - file = selectedItems[0]->url(); + file = selectedItems[0].url(); } + if (!file.isValid()) { + return; + } + const int itemCount = selectedItems.count(); if (itemCount > 1) { KIconLoader iconLoader; - QPixmap icon = iconLoader.loadIcon("exec", - K3Icon::NoGroup, - K3Icon::SizeEnormous); + QPixmap icon = iconLoader.loadIcon("system-run", + KIconLoader::NoGroup, + m_preview->width()); m_preview->setPixmap(icon); - m_nameLabel->setText(i18np("%1 item selected", "%1 items selected", selectedItems.count())); - } else if (!applyBookmark(file)) { + m_nameLabel->setText(i18ncp("@info", "%1 item selected", "%1 items selected", selectedItems.count())); + } else if (!applyPlace(file)) { // try to get a preview pixmap from the item... KUrl::List list; list.append(file); @@ -183,7 +215,7 @@ void InfoSidebarPage::showItemInfo() KIO::PreviewJob* job = KIO::filePreview(list, m_preview->width(), - K3Icon::SizeEnormous, + m_preview->height(), 0, 0, true, @@ -213,8 +245,8 @@ void InfoSidebarPage::slotTimeout() void InfoSidebarPage::showIcon(const KFileItem& item) { m_pendingPreview = false; - if (!applyBookmark(item.url())) { - m_preview->setPixmap(item.pixmap(K3Icon::SizeEnormous)); + if (!applyPlace(item.url())) { + m_preview->setPixmap(item.pixmap(KIconLoader::SizeEnormous)); } } @@ -228,7 +260,7 @@ void InfoSidebarPage::showPreview(const KFileItem& item, } } -bool InfoSidebarPage::applyBookmark(const KUrl& url) +bool InfoSidebarPage::applyPlace(const KUrl& url) { KFilePlacesModel* placesModel = DolphinSettings::instance().placesModel(); int count = placesModel->rowCount(); @@ -262,21 +294,31 @@ void InfoSidebarPage::showMetaInfo() const KFileItemList& selectedItems = selection(); if (selectedItems.size() <= 1) { - KFileItem fileItem(S_IFDIR, KFileItem::Unknown, m_shownUrl); - fileItem.refresh(); + KFileItem fileItem; + if (m_fileItem.isNull()) { + // no pending request is ongoing + fileItem = KFileItem(KFileItem::Unknown, KFileItem::Unknown, m_shownUrl); + fileItem.refresh(); + } else { + fileItem = m_fileItem; + } if (fileItem.isDir()) { - addInfoLine(text, i18n("Type:"), i18n("Folder")); + addInfoLine(text, i18nc("@label", "Type:"), i18nc("@label", "Folder")); } else { - addInfoLine(text, i18n("Type:"), fileItem.mimeComment()); - - QString sizeText(KIO::convertSize(fileItem.size())); - addInfoLine(text, i18n("Size:"), sizeText); - addInfoLine(text, i18n("Modified:"), fileItem.timeString()); - - // TODO: deactivate showing additional meta information, as the system - // hangs when retrieving the meta information of a zipped file - /*const KFileMetaInfo metaInfo(fileItem.url()); + addInfoLine(text, i18nc("@label", "Type:"), fileItem.mimeComment()); + + addInfoLine(text, i18nc("@label", "Size:"), KIO::convertSize(fileItem.size())); + addInfoLine(text, i18nc("@label", "Modified:"), fileItem.timeString()); + + // TODO: See convertMetaInfo below, find a way to display only interesting information + // in a readable way + const KFileMetaInfo::WhatFlags flags = KFileMetaInfo::Fastest | + KFileMetaInfo::TechnicalInfo | + KFileMetaInfo::ContentInfo | + KFileMetaInfo::Thumbnail; + const QString path = fileItem.url().url(); + const KFileMetaInfo metaInfo(path, QString(), flags); if (metaInfo.isValid()) { const QHash& items = metaInfo.items(); QHash::const_iterator it = items.constBegin(); @@ -290,7 +332,7 @@ void InfoSidebarPage::showMetaInfo() } ++it; } - }*/ + } } if (MetaDataWidget::metaDataAvailable()) { @@ -298,16 +340,22 @@ void InfoSidebarPage::showMetaInfo() } } else { if (MetaDataWidget::metaDataAvailable()) { - m_metadataWidget->setFiles(selectedItems.urlList()); + KUrl::List urls; + foreach (const KFileItem& item, selectedItems) { + urls.append(item.url()); + } + m_metadataWidget->setFiles(urls); } unsigned long int totalSize = 0; - foreach (KFileItem* item, selectedItems) { - // TODO: what to do with directories (same with the one-item-selected-code)?, - // item->size() does not return the size of the content : not very instinctive for users - totalSize += item->size(); + foreach (const KFileItem& item, selectedItems) { + // Only count the size of files, not dirs; to match what + // DolphinViewContainer::selectionStatusBarText does. + if (!item.isDir() && !item.isLink()) { + totalSize += item.size(); + } } - addInfoLine(text, i18n("Total size:"), KIO::convertSize(totalSize)); + addInfoLine(text, i18nc("@label", "Total size:"), KIO::convertSize(totalSize)); } m_infoLabel->setText(text); } @@ -316,7 +364,7 @@ void InfoSidebarPage::addInfoLine(QString& text, const QString& labelText, const QString& infoText) { - if (!infoText.isEmpty()) { + if (!text.isEmpty()) { text += "
"; } text += QString("%1 %2").arg(labelText).arg(infoText);