X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/9f7c2424d9c6df1a8461e24a8865552629fcda1a..b1c9b5126d:/src/settings/previewssettingspage.cpp

diff --git a/src/settings/previewssettingspage.cpp b/src/settings/previewssettingspage.cpp
index d9a361c8d..e0e07b64f 100644
--- a/src/settings/previewssettingspage.cpp
+++ b/src/settings/previewssettingspage.cpp
@@ -37,6 +37,10 @@
 #include <khbox.h>
 #include <kvbox.h>
 
+// default settings
+const bool USE_THUMBNAILS = true;
+const int MAX_PREVIEW_SIZE = 5; // 5 MB
+
 PreviewsSettingsPage::PreviewsSettingsPage(QWidget* parent) :
     SettingsPageBase(parent),
     m_maxPreviewSize(0),
@@ -54,8 +58,15 @@ PreviewsSettingsPage::PreviewsSettingsPage(QWidget* parent) :
 
     new QLabel(i18nc("@label:slider", "Maximum file size:"), hBox);
     m_maxPreviewSize = new QSlider(Qt::Horizontal, hBox);
+    m_maxPreviewSize->setPageStep(10);
+    m_maxPreviewSize->setSingleStep(1);
+    m_maxPreviewSize->setTickPosition(QSlider::TicksBelow);
+    m_maxPreviewSize->setRange(1, 100); /* MB */
 
     m_spinBox = new QSpinBox(hBox);
+    m_spinBox->setSingleStep(1);
+    m_spinBox->setSuffix(" MB");
+    m_spinBox->setRange(1, 100); /* MB */
 
     connect(m_maxPreviewSize, SIGNAL(valueChanged(int)),
             m_spinBox, SLOT(setValue(int)));
@@ -98,41 +109,29 @@ void PreviewsSettingsPage::applySettings()
 
 void PreviewsSettingsPage::restoreDefaults()
 {
-    GeneralSettings* settings = DolphinSettings::instance().generalSettings();
-    settings->useDefaults(true);
-    loadSettings();
-    settings->useDefaults(false);
+    m_maxPreviewSize->setValue(MAX_PREVIEW_SIZE);
+    m_useFileThumbnails->setChecked(USE_THUMBNAILS);
 }
 
 void PreviewsSettingsPage::loadSettings()
 {
     const int min = 1;   // MB
     const int max = 100; // MB
-    m_maxPreviewSize->setRange(min, max);
-    m_maxPreviewSize->setPageStep(10);
-    m_maxPreviewSize->setSingleStep(1);
-    m_maxPreviewSize->setTickPosition(QSlider::TicksBelow);
 
     KConfigGroup globalConfig(KGlobal::config(), "PreviewSettings");
     // TODO: The default value of 5 MB must match with the default value inside
     // kdelibs/kio/kio/previewjob.cpp. Maybe a static getter method in PreviewJob
     // should be added for getting the default size?
-    const int maxByteSize = globalConfig.readEntry("MaximumSize", 5 * 1024 * 1024 /* 5 MB */);
+    const int maxByteSize = globalConfig.readEntry("MaximumSize", MAX_PREVIEW_SIZE * 1024 * 1024);
     int maxMByteSize = maxByteSize / (1024 * 1024);
-    if (maxMByteSize < 1) {
-        maxMByteSize = 1;
+    if (maxMByteSize < min) {
+        maxMByteSize = min;
     } else if (maxMByteSize > max) {
         maxMByteSize = max;
     }
-
-    m_spinBox->setRange(min, max);
-    m_spinBox->setSingleStep(1);
-    m_spinBox->setSuffix(" MB");
-
     m_maxPreviewSize->setValue(maxMByteSize);
-    m_spinBox->setValue(m_maxPreviewSize->value());
 
-    const bool useFileThumbnails = globalConfig.readEntry("UseFileThumbnails", true);
+    const bool useFileThumbnails = globalConfig.readEntry("UseFileThumbnails", USE_THUMBNAILS);
     m_useFileThumbnails->setChecked(useFileThumbnails);
 }