X-Git-Url: https://cloud.milkyroute.net/gitweb/dolphin.git/blobdiff_plain/d472cb2a25cef38dbebbd0ec9073e4ec05d65272..19cd2364a917c55e245dbdf3bfc87b2dc520046c:/src/global.cpp diff --git a/src/global.cpp b/src/global.cpp index d217a67ec..5d6d90b59 100644 --- a/src/global.cpp +++ b/src/global.cpp @@ -62,8 +62,7 @@ bool Dolphin::attachToExistingInstance(const QList& inputUrls, bool openFi { bool attached = false; - // TODO: once Wayland clients can raise or activate themselves remove check from conditional - if (KWindowSystem::isPlatformWayland() || inputUrls.isEmpty() || !GeneralSettings::openExternallyCalledFolderInNewTab()) { + if (inputUrls.isEmpty() || !GeneralSettings::openExternallyCalledFolderInNewTab()) { return false; } @@ -72,35 +71,55 @@ bool Dolphin::attachToExistingInstance(const QList& inputUrls, bool openFi return false; } - QStringList newUrls; + int activeWindowIndex = -1; + for (const auto& interface: qAsConst(dolphinInterfaces)) { + ++activeWindowIndex; - // check to see if any instances already have any of the given URLs open + auto isActiveWindowReply = interface.first->isActiveWindow(); + isActiveWindowReply.waitForFinished(); + if (!isActiveWindowReply.isError() && isActiveWindowReply.value()) { + break; + } + } + + // check to see if any instances already have any of the given URLs or their parents open const auto urls = QUrl::toStringList(inputUrls); for (const QString& url : urls) { bool urlFound = false; - for (auto& interface: dolphinInterfaces) { - auto isUrlOpenReply = interface.first->isUrlOpen(url); + + // looping through the windows starting from the active one + int i = activeWindowIndex; + do { + auto &interface = dolphinInterfaces[i]; + + auto isUrlOpenReply = openFiles ? interface.first->isUrlOrParentOpen(url) : interface.first->isUrlOpen(url); isUrlOpenReply.waitForFinished(); if (!isUrlOpenReply.isError() && isUrlOpenReply.value()) { interface.second.append(url); urlFound = true; break; } + + i = (i + 1) % dolphinInterfaces.size(); } + while (i != activeWindowIndex); + if (!urlFound) { - newUrls.append(url); + dolphinInterfaces[activeWindowIndex].second.append(url); } } - dolphinInterfaces.front().second << newUrls; for (const auto& interface: qAsConst(dolphinInterfaces)) { - if (!interface.second.isEmpty()) { - auto reply = openFiles ? interface.first->openFiles(interface.second, splitView) : interface.first->openDirectories(interface.second, splitView); - reply.waitForFinished(); - if (!reply.isError()) { - interface.first->activateWindow(); - attached = true; - } + if (interface.second.isEmpty()) { + continue; + } + auto reply = openFiles ? + interface.first->openFiles(interface.second, splitView) : + interface.first->openDirectories(interface.second, splitView); + reply.waitForFinished(); + if (!reply.isError()) { + interface.first->activateWindow(); + attached = true; } } return attached;