]> cloud.milkyroute.net Git - dolphin.git/commit
Fix location bar being wrongly aligned on first startup
authorFelix Ernst <fe.a.ernst@gmail.com>
Wed, 6 Jan 2021 01:38:45 +0000 (01:38 +0000)
committerFelix Ernst <fe.a.ernst@gmail.com>
Wed, 6 Jan 2021 01:38:45 +0000 (01:38 +0000)
commit0cee94ce82ccb82afd0c4e22d77e251276e7a447
treeecff9e2193de4ca82f0f99d455abd7735e850d57
parenta993a5979dcfde63004b2ef00c98f1fa50e07b2c
Fix location bar being wrongly aligned on first startup

When starting Dolphin the very first time, the spacing in front of the
location bar is wrong. This commit fixes this by completely updating
all cached geometry every time adjustSpacing() is called. Because this
happens once on a timer 100 ms after every url change, it will happen
once shortly after the window is shown. At that point all geometry is
where it should be and spacing calculation works as expected.

The ViewContainer geometry retrieval is refactored into a small nested
helper class in DolphinNavigatorsWidgetAction by the name
ViewGeometriesHelper.

Previously the logic of that class was divided between DolphinTabPage
and DolphinNavigatorsWidgetAction.

BUG: 429447
FIXED-IN: 21.04.0
src/dolphinnavigatorswidgetaction.cpp
src/dolphinnavigatorswidgetaction.h
src/dolphintabpage.cpp
src/dolphintabpage.h