]> cloud.milkyroute.net Git - dolphin.git/commit
Add only canonical paths to dirWatcher
authorRobert Hoffmann <externer.dl.hoffmann@muenchen.de>
Tue, 7 Jan 2020 09:53:35 +0000 (10:53 +0100)
committerRobert Hoffmann <externer.dl.hoffmann@muenchen.de>
Sat, 11 Jan 2020 20:59:12 +0000 (21:59 +0100)
commit17e127edcd25f1fa62b1ac1940149763f88291fc
tree98634e1a3785eac6321028d193729f41455faa10
parent09e215be4648a96e2daa5a9e5b6adc34ab444f16
Add only canonical paths to dirWatcher

Summary: KDirWatch only works correctly with canonical paths, i.e. symbolic links resolved.

Test Plan:
1. Create dirs:
$ mkdir test1
$ mkdir test1/subdir
$ ln -s test1 test2

2. Start dolphin, navigate to test2/subdir, then in terminal:
$ echo test > test2/subdir/test

Without the patch, test2/subdir/test won't be shown automatically, only after reload (F5).
With the patch applied, test2/subdir/test will be shown automatically.

3. Restart dolphin, navigate to test2/subdir, then in terminal:
$ echo test >> test2/subdir/test

Without the patch, the increased size of test2/subdir/test won't be shown automatically,
only after reload (F5). With the patch applied, it will be shown automatically.

4. Restart dolphin, navigate to test2/subdir, then in terminal:
$ rm test2/subdir/test

Without the patch, test2/subdir/test stays visible, will only disappear after reload (F5).
With the patch applied, it will disappear automatically.

Reviewers: dfaure, #dolphin, elvisangelaccio

Reviewed By: dfaure, #dolphin, elvisangelaccio

Subscribers: ngraham, elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25732
src/kitemviews/private/kdirectorycontentscounter.cpp