]> cloud.milkyroute.net Git - dolphin.git/commit
[PlacesItemModelTest] Revert last two commits
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 13 Oct 2018 16:49:35 +0000 (18:49 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 13 Oct 2018 20:06:32 +0000 (22:06 +0200)
commit277700425e7d77345de74ff0c6dc58fb0aca193c
tree0bde10fdce17ea4924d525e349b0b7b8d0189e6d
parentc527dc217234e6a2dba4d9ee08945c17b9a215bd
[PlacesItemModelTest] Revert last two commits

Commit c527dc2172 proves that on the CI sometimes the `QAbstractItemModel::dataChanged`
signal is not being emitted at all (build #208 failed because the test timed out).

KFilePlacesModel emits `dataChanged()` in the `_k_reloadBookmarks()`
slot only when it's called after the KBookmarkManager emits the `changed()` signal.

And the `changed()` signal is emitted after KDirWatch emits the
`created` signal.

On the CI server kdirwatch is probably not reliable, which would explain
why the test randomly fails.
src/panels/places/placesitemmodel.cpp
src/panels/places/placesitemmodel.h
src/tests/placesitemmodeltest.cpp