]> cloud.milkyroute.net Git - dolphin.git/commit
Use collapsible box to configure visible roles
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Tue, 26 Jun 2018 20:13:51 +0000 (22:13 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Tue, 26 Jun 2018 20:13:51 +0000 (22:13 +0200)
commit280c97448141d0685806b46af4c80a354f601f26
tree7d7000a817687717090f5a984e309373e82493a8
parent9b7ceaa74da3820f43a8743a4824cf5419466791
Use collapsible box to configure visible roles

Summary:
A modal dialog that opens another modal dialog is bad UX and should be
avoided whenever possible. These days we have `KCollapsibleGroupBox`
that can be used to show advanced settings without cluttering the
default layout.

This change removes the `AdditionalInfoDialog` and uses a collapsible
groupbox instead. The `Apply` buttons gets enabled whenever a role gets
checked or unchecked, consistently with the existing checkboxes.

Test Plan: Change visible roles in the view properties dialog.

Reviewers: #dolphin, #vdg

Reviewed By: #vdg

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D13569
src/CMakeLists.txt
src/settings/additionalinfodialog.cpp [deleted file]
src/settings/additionalinfodialog.h [deleted file]
src/settings/viewpropertiesdialog.cpp
src/settings/viewpropertiesdialog.h