]> cloud.milkyroute.net Git - dolphin.git/commit
Adress most of the second round of Angelaccio's review comments
authorFelix Ernst <fe.a.ernst@gmail.com>
Thu, 5 Nov 2020 22:30:07 +0000 (23:30 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Mon, 9 Nov 2020 22:49:07 +0000 (23:49 +0100)
commit2d4d2ce9a14902ee5a2b236f8510596fc2f86b99
tree07607a2561e3f6e268e4e883f422582bdc908013
parent42023831374496c62708ce7ad2cdd69104a1c820
Adress most of the second round of Angelaccio's review comments

This commit applies most suggestions which were made on the MR.
Most notably the DolphinUrlNavigator class is split up which leads to
the creation of a DolphinUrlNavigatorsController class.

Additionally some minor coding style and const correctness changes are
included.

The error value of cached integers is changed from -1 to INT_MIN
because situations could come up in which -1 would be a valid value.
src/CMakeLists.txt
src/dolphinmainwindow.cpp
src/dolphinnavigatorswidgetaction.cpp
src/dolphinnavigatorswidgetaction.h
src/dolphintabwidget.cpp
src/dolphintabwidget.h
src/dolphinurlnavigator.cpp
src/dolphinurlnavigator.h
src/dolphinurlnavigatorscontroller.cpp [new file with mode: 0644]
src/dolphinurlnavigatorscontroller.h [new file with mode: 0644]
src/dolphinviewcontainer.cpp