]> cloud.milkyroute.net Git - dolphin.git/commit
Fixes multiple VCS plugin calls on single directory update.
authorNikolai Krasheninnikov <nkrasheninnikov@yandex.ru>
Sun, 26 Jan 2020 16:06:40 +0000 (17:06 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 26 Jan 2020 16:09:18 +0000 (17:09 +0100)
commit305085b58143c431d9abb7bd8dcb2f0954df725a
tree4e7dc4d9b7aa7b4cc6e24b4556d699ec10cf8660
parent17e1a48c68000f92033196b6d19d876143a13608
Fixes multiple VCS plugin calls on single directory update.

Summary:
Fixes multiple VCS plugin beginRetrival()/endRetrival()/itemVersion() calls on single directory update.
When VCS pluging finished gathering directory information VersionControlObserver::slotThreadFinished() calls KFileItemModel::setData() on each entry with appropriate item VCS information.
This in turn emits KFileItemModel::itemsChanged() which is connected with VersionControlObserver::delayedDirectoryVerification() which is starting to gather VCS directory information again.
This commits breaks the vicious circle.

BUG: 415698
FIXED-IN: 20.04.0

Reviewers: #dolphin, meven, ngraham, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D26721
src/views/versioncontrol/versioncontrolobserver.cpp
src/views/versioncontrol/versioncontrolobserver.h