]> cloud.milkyroute.net Git - dolphin.git/commit
Making sure that DBus objects are all created before the service
authorAlexander Saoutkin <a.saoutkin@gmail.com>
Mon, 2 Sep 2019 21:13:52 +0000 (23:13 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Mon, 2 Sep 2019 21:13:53 +0000 (23:13 +0200)
commit56b3059f774ae5917185d91a380c9f0a95e7584f
tree9916a0c7aff377f07688e3ca243acd86ce70f5af
parentc5a713763daf113c78697341bfea7dc0860192a3
Making sure that DBus objects are all created before the service

Summary:
Currently the DBus service is created before the MainWindow DBus object is
created. This can cause hangs if another service makes calls to a a method
in an object that's not been initialised, when the service is already published.
This patch defers the creation of the service until all DBus objects are
created.

Test Plan:
Tested in KDevelop. Have "open new folders in tabs" feature enabled.
Open several folders with Dolphin at once. Before this patch
there would be noticeable hanging. With this patch all tabs instantly open with
no hanging.

Reviewers: elvisangelaccio, ngraham

Reviewed By: elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D23672
src/main.cpp