]> cloud.milkyroute.net Git - dolphin.git/commit
Make KFileItemModel::createMimeData() faster
authorFrank Reininghaus <frank78ac@googlemail.com>
Fri, 6 Dec 2013 00:11:04 +0000 (01:11 +0100)
committerFrank Reininghaus <frank78ac@googlemail.com>
Fri, 6 Dec 2013 00:22:39 +0000 (01:22 +0100)
commit6e3673305832180f46911743180d6ad090f2c6a0
tree94c7313193c96907d0191b02dd9d0b6b0461c715
parent92cb6b3a1859cbebbac6ab0526a7216def8b44a5
Make KFileItemModel::createMimeData() faster

Moreover, this commit ensures that the order of the URLs in the
QMimeData object is the same as the order of the items in the view.

Selecting many items and copying them to the clipboard could take quite
a bit of time. This is because we used
KDirModel::simplifiedUrlList(urls) to remove child items from the list
of URLs, and this function sorts the URLs internally to make it easier
to find out which of them are child URLs.

However, since commit 5c5d87fec44e7c5934e4b24060200173153f0ff4, the
selected indices are already stored in ascending order, and this makes
it easy to detect if an item is a child of the last item that has been
added to the QMimeData.

BUG: 283409
REVIEW: 113515
FIXED-IN: 4.13.0
src/kitemviews/kfileitemmodel.cpp