]> cloud.milkyroute.net Git - dolphin.git/commit
Speedup sort
authorJaime Torres <jtamate@gmail.com>
Fri, 13 Jul 2018 16:54:49 +0000 (18:54 +0200)
committerJaime Torres <jtamate@gmail.com>
Fri, 13 Jul 2018 16:55:42 +0000 (18:55 +0200)
commit765cc968c9dfbd4350226b775377506135c0442d
tree0639585929650f3bd1204d001813cf54444290fb
parent1ba972adf57aa82561eeea95890914d4843fc725
Speedup sort

Summary:
Use a lambda function to use only one QCollator initialized only once.

This requires a workaround for https://bugreports.qt.io/browse/QTBUG-69361
Just a single comparison to force the clean state of QCollator.

Test Plan:
Sorting in a directory with 82874 images:
[TIME] Sorting: 19883  (before)
[TIME] Sorting: 4198 (after)

kfileitemmodelbenchmark before: ..............   Passed   29.36 sec
kfileitemmodelbenchmark after:    ..............   Passed   20.39 sec

Reviewers: #dolphin, #frameworks, markg, elvisangelaccio, bruns

Reviewed By: #dolphin, markg, elvisangelaccio

Subscribers: elvisangelaccio, apol, bruns, markg, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D13814
src/kitemviews/kfileitemmodel.cpp
src/kitemviews/kfileitemmodel.h