]> cloud.milkyroute.net Git - dolphin.git/commit
projects / dolphin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 87f8303) | patch
Fix crash when disabling "Show in groups"
authorFrank Reininghaus <frank78ac@googlemail.com>
Wed, 14 Aug 2013 21:40:02 +0000 (23:40 +0200)
committerFrank Reininghaus <frank78ac@googlemail.com>
Wed, 14 Aug 2013 21:40:02 +0000 (23:40 +0200)
commit7e5b7d562672ecda1ec2db0cceb80a17407150f0
tree0931cb5d0869be45222b31ee54d56e2f2dcb02cftree
parent87f830302347e9773404f51de73afc7041829374commit | diff
Fix crash when disabling "Show in groups"

The problem was that items are removed from m_visibleGroups while
a QMutableHashIterator iterates over this hash, such that the iterator
can become invalid. The solution is to use a QHashIterator instead,
which takes a copy of the hash. Therefore, it is not affected if
m_visibleGroups is modified in any way.

BUG: 323248
FIXED-IN: 4.11.1
REVIEW: 111919
src/kitemviews/kitemlistview.cpp diff | blob | blame | history