]> cloud.milkyroute.net Git - dolphin.git/commit
projects / dolphin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3ff6e83) | patch
Use the QMap iterator instead of foreach(key, map.keys()) in UpdateItemStatesThread...
authorEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Wed, 15 Jan 2014 19:27:20 +0000 (20:27 +0100)
committerEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Wed, 15 Jan 2014 19:27:20 +0000 (20:27 +0100)
commit8a46dd8d8e2374fda5a27d2079ef30722ee08000
tree1e99573f0d8e14dd8f06240c011da80a5fb18329tree
parent3ff6e83491e2da9678af0bc149e450ff87db5e8dcommit | diff
Use the QMap iterator instead of foreach(key, map.keys()) in UpdateItemStatesThread::run()
and in VersionControlObserver::slotThreadFinished().

So we get O(n) complexity instead of O(n*logn), and O(1) memory instead of O(n).
Thanks to Thiago Macieira for providing this information.

FIXED-IN: 4.13
REVIEW: 115018
src/views/versioncontrol/updateitemstatesthread.cpp diff | blob | blame | history
src/views/versioncontrol/versioncontrolobserver.cpp diff | blob | blame | history