]> cloud.milkyroute.net Git - dolphin.git/commit
refactor(search): De-couple baloo URL parsing logic from UI
authorIsmael Asensio <isma.af@gmail.com>
Wed, 13 Nov 2019 21:16:35 +0000 (22:16 +0100)
committerIsmael Asensio <isma.af@gmail.com>
Wed, 13 Nov 2019 21:21:07 +0000 (22:21 +0100)
commit8d92c8be7f117dee18710ee1ba6b7cfa45d3f5f0
tree57488f5813f057727a5f64bdd473b72c8d5942a7
parent3984e607bb4437a38af16e007f1c23fbcff7dfb2
refactor(search): De-couple baloo URL parsing logic from UI

Summary:
Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is.
The search box UI is later updated using the model fields.

This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements.

Test Plan:
No behavior changes.
Test case is added in the follow-up revision: D25258

Reviewers: #dolphin, elvisangelaccio, bruns

Reviewed By: #dolphin, elvisangelaccio, bruns

Subscribers: ngraham, bruns, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25257
src/CMakeLists.txt
src/search/dolphinquery.cpp [new file with mode: 0644]
src/search/dolphinquery.h [new file with mode: 0644]
src/search/dolphinsearchbox.cpp
src/search/dolphinsearchbox.h