]> cloud.milkyroute.net Git - dolphin.git/commit
Expose full set of script execution options in settings window
authorNate Graham <nate@kde.org>
Thu, 26 Sep 2019 18:31:05 +0000 (12:31 -0600)
committerNate Graham <nate@kde.org>
Sun, 29 Sep 2019 16:27:56 +0000 (10:27 -0600)
commit983273924d2887cdccdd7c3618d332b52dc0dad6
treeb90d7e56e01193870ea01d34f5b7f12aff16cc43
parenteec49bc38f4e256b66bf16ee5428c5f5d7e97e25
Expose full set of script execution options in settings window

Summary:
Right now the script execution setting is a checkbox, capable only of handling boolean
input. This is not appropriate because there are actually three options available.

Accordingly, this patch replaces the checkbox with a combobox (to save space compared
to radio buttons) that clearly exposes all three options.

BUG: 371837
FIXED-IN: 19.12.0

Test Plan:
{F7440559}

- All three options do what they say they'll do
- All options get saved properly
- The combobox displays the correct option when the window is loaded
- The {nav Defaults} button resets it to "always ask" as expected

Reviewers: elvisangelaccio, #dolphin, #vdg

Reviewed By: elvisangelaccio, #dolphin

Subscribers: kfm-devel

Tags: #dolphin

Maniphest Tasks: T9932

Differential Revision: https://phabricator.kde.org/D24247
src/settings/general/confirmationssettingspage.cpp
src/settings/general/confirmationssettingspage.h