]> cloud.milkyroute.net Git - dolphin.git/commit
Prevent folders from drag and dropping onto themselves in dolphin main view
authorEmirald Mateli <aldo.mateli@gmail.com>
Sat, 11 Nov 2017 14:05:15 +0000 (15:05 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 11 Nov 2017 14:06:13 +0000 (15:06 +0100)
commit99e80c1c7e6e77aa26ccbca4fbb0430b35974544
treebe2f13eb7b687cdead75488e4324e5f821214871
parentfa04e37569a316b3aaab3ca9fc42d50501347fd8
Prevent folders from drag and dropping onto themselves in dolphin main view

Summary:
This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.

The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.

BUG: 307747

Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
{F3787651}

Test Plan:
1. Drag a folder.
2. Drop it onto itself.

Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure

Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure

Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D6281
src/kitemviews/kfileitemmodel.h
src/kitemviews/kitemlistcontroller.cpp
src/kitemviews/kitemmodelbase.cpp
src/kitemviews/kitemmodelbase.h
src/panels/places/placesitemmodel.cpp
src/panels/places/placesitemmodel.h
src/tests/CMakeLists.txt
src/tests/draganddrophelpertest.cpp [new file with mode: 0644]
src/views/draganddrophelper.cpp
src/views/draganddrophelper.h