]> cloud.milkyroute.net Git - dolphin.git/commit
KFileItemModel: Delay emitting currentDirectoryRemoved() signal
authorAmol Godbole <amolagodbole@gmail.com>
Mon, 4 Sep 2023 05:24:38 +0000 (00:24 -0500)
committerAmol Godbole <amolagodbole@gmail.com>
Mon, 4 Sep 2023 05:53:38 +0000 (00:53 -0500)
commit9ba09040134f743ca3a2082589cc943c2d4bf175
tree694dfe04781e641487e83cbfdae4a4c67d25eefd
parentd7535d6977beb068d5ebf751278f585e9139c629
KFileItemModel: Delay emitting currentDirectoryRemoved() signal

The KCoreDirLister object is modified before KCoreDirListerCache::deleteDir()
returns because the signal currentDirectoryRemoved() is emitted.
This prevents removal of the deleted lister from dirData.listersCurrentlyHolding
in KCoreDirListerCache::forgetDirs() when the tab is closed, which causes the
crash described in the bug. Hence, the signal currentDirectoryRemoved()
is delayed to ensure this does not occur.

BUG: 473377
src/kitemviews/kfileitemmodel.cpp