]> cloud.milkyroute.net Git - dolphin.git/commit
Faster drag&drop in directories with thousands of files
authorJaime Torres <jtamate@gmail.com>
Sun, 4 Feb 2018 20:19:33 +0000 (21:19 +0100)
committerJaime Torres <jtamate@gmail.com>
Mon, 5 Feb 2018 18:25:44 +0000 (19:25 +0100)
commit9fbf7a0b624aee6b116efdf69462e73f0275fab6
tree23d2da280aeda134048aec882cf8201d27fca209
parent20d57ab48875a4a8cff440254dc379e4bc1393bc
Faster drag&drop in directories with thousands of files

Summary:
The check is called when the mouse is moved in a drag&drop operation.

Dragging all files in a directory with 3000 files under callgrind,
moving the mouse to the other panel and then canceling, doing it twice,
callgrind shows that the method urlListMatchesUrl is called around
200 times, spending around 9,30% of the cpu in those calls.
Applying the patch, callgrind tells it uses now 0.31% of the cpu in 1208 calls.

CCBUG: 342056

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D10085
src/kitemviews/kitemlistcontroller.cpp
src/views/draganddrophelper.cpp
src/views/draganddrophelper.h