]> cloud.milkyroute.net Git - dolphin.git/commit
Fix crash while entering selection mode with Qt6.7
authorFelix Ernst <felixernst@kde.org>
Wed, 17 Apr 2024 07:32:27 +0000 (07:32 +0000)
committerMéven Car <meven.car@kdemail.net>
Wed, 17 Apr 2024 07:32:27 +0000 (07:32 +0000)
commita07f24228a94aab2bdeb3caaf7a4d694c0180ed7
treee0256a0df801ce43e0e4a928eb0f9b5683166aaf
parenta16b9e582803a1ac03a8bec6c2987e7fb15f9578
Fix crash while entering selection mode with Qt6.7

`deleteLater()` on a non-existing object seems to cause a crash with
Qt6.7. This makes some sense but wasn't the case previously.

I didn't test this yet but it is a harmless change so if anyone can confirm we can IMO merge directly.

This was brought up in https://invent.kde.org/system/dolphin/-/merge_requests/764#note_920935, reported in the bug linked below, and the sentry crash reporting page also has a few dozen reports (https://crash-reports.kde.org/organizations/kde/issues/13589/?project=4&query=is%3Aunresolved&referrer=issue-stream&stream_index=1).

Dolphin 24.02 is also affected but we are already past the last bug fix release for it.

BUG: 485599
src/selectionmode/bottombarcontentscontainer.cpp