]> cloud.milkyroute.net Git - dolphin.git/commit
Update the Places Panel entries when switching the language
authorFrank Reininghaus <frank78ac@googlemail.com>
Fri, 15 Nov 2013 08:16:22 +0000 (09:16 +0100)
committerFrank Reininghaus <frank78ac@googlemail.com>
Fri, 15 Nov 2013 08:20:10 +0000 (09:20 +0100)
commitac8722dc7d1a6b2f7669b270d65c3ed834582d7e
treeda31bc83023e2e423fd7b775722a4855eba51611
parent980846ab36eef12c152aa913267145b8bab2f326
Update the Places Panel entries when switching the language

Before this commit, we stored the translated "Places" in
.kde4/share/apps/kfileplaces/bookmarks.xml. This was not intentional -
it only happened because
PlacesItem::updateBookmarkForRole(const QByteArray& role) always stored
the translated text (returned by PlacesItem::text()) in the KBookmark.

This is be fixed by first checking if the text() is equal to the
translation of the text that is already stored in the KBookmark, and
not updating it in that case.

Note that we have to make sure that all "Places"-related use the same
context "KFile System Bookmarks" to make that work.

Thanks to Burkhard Lück and Albert Astals Cid for helping to fix this
problem!

BUG: 319282
FIXED-IN: 4.12.0
REVIEW: 113850
src/panels/places/placesitem.cpp