]> cloud.milkyroute.net Git - dolphin.git/commit
Fix crash when closing split view with ownCloud plugin loaded
authorMartin T. H. Sandsmark <martin.sandsmark@kde.org>
Sun, 15 May 2016 16:09:09 +0000 (18:09 +0200)
committerMartin T. H. Sandsmark <martin.sandsmark@kde.org>
Sat, 21 May 2016 16:11:46 +0000 (18:11 +0200)
commitb1471bbd09d88da3ffe8159075b3108bf9586220
treec594e1679dbd0fab59be0a352ed76d79d0b663e4
parentb7ad5fb99d32d43fe4e083a8ffc2ebfbd046d2db
Fix crash when closing split view with ownCloud plugin loaded

KPluginLoader::instantiatePlugins() wraps QPluginLoader::instace(),
which doesn't return a new object for each call, so if we set the
KFileItemModelRolesUpdater instance as parent to the plugin the shared
instance will be deleted leading to crashes when other instances of
KFileItemModelRolesUpdater tries to use their plugin objects.

To fix this, set the QApplication as a parent.

BUG: 357479

REVIEW: 127930
src/kitemviews/kfileitemmodelrolesupdater.cpp