]> cloud.milkyroute.net Git - dolphin.git/commit
Prevent possible infinite recursion in ViewProperties
authorFrank Reininghaus <frank78ac@googlemail.com>
Sun, 23 Jun 2013 08:01:24 +0000 (10:01 +0200)
committerFrank Reininghaus <frank78ac@googlemail.com>
Sun, 23 Jun 2013 08:01:24 +0000 (10:01 +0200)
commitb4dc66e27fd007bebeca3f68dbfad17483ca9241
tree36185ceaf9ad7cdfe20fc7c17100bae9b6acdc0b
parente8c4d19b7c8d1881dae2a28b1ff7202683648ceb
Prevent possible infinite recursion in ViewProperties

If each directory can have its own view properties, and loadting the
.directory file fails in a directory, we have to load the global view
properties. However, if we try to do this by changing the "global view
properties setting" and loading the view properties for the same
directory again, we might get an infinite recursion if changing the
setting fails.

We now force a loading of the global view properties by constructing a
new ViewProperties object with an empty URL.

Thanks to Kurt Hindenburg for helping to debug this issue (which was
only reproducible on MacOS).

BUG: 316209
FIXED-IN: 4.10.5
REVIEW: 111182
src/views/viewproperties.cpp